From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFC22C282DE for ; Wed, 5 Mar 2025 20:37:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2B356B0082; Wed, 5 Mar 2025 15:37:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BE7A66B0083; Wed, 5 Mar 2025 15:37:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A55986B0089; Wed, 5 Mar 2025 15:37:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8166F6B0082 for ; Wed, 5 Mar 2025 15:37:01 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FD7DB7393 for ; Wed, 5 Mar 2025 20:37:03 +0000 (UTC) X-FDA: 83188656726.20.4CB548E Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf11.hostedemail.com (Postfix) with ESMTP id 236E840006 for ; Wed, 5 Mar 2025 20:37:00 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IAhCjXGB; spf=pass (imf11.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741207021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SsmX/OpLN1sMnCZRxg3yLh3oM0HIrvMLKk0gSzLVUKM=; b=HzSPGSi5pEAPFfDbqkFHcVm4l8gTQ9M5TeTO1RilDR08z050x3ZMrDLb+XZYnTRWMHQ1Dq WQfQ4rEkXlqNpEaXeE03biwjajVbir9Yv5/W0zCZVJifs2xMW0aP4WcSXCYPGmroVwiQlX TJLhcujKOoKy7J3fPQxtF/8nZRsKI70= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IAhCjXGB; spf=pass (imf11.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741207021; a=rsa-sha256; cv=none; b=3I6OSLbWJQpIu3hjoi4ndpGw/0bhWoYpthccrmphm74uxx7uI+4Y422xAXPvb33EvH9xpR xmye6nQVYH4Qu406SVAqbkcr8u0oQeLqLcxte+qQBxnPAegonvafxTXguYpwAlYL6TZWBH LoywW3CL9SYX+otT2dPyxTEutBW11Nk= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4394036c0efso46310905e9.2 for ; Wed, 05 Mar 2025 12:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741207019; x=1741811819; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SsmX/OpLN1sMnCZRxg3yLh3oM0HIrvMLKk0gSzLVUKM=; b=IAhCjXGBbGatMj4gVV2nHX+vzHqX5wFHN+vUEhR7/3DF+JX61zb8CV1ODyk7kqUARS 3vaJroaDrTzggBca6nEZYiO6TfIP6zxdLt/n6QHLhd5tY/ZrgMQYYcGkqJ0wyiNMFmnK sERLUnR5K57eihajpJxuuMZAs3oeCqj94ARASodNORijDoABSDZxtciUtr7vHW64ZZ55 nycxgapWWywRHtBTkmR7dc380VGlBOTDLvqd6Pj//8Idrb+Y3vEFpL0nasTfG65ANDGs WwJ8w479PibaNkVNqp1Nacb6UBWz6zuqFU8vKcPA21hastdrFMQGkPoWMMcYPyeS7efy exlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741207019; x=1741811819; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SsmX/OpLN1sMnCZRxg3yLh3oM0HIrvMLKk0gSzLVUKM=; b=a1QZ42pPyXxl3ezNJZFSP8+M8+sDp0sHspGXFpYXwCUCbPuPZ6v1Ou2r23/U95um0y OSkGpmnxPGt+Gvxosk877S7LeHRxobSE0+nd1aYMtRjcel5JKFhNOO5Ms26A3wbdOcNj b2cJPsqpZGkLjsTsOiQIeoVN5TETdhLOlHsY68/IBq/Q9KB/6CorvwbAz5dKuCxwlZ7a WEnGRHtijfGihYdzb+/RI/vvIE+U9fxHi0cIJ6uG4Z6Rws7UoW45MoHHt0eQzl9+vaSQ Iq7Z16AXnn5KAwYSDn4qvLUiFVo0G4Y1XKUfurAJAgykojhwW+xMuAKdWRjgcUUP/N+d dFMg== X-Forwarded-Encrypted: i=1; AJvYcCWEzK7OeFWA8E7k6I765XpjrwQgd29gqCDo1GKwTP0mXiw5OfW3s0XsWmj4wyISjCSaHy96CGQ0/g==@kvack.org X-Gm-Message-State: AOJu0YyFMvyIyomn55e2SES6eepcYuUd66df3hvuS7X+99l9NvDMz/hh qi0Fq6Pl0YRH8XX5tNpmuEupvJUYzOEIkPlrx9EVBUoeFh3he7/j X-Gm-Gg: ASbGncv5tjpuI5UsEk06k3DIwD6dclqXEE/1uf4eph7zc3f6rkdDaYKh0v2Say6Cqa0 BHLDfOSOb2j7Us95+T06/u0cAkTBZ25eroNj9w7kd4hGUaUQkkbqPvECI3+UiWUKaGlwCtfhLb5 rUucUXwh1Hl19PVUd5k6FD+FeyCRiDi1w5tv1bKur+6KYt4p9S632PruKKxzR8onRg1crfbWBzJ kZ5CjvYCJ3EWObLYhxub0JBeV0I86rGwBPeQ0WRqggYHzOqAnmYpCKg+W/rSua8CvFTnnl3y1Bg ZI0hcoYOvYUjxFT7XKWdBp+KlxFNqlOQV0FVRWOWaWkn1dr85WDNkgsdzQ== X-Google-Smtp-Source: AGHT+IF1yVfuC5cS7K4wj9YscnLWgyaGE58k0iUTo9bMqcQWJWNwvwLwpjIqgRC/S8h9Lcpu1anzEw== X-Received: by 2002:a05:600c:1988:b0:43b:c590:173c with SMTP id 5b1f17b1804b1-43bd29c7904mr34660015e9.24.1741207019094; Wed, 05 Mar 2025 12:36:59 -0800 (PST) Received: from smtpclient.apple ([5.29.8.141]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd431124asm27810065e9.38.2025.03.05.12.36.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Mar 2025 12:36:58 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [RFC PATCH 00/16] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE From: Nadav Amit In-Reply-To: <20250305181611.54484-1-sj@kernel.org> Date: Wed, 5 Mar 2025 22:36:45 +0200 Cc: "Liam R. Howlett" , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, Linux Kernel Mailing List , "open list:MEMORY MANAGEMENT" Content-Transfer-Encoding: quoted-printable Message-Id: <7BC81F7C-191F-451D-8FE5-5BB268F6B0A1@gmail.com> References: <20250305181611.54484-1-sj@kernel.org> To: SeongJae Park X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Rspam-User: X-Rspamd-Queue-Id: 236E840006 X-Rspamd-Server: rspam09 X-Stat-Signature: o3mxcb6aizpn5kacm7xr63wcz3ftk7da X-HE-Tag: 1741207020-899038 X-HE-Meta: U2FsdGVkX1+ia9/4uBhWL5ca1zjup5LWmYhY+aadHwwUJBmXCqEkW+tTO0yziQPkMfBiLKvbGTb0rNZQ40wVZuSuvyxIp4UHkJgkFtu6bXyIYJvoMbky4rAD/wTnRUESesNDI3iBkPxtgVLVZrDY97WGnt+J0VT/5R135Wk4xJYkEQuYA+HVvacMtWS703hqeAnhZu1Pbp9CkzLFvLjfy2prahG97279a/5rKtyy1/PfFjsgQgXlFsji0G93lbqhcA7HkqWqsZlsaZN5LEHJQ/iNT6Nt0fKWL1ltmakaBAKiHOIP47FtarOg1R5IENQr7PTy8IKjO6t6+FVYb/o3UE7CYRFxCkcOVtt6DAut9Gwi3ZL+xODGL0+TomkEfxLCFlH4HLmf/JkAjTR2qUotUWI17HAB00Ltjp9lsA18wWE5P2RpDUnWpFYG6wdOMJWA7IChBb2eBBRMud66CbK4eq7xVmJmCpzbEKuMLAM0ImoVRGVcnhUGKg5mpdOYjhZywbxp7tzxVFbZPDiONsZF3kM/wm6plTtqgSm4WCUcPBa02VqCjc+Yvs/KEOhwha/al9Tq2G5RLIzChyD80VAkb3ju+dRF9/1Ht6BXIDlrKA8ajdHaWcz0wRdtwj92ItSy5pa/zpoKvUcgq6vrUspk6HHIlbNfUmo8IPmT6p8/ZaKTA1/a/9oQys31GypiJTp+qXpj5o0FJpt3twqMs+SKW+drKJE5W6XjnR/CFjLvJjdBI3dhUv2pcGk1nFKgEzidipn3cRD8DGQREMwCx09FlZZ37lfm2IEHnlAv/lDdcj2CkNJDAnMj34c1zhpjXfR1p7yE0dApXB0aSyKzH5GtnN1JQuyb7d5b3NAmEhIpdok3iuw8xfndok72T6E0dprh9WpoQ+d5PMlg6snoeaoO11m6EtIFQ3TZk39TE9jm6CuhtFt643zYYRCCOZjqYNMdaB5zKtCg+3O/TE4oV9P x+QQ1XVJ hvau3o4nH1yuzevqR1Dfe0EGbehQ+JmX6xWMAAvLV8VuD/6fEW5QBWVuBNuD0XhW044eCTUIcdl+5/csrImbU62lDWK8xzxc+O8vrKGSbaz2eFPLkYeCYOMzD9xeS7JSHDPesuGqR4g+s7m66Fn/KPZ4AALDxG99UqmFvnNBCljhYXtH2Sit30aZztFn2ERoeccEn1r+qB1cXnamIS8YaWyVrGl4/PpTvIAPtUTgbgHIeduT1o9fZIm+g8WT3l9hSoJNo2PDXWfDLsls/Ai2UrUm17XB9UVcJ/OtYc8DUNwV8a4C6zd3wj1HxTb/vmyXzT+s3fO1oY2PZkk0aoMkt5tQDtzIu9MgKgEUe3Z3MJv4A+QmUiBLB1Ne+v0K/S0pSqMBajjOcIsNTt+12dxa6iBonAsghraDicpQOEf7942cP26vVTX5oOfIiXqIAZSLDXgCpDlAqSpnDzz5ae1i0VfbJLzC1/+IHBscLiFD/vDYwyLvrEW4V2Vh5rwcHtdpnip1Y7z9U0UtLrb8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000227, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 5 Mar 2025, at 20:15, SeongJae Park wrote: >=20 > For MADV_DONTNEED[_LOCKED] or MADV_FREE madvise requests, tlb flushes > can happen for each vma of the given address ranges. Because such tlb > flushes are for address ranges of same process, doing those in a batch > is more efficient while still being safe. Modify madvise() and > process_madvise() entry level code path to do such batched tlb = flushes, > while the internal unmap logics do only gathering of the tlb entries = to > flush. I made some related (similar?) patches in the past. You can see if you find something useful in the discussion there. I think your version = avoids some of the =E2=80=9Cmistakes=E2=80=9D I made. [1] = https://lore.kernel.org/all/20210926161259.238054-1-namit@vmware.com/T/#m2= 3ccd29bad04a963c4d8c64ec3581f7c301c7806=