From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DEE6C35274 for ; Thu, 21 Dec 2023 05:47:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27856B007E; Thu, 21 Dec 2023 00:47:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD6B56B0080; Thu, 21 Dec 2023 00:47:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9F156B0082; Thu, 21 Dec 2023 00:47:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A90A96B007E for ; Thu, 21 Dec 2023 00:47:44 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 73BACC05C7 for ; Thu, 21 Dec 2023 05:47:44 +0000 (UTC) X-FDA: 81589743648.29.8BD7C19 Received: from out-183.mta0.migadu.com (out-183.mta0.migadu.com [91.218.175.183]) by imf07.hostedemail.com (Postfix) with ESMTP id 9627040015 for ; Thu, 21 Dec 2023 05:47:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V1Sdgytx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703137662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aoopr+ccNsQyXfz/YUalVeZvDB+jSnnz+aOkdBpWeU0=; b=MSeuEI6bdOi/2GfTUDG60GLbJZrkMiPsvLd1z2I9lU7v8I/vU3KZJCh2v2p8TSATalRRGz TGwTWse6UXSBXaJ+Fon7m4jgneA//Af+X3GITOIavC849QQXRwKaX1etfz+pAcJ2fjIKrJ hunK6zGerbeinyQHbWlQUjZ8nz6hG2o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=V1Sdgytx; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf07.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.183 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703137662; a=rsa-sha256; cv=none; b=KCdNV9Yjt6SEzWOiQ7h/BbSoDz3sCgc1DmbpIF+woc5PrGEJsT8wGNCnYvlN25Y9V3XYj8 uYYRDyo/kbSKnrRbOpNlWKIhQZYF8ImA817qz5R/5m3gpnATCu2dFcdWDEcxbXy23ifchO uNYZuBjofVPhk8ZZm1Xf75hbGCQea78= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703137659; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoopr+ccNsQyXfz/YUalVeZvDB+jSnnz+aOkdBpWeU0=; b=V1Sdgytx1Nwd2uNmlTnQaQ+xhip20uNc/DB/VFV6TjM1CbAernGsYjcKqpbioQHmELDDvz vWexG8icTH1CE/sFCW1/irRY6i/mDg/oa7Pz/wz9L3LL2roWytU5ZslpeYJlI2mMh+Iqcr uuI5N17JNexTHXbTozmaub+p5p7jPoo= Mime-Version: 1.0 Subject: Re: [PATCH v2 04/40] mm/rmap: introduce and use hugetlb_try_dup_anon_rmap() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20231220224504.646757-5-david@redhat.com> Date: Thu, 21 Dec 2023 13:47:01 +0800 Cc: LKML , Linux-MM , Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Ryan Roberts , Yin Fengwei , Mike Kravetz , Peter Xu Content-Transfer-Encoding: 7bit Message-Id: <7A77CCE2-92F1-47D5-BCCC-C520210ED3EF@linux.dev> References: <20231220224504.646757-1-david@redhat.com> <20231220224504.646757-5-david@redhat.com> To: David Hildenbrand X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 9627040015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pgwfeattzgjcsohuuw8pjct3n1exhh5z X-HE-Tag: 1703137661-665207 X-HE-Meta: U2FsdGVkX18ulp1U6o5GklQ7rBCRv6uclmhmTbFJ0DdYQ8LoH+BZb+ZOCuBGFL4TH+5M7/T59Y8QNzaDM4ZrQXBB0RrqhUlCTDkLkQnO88qgTPXRrP4n7GyrYVYcmJ2OmNJJjeaCGL7cKfvFNO62u7TwiG9xMqnQy1spv3j1sSqyyOYfm4IWpJS3NcK+pBpI5zSTYboPLsEqVgMHEb7A8Zo0MdrEqFus+GeIGjH55Z6QlqCm0ZgMt3hfTvXhm42/VRTGvtlaYwoueG/VGe7fFiTDF1PWFdItRxcMQw0jBWNF2aoNM3UPQmYJkfXoOSXZ5BBatS/t/LLV4QZHsTPUXpT8K4SPyudV1NVz3HMUX7pdc9H1coECeqBVViEl+lHQxZfDWFLGr0i+APaf5djbJ5KrPIT8dOadKEoYlofsLnCW/dwVU8h7urdtDzEkYCAJGOnEuH6J+nX/odnxJyZ1F7fZNG4DqYaJCAfB+YRg0IzoWZplajthc0JToTJsGAMd0nXFGaN6S+i08rWhmucypEJW92VT+sbq0Pr42E9P03w9o3rAkpHcMoKsRArEKckr2tKoeZSAZyWIAYLuJYBZuPbu+tq0x0FSwQNILxHfXbhM4Cg3ZIl70sIU311M8cwMnSwP39v4BqWmVa3NxRnIFbv3kitskjs5d00GPpWkiXtaFJsLe/v9+MwD2qu0Jal8Si1N8BXhcI4Bh+4gyXfU+1w3dFYgo+I3BgNlQBnP/KgOSZJAcs0Ovj9os2iV9Vki5BT4ejIUaQXBtSF4F45lPuwvMcjnjSgzsXy+eOe3nVk5l/Z2kAKkYo2Qelo9QEJE3wOFdImoSI0hL3HOKTVx8IF/zWegnTCIeBjyV5oa6LmdJtwO2JUL+hrI5JafSFAfClnKWfC3BJQ2umJAMj6THvp1djARPIHsYgT+ZX9mYuqivUl16B8No49sO3Zl+cy70LiNamu10N63vmnHEDr mKEt+Dgr t/fRz70yJd51IQbIytUlojKkBukReBnxqtTvh6ny/pFOzE1S65izHW14JNccV4miZihYF3l+AjSiwnWGQp5ydHEVkMTU+iJKDWfHTH8l7cDre9LkVRUd+BqAzhcomjG8rR0NQOyNnS37P0K9+i8Lp6+9+WEsc13grHmEOwfDsP/pzEdaKQDL9/jYzIgxneS6Ct3w1AcybYmDlYk/UrWHal/zAurZgeguDJx01xKXpPP/gOF2wc/1zDgFqkTOvLBWsxXE9pmyHPeLZe6pNjBiChEghpewJlMoYrWYCErGpa81C1FTJyysrQSCc43I+SyK6WtsCWILW2tnmRnA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Dec 21, 2023, at 06:44, David Hildenbrand wrote: > > hugetlb rmap handling differs quite a lot from "ordinary" rmap code. > For example, hugetlb currently only supports entire mappings, and treats > any mapping as mapped using a single "logical PTE". Let's move it out > of the way so we can overhaul our "ordinary" rmap. > implementation/interface. > > So let's introduce and use hugetlb_try_dup_anon_rmap() to make all > hugetlb handling use dedicated hugetlb_* rmap functions. > > Add sanity checks that we end up with the right folios in the right > functions. > > Note that is_device_private_page() does not apply to hugetlb. > > Reviewed-by: Yin Fengwei > Reviewed-by: Ryan Roberts > Signed-off-by: David Hildenbrand Reviewed-by: Muchun Song Thanks.