From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC17BEB64DC for ; Tue, 11 Jul 2023 09:49:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D9EE6B0071; Tue, 11 Jul 2023 05:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 093606B0074; Tue, 11 Jul 2023 05:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6B196B0075; Tue, 11 Jul 2023 05:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D2AD76B0071 for ; Tue, 11 Jul 2023 05:49:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 955B1AF9F1 for ; Tue, 11 Jul 2023 09:49:31 +0000 (UTC) X-FDA: 80998858542.17.1B9F81A Received: from bjm7-spam01.kuaishou.com (smtpcn03.kuaishou.com [103.107.217.217]) by imf02.hostedemail.com (Postfix) with ESMTP id AF24F80008 for ; Tue, 11 Jul 2023 09:49:28 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kuaishou.com header.s=dkim header.b=eJEuzGt+; spf=pass (imf02.hostedemail.com: domain of yangyifei03@kuaishou.com designates 103.107.217.217 as permitted sender) smtp.mailfrom=yangyifei03@kuaishou.com; dmarc=pass (policy=none) header.from=kuaishou.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689068969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Fil9ZNXmOZXtimgcREG39RpKuG9OuqTCFGDtaRA8+G4=; b=H6gae4w9KknTRQskMsIwjP50Sh2iyGK9jNNJhAz0iSNnoexQNsxcZL2FaBqKObNmYp2xPk Sr0c9YONDuJWNXarU+p03ma/05fosJuP0QzCPrUd471CIrFnw1+A22A49f6qRsDobGAvgr VZikJPn0CkhdYfX30i+3KNKradeU5YU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kuaishou.com header.s=dkim header.b=eJEuzGt+; spf=pass (imf02.hostedemail.com: domain of yangyifei03@kuaishou.com designates 103.107.217.217 as permitted sender) smtp.mailfrom=yangyifei03@kuaishou.com; dmarc=pass (policy=none) header.from=kuaishou.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689068969; a=rsa-sha256; cv=none; b=eJuvWVI/8RNYbZjkKuRMKNNV1RwPt7AAAdHWBOw7DuoAg8WjxAodtHcPDGO10Bnos0sP90 uecMkblkY5u9+hzJsG5K8/pNU1PCCTmbWom7ciO8aggzxXi6FL3w97AvmpKgt4ZlzV0Y92 JkJ472fT/4ofc9Xmnl62DPLZrxdKe/Y= Received: from bjxm-pm-mail11.kuaishou.com ([172.28.128.11]) by bjm7-spam01.kuaishou.com with ESMTPS id 36B9jRed030878 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 11 Jul 2023 17:45:27 +0800 (GMT-8) (envelope-from yangyifei03@kuaishou.com) DKIM-Signature: v=1; a=rsa-sha256; d=kuaishou.com; s=dkim; c=relaxed/relaxed; t=1689068682; h=from:subject:to:date:message-id; bh=Fil9ZNXmOZXtimgcREG39RpKuG9OuqTCFGDtaRA8+G4=; b=eJEuzGt+Yho0hrgXTcj1HRqM3WPsYV6MFlMjdxQE1AFjnCqc8FsxVwHYK6SBw3wk6cx1HOcUD04 w7vzjrI7+TsK6QVMxgtnMdZQoKqt2SkYKNUKfYCqCKVk7uIjBtwoiQPClkehnNibU2UL7BQ0r8Tfv ldAe2pAxmhdjs++oLM0= Received: from bjm7-pm-mail12.kuaishou.com (172.28.1.94) by bjxm-pm-mail11.kuaishou.com (172.28.128.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Tue, 11 Jul 2023 17:44:42 +0800 Received: from bjm7-pm-mail12.kuaishou.com ([fe80::467b:4542:43f4:a47d]) by bjm7-pm-mail12.kuaishou.com ([fe80::467b:4542:43f4:a47d%8]) with mapi id 15.02.1118.020; Tue, 11 Jul 2023 17:43:02 +0800 From: =?gb2312?B?0e7S3bfJ?= To: "akpm@linux-foundation.org" CC: "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , =?gb2312?B?0e7S3bfJ?= Subject: Re: [PATCH] mm:vmscan: fix inaccurate reclaim during proactive reclaim Thread-Topic: [PATCH] mm:vmscan: fix inaccurate reclaim during proactive reclaim Thread-Index: AQHZs9wVKSECs+LJ10u1nOjpUwf77w== Date: Tue, 11 Jul 2023 09:43:02 +0000 Message-ID: <7A6BB714-4DDB-492C-9CEE-1C52DBB3F0CF@kuaishou.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.28.1.32] Content-Type: multipart/alternative; boundary="_000_7A6BB7144DDB492C9CEE1C52DBB3F0CFkuaishoucom_" MIME-Version: 1.0 X-DNSRBL: X-MAIL:bjm7-spam01.kuaishou.com 36B9jRed030878 X-Rspamd-Queue-Id: AF24F80008 X-Rspam-User: X-Stat-Signature: 998e3cmrrpb3jjp1ocxirqimob616tp8 X-Rspamd-Server: rspam01 X-HE-Tag: 1689068968-806587 X-HE-Meta: U2FsdGVkX1/cqPOJ9m9oZHniL6bEmUtawm8jzSbtWI+SzskaRuKgcWmJR45ZHS9FM8d6IhGJ4oCryINmaA5P3HRs55CzCqFYbg4ftlNkPj1EEedZaY/f4qBzpnb2DwhS2pkZA9QUXnroYxLzDiPZ/87k1MpK8JcBjsTKcChXChdeCmhrUlBhWccKXo96m/XgHd2O9xrpttfBouN9CSAZS53ejv0vWGZDUFUljQso8rm1O1Wi2qw35g2NgEudNu2HQyg3bs1WVQyQOfq5QTLqQMmKPU/yIqPACziVKAHRO/c64UWNtVkiXOIrROohizb5aqLcTWSiAW8pDAvk+1LzGsfr+Dx9FyloNmW84kHhW/yjkWA7rOCRtfq8aa+S8r4g2fVRa/oYe/D3kO6Cr3PAAT97Cwm5sN0NOOyunX9G/BRJ/C6jGcpmHrHpX4H2wyHWGc/IMQ/uOqW48M6EJUMNwTBwj7aM+t9KOfhTHHbVgWe+3b4DliCgaKKX4vQSiFWuJlsDhuz7FKnCPatn2f0lgR+kjCm1uLZ92CyxdLWvnr6Zp4AsDZAsoRZVwdQC5G5E23hCYjq1j++g+J1RspMcwSqYhOufjsufeV4Viuu+1+EsndVrcgZjRQgwxf1H8nj8YZJi6wgLN2XafZkihCkTOeG+QAGVMs5QC9Mbsy8A/8I2XsMLP6n4MCloSs6NKQHaXBya3JqgFRWLyaIKzzJ+PA47Pug4claP6kg1qc8TNJKiOKkoswUsdDDm3Gf8DYjt/BQPgkFsQclw7TRrPLtdSZ3PPyOsWo9ZhfEvIziHK4tpzckb9ozPGhtjJFmyDkzn4AwrkCkHEScFoJFMuE/NrHn3Zlq1qp/Z3rQL3mczURrJ7Eoj3GD5fKp1+b0UevaRsIr22vsOvCtKqUq/4d8JB9CM6/40DGSkBvuVJrZDwLEkx9SpSnewKWybUYco909glPu/5M7GK9gm5gc4AS4 qqXKgfAN aTsL2/OBoyemUaGJ/vn79fidYWMHAU9w70DfoO+5uVE12nwr5LVGZM3ofh3ROA9qbnv2sAOGghqJg4bcCzBcL/F6LGa1RQWtK2Dxa9fNSp4SBBMW577IAeDzbS7KKr0UYmKrfd6ewv95aej5RQgb9nh4tdrIIVeSr5b1eRf7yaOWgl2g1Y8xt1gdcuRUutORWOz98I5KHR8fJg9Gr3mYSLQRJ1BWGCPStdGgAzVLkD8A2r8Vw9O1SKeVuJ1Rv0zr164wGmomGHwtY/LCMUpWjWP72w8VUqDaig68S3CtBkrA9k3hJk1ofQvCVZumsaEvuUQUvDJ0ACsEAMkON6j/kxyu8fvaykdqRQ5hKZIuRFU8ZDGJIkONEZ1fFkKM9e0ZOXQEhOCyUeZNSfoH06/TpiBvCtuQpuCGBPMizeE0Hy8VkkhF2SS/Q5Q2xoTfL5e6oYhLry2fQq1k6lSUi4YqvvVDV/4zCwNn4N3nQHCcXDmrHaf5e+feRcdvrew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.111949, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_000_7A6BB7144DDB492C9CEE1C52DBB3F0CFkuaishoucom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 VGhhbmsgeW91IGZvciB5b3VyIHJlcGx5LiBzaHJpbmtfbHJ1dmVjKCkgaXMgbmVzdGVkIGluIGRl ZXAgbG9vcC4gUmVjbGFpbWVyIG1heSBoYXZlIGFscmVhZHkgcmVjbGFpbWVkIHBhcnQgb2YgcmVx dWVzdGVkIG1lbW9yeSBpbiBvbmUgbG9vcCwgYnV0IGJlZm9yZSBhZGp1c3Qgc2MtPm5yX3RvX3Jl Y2xhaW0gaW4gb3V0ZXIgbG9vcCwgY2FsbCBzaHJpbmtfbHJ1dmVjKCkgYWdhaW4gd2lsbCBzdGls bCBmb2xsb3cgdGhlIGN1cnJlbnQgc2MtPm5yX3RvX3JlY2xhaW0gdG8gd29yay4gSXQgd2lsbCBl dmVudHVhbGx5IGxlYWQgdG8gb3ZlcnJlY2xhaW0uDQpQcm9ibGVtYXRpYyBjYXNlIGlzIGVhc3kg dG8gYmUgY29uc3RydWN0ZWQuIEFsbG9jYXRlIGxvdHMgb2YgYW5vbnltb3VzIG1lbW9yeShlLmcu IDIwRykgaW4gYSBtZW1jZywgdGhlbiBzd2FwcGluZyBieSB3cml0aW5nIG1lbW9yeS5yZWNsYWlt IGFuZCB0aGVyZSBpcyBhIGNlcnRhaW4gcHJvYmFiaWxpdHkgb2Ygb3ZlcnJlY2xhaW0uDQooU29y cnkgdG8gZmluZCBvdXQgdGhhdCB0aGVyZSB3YXMgYSBwcm9ibGVtIHdpdGggdGhlIGZvcm1hdCBv ZiB0aGUgcHJldmlvdXMgcmVwbHkuIFRoYW5rcyBhZ2Fpbi4pDQo= --_000_7A6BB7144DDB492C9CEE1C52DBB3F0CFkuaishoucom_ Content-Type: text/html; charset="gb2312" Content-ID: <5C94FBED2EFD864C8234E938B6572747@kuaishou.com> Content-Transfer-Encoding: quoted-printable Thank you for your reply. shrink_lruvec() is nested in deep loop. Reclaimer= may have already reclaimed part of requested memory in one loop, but = before adjust sc->nr_to_reclaim in outer loop, call shrink_lruvec() agai= n will still follow the current sc->nr_to_reclaim to work. It will eventually lead to overreclaim. 
Problematic case is easy to be constructed. Allocate lots of anonymous memory(e.g= . 20G) in a memcg, then swapping by writing memory.reclaim and there is a certain probability of overreclaim.
(Sorry to find out that there was a problem with the format of the previous reply= . Thanks again.)
--_000_7A6BB7144DDB492C9CEE1C52DBB3F0CFkuaishoucom_--