From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 997F7D68BDC for ; Thu, 18 Dec 2025 05:40:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D07736B0088; Thu, 18 Dec 2025 00:40:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5706B0089; Thu, 18 Dec 2025 00:40:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5F756B008A; Thu, 18 Dec 2025 00:40:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A012C6B0088 for ; Thu, 18 Dec 2025 00:40:19 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3868B8BB08 for ; Thu, 18 Dec 2025 05:40:19 +0000 (UTC) X-FDA: 84231491358.24.189C136 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011039.outbound.protection.outlook.com [52.101.52.39]) by imf14.hostedemail.com (Postfix) with ESMTP id 375D4100002 for ; Thu, 18 Dec 2025 05:40:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=BgbpAkrp; spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 52.101.52.39 as permitted sender) smtp.mailfrom=shivankg@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1766036416; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zpthoi3Lr2+b0JuPpAwOn9AAG/xyFZazZl9X2h6hsX0=; b=2BxIQfK9v3YWQI+hsvvTZLjpbfyU7hZrI/ucmQGxUMIErz6jD+BH9Jy1IJFPqQ1JXVf/21 gdcEpAeONh/QAg2vgUXMwuIT7jcykfXwwgmgVBKtijvgMPYweOcmjFHT0QqeRGTm1y526j uA0ZkXGBDdTuMJo03ycRrrtTMGgBNi4= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=BgbpAkrp; spf=pass (imf14.hostedemail.com: domain of shivankg@amd.com designates 52.101.52.39 as permitted sender) smtp.mailfrom=shivankg@amd.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1766036416; a=rsa-sha256; cv=pass; b=hD6TyHjuJC15Z+7P8tc+0u7U8ANNkU/ih9ty6l3eb5zm5JgzW84AhQYKAzP8ivY5nLP7DG 5d9cQMkinSKvld+YwRlNbR3J7mpeB1NLHGMd/QGRyVjOHIBx0YHoYQHa+NW8thyM5uaFbo 2g3PnusRx+oSwDsdMJ8vMLZJR3VIzKg= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W6hjm1xddv6lTYWRqGbUn+Mci8NSVoZFhXpoSQux0nME/uSCfRvGkRdbZzcpNvoOFUqb33ZC/Dy9wCcb0mphwqIbVlm6mpCE+e/403m1t91fOmlkkL3YOLcp2VWH45F6RG1BcB+cbSH8ENJa5yDP1WaAXzvS3WWZa1pkayXiwcefaK+aUZTmlmoeBkyIzma/4k2aCR4AVidNdNby+fPhdNQ1/5xntiKTyPJu4c9Tf2gqqVAXqCTckwhgjppbgrM1mmp0ilNDP6EMkTQJccayn9rMc+vtYr+j4nm2qd32JrqOZeCMQjO+wAoe8vEAOnm2nUBEc87ItCooMCS5K9scKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zpthoi3Lr2+b0JuPpAwOn9AAG/xyFZazZl9X2h6hsX0=; b=U3RoOYv7VUgvTerGNLcIj4wxCCn9ucj9gU4NZBGw4VbNIN1MyoDu/Aaz0e+6lykAMby5PF3aLmDWh9kXFSdtCR4oErpH6f4+d1nxP24UYWbZ3X6Pan/UCRlUGs0msbPlAL2rMsLoWJbaHl3jh6jc4RhpS3TUwizLuYGXrp7uL40QzSxHWrEMzfRd1neOjJFXu7g8njfbd4vnMjo6KBOMZMyF8l724RzpBmFqtpPVQ3LtYW7VwQ3d3VaJ/LBEpvZrrC5No7uKpsdhXBCf1ojHjhVzr5q06kLOsKgacEmKoMxRfp/sBsgSBVTTVDTk2fK/AWtLihz0wb6ZskRr9i2mrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zpthoi3Lr2+b0JuPpAwOn9AAG/xyFZazZl9X2h6hsX0=; b=BgbpAkrpmUJ1t39Z95UZrifeg6wOgD+GGiO8BzW6yZIz6x/ihtdnyQJd8qwhTPIfX/hNXXqxBeVM5yZEHXCq8yeG1NyZJfnYCawuxlqCqH1aIzFraCwDA3VNs3RV8MiaQL/7cSKkNwX9MqL5Qb9HvaJ7cFpY+gsCqEkyO6w4mHQ= Received: from SJ0PR12MB7458.namprd12.prod.outlook.com (2603:10b6:a03:48d::13) by SJ0PR12MB8615.namprd12.prod.outlook.com (2603:10b6:a03:484::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Thu, 18 Dec 2025 05:40:12 +0000 Received: from SJ0PR12MB7458.namprd12.prod.outlook.com ([fe80::83e7:e6cf:26ed:2f3d]) by SJ0PR12MB7458.namprd12.prod.outlook.com ([fe80::83e7:e6cf:26ed:2f3d%6]) with mapi id 15.20.9434.001; Thu, 18 Dec 2025 05:40:12 +0000 Message-ID: <79fb5cb2-8a24-4260-a9e9-bdf2c5ef602f@amd.com> Date: Thu, 18 Dec 2025 11:10:04 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm/khugepaged: use enum scan_result for result variables To: Zi Yan Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org References: <20251216111139.95438-2-shivankg@amd.com> <20251216111139.95438-6-shivankg@amd.com> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN4PR01CA0084.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:26d::14) To SJ0PR12MB7458.namprd12.prod.outlook.com (2603:10b6:a03:48d::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR12MB7458:EE_|SJ0PR12MB8615:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ba1562b-91dd-4d87-2520-08de3df7e9fc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|7416014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ckc4aWZPb25PZW9TM3I0SkszS3FoZTlpVjVuYWlNOGVSTVUzc3c1c081ZzZo?= =?utf-8?B?TG5WejlIZC9pMTFyYUc5dFNoL2dTL3dXRmpBSjlKdGk3cUZQTWZNdC9RTTM3?= =?utf-8?B?S1hQdGt4aDhId0J5T2NrWENwSit0T1lYdmhyV2ZOQ2h4NGtIQXFreXk3SWdh?= =?utf-8?B?VzJPNFRqMTkwb2NLcUM2bk02d3k5VlQ3Wi9VMVpsUTMzcnVGNitSVzlXRndz?= =?utf-8?B?YXlydi90R0RYTi9tNWV6ZElCZUdudy95U2k4R0hFc3Z0WTR4bnVtQlB5L21l?= =?utf-8?B?eFJlRW1WOU1KUlFXWkhkbXdJVmFrNXdnS2kxWHAvenpYL0ZsQVh1TDYyU0tT?= =?utf-8?B?a21TaUJUSzRmcmJhV1Q2R3J1Tm4zSkVHNnVXMFZ2NGVnRURpajd0V3M5elRp?= =?utf-8?B?WjEwam1DWDVsZ2hjZHdVK0ZjVGNpZ1o2bSt0NVhNNkEvdWpDSjN6WFpCalZw?= =?utf-8?B?L2ozVTAxTWtyTEo5WjhaOWcyR3NhS3l2Q2liaExueXpBRFRvWmF5enRzSHJJ?= =?utf-8?B?M29vbGFCTncrQ2pNdWpqc1gvWnhWKzNNbTExNXdKR0J4NWIwdGJGRlVKUGtr?= =?utf-8?B?RW5OejViZHJXL0Q3ZjlDT3YwRlp1cExpcktGMWZFRktwWUd0VnhLNERxYVVs?= =?utf-8?B?dXp3Umpla3p6Ny9kampRYnprRVhBYjdXTk1qN2src0YvaHNmczV1ZUlxdm1U?= =?utf-8?B?My9FMHlzY05ONGpCV2pvVmF5emZFRU5ldjE1ZkFZSmorZGE4NEovWFBYbDA3?= =?utf-8?B?MnczNEhKRDlRS1pyc2NQaFdjQ2diZVRhMzREZEk2M3BwWHN3WjllcTNOam9n?= =?utf-8?B?b0JWK1dxNWtvU2Frdzc5RnpKMWZ0Wkcva0ZRMTNYOVc3OUZmTzZ3VXVGWFB5?= =?utf-8?B?OWFMYWFBVndTQVJHS1NOS1pNdWp1WjJLdUFhR3R5dSt1R2trRFJWejdNOXhO?= =?utf-8?B?OWttaTFTWTlJejcyb1pPcnlFdUJjVGFKaUZ2RkI1M3k0TGowQ05KTXdoTnhW?= =?utf-8?B?L0hTQy9iWEt3S3E2d3NpTkJoeVpVK0JneEZ4ZnZUWFFkb1ovdTBXeGV6eHhy?= =?utf-8?B?SVdKRGFiTWJVN0ZuRzFJMTV6MUxvb2xwVWVNRktVbm1VMHhnYUExeWFpbWVR?= =?utf-8?B?OFQ1dGppc1ovTTNJN3FaTk1hV2VkR1d0bkoweEt3U3VuL3kvYmwvNm96T2lk?= =?utf-8?B?U3dkd0J6eHZLWGxFbEZ6Zk5McGtJbGUvMnRZWnJaVDdGMDRQVXhSai9nU1Vq?= =?utf-8?B?a3Jza01yNVk5NzFMZ2diakhpS2J5Mkh0UXhYb29JeHE2b05HbHhnMlRUTy9M?= =?utf-8?B?N3hUV1lQQlZDamVpVkkvcXVMb0Nvem5QS3I3elVkMlROMlpLUG1SMDhwS0FE?= =?utf-8?B?T0xHUmZWbVh0YzhjdDlPMmhKanpVYThMV0FMZU9lMU50b2ZuOHFkb2tLMVlz?= =?utf-8?B?U0JyUnZqNXZRd3BSRDJabHhQOXU1N2FyQk5lb0FQRHI2TlpCVklKaExlZVRJ?= =?utf-8?B?cm5LTWZmMW8vVmJlMVA0V0lFTWpKeHpNN0JrNm82Z3hRUG14L3pGbzZ5VFkv?= =?utf-8?B?a2NtOGJrWFFreHZLN3ZQclFNaHVPcEgxS3J0cGN6VkpMR1hGMURSd0xpbXJS?= =?utf-8?B?aFY4T2J0aUNxNmZvTlkwalpua2dWVDIyTGsxVzdVNEQ3czZ0Mk4zUlZMS2Fr?= =?utf-8?B?TWRQWDZJdVFldkhEdUd1elRjb3daZGlrSWxRbTRzRWFWUkF0aTRqSXB4c0dP?= =?utf-8?B?TlBqdFQwSjhiMCtZaFBJVVVodHFpVEpMOU14ckgwbG1mT25pdVBnenQrOUNE?= =?utf-8?B?cmVoSENJTER0L3NGUWRiY1lUU2YrUS8zUnJDdmVQaC9PaVIzRW1FWWxXYm9u?= =?utf-8?B?QzIvak83RlRzL0VXMGVmSkVIMWwrWHY5SmdlMTVkdllLenlTdHRySG5XQVFC?= =?utf-8?Q?RT1UJ/90caAHH8xrZcEHz4HjQV8DoENC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR12MB7458.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(7416014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkdZLzVyUXFCTTVwV0lxbXNBTmFXNFRxaEFtZWZkMTZKbWszUzZoRWFNb3ZQ?= =?utf-8?B?Nm85Mjc3UzBaMkc3UWd3elVNUXRYZGJLRGdmUDZmK0V2VmIyRFJBVmxqVFJq?= =?utf-8?B?alNZa0o5WWtlYXNCN0RvSVF2T1ZYcHNJakFhY3FhZDlqWTZDTGdkOGl4NkEz?= =?utf-8?B?SGI3OXBpTGdmTUZ4TVAvMklxYWMxVzVNZnNWcitDY0lyR2tkK09NSjhidi80?= =?utf-8?B?UW5NNk5lSUtQTTRHcUZEamxnTFVkWEMvTGRwZG5odW4wRndlTHY0OFhqWW5h?= =?utf-8?B?WHYxQ3RiVTljZ3VVcG5qQ1EzM3RqSkhMMEFpZ2dNcjVzR1JMc0l0R1NLZThm?= =?utf-8?B?K1N1SEg1Vk1mWDRBeVFnSnRIemoxTDUwTE93Z0JDRjJlOTFXT2hvNGVQZG5p?= =?utf-8?B?K0pSZWhxZ3AyODZGOFVBc296aUhhRFNrbDd2TGFJdU1IaktzTmxtZFljQmtH?= =?utf-8?B?NVo3bGxjcHBaeDNiYXVFRzNEWWNTODJIZFo4TStidUJQRVdFeGlkTEdrRXd1?= =?utf-8?B?QnQ5NTRja2VDWlNMT0M3cG9sSHAvYkVZSmdRc01hTUUrdXNXVy83ZjNzUWw2?= =?utf-8?B?dVN4NlN6VTRuN3ZaSkVjV3AxNDZYN1N0UGhnVEpvRTBiNEpadTBXbmMwVkdS?= =?utf-8?B?Y1dnWWx1cUE1ZTZDUWlxVW1lbi9OVm1ZeEtiU0hmY2h1SnNGdm9sSmJuYmlP?= =?utf-8?B?Qm4vaXFiMXVUVkFkMjVPNkVkMkh0UGllOWY2a3ZNRE4xQ3h1RzdGTjFseXR4?= =?utf-8?B?WjNKK3lvK0d3bzVOc1U0U3VtSWFlYTE3eGVRbDFyVkxlbjEvSlNhM2YwNU1N?= =?utf-8?B?QjBYNDN4TFNKS0NjaWJRN0JwQkdGaE9mSk5sWnhaQ1M1bWdUR05ZcjJhSzAy?= =?utf-8?B?bDlZVFZHaUllRHhOT28zYXdpRHdxTUhXdERDSjJ5MmNQSUtRajBSL1F0amVv?= =?utf-8?B?a1FKZG9rUEFLdHVHek42RUFERm43b3BNRzhPMGVodkU4VXhnTG1hM1ppT2p2?= =?utf-8?B?WXhPVnNNN0w4NUtPelZCa21rOVJzRnBPNUdSOEQ0U3Y3eEJjb1lKb09OYkE2?= =?utf-8?B?S2FUKzBDbVlDOHE0Q2cxbHluMFBTYWhQWWZLNTR0UFo3ZHV5RUZVL0ZKWmhu?= =?utf-8?B?bXB5OFJtR25pK2ZmTTlEb2gzbWo2S29uK2dYMmRzNjE1QWo4K0thNU1uc1Bq?= =?utf-8?B?T0xqQnBtd05hVDYzNy9iajAvYlJRcXZnZEpEK2hzK3hQcnNmS21wWjJpNHNP?= =?utf-8?B?K29IM2JZemJLNHNjelp1c1RQZ3lEbEhNeENITHN2ZEpmTFkxVE5xak4vTVRO?= =?utf-8?B?WngyU29zemZleEpMbVFZTWFQcDNndzUrd0IrRzZTdVcwY01tbmJ0S29MVmVC?= =?utf-8?B?VnZOUmYrckUwNGx5WFNxN3VneHJzUExCWnRjVDhQZWp6TkMrcUFJZEwzdHp0?= =?utf-8?B?NkduZ2MwYVlVdmxUMjlMQnV3MHFwdURSYzJmRFFTTy9wVFlNV2N4Z2pNMlJ5?= =?utf-8?B?ZUludXRjMjFDUkc5SXAwTkNpVDJnS1VaZzVXOFJKUlAzUjRZSHZHa3VNWnlL?= =?utf-8?B?MHVSSnZYRmFMY1BVbS9JeGdrbGkxWklYNHRBbC9wank5WUN3dVhXSGhGN1Bu?= =?utf-8?B?N2trOFhUVXp5L0NOaWJ2UHBSQ3YwaXVacVNVdllSbnVQaXk3OWdXMHY0czR0?= =?utf-8?B?NkhrbnBYKzBDUDFncC9PcDBtN003bC9TLzZGdFV0bU45blRtaUFtdVVzdVpN?= =?utf-8?B?U3JsS1IwZE1xMDBCMkVEa1NjekdxME11U0RrVlVsZEQrdjNvaGJVY2NZa3p3?= =?utf-8?B?eVkrVlZYK1l5ZFVGclVnUFJNYnFPdUlleE5OamIwV29vYVYydVJULzQrVnpR?= =?utf-8?B?U0JpWDk1Q29MSU5OR0lqY042RkNXazBheDV2MWowWUVCalBYMEVvOWU4R09w?= =?utf-8?B?empuWHBRa1U4MmllL09vdDN2eCtyRk9JNEN4ZXZ3VTFqSERIbFk5QURDK1l2?= =?utf-8?B?Q3Q3WE1IUTBIRVRoQzFjKy9HN0NvcUt5ZmNzTStjblo2Q2NZbHhSUnkvbERG?= =?utf-8?B?Q3lhWnhLbyt1MVJrdGp3d1EzbTBVZnRteE1VZVlxZTVZblVVY0lhNWx2VVZj?= =?utf-8?Q?iMIylVSIzBuuu5nQEDFkSjcN3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba1562b-91dd-4d87-2520-08de3df7e9fc X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB7458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Dec 2025 05:40:12.6644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4BG68sTA8ynVMQbuVBLQpLfMy8P5+VqLmF7Iz9ea4DBDDfPeBg+XuHx6cxB1ou4ckTb4DI6bxhKMoCf7HD+ZQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8615 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 375D4100002 X-Stat-Signature: tfkc1tww5w9jtt1ec98fcxf1o5acsq7j X-HE-Tag: 1766036416-843142 X-HE-Meta: U2FsdGVkX18gASLo5p6S6NL7tbjoq46Rz5tHCqZc6IhxuZoVbEiaGRc3zINzq23XGiMk+LzystXnQZvnIpjJNQONZK46rVo09qxJk5m9Pal88PEUDazTL1IOqqsmw6wJCPv5YJx09cqWdAKQcPJOH7rcTDZBxQko8qT0x+RnUhbvPBksBhjzeS4lUCPeqQFllguw5ni8LYuJuVia5FlJZiTPd0F4+dvB1pBOt0OlN4qdrQ/bLxvAtNjxZHn9TrzutUyF6uiQGaF5S8aXt4Vz5/Dp9VP4qRr0zmHZMu2L8Vy1dPjeFLlv9MzwTACibC3cYhRVtvJVpQpiDFUrYYqPzDSZjArHoZnHv11KgajpzhHHTKrHMzbhAL2XQkI8HzYvIUCmGweqkFSximuHSplfnvp1P+xA/sLukQX2xq6/QmSP1zM5bEtt/AeFOLFGNWzHnrpnSbLetuJEgu+VayDFeRziS5XKrxm4vyzj/avsH7Dusun7+N9BA/flig31qSEEXxrjYBvVqqr160bF2yIXLkoChK4kRuPM6tdRVHqiT0DYKAzP1fyYP657pHo74cPfaM5DvP5Kd2XPqjMWGzxA9int9u7vvVu9kq9tZoLiciFaZancQaSV3NT5vP5pyWxsgfMee/93M4hPDkCJUH5/y8/xDKybGKApTT6CBiTpvMnwKI/86UE2x77VQO5Q7qNeHddKLj8nYts7N3XwuxwlArAIbqJnmaMwuXJ0qBEjSDDlTTpfzO5Rr3ecZsqzhalJENmPtdG7YB8ZPuBNf4/iZvI8vyHlifcj05dR+8KkJ8P0mI/yRHfCFX2ja5CXYkYYdZFytTNFQd9NAtIPJP2rOqkEMoaoItAEKySqIqzR65BjplxSLK0lk2QmUASqcV5zhrIzVq++nQGBcg2FgJosyMN5GjaOuTJCVA8bDeOpB90iL6kWvP1x3F954pusZgGYKhjZ+u77ldTJsN+yOP+ v2Nr33Jn Ftv/uiunOzd/NBCyJEAjfe3ADWu0ulPRb1S6KFP/2uAR//WfX9bYlYmoHdH9HJYDzxVdfgBtGJXQOMDzjFi6rCYwOiuU8ywv0YrOQzIbFRy7hF+FdxLsgjIWnMQCjzebxOsS0vEN3hcbgzMFBWW9UWN4kKvdc8WLBu/THZ83+HwQr2eyeyIiBY6td/Z9jV4yDtiwIoVsI7govGFAouYSr90RxALFei1apYFjNl0he/V9uBRTaCLgvDriLG1i2QCqTkK3ejW9JmanrjsnylElDo2QM9J5qGTX/Egoe7xgE0RzfqgejH8oiN/3n9QFQdUKwF6vyK4tGZLFgsXoivqMtpCYfn9k5S8ZrJ2HSp2K4vgh0ABHIMs6tKhoTHnmQ7cNqJx1CRjJkhzyExBsHmwW36U550gJ8lXBKk9IwqyrycJ56dlQl9yinA64qzwGQ2pIt3PPRRF+ENI59VTc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/16/2025 9:08 PM, Zi Yan wrote: > On 16 Dec 2025, at 6:11, Shivank Garg wrote: > > >> int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr, >> bool install_pmd) >> { > > And here. Since this function is declared in khugepaged.h, I need to move the enum definition to that header. I see two options for handling the CONFIG_TRANSPARENT_HUGEPAGE check: 1. Define enum OUTSIDE the ifdef: This allows the static inline stub to also return enum scan_result, keeping the API consistent. 2. Define enum INSIDE the ifdef: The enum is hidden when THP is disabled, forcing the stub to return int 0 instead. The only external caller (uprobes.c) of collapse_pte_mapped_thp currently ignores the return value. What is the more preferred way for enum definition in such scenario? Thanks, Shivank > In addition, the return types of find_pmd_or_thp_or_none(), > hugepage_vma_revalidate(), alloc_charge_folio(), and check_pmd_state() need to be changed to enum scan_result too. > > Best Regards, > Yan, Zi