From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E54EE7719E for ; Mon, 13 Jan 2025 05:55:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4C996B008C; Mon, 13 Jan 2025 00:55:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB746B0092; Mon, 13 Jan 2025 00:55:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEAAB6B0093; Mon, 13 Jan 2025 00:55:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9235D6B008C for ; Mon, 13 Jan 2025 00:55:49 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4459A1C762A for ; Mon, 13 Jan 2025 05:55:49 +0000 (UTC) X-FDA: 83001367218.18.BC15A11 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf26.hostedemail.com (Postfix) with ESMTP id 2722E14000E for ; Mon, 13 Jan 2025 05:55:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736747747; a=rsa-sha256; cv=none; b=XWW6WfxjMf8/LSjXcFljiQ7l+SD2firKfv9HCV/AnuZ3x28/+Bu59ItEM/BXMZvnVuyK6/ 1g8ECW3Ckcd886TXGWkYPTfPqd6TuIdd60eZrwkfMQZyrW5bfyupoBDT8kNs+sY4z98Xwi Bz+TD4JCUQMfL91WuHdTUyBxgBCk7Hw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf26.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736747747; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AH4JPnDj9kmOQX6N/Zfxo5pnfG6b5kjILK8BdIC7AcU=; b=7TObQiWjYRvaRZ8nlqRv71g6ZEpr77z7XQkvEv8CIIrCRGBap3ri8fAjP0oQKg8LAFwnXN Vo1E1GDUjBP98/F7pGo9iI2ajHuboCXRoGeZcxDSt4v3pYMseF+s6JKcpXki6SSClj/EJ3 moLDPNeKxi5uIJxZXSpRaaT+/LOo1pk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5CB671595; Sun, 12 Jan 2025 21:56:14 -0800 (PST) Received: from [10.163.57.117] (unknown [10.163.57.117]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AD64C3F66E; Sun, 12 Jan 2025 21:55:43 -0800 (PST) Message-ID: <79f364d7-b94f-450b-97ef-c7539c9671ce@arm.com> Date: Mon, 13 Jan 2025 11:25:44 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm/cow: Modify the incorrect checking parameters To: Hao Ge , akpm@linux-foundation.org, shuah@kernel.org Cc: sj@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Hao Ge References: <1514aee8-e75c-4c05-8943-65681254feda@linux.dev> <20250113050908.93638-1-hao.ge@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250113050908.93638-1-hao.ge@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: x5hecs8odnkky4bxb6umas17we68du7o X-Rspam-User: X-Rspamd-Queue-Id: 2722E14000E X-Rspamd-Server: rspam08 X-HE-Tag: 1736747746-522191 X-HE-Meta: U2FsdGVkX19ZzYIKfeurFleoXK6Nl0R0ystYlWrqp9vPcOSh5lFJ6W2/YO1njgngYqNM4XB39U22cHx+yI+i6pkZ8X2MpBPLbf9QReUKnpjaycw2I2Rd2tINTEB5+Fi7yxtoJVytysB5nYmVTgbcyQUGoJJcB5qg9y9LYRLJy45HyXeqy8C6ji57ynKdB+u/UeBDMZeBHnz0lmJDO+FRE1JCDulO2u5Jeo6zfaUVmXGF9t7OFrn+ZscFUx4FEPTYgVg+r1Zrccv+lBu2er37rIo0l3KHdOcsjIi7oKgKkUCok6QnwdBCCuKSVU8yLj4WpLm8dWFgFMAYSGU7ZGXUONcLHW8cv44wMuCiY120m7DrnrfGpXioiaXlhTxG6/ZlSLy/VAoVYbOZAD+r/xenlRCY1sj5vVV5sHmeV659kLHXTQqIY54rZC2GupFc/PW0ykdjwxMtBXrPXWeJEMyPydlouUn2PJKy8RWYFk40M1BN4ZZWGQMcTlLX3A82EXs05+Npg29VNU8JLQWJxsLPZHrp5JNkRiaxtn07hOvBFSLeQ2OK3YkP+9THzrF2xl8pejxkjDUAsne5+v0m8VK4IiPSfPSrGApd+zk6oKqu1xM5IaN3107vErMbSYglFe2GPRRnEgvdaU7M0j4N3VZpspkZRyemhDxfiia3wAV3OleIn/H+uz9x8W0cw0J6bN9EnuwVQpnnKs0fCNH034cNcvv70Bl7QxvxX5aow5oABmjD834ZDstVZQPyROQR0UNDXX7SRFT97qsMD+MVajYpdnhiFS/IFo9MnmxaEdYkLlNP9O4MVyLL3EE1zR+Z/IkrqDWaaIHCFLinZuqSQ9VClH6KanY9I+JeJkqX83EWQ0T4n01iY9RbCf39ttegMYYQDhVD4rt3CJ/9gSuNfnqqdcRu67+2jThhdvw6voL+++PO9HDTF8Laic1ExQLPn21nR8sRlPmS3YNKxbye83m jZWfQOcw abJ1xkhprBREO0dnkBlCn2iwlETtDuvyteD0j8YJpDqM01TG3gg8t9BtrCXdbMjhMQuaCBCxoKnEn+8nQp9B9pyL7OGuqcDnJ+1tEfvJ4ADOGuWzhDpnzfE+0iozxQ14oWHdJmCJnlMkHQ4SmxgnsMK3lnC3J5dfVkO0oPwBPMPLch9B3xrISLX4Jg1cfV/qSM2IUKHaxqPahN9c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: A small nit. Please always send a new patch version separately as a new email thread instead - not part of an ongoing discussion. On 1/13/25 10:39, Hao Ge wrote: > From: Hao Ge > > In the cow.c,some error handle have passed incorrect > parameters. It should be "smem", but it was mistakenly > written as "mem". > > Let's fix it. > > Fixes: f8664f3c4a08 ("selftests/vm: cow: basic COW tests for non-anonymous pages") > Signed-off-by: Hao Ge > --- > v2: Anshuman pointed out that the error is not limited to the run_with_memfd_hugetlb function; > there are other places where it occurs as well. > Therefore, let's fix it all together. > Similarly, Update the Fix tag to be accurate. LGTM Reviewed-by: Anshuman Khandual > --- > tools/testing/selftests/mm/cow.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index 32c6ccc2a6be..c52c93996ba1 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -1482,7 +1482,7 @@ static void run_with_zeropage(non_anon_test_fn fn, const char *desc) > } > > smem = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0); > - if (mem == MAP_FAILED) { > + if (smem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } > @@ -1583,7 +1583,7 @@ static void run_with_memfd(non_anon_test_fn fn, const char *desc) > goto close; > } > smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0); > - if (mem == MAP_FAILED) { > + if (smem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } > @@ -1634,7 +1634,7 @@ static void run_with_tmpfile(non_anon_test_fn fn, const char *desc) > goto close; > } > smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0); > - if (mem == MAP_FAILED) { > + if (smem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } > @@ -1684,7 +1684,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc, > goto close; > } > smem = mmap(NULL, hugetlbsize, PROT_READ, MAP_SHARED, fd, 0); > - if (mem == MAP_FAILED) { > + if (smem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } > @@ -1696,7 +1696,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc, > fn(mem, smem, hugetlbsize); > munmap: > munmap(mem, hugetlbsize); > - if (mem != MAP_FAILED) > + if (smem != MAP_FAILED) > munmap(smem, hugetlbsize); > close: > close(fd);