From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Hao Ge <hao.ge@linux.dev>, akpm@linux-foundation.org, shuah@kernel.org
Cc: sj@kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Hao Ge <gehao@kylinos.cn>
Subject: Re: [PATCH v2] selftests/mm/cow: Modify the incorrect checking parameters
Date: Mon, 13 Jan 2025 11:25:44 +0530 [thread overview]
Message-ID: <79f364d7-b94f-450b-97ef-c7539c9671ce@arm.com> (raw)
In-Reply-To: <20250113050908.93638-1-hao.ge@linux.dev>
A small nit.
Please always send a new patch version separately as a new email
thread instead - not part of an ongoing discussion.
On 1/13/25 10:39, Hao Ge wrote:
> From: Hao Ge <gehao@kylinos.cn>
>
> In the cow.c,some error handle have passed incorrect
> parameters. It should be "smem", but it was mistakenly
> written as "mem".
>
> Let's fix it.
>
> Fixes: f8664f3c4a08 ("selftests/vm: cow: basic COW tests for non-anonymous pages")
> Signed-off-by: Hao Ge <gehao@kylinos.cn>
> ---
> v2: Anshuman pointed out that the error is not limited to the run_with_memfd_hugetlb function;
> there are other places where it occurs as well.
> Therefore, let's fix it all together.
> Similarly, Update the Fix tag to be accurate.
LGTM
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> tools/testing/selftests/mm/cow.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c
> index 32c6ccc2a6be..c52c93996ba1 100644
> --- a/tools/testing/selftests/mm/cow.c
> +++ b/tools/testing/selftests/mm/cow.c
> @@ -1482,7 +1482,7 @@ static void run_with_zeropage(non_anon_test_fn fn, const char *desc)
> }
>
> smem = mmap(NULL, pagesize, PROT_READ, MAP_PRIVATE | MAP_ANON, -1, 0);
> - if (mem == MAP_FAILED) {
> + if (smem == MAP_FAILED) {
> ksft_test_result_fail("mmap() failed\n");
> goto munmap;
> }
> @@ -1583,7 +1583,7 @@ static void run_with_memfd(non_anon_test_fn fn, const char *desc)
> goto close;
> }
> smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0);
> - if (mem == MAP_FAILED) {
> + if (smem == MAP_FAILED) {
> ksft_test_result_fail("mmap() failed\n");
> goto munmap;
> }
> @@ -1634,7 +1634,7 @@ static void run_with_tmpfile(non_anon_test_fn fn, const char *desc)
> goto close;
> }
> smem = mmap(NULL, pagesize, PROT_READ, MAP_SHARED, fd, 0);
> - if (mem == MAP_FAILED) {
> + if (smem == MAP_FAILED) {
> ksft_test_result_fail("mmap() failed\n");
> goto munmap;
> }
> @@ -1684,7 +1684,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc,
> goto close;
> }
> smem = mmap(NULL, hugetlbsize, PROT_READ, MAP_SHARED, fd, 0);
> - if (mem == MAP_FAILED) {
> + if (smem == MAP_FAILED) {
> ksft_test_result_fail("mmap() failed\n");
> goto munmap;
> }
> @@ -1696,7 +1696,7 @@ static void run_with_memfd_hugetlb(non_anon_test_fn fn, const char *desc,
> fn(mem, smem, hugetlbsize);
> munmap:
> munmap(mem, hugetlbsize);
> - if (mem != MAP_FAILED)
> + if (smem != MAP_FAILED)
> munmap(smem, hugetlbsize);
> close:
> close(fd);
next prev parent reply other threads:[~2025-01-13 5:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 3:28 [PATCH] " Hao Ge
2025-01-13 4:26 ` Anshuman Khandual
2025-01-13 4:59 ` Hao Ge
2025-01-13 5:09 ` [PATCH v2] " Hao Ge
2025-01-13 5:55 ` Anshuman Khandual [this message]
2025-01-13 6:02 ` Dev Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79f364d7-b94f-450b-97ef-c7539c9671ce@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=gehao@kylinos.cn \
--cc=hao.ge@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox