From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08DCC7EE2A for ; Mon, 30 Jun 2025 07:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07AF36B0096; Mon, 30 Jun 2025 03:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 051B96B0099; Mon, 30 Jun 2025 03:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0E746B009A; Mon, 30 Jun 2025 03:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id CF1D16B0096 for ; Mon, 30 Jun 2025 03:58:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 73419B9895 for ; Mon, 30 Jun 2025 07:58:59 +0000 (UTC) X-FDA: 83611315998.02.5718E80 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 0F853160007 for ; Mon, 30 Jun 2025 07:58:56 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9JYlKVV; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751270337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uKchN/Kd3xPno2/C3cLbSDdTj6THoTeapF7mxwqqs5s=; b=h7JSK3pLf7G+2wVyq23eQ/onMNocs5RQT0tr00KaCgqU8QEN1ixLBqB35C9gQRIgQvhBYb Hb4vcLKUrzjPGNXEMo23pTjmrSGyTzomY2seqziHerSbnlMOwGC1HFvilMLyzmb5Oxb5/9 g7NEdOA5vw9ghVahWGtrYOK0Yp6KxvI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O9JYlKVV; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751270337; a=rsa-sha256; cv=none; b=wyPfuSFwyCiDDplqyqAJKWZko1PUwQYX9tmK5fkvmfXeQCqtLqxocMmlbwbP9zw3SQYSnY iQypDZKKGtqwkkL+hdrVawgW+6AEpdXQvRVygzWMutI2CMSOyGxmXG5pnHvXjET0jfnP4C cmt+/cIJWT4jL3TTaFBsEyd146C+8Rg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751270336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uKchN/Kd3xPno2/C3cLbSDdTj6THoTeapF7mxwqqs5s=; b=O9JYlKVVIeDoEyy3g3KOzDWEA+Fu2p9U424wngnjx0tuKPUeV2f4ll8njZNxkhjkTDZ7R3 DV0htGA9nbVjHk2QjeFgblJmeiqlmxRAFbJstblPDWeqvMAy9IEtwxtFlrdnXkMO5lCbwK WgOXMcqg24JMeg5zDPhyQ3Q6o44ee6w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-wcad_F9NMv6vt3Z0c3qWEw-1; Mon, 30 Jun 2025 03:58:55 -0400 X-MC-Unique: wcad_F9NMv6vt3Z0c3qWEw-1 X-Mimecast-MFC-AGG-ID: wcad_F9NMv6vt3Z0c3qWEw_1751270334 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a56b3dee17so2469796f8f.0 for ; Mon, 30 Jun 2025 00:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751270334; x=1751875134; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=uKchN/Kd3xPno2/C3cLbSDdTj6THoTeapF7mxwqqs5s=; b=QA/cc08Dl1F9iDj5sfo4CUwJs5bzyWdOLBcKBw+KAzSQvxlp7UcSkmzcq9Myn4GPCo 64byU439IKv3MVSuYAbH5yvsV23Z5nQnu5AxGeQ7QMqaxp1o2WRZZ79G5QutZjm9G5F2 amoQf+W2NBfiUXz/B+W0/5F07P5FocTCxT/GVT4or66HfGxdCCJHRf1uShb47BbBB2GF ug83EJxXQq05l3c8z8Uo4jaFxvbZj9TA82Vc59yC0PWloTXbrz9+ITHiAQCASIFfc3W7 1jWCeQ0wTrOx/mE4Jum1hoQSgcGPjEUpoUEguuDSk7xnmTB93JnNwcAmdsLljihuk6yC jLOw== X-Forwarded-Encrypted: i=1; AJvYcCWc4TfrSUnPjqgeHoByCZ8ZzM3gOZ169L2BlhIGnvyl38AnR/SKWIaL+vkHf1XKbV8V1rIPXhelTg==@kvack.org X-Gm-Message-State: AOJu0YzlgKFr3+kSM7tXlpwlgQKaKm7XuiaWyxuB1eThzRZC4zYBegAB l3bHVOUR5n/1Sytx3l7ONvT/k9XFx5jLCKrVl6z6N0aKjfVzs0MVyKonTFfP4eieHhXXVgrAWSk Oo90ioKF4QRRANjub/KAaZtVOtWXaQ33vUPHlwLl4uZ7oo75VwjnK X-Gm-Gg: ASbGncvWYT8Mvrx6auKjOWGJzxBPynkIr1VqVi3RwAih5NfdaSdsDmGtge8CjN46xA+ UzksxfEdhqd00LeRRXwvFyH6iJHQSK6MLMhbbgbSdiFcvUIKeSCaIjcaW5/yirXxbh/c5MkHvDu fvZqRMGCkDF5nSY/3thkCe0yFNAMyyC4jKBwfUhQ/2h5nvNRQOZh2GdCCGPtvN0P2TPEv69359P 6acq+6814oBqpj7p1y5qC0gK9C02clkMJx+GVHwaeHfXCGX6+e6/rfAOjacOFLRllrIup3K6Hg2 FxnUhWt+dI5Xu90id4gSUVmmShT6PZMvd6cKbBb8Q9FssbiusJ4sDAPsTRlomVcg8NRhX952mA7 vsAfLr1c06Btw5Jkaz3XH9JQ7h175xckMpKRFqd6GaaO3e6ZD1A== X-Received: by 2002:a05:6000:40c8:b0:3a4:dfbe:2b14 with SMTP id ffacd0b85a97d-3a98b53f408mr9929764f8f.16.1751270333858; Mon, 30 Jun 2025 00:58:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg6jLM4W2W7u+JMBhviwlHgCOipqDz/vK1tURQH3cYOb+VSv5PC2t/JtU8pMUXYnag/Sumjg== X-Received: by 2002:a05:6000:40c8:b0:3a4:dfbe:2b14 with SMTP id ffacd0b85a97d-3a98b53f408mr9929741f8f.16.1751270333431; Mon, 30 Jun 2025 00:58:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f40:b300:53f7:d260:aff4:7256? (p200300d82f40b30053f7d260aff47256.dip0.t-ipconnect.de. [2003:d8:2f40:b300:53f7:d260:aff4:7256]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e591d7sm9803295f8f.67.2025.06.30.00.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 00:58:52 -0700 (PDT) Message-ID: <79f19625-f5d4-4e53-92c7-c4b34a0a6a98@redhat.com> Date: Mon, 30 Jun 2025 09:58:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] khugepaged: Reduce race probability between migration and khugepaged To: Anshuman Khandual , Dev Jain , akpm@linux-foundation.org Cc: ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, baohua@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250630044837.4675-1-dev.jain@arm.com> <786c83e0-d69f-4fa3-a39c-94c4dfc08a20@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <786c83e0-d69f-4fa3-a39c-94c4dfc08a20@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: RiURE6GN0sTIVnFixXwFU7ZMdPlP5c4nEEe_VyYcRsw_1751270334 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0F853160007 X-Stat-Signature: iodu1q6zmtf98zkdyyf6pqe94fp1mrdu X-HE-Tag: 1751270336-282236 X-HE-Meta: U2FsdGVkX19BN6VckIob+tlk3bi2RGVI5YeuwWrEp+0y6aTR0gQ3LwqD8IuXClCs4ieKOX4tYkHjBcbPFoOf71hXpqajXtcKBde1z3bV4t9aVk5XWF//QsIgqNC0cEHGJY9NN0B6fdXYkPai6VVlNKAAbu4bWtDErabKoB6Wixh2fkCts1FNmDloA17nIgGtYnQSJag/7QFvCCtrbfwvqGjkxLutsDERp1bwsRXPmWxz4qkTAubYevt8UCkIMLT7tfZwO7ye8HiJhI+ylOwFxV08htBrxUq66ozzTBvthrUNKrpQqpvXZcV7pX0J+IhWd8gFd/rV26MBeB52WTpWlbPfDeDx1LL0mJvqlBiQvGJUlx5AKy6of/yeW4VsyO+sNCxbhu6SMY2vwFCesdsilmbhG7bYjObif9nYDrKTnFb/E2kfMrj/9+JUxaoohcC4+EyHrZ9M9Q7Cdv95aMLivnY1kCNgcPYCaMrdEFbIJNBjtQi1upS+io/lstwWCPtS/QsTyCq1k9R5PocNp+0LdNwr8d8E/3f4euokGKGzcTD2vL1meA77lNiyfIsfx4TSw42Wnh2NLdblRbP1oAw+hro3L9eBv/zCUbtoA7s6kiEutnPuzBD7cWjOHs2jEcl1Ph6M5dQ7djVtbiT5Jii482wgcytrh6yj5YPgpKVFVO5cQSSj+MZ9Pr+SeKmdZOaH1rFqc5sB+etzXfK5xowRolw005912r7elCblZgTvZ9DqXeFVgj4baWzvpFIUmFmVSMjswHLKbS2nreT8m40R20LJbg5eZGcosyodgeegzfAvqYcqJbGRgRX8I3dHXEAoXK2WTxEJUZx9MMReuEGR0QkJqrRgDMcdaUCyTkkz2MmRn7mG33BjUOcoanvGpNYm2hbxbh94G9S9vsr+kP2HoGpMGj5tSWGOl4X3RxNGC3JtJkDe415H7eiLR5R6maXQgAa9YEMjiYJqellePsz BvF2pobX NyHMWddjILB+st45N5Ouf42KX+kWmK1KhRxjSnm7/i+R84Nnlou1Iy8S3V2QtvCjLSa24k7XubGDhn0gWtjIAgfFXMgo99oEm6yZjI7DkfMCktz2QnW3zF59mZM4UKoECQ6uvcUHc8koEtw281UBxUYkTvqGq3Ms9s+B7FyV10WLulOBuXxWWeB2jJcoWHIA58gVhtfibj8+o6eluzXJ5xnMgqB3+IOZam+lOH5JeH7719r7xahFvhNz4/s9axPvHUhqp0IFoSbpJg7FitYi3tMtB0oMdTMBlh2GEMPRXtv54A8+Ms5G3xOf0PdYCdE4A5QAXrCwDlPcaX3nDeBNAkMXy/ogkFM5uLhoS2deB9nYJc68zpObPGe6ddiuXDFcapiZzh47XVSW4MbK+hH9gJlmDE8xjIPh8BLyLaDzE8fDZ5Q8ugSNq7Z5je4jQuGhMZ3ZsL2bS9rBwJUi5wjJNFCmPKfZRtZGaEoa9Y8eOom0JhfhVwI4Ae4ryn/tCkEJ0RHxyA5utasdt3xxkFoPClLbLgS4MjBt31Lc0PAVCNHNWkJyHEoVdeXmnAV90JioiOSznceL98hSR7PE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.06.25 09:55, Anshuman Khandual wrote: > On 30/06/25 10:18 AM, Dev Jain wrote: >> Suppose a folio is under migration, and khugepaged is also trying to >> collapse it. collapse_pte_mapped_thp() will retrieve the folio from the >> page cache via filemap_lock_folio(), thus taking a reference on the folio >> and sleeping on the folio lock, since the lock is held by the migration >> path. Migration will then fail in >> __folio_migrate_mapping -> folio_ref_freeze. Reduce the probability of >> such a race happening (leading to migration failure) by bailing out >> if we detect a PMD is marked with a migration entry. > > Could the migration be re-attempted after such failure ? Seems like > the migration failure here is traded for a scan failure instead. > >> >> This fixes the migration-shared-anon-thp testcase failure on Apple M3. > > Could you please provide some more context why this test case was > failing earlier and how does this change here fixes the problem ? > >> >> Note that, this is not a "fix" since it only reduces the chance of >> interference of khugepaged with migration, wherein both the kernel >> functionalities are deemed "best-effort". >>> Signed-off-by: Dev Jain >> --- >> >> This patch was part of >> https://lore.kernel.org/all/20250625055806.82645-1-dev.jain@arm.com/ >> but I have sent it separately on suggestion of Lorenzo, and also because >> I plan to send the first two patches after David Hildenbrand's >> folio_pte_batch series gets merged. >> >> mm/khugepaged.c | 12 ++++++++++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >> index 1aa7ca67c756..99977bb9bf6a 100644 >> --- a/mm/khugepaged.c >> +++ b/mm/khugepaged.c >> @@ -31,6 +31,7 @@ enum scan_result { >> SCAN_FAIL, >> SCAN_SUCCEED, >> SCAN_PMD_NULL, >> + SCAN_PMD_MIGRATION, >> SCAN_PMD_NONE, >> SCAN_PMD_MAPPED, >> SCAN_EXCEED_NONE_PTE, >> @@ -941,6 +942,8 @@ static inline int check_pmd_state(pmd_t *pmd) >> >> if (pmd_none(pmde)) >> return SCAN_PMD_NONE; >> + if (is_pmd_migration_entry(pmde)) >> + return SCAN_PMD_MIGRATION; >> if (!pmd_present(pmde)) >> return SCAN_PMD_NULL; >> if (pmd_trans_huge(pmde)) >> @@ -1502,9 +1505,12 @@ int collapse_pte_mapped_thp(struct mm_struct *mm, unsigned long addr, >> !range_in_vma(vma, haddr, haddr + HPAGE_PMD_SIZE)) >> return SCAN_VMA_CHECK; >> >> - /* Fast check before locking page if already PMD-mapped */ >> + /* >> + * Fast check before locking folio if already PMD-mapped, or if the >> + * folio is under migration >> + */ >> result = find_pmd_or_thp_or_none(mm, haddr, &pmd); >> - if (result == SCAN_PMD_MAPPED) >> + if (result == SCAN_PMD_MAPPED || result == SCAN_PMD_MIGRATION) > Should mapped PMD and migrating PMD be treated equally while scanning ? Wanted to ask the same thing I think: why not simply use SCAN_PMD_MAPPED? After all, the folio is already pmd-mapped, just not using a present entry but (temporarily) using a migration entry. -- Cheers, David / dhildenb