From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717B7C41535 for ; Tue, 19 Dec 2023 17:56:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6BFE8D0002; Tue, 19 Dec 2023 12:56:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1BD28D0001; Tue, 19 Dec 2023 12:56:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E47F8D0002; Tue, 19 Dec 2023 12:56:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8C6C78D0001 for ; Tue, 19 Dec 2023 12:56:37 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3E101A03E4 for ; Tue, 19 Dec 2023 17:56:37 +0000 (UTC) X-FDA: 81584322834.25.DAB502B Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf30.hostedemail.com (Postfix) with ESMTP id ED3038001E for ; Tue, 19 Dec 2023 17:56:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=dvjG3qMo; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=LAjWUgxd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703008595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WU2yvYz91boprhIP6+puBEddYZyA+Gt+AEiyct5l+lI=; b=EStYh+VJEvup5G2bFMCgWy9kwVeAV7+c3qXT/XYy/CxBURvmmfx2Q+g+9HUNfnP6aHNo67 B/vBGw4tBmoQUgfnBvlmMNfCZ830Dipk8EYyNTPGzLeCeCOQs7M7+jgDq05InH3wMvweV2 K9L3RqGcBkOLPh0Srmiq1iqwcgfueyo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=dvjG3qMo; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=LAjWUgxd; dmarc=none; spf=pass (imf30.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703008595; a=rsa-sha256; cv=none; b=mzu2cs4YqQPfZOmvTHr+AVbBPrCpw1GBWLXhAoiBvfdynNNidYJjWA2QRH3GpD3It0iYvI d91lYm4a2kB0w4u/4dBsjImmPtCVbgZ/RLWk7PkkNCuWYx1RWqmPci0SN9+oVSO/Bb1hEQ MtaNa6Y0tPxEVASKrkGzOiqBxzwF62o= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 49FAA5C01CF; Tue, 19 Dec 2023 12:56:34 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 19 Dec 2023 12:56:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1703008594; x=1703094994; bh=WU2yvYz91b oprhIP6+puBEddYZyA+Gt+AEiyct5l+lI=; b=dvjG3qMoNl9UGeyecEjJDCHnYd 2dJrM02zRpoAh3BwrJVyhz2biS2BZzRMgNxs8RIqCeWAn8tNXUgpWeaK5C3JTmA7 UwWTVY0DsYlUsYeZMzmFoE3mNUeFzz/+tAh24W8+hJmIa2ztb3mnyPQoV1Pm1cvW S6urYKvOCjhmQ0VHnw9B6Gy5DqTGo1G+HkirihxPB3NfnBmIFVYLqDPt6nAVeOaB A8At/HO3cCrycOp/dzTZ+npiPojsdDH7AhJviSHDKPaVBVDXuGbYBRTgZavzDdVV v2NNVvu4qEKI7Q5lny4BrsDQ4nSz/nDghbNL4B3nkj+IgJMkYfVXdPSTN5kw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703008594; x=1703094994; bh=WU2yvYz91boprhIP6+puBEddYZyA +Gt+AEiyct5l+lI=; b=LAjWUgxdNQEEA7YL6h9fYC30mhGXTmWiOtzP1t+2r+ID UGmiL9g+TTZ5TOTCGNN3+5Z1LjfX3a7nA74wBI5Ky2Ixjrg9dFQpWLektiv9LAan +vLbv4VG6tmP4y4FJ+w9DngEKC3pMCMrtFgg/2/BD0rp6v8vs2CXTz6Gh7p/9v3o fBfBxgifOZV6wN0yOl42+TY/UbGeUIpgHbLpnO/DH0e8yTVc6OorT8Y0Dvdh3eRt oXV1eBl0oapZ/++1Iv7DGM2pDMYJtNUM3ZW6g8Goi0O2Zv8fheIlYgalZpefy1sg j454hi3496+qrKuu22vg/bx9Kj9Xrds2w31MDq2Sdg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddutddguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtse httdertderredtnecuhfhrohhmpedfufhtvghfrghnucftohgvshgthhdfuceoshhhrhes uggvvhhkvghrnhgvlhdrihhoqeenucggtffrrghtthgvrhhnpeekheefvdetueetffffhe ffhfdutddtkeejueffveeijedvgffhffehvefhgefggfenucffohhmrghinhepkhgvrhhn vghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 60A88B6008D; Tue, 19 Dec 2023 12:56:33 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1350-g1d0a93a8fb-fm-20231218.001-g1d0a93a8 MIME-Version: 1.0 Message-Id: <79e0cb77-ea6a-427f-af5e-c1762049ac89@app.fastmail.com> In-Reply-To: <20231219142508.86265-1-jefflexu@linux.alibaba.com> References: <20231219142508.86265-1-jefflexu@linux.alibaba.com> Date: Tue, 19 Dec 2023 09:56:12 -0800 From: "Stefan Roesch" To: "Jingbo Xu" , "Andrew Morton" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, joseph.qi@linux.alibaba.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH v3 0/2] mm: fix arithmetic for bdi min_ratio and max_ratio Content-Type: text/plain X-Rspamd-Queue-Id: ED3038001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: o8umxmjqt39pyxy7e3ugx84usj58etuc X-HE-Tag: 1703008594-608430 X-HE-Meta: U2FsdGVkX1+AKrxXerHSZ9RRn3SZov+9GDB1hwle6sMxbGU/6O2LpL/3CIaQ7QPHj5mL3IkXEWo8CnlCdjBuD7FsjIH+dHqstUws1Nae3tJZxE+nD6Y/rEIhSPDXMVKSvA5MZWaFcWzutAYeJhYctQV2kixxPaprK0K2Gw1YtdkOu5W62V6SvXndZdMv8FAGpN5QShq6kvo6ycfbHbhbo6t9t46DBjomyhe3mRNeTtJBaHGaXSuQoi1QMw8lrPlZub73kyI2+IdXyPktsa2G6170fMLsvDwiQcNS5tJmDPZQ1+ndX3rtZLg32lx+P6HiWyOGCq41w3hL0Hww1wW64lAxe9C543LM10VVRglcSxabGxb4Ve6/m8tHKG1RPyH2BRQN4AW06WzSlDW7y60xGC1RgdJUUHBFICiU0VpW/fLIdsM/hWFMd06zWxNI5uhwprXhrV20/41R9wBn+vIOCiS5j95OwxCHDV2WKkCqEDoOa9tjpQ4+apI4BAJvtF0yQ0Zw0CzxEzZfZ//ufh7dZTxoUTbxBU5nBqPvnXl0deibeBEoggb1nUVKgyMaPUjt07h6LOBtZiqFgae8TH8Rlj5DRRVNVi7I/TIjX1KniYQu5mlhDzlcXK4SJlhwx1HuHVG6UCrpJFRK7MEEVt7c09nJxh3r+h8T6h7/zkZoR8qnub8dNzFE1IEU1y6RUbWqbIxanSYgH6dPEdA8bqQQ2dDBmS3u2WHg48ysutdxTQc8tH73VG0XP3f/Rmz3mmUoqcY5ybbVCyL7977MRLSKac3GB5xtAL+lAtpjcSjduC9PdIfEN0zBKXOyD47iSdgrYKGSXXN1cZvoalA8mGRcP7h8CX3iw1Y97lcvGkHRepn6zEx0kJplrWqaVWfwd8lOe0o83Ow6eEhaEsHyGw0PqbZrPC61qUvj1+DJfCMkiwyQFOn64fjqQQX5iQIHetBhFJ7FUlp/Ig/Z30ey0Hi U7dAD0U0 Bj96MxAPn8ZZeLIGbteeMzYOZKA9YEbxsarNFl9gX7m8QvqP7N20QG00B4kwxSjFcc0pA6IiDMwYjT6OZPbOO/8Rtw129yidi05+f3YGs+RnrjbtwH0KAfU/L/OpQZHiAXP92COVxmtqnJCXRP18Rm/ZZp++rNzrmql+yi8a2jwMbNJn2bSdCdErfI8ew+kVhV6Feb6x1xvaDsvjPtvY9XF6OZ2KimCgUs8ZeuMtiMDkmoDZ3QzKves9ate3GXYncexi451s0ck/3Yky1lNO2vfa4YUl9sq6uINih X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It would be good if the cover letter describes what this fixes. On Tue, Dec 19, 2023, at 6:25 AM, Jingbo Xu wrote: > changes since v2: > - patch 2: drop div64_u64(), instead write it out mathematically > (Matthew Wilcox) > > changes since v1: > - split the previous v1 patch into two separate patches with > corresponding "Fixes" tag (Andrew Morton) > - patch 2: remove "UL" suffix for the "100" constant > > v1: > https://lore.kernel.org/all/20231218031640.77983-1-jefflexu@linux.alibaba.com/ > v2: > https://lore.kernel.org/all/20231219024246.65654-1-jefflexu@linux.alibaba.com/ > > Jingbo Xu (2): > mm: fix arithmetic for bdi min_ratio > mm: fix arithmetic for max_prop_frac when setting max_ratio > > mm/page-writeback.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -- > 2.19.1.6.gb485710b