From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA74BC71136 for ; Thu, 12 Jun 2025 12:36:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B9686B007B; Thu, 12 Jun 2025 08:36:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2428A6B0088; Thu, 12 Jun 2025 08:36:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E65A6B0089; Thu, 12 Jun 2025 08:36:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E294E6B007B for ; Thu, 12 Jun 2025 08:36:35 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5D408120DD5 for ; Thu, 12 Jun 2025 12:36:35 +0000 (UTC) X-FDA: 83546697150.13.7346AE6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id BF7451C0008 for ; Thu, 12 Jun 2025 12:36:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ncecoy/x"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749731793; a=rsa-sha256; cv=none; b=HgmcFet6JD/XO1LtIiqfDLLx87BFrDR7drV/M9r02QD6MsLdlMrvrwiJxCT8mrDklPvUIH VEy7pOC3T0EiCmjnglGI9utPnY5zHeFpXJ94QCls3K9pmW5aJrzYK7ROYLb0jR3OeKxwSQ ihEdaJIuRZro/A3S9YEr1ro9DawCUJQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Ncecoy/x"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749731793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Bh4dX1JlKlhpTIcfeVbnBt6ZIPlXQjwiP+ROQ/J7Y8=; b=0blaWque2wQLhVnZBY/342DKA3KKeUlGfWX8LIGt92o1CzN/Y+UpBLZWETIpkGY6Ws8jkv 9MlBHawCzTY0KaFMRhOYrh3cb7W6CeLLIskw3w77+lc8bP94EggTJ+XcgI8/6hAKZABfLK KNHcIF0uZFCjsFGaC6dBnGr0P0xh7pA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749731792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4Bh4dX1JlKlhpTIcfeVbnBt6ZIPlXQjwiP+ROQ/J7Y8=; b=Ncecoy/xWjibUna/AwcW19ZV48hUsoa10NNFe+ESTNoWQVQ3txDB1tUfR/CyWZI7EMxdkf mNY//KUmQUhzTVoyGUUQ2UTyLW0OZjPNqE5GGuzaRYmGJJsKKfg4XB2tWFQLZqX1Bj6vCb ptN4BceuyREJfPkY9XLgZrM8lm2jxTA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-0D_JLMgEMMSAhRBn4liGCA-1; Thu, 12 Jun 2025 08:36:31 -0400 X-MC-Unique: 0D_JLMgEMMSAhRBn4liGCA-1 X-Mimecast-MFC-AGG-ID: 0D_JLMgEMMSAhRBn4liGCA_1749731790 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a5281ba3a4so392402f8f.0 for ; Thu, 12 Jun 2025 05:36:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749731790; x=1750336590; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4Bh4dX1JlKlhpTIcfeVbnBt6ZIPlXQjwiP+ROQ/J7Y8=; b=mmnbxiOH6EjOm6OR5kzXaMDcQkBJnQk+E28LLev9wiPG0DdXIhHDGk4fPWmGl3g7n5 eUKRPHJkPlHD2h+37CkcVHpHuI3i01OZ9TydT4jLKcmGqocVLtsQLSWzSOTHgcVAE3i/ utdaMDOvswLmo+D2XhbIBxAEJcTNUsPCfokAEtLYwhZmpBEsWGb0vNjLZfRXHJn83RkF IGFDwKyT9EyuKGSHACBw1eeipbvnl2VhPLYqwSZi1EYCLROwtaoo8SSrkWucU0zVZW2E FwtFzRKl2AI20dnOOHBKS45+MKK3JUwEaR/mfPJfk7MKmTZGToT5DBV/Hv/QsHGv1iMV SLaw== X-Forwarded-Encrypted: i=1; AJvYcCWIc9jyUIOYU2R3ZGwbvy8T91SAbgSD2N8EGoUkZffGGsdlM6mfAkNx7pxZCEniJKoh0FCWw1kjig==@kvack.org X-Gm-Message-State: AOJu0YyVxEpdS4pjL1PMLiQSDE8B3+9kOECxr0BCSkOnInrwRt55+X+y hHzHKGUlbqi/9haBKOaKU/R+oI2U58ckCLqXnBJ1epDCQBqtAdSpj0A8SJLlPGHeqoy5eZZKgBw QOdmJYtl3y5/RXiZMZb5qxqSySMW85B+ZqugzyP6of8ibRjNe9Omc X-Gm-Gg: ASbGncv1G5ZleGqmtmRdMV28BWRO9vnuAHm+oRIaFUtolbesrTEct4qSGn7Qvfe0qmz S8vF08L1eUzaWVVJ8RBZYZosinGN+3fTlopwvZ6cUBKhY/Y6OmTFQ9aE9UAV8rsYcDjWLamBLuN xa3HmRQLjqGE6hEtZu8AfzqngIX3/Poon7uZggO1o8MRK1BZVy+xj6ptxBYHTP0FGFDgRkR/LAW IfsLp1h5qk7RCXMx9ngxW5yRCbs7slbgemXWzsQv+USiMeJs2NmKsqIAXXtBBFsILER4/vJTVZl oXZgSSYnMTZS2t6qw63kWo30JRUvgpRy9Lj3+5lS0fuLqhtw7sZeBUO0bJ+iglgC3QBS0aii4DU +UP0SXSTizzetjAQ/h2vxy0TkhOBEw0zWD9s9IaR2OWcqPsfZ4w== X-Received: by 2002:a5d:64c5:0:b0:3a4:d700:f773 with SMTP id ffacd0b85a97d-3a5606a2f5amr2645503f8f.11.1749731789730; Thu, 12 Jun 2025 05:36:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHP7GX8mmfHyy1XVyDTzaFoVHDRBqUqGtA2T6X6nOqxDvXWDpKckqBp/AufLCjgyp/gY7i0aQ== X-Received: by 2002:a5d:64c5:0:b0:3a4:d700:f773 with SMTP id ffacd0b85a97d-3a5606a2f5amr2645470f8f.11.1749731789304; Thu, 12 Jun 2025 05:36:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a561b65b0dsm1909627f8f.95.2025.06.12.05.36.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 05:36:28 -0700 (PDT) Message-ID: <79b5314e-a8d6-401c-a3d5-242a5887f562@redhat.com> Date: Thu, 12 Jun 2025 14:36:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pagewalk: Clean up folio_walk_start() by removing expose_page To: peng li Cc: Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250612120903.2678910-1-peng8420.li@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250612120903.2678910-1-peng8420.li@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -oxZyabOCI5fyC7bsXlRv3MQgLQQKZQIO3ZfVD2JhHo_1749731790 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: 14pipix8zsxpfe9in6q9nrkjk5b6pdbx X-Rspamd-Queue-Id: BF7451C0008 X-Rspam-User: X-HE-Tag: 1749731792-899236 X-HE-Meta: U2FsdGVkX1/5dCmlZXUqWT7GbYiQtxcjVgrU12/shC/q2GwpYBFFZrgI9ReCc3w7Av8ah8EWtdk78a40mncLuL0smH1Lvsg1S8Fzj3Qx/lZjfvhi1/gXCgGfoh4qmMA7eV4u7EFq5uiaRhPg+j8kO2TBioFUGRYILINFmGdSHFBfF1i+BNAY2nBot4I8cTio6g3KjzQmsDh2D94nsUz2p7yL3pUSsHTZw211tqyIMg0S6aco2VhDxxU25hH388JBup0HpKcoyEm28W6dr1LBbNQpfh0uXnDpkm1o+ptIkhBQVyBdmeTBHKAf06zz11+fOv/hKkiLMKE9av612YePQrJK7DFzNMiQvLE66UZL5hZoD4PwA1u/vaeY3sbWWjKsHWyNzuxP4zqs4+aCPkMbplaGyrnOheKc4R5iFwkfkjFtVsS3q38qIH0coAJjCberX+YJ7wGVzto57bWMmvc1xyB4rrGd6EGiJs54RJVsU29hE1RiOhjHT2xtDaaF56AHLJEfmGd41lPZyfT7F+DlMK44SOmqGKRAaAzi14vGfpB7zKKQb2W/5DATBJ9zZwEKWa3a3NN1jouv0v+lqCrUiNSLV3lX7oqqXD7+XKaRrTtHJyKh59lt2+AqRIw6PJ3fOI6Vs8m/79tbpqMg3voY1hdhpqIAHYuFwsERA0o9qfpxUwppRCr6jByefktU+IXLlPYa7KMc2r847JUVItVb/R4ZuLx3YSIWOgHmy5Utd1ZImRJRCGsHsk8f4vt5+oy4vh472X1+37cHD25N6uaw+jrglzLKwP8WlJhRzjkr1nRVIqiCKoCHsmbuZdnS2vrg8vWNQpniUTFYyPuo2CAmbx2KNg/hpROliDAC3ztCiCszVjpHSmF+gCetlwaghKiTp0ZkAEmufndglNc21rOYCVr6f2LRkuac09XeRuCvNcefFZN2BNLvx5+osuVyuA7H5Z3eCPcx4xmxe9WLBl0 m+ziUIM5 llGwON5oO+OakR6fNPHFuxKsacNDL/55a7ClTxmIw9+2W5TGpmpRjMjYvcQ7Rm7QdwA5/9HJ8q/NAslEgGqY4bc/2aihxFWhmyuuyNAISiDjT4wz5AE6cduN87ZWx6I5JW420yZUp709jJOZShC8iIz1604ktucYblnjuwEAb2x3TqfD4Uw1Pfz5q1Hts/yFaTYo/wT4Qhx00LR+DRmHJVZSpr1YzYJ5niVGvLS0+JWnnAOSCPtn5ezLllEIvLUbJN9QMJUUvVk646fLAwPE6yDpTWgr0/QrqbaQ30c2U+wdvpQrcDuHg/tmDhVXVW0sjOeFpuuQFewKewz7Tq0xbM53nGtIdw8ZH1Jb2A0P3bxbLFZ71oToRWyEWkdticSEJSoypr1QrzQouLIhASjQlfJIiJKXUYJEppTcXzY/lsjOgywJYcVB+XLu0umO6bxJqkGB+D4t2EalVFkNv/ti97snbjAKUKSuMOvutCUJtvTtoNYjqrMKOQun1wPQEzuH3nqMQFwA4LZfQ2B8jQW+ghBbInqx9FMZA3w39 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.06.25 14:09, peng li wrote: > The name expose_page is confusing to understand. From the code logic, it is > probably meant to express "belongs to the normal page and get offset from > the mapped page"? > Perhaps changing "expose_page" to "normal_mapped_page" can better express > its behavior? But perhaps its existence is meaningless, because fw->page > can be directly confirmed and obtained from the page type without the need > for a separate flag. > > Key changes: > 1. Remove expose_page and its conditional logic > 2. Always set fw->page when a valid page is found > 3. Add clarifying comments about offset calculation > 4. Initialize fw->page to NULL at PMD/PTE levels > > Signed-off-by: peng li > --- I don't see the cleanup here, really. -- Cheers, David / dhildenb