From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A03D0BB6C for ; Thu, 24 Oct 2024 08:07:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D79536B0085; Thu, 24 Oct 2024 04:07:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D29116B0088; Thu, 24 Oct 2024 04:07:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF0646B008A; Thu, 24 Oct 2024 04:07:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A1A836B0085 for ; Thu, 24 Oct 2024 04:07:24 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0DEDB411B2 for ; Thu, 24 Oct 2024 08:07:14 +0000 (UTC) X-FDA: 82707765798.28.602DFB8 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf18.hostedemail.com (Postfix) with ESMTP id 5D2A31C0018 for ; Thu, 24 Oct 2024 08:07:13 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729757129; a=rsa-sha256; cv=none; b=dNy+UynqRMJvjxb/A4Jbt1Hn1qJpuTaimhkQ775ZT13UsOtaFtp8xHBaXKg7USS8djCwpu 8ZFVR2DiA4AtDYW94ZtLoJ/qznO1ulEXtC/TvxnDPUEkgDwlJLgU7Yis9uF2HFwTqWWcEr UQFZsI7N4fYmoilBRdMKgPkO0AK6DiQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf18.hostedemail.com: domain of yukaixiong@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=yukaixiong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729757129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Baf8x7l4hK3P3+d2ngYpO5HCIzNRx+Oue3zvFPkYp7Y=; b=dxFfswP5+G3NErcSWhiZKa08cD7HzuYVQO3Fen6Fv5BNmoKXEvvQGNqd2AL5/rFilW/Tj/ CBAiGrDM1zftJJdMnxtiIBwEVsGz/l8d0ozQsYAqEZw6ZPKqQEGClw/82HMq6KWxRMnzK6 tuzenEbefXC4/zM83Bjm45ZOOksTQ+0= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4XYz193blfz1HLRk; Thu, 24 Oct 2024 16:02:53 +0800 (CST) Received: from kwepemh100016.china.huawei.com (unknown [7.202.181.102]) by mail.maildlp.com (Postfix) with ESMTPS id 603111A016C; Thu, 24 Oct 2024 16:07:15 +0800 (CST) Received: from [10.174.179.93] (10.174.179.93) by kwepemh100016.china.huawei.com (7.202.181.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 24 Oct 2024 16:07:11 +0800 Subject: Re: [PATCH v3 -next 00/15] sysctl: move sysctls from vm_table into its own files To: Joel Granados References: <20241010152215.3025842-1-yukaixiong@huawei.com> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: yukaixiong Message-ID: <79b33640-fc81-b4c1-4967-30189d9a4b23@huawei.com> Date: Thu, 24 Oct 2024 16:07:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.93] X-ClientProxiedBy: dggpeml500026.china.huawei.com (7.185.36.106) To kwepemh100016.china.huawei.com (7.202.181.102) X-Rspamd-Queue-Id: 5D2A31C0018 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qjdudto65611athkuwx39oqef9z6a8uc X-HE-Tag: 1729757233-588514 X-HE-Meta: U2FsdGVkX19MvShCNA5ngNuQRgKmjrpztXTpxHiEOKRu7gHFephH6c7aGJ1SwPbWcpl3UKCFDUPHYZlvZX9ytIi05wD5Duf+8SGGtgFpcfwu4y3pyDDfMXZ0zjmf3Aqa7ikYK5+nKg+mIatfrN+9BqLkoodTfIHgsLr76/Y5J5G14WeISCXRk3zg8aDHakZ+aFIr2nq040w5akyVZtm5NDZMtyFO+hiE8Q2CdXaDG/7/Ab9GJzsDCJEr06BvXVfJ+2SGruvwbo144hmlVRPrayEve/fBXQv4FNkbfB+4WbH4DBS7tR5wBEZWSY4uqm56wPD7/mlQaIrKTjDafZP3a4jLmUdi4JFgllXWPJU3+538yOGqFW7HBPe/zMfXpyqAxYFedw3gxs8vZNqyP7wIvjqNprC3jPsnmTEh+/FG5X2W2N3TquahC5gj7Qo0OcwfM59n4PIvkVeXJ7h8zkAE8py4aFd//tcOhz9LrHOU3NlA316nDzqypIhF49Tenz4VsspM6/tuHHKYGKY8IReQsY9P/BN4xuj7lUjqLtt+Sk0ZvijwijaFklCZf8lXpNy4N26g0hAuQfBXHKgw8wSPBmon/LGkrgKECrGksxz72AzzKuKHnJgl3Ia4Udyu9+logJLuUAiQOmbqof1trmJAhwH646oV2u4K4+BCif+n7YCvsdvQYN2g27yWnQ2Gixx0iYj+EQgQN3Vs2Nbe2Y4xQhBR5i7dPBkAsGPAO5KMfInaAgkPkHdkFjVnH0xmnRfcDyHq6w6mlSPr2MbdicdOBArnHES95pR/xmT19sLIq//8O3GcZl+qVv3D6S9srAP+0MRs56CcGO8s8C8jySJ0o+mwb6T02PshlpTWJdvl9i1YUW9tneBz+7ZQcglxVGH/MR+X0aASwlJ0X7P17JqFvvJQuX1Kp8eowFQEWg62nbXveomPiRq56exqs8eeicJ7KIVBlIdvPt5LmM29vgk VuB5/1Jr 9F3ei8m08xXcL4n/isYYsMSSNAseB8kLDF2W137L5IX/x6yQW/k/0DIBeTe0tu1QcZ8eU+ryrRj8saP1eiQ6pheu3mGyfw8+nEhGHYpsJI7VbAr+82wCYzctschsumgrmCbDOCYieCPjpG5GjdttCp5NLM2+rAIdhRZ/0rNPCG7DA197BROPC78OY/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/10/21 15:22, Joel Granados wrote: > On Thu, Oct 10, 2024 at 11:22:00PM +0800, Kaixiong Yu wrote: >> This patch series moves sysctls of vm_table in kernel/sysctl.c to >> places where they actually belong, and do some related code clean-ups. >> After this patch series, all sysctls in vm_table have been moved into its >> own files, meanwhile, delete vm_table. >> >> All the modifications of this patch series base on >> linux-next(tags/next-20241010). To test this patch series, the code was >> compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and >> x86_64 architectures. After this patch series is applied, all files >> under /proc/sys/vm can be read or written normally. >> >> Changes in v3: >> - change patch1~10, patch14 title suggested by Joel Granados >> - change sysctl_stat_interval to static type in patch1 >> - add acked-by from Paul Moore in patch7 >> - change dirtytime_expire_interval to static type in patch9 >> - add acked-by from Anna Schumaker in patch11 >> >> Changes in v2: >> - fix sysctl_max_map_count undeclared issue in mm/nommu.c for patch6 >> - update changelog for patch7/12, suggested by Kees/Paul >> - fix patch8, sorry for wrong changes and forget to built with NOMMU >> - add reviewed-by from Kees except patch8 since patch8 is wrong in v1 >> - add reviewed-by from Jan Kara, Christian Brauner in patch12 >> >> Kaixiong Yu (15): >> mm: vmstat: move sysctls to mm/vmstat.c >> mm: filemap: move sysctl to mm/filemap.c >> mm: swap: move sysctl to mm/swap.c >> mm: vmscan: move vmscan sysctls to mm/vmscan.c >> mm: util: move sysctls to mm/util.c >> mm: mmap: move sysctl to mm/mmap.c >> security: min_addr: move sysctl to security/min_addr.c >> mm: nommu: move sysctl to mm/nommu.c >> fs: fs-writeback: move sysctl to fs/fs-writeback.c >> fs: drop_caches: move sysctl to fs/drop_caches.c >> sunrpc: use vfs_pressure_ratio() helper >> fs: dcache: move the sysctl to fs/dcache.c >> x86: vdso: move the sysctl to arch/x86/entry/vdso/vdso32-setup.c >> sh: vdso: move the sysctl to arch/sh/kernel/vsyscall/vsyscall.c >> sysctl: remove unneeded include >> >> arch/sh/kernel/vsyscall/vsyscall.c | 14 ++ >> arch/x86/entry/vdso/vdso32-setup.c | 16 ++- >> fs/dcache.c | 21 ++- >> fs/drop_caches.c | 23 ++- >> fs/fs-writeback.c | 30 ++-- >> include/linux/dcache.h | 7 +- >> include/linux/mm.h | 23 --- >> include/linux/mman.h | 2 - >> include/linux/swap.h | 9 -- >> include/linux/vmstat.h | 11 -- >> include/linux/writeback.h | 4 - >> kernel/sysctl.c | 221 ----------------------------- >> mm/filemap.c | 18 ++- >> mm/internal.h | 10 ++ >> mm/mmap.c | 54 +++++++ >> mm/nommu.c | 15 +- >> mm/swap.c | 16 ++- >> mm/swap.h | 1 + >> mm/util.c | 67 +++++++-- >> mm/vmscan.c | 23 +++ >> mm/vmstat.c | 44 +++++- >> net/sunrpc/auth.c | 2 +- >> security/min_addr.c | 11 ++ >> 23 files changed, 330 insertions(+), 312 deletions(-) >> >> -- >> 2.34.1 >> > General comment for the patchset in general. I would consider making the > new sysctl tables const. There is an effort for doing this and it has > already lanted in linux-next. So if you base your patch from a recent > next release, then it should just work. If you *do* decide to add a > const qualifier, then note that you will create a dependency with the > sysctl patchset currently in next and that will have to go in before. > > Best > Sorry, I don't understand what is the meaning of "create a dependency with the sysctl patchset". Do you just want me to change all "static struct ctl_table" type table into "static const struct ctl_table" type in my patchset?