From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80602E7719C for ; Fri, 10 Jan 2025 07:04:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8CD66B009B; Fri, 10 Jan 2025 02:04:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3C1B6B00B6; Fri, 10 Jan 2025 02:04:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C03B56B00B9; Fri, 10 Jan 2025 02:04:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 58E986B009B for ; Fri, 10 Jan 2025 02:04:24 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D88951C7103 for ; Fri, 10 Jan 2025 07:04:22 +0000 (UTC) X-FDA: 82990653564.05.C114127 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf19.hostedemail.com (Postfix) with ESMTP id 0247F1A000A for ; Fri, 10 Jan 2025 07:04:20 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dwx0B7Sb; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736492661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=TSinf6N/0VJotrgoS9AqZpAeK3QAzQHTs6pqTPPLGL8=; b=JxrC7we0AeEfnbWm+vQirF33gGHfhbkA9OERGvZ9Gg4PT8HIYda8ZEEa/NAKmlf69XD5Nn +WJIWQbD1vB+EWqs5d0zpj9UD2/OKURhfhEZKAkbr78CFvBc6uXAZqf4gIfKFK+KCSsJDV cvkPNXFc+iH/CQnVjdbL84ESdvdrSEg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=dwx0B7Sb; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.52 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736492661; a=rsa-sha256; cv=none; b=0bis2KWPbDWyRtDUFzuLWw0ThKmJo08nuf8eAuR4HX0SEwquPPxyFhNo4EOOo84Rxr3f0j tmOJViRJLV5x93DRJ2BKs/Q71xAQLYMuTjMl62lVccLwMGecEuJlxluzm3GrhjAJ75EfbO Uk5esPGeHIDdb9JfnN7ER+Anp1FmOaU= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-43625c4a50dso13089565e9.0 for ; Thu, 09 Jan 2025 23:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736492659; x=1737097459; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=TSinf6N/0VJotrgoS9AqZpAeK3QAzQHTs6pqTPPLGL8=; b=dwx0B7SbY0ob4YzDBuA30VdyYN5bdadgYMDAXnsB+le3AXMY0fJVL9I4V4tBMfOezc e5Qa3Tm0edT1hf0m+BtqovQ/cOJx9Iabrs2wgF1xlKKdzUPu1q6D3E1vDf3FLrgRWxFp vMs40/RpPE/GuDJHD/ujtedYYmjN0jCGCxUY+udc5wJScLDSnHnh8M53ZvSRVTGSWLw7 /BjD2lKfBsor5UA5u/RTWQfLiyTRucoS24hJ28SaAa6eZ5MMS58yu6q8ojPyyxeTBtqF p4yHI8NWzHHhtbNhp7TTmELC6/yxh46F+GEwK0o6MktWqM95KxAT8T9H3jHMJjIdmccI pU5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736492659; x=1737097459; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TSinf6N/0VJotrgoS9AqZpAeK3QAzQHTs6pqTPPLGL8=; b=b6rEKi5i4UgN1yQq+wifhgm+sKCC/ssB7gkKf5w4JzjRLm/xDHU2GczZfstP4BqWpE 2XC54PsNaaOcGqZ4GvveszGiui6bWPm8LGEFGFeIld/YB8i+jFt1UPv/tooAwTEpgVPO rX/k2DzqB+tydovGmWs1JKTJ57WSgjqfZRrg3F9uhs3M4OgmFXXp89bRlwv1Ygl6Bfzi Tdn/oLazI0ev476SCadoReQA4vSG8Imw+Uv65JNrZF2aM3akCQYXpp551NjYSBy2DZSZ Oui24bxAMo1PzP2KJIZE7vNpUB3nzD6HhtVM0+C4Lc+P061AYSK/9SI8ykQ5M+qMQaBa 5gGg== X-Gm-Message-State: AOJu0Yx6x1oDTs2NTbDZHUWDJjvgeGClbipa+KYK4k/eUOUmhMlj1HTM vsZcmbjZXVX+PHBIjsmVh1/bDpjUJPmviBAQiH+6QnYNdc/bKDlZbSh8iYfUdYM= X-Gm-Gg: ASbGnctieYkZwuKuT6zNJ3CzWRP4aAVPGWr/zZZwX8z09kM4gnV9Dv+fg3LIIQnE+al I8B78/AlgJRaW87jHxwbUr7sg0nwf4qJ+z/I+T3gkrChwBhIGrX+HNRH3T6QmABD/aBLmCbX7z7 pai268yu5jOPLBaJSgXWy2bYrlM0kJV40uf4sGris84MgZokEez2VE6cS0s5cU9vZ3s6bo+IgZm CxQmpvZzIcEcv8/Ypnke3uSi4sSF/w6Df9nV4CC+iPhDP0MEG847+dtonkfjw== X-Google-Smtp-Source: AGHT+IHVB1Z5oLAzz5+2v4TiDGeOGCXe5z1dLMj14NQPRrPjORAtXT5lIJXagxVefF94F2w1W6SYXw== X-Received: by 2002:a05:600c:3b94:b0:434:e2ea:fc94 with SMTP id 5b1f17b1804b1-436e2696cb8mr88568035e9.11.1736492659294; Thu, 09 Jan 2025 23:04:19 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e383965sm3771085f8f.31.2025.01.09.23.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 23:04:18 -0800 (PST) Date: Fri, 10 Jan 2025 10:04:15 +0300 From: Dan Carpenter To: Alistair Popple Cc: linux-mm@kvack.org Subject: [bug report] mm: allow compound zone device pages Message-ID: <79a80894-a0e9-4636-bf18-173ba843f843@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0247F1A000A X-Rspam-User: X-Stat-Signature: q7hnb8ifxpqy1ksqxfmi5d8tsnkpr5s3 X-HE-Tag: 1736492660-93709 X-HE-Meta: U2FsdGVkX1+YrbpxtSJ8HPEtTcLUV6B9gKSEvqqahyBRQ0M4kcXqxLk2ZWoD+FDOnP32B4AAos5AnxqVWREYX+ZZzn28d3YYIocm0jAVca9eXaA2RFvvIw2joBBBXhafhHefvnsI0LSP2jCER/eAUYe49N/g13G0o4JuaA0+cTvSeF7ZyiNMjHkXrDmeFGOoOs0i4g9vJqlRzs1XxqQZ7g48BkByKX6CeN3z3kNmpd4Og53g0Qo1izrImVGOkkRTc2P9nfC8WNcVpJH8Upfj4gX3YOMroPVI+65cXkR2VtACPTdcae8HFbrxHt/0qLt72dKj4Rk1Xhmcb0HIAjU0LIOw22PZfacVjT/GVkqVwnNOqftzB96HpgwLIF8BjhV/0zLgDyCGzs1xFI2+vAqtG/puzWlYVWelWpYiAggFxRIEmKFRU7KLOxD0W29hXywep3beuX+ZfGfC7LQHkiYRXxXgM9oKeSZwB19lfArZEbHR1wKvWqxI71vZVRAG5qkhgqzwGUDz+CFTXeW1XdymBukIiSsQnWVEwQnYjxmFxNbPWcCPajIXuD0GSJ2IP0Ah0U4q9eym95aQUZXiL4UT4Q6ibUR7sXi8zQRJlL8+n4p4br06BHXYGFFZkV4hLBEmsgzB6iMjY9ou98oV391fuge0xEmVNNGj3/ao4fAcu8JmTpg9yIsLvOt41F1CGkkunnJarmx4I3qvIhuglyMYsKwT6ZRb6QuZCAWdY3qKOthlqNm2kt2qA5fjxIlIrGM+m7Y2912kVisLavscLBGC08odxJLAcnUpUzply0viffV6fwm4ST0RKBlonnugE4zGwgBjY1sZJAOPyh7VC/c+n6rYDe2l+TDCVohYeIZ2UL3V99FF5CvLYh4bXJaPs/hF2ScZk0GLfGvgGq2pkTKMzcf31mv44XLz0BzUNLal49hBB5qpDjaPZorST8a59O0PGKfhF+bV9mU0do1MpoQ UD+O7n/B oHtERZbwTfhvUjb/1myiwp8MapNRfJNmluPRnZtj3aoi965o6593M13T6CU+13q/wvprxn7o2+Mu9L+a+YlINFtVBnhEH4M4y4RX0r5wOSYpb2ZptJb6ORiYjeaPqOrHiGnzCGUFtbP68rpLckNVcqIt1URLjCSqxsmC7JougvWFDrvUO6/1hVQ9heQu2LWY3VP/j1nxIX4IBNM0vanbu1RXBYfZtxtzbUXTbJdm9V889yuD/I9Q8XiA9cp8MmQYoJfs2qD62pyreoio= X-Bogosity: Ham, tests=bogofilter, spamicity=0.014325, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Alistair Popple, This is a semi-automatic email about new static checker warnings. Commit 04cabee2d411 ("mm: allow compound zone device pages") from Jan 7, 2025, leads to the following Smatch complaint: mm/migrate_device.c:157 migrate_vma_collect_pmd() warn: variable dereferenced before check 'page' (see line 156) mm/migrate_device.c 155 page = vm_normal_page(migrate->vma, addr, pte); 156 pgmap = page_pgmap(page); ^^^^ Unchecked dereference 157 if (page && !is_zone_device_page(page) && ^^^^ Too late 158 !(migrate->flags & MIGRATE_VMA_SELECT_SYSTEM)) 159 goto next; regards, dan carpenter