From: Dan Carpenter <dan.carpenter@linaro.org>
To: Alistair Popple <apopple@nvidia.com>
Cc: linux-mm@kvack.org
Subject: [bug report] mm: allow compound zone device pages
Date: Fri, 10 Jan 2025 10:04:15 +0300 [thread overview]
Message-ID: <79a80894-a0e9-4636-bf18-173ba843f843@stanley.mountain> (raw)
Hello Alistair Popple,
This is a semi-automatic email about new static checker warnings.
Commit 04cabee2d411 ("mm: allow compound zone device pages") from Jan
7, 2025, leads to the following Smatch complaint:
mm/migrate_device.c:157 migrate_vma_collect_pmd()
warn: variable dereferenced before check 'page' (see line 156)
mm/migrate_device.c
155 page = vm_normal_page(migrate->vma, addr, pte);
156 pgmap = page_pgmap(page);
^^^^
Unchecked dereference
157 if (page && !is_zone_device_page(page) &&
^^^^
Too late
158 !(migrate->flags & MIGRATE_VMA_SELECT_SYSTEM))
159 goto next;
regards,
dan carpenter
reply other threads:[~2025-01-10 7:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a80894-a0e9-4636-bf18-173ba843f843@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=apopple@nvidia.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox