From: David Hildenbrand <david@redhat.com>
To: Alex Sierra <alex.sierra@amd.com>, jgg@nvidia.com
Cc: Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
willy@infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH v6 02/14] mm: handling Non-LRU pages returned by vm_normal_pages
Date: Tue, 28 Jun 2022 12:42:44 +0200 [thread overview]
Message-ID: <79a7969c-311f-d36b-4d44-dfe2f02c9b99@redhat.com> (raw)
In-Reply-To: <20220628001454.3503-3-alex.sierra@amd.com>
On 28.06.22 02:14, Alex Sierra wrote:
> With DEVICE_COHERENT, we'll soon have vm_normal_pages() return
> device-managed anonymous pages that are not LRU pages. Although they
> behave like normal pages for purposes of mapping in CPU page, and for
> COW. They do not support LRU lists, NUMA migration or THP.
>
> We also introduced a FOLL_LRU flag that adds the same behaviour to
> follow_page and related APIs, to allow callers to specify that they
> expect to put pages on an LRU list.
>
> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
> Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Reviewed-by: Alistair Popple <apopple@nvidia.com>
> ---
I think my review feedback regarding FOLL_LRU has been ignored.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-06-28 10:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 0:14 [PATCH v6 00/14] Add MEMORY_DEVICE_COHERENT for coherent device memory mapping Alex Sierra
2022-06-28 0:14 ` [PATCH v6 01/14] mm: add zone device coherent type memory support Alex Sierra
2022-06-28 0:14 ` [PATCH v6 02/14] mm: handling Non-LRU pages returned by vm_normal_pages Alex Sierra
2022-06-28 10:42 ` David Hildenbrand [this message]
2022-06-29 3:56 ` Sierra Guiza, Alejandro (Alex)
2022-06-28 0:14 ` [PATCH v6 03/14] mm: add device coherent vma selection for memory migration Alex Sierra
2022-06-28 0:14 ` [PATCH v6 04/14] mm: remove the vma check in migrate_vma_setup() Alex Sierra
2022-06-28 0:14 ` [PATCH v6 05/14] mm/gup: migrate device coherent pages when pinning instead of failing Alex Sierra
2022-06-28 0:14 ` [PATCH v6 06/14] mm: add device coherent checker to is_pinnable_page Alex Sierra
2022-06-28 10:41 ` David Hildenbrand
2022-06-28 0:14 ` [PATCH v6 07/14] drm/amdkfd: add SPM support for SVM Alex Sierra
2022-06-28 0:14 ` [PATCH v6 08/14] lib: test_hmm add ioctl to get zone device type Alex Sierra
2022-06-28 0:14 ` [PATCH v6 09/14] lib: test_hmm add module param for " Alex Sierra
2022-06-28 0:14 ` [PATCH v6 10/14] lib: add support for device coherent type in test_hmm Alex Sierra
2022-06-28 0:14 ` [PATCH v6 11/14] tools: update hmm-test to support device coherent type Alex Sierra
2022-06-28 0:14 ` [PATCH v6 12/14] tools: update test_hmm script to support SP config Alex Sierra
2022-06-28 0:14 ` [PATCH v6 13/14] tools: add hmm gup tests for device coherent type Alex Sierra
2022-06-28 0:14 ` [PATCH v6 14/14] tools: add selftests to hmm for COW in device memory Alex Sierra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79a7969c-311f-d36b-4d44-dfe2f02c9b99@redhat.com \
--to=david@redhat.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=apopple@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox