From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2650C54E71 for ; Wed, 21 May 2025 15:16:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA436B0082; Wed, 21 May 2025 11:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5B0F6B0085; Wed, 21 May 2025 11:16:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D21AF6B008A; Wed, 21 May 2025 11:16:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AF7836B0082 for ; Wed, 21 May 2025 11:16:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5302EC0907 for ; Wed, 21 May 2025 15:16:36 +0000 (UTC) X-FDA: 83467266792.28.9A28324 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf12.hostedemail.com (Postfix) with ESMTP id 59BAE4000D for ; Wed, 21 May 2025 15:16:33 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iBrSscGt; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747840594; a=rsa-sha256; cv=none; b=qubNnY9ry2X7Zu6tMZmzyNax8XcxirPf+dyNFDurYu4ajnsf8ZGqaYksyxjrSwJMN1eIio /MWu5tYs5UeddHATysftSOeQfT4ZFlFjDxfZ/Av0guTtNwxRX5NRbL8A2hLnnaiWqjJEIz 6gJKWMl10ezaSdmgX97rbe0tKFTmwOs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iBrSscGt; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf12.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747840594; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QG+GYrq6Cy/FY3S2OvryztQ1JVISfSggGP7APd3bH6o=; b=qqEWiYiAxZ9e+e0qDVaVq07vqURg+NeDKvdw/uP25baOarsrXpdwm7NKM9trO484BwE0W8 EppG/+bHGkCYk7EXKBTBTweCivV89C0XV1bH0ZR+lHxALYNT7PE9rdB5JQxcztlF6X5Ttz X3TQhbwX2V/qKAZchSMy81NX1Yaq7wk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1747840593; x=1779376593; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=uIFp6FUN2+rM4RSf61UGlgnH3srvVhm65Sk5NDLSisw=; b=iBrSscGtFFrsaky1PLRSLS5mJhmyjMV3WDHujbYbMzcBvfxHXEiZ8ZAi pvaorHsdte/Sg3buDmW8j3dAn+3zZri5Tp3ZSb0oaxAWJE5rVIcgLEFK+ hqFQPcNl1q8p6KVxK/PQWh6bEFVjxTuZT/V417/7XCDzeAs6iuWTCPzi9 hEPc+PUTKH2qMtg4SFQN9rimKw1NxHdCdsrZEqxQ+fAxZtQYOt36g7t0C xYsfvgtwEHcsZeLFdFBBuSGaz6GMc4jJlTZMuMLio+1f/QKONgloDU0no SZbpYnB7sEp3/k+n24EEU5tJbpuIMmtUfdZqaU05xf35P+2nW5W9Y/JRD Q==; X-CSE-ConnectionGUID: S9IjfPWeSCyhHA6a7JAXYA== X-CSE-MsgGUID: lQG7UkbHT9m6bT7q/Q8XsQ== X-IronPort-AV: E=McAfee;i="6700,10204,11440"; a="49922249" X-IronPort-AV: E=Sophos;i="6.15,303,1739865600"; d="scan'208";a="49922249" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 08:16:24 -0700 X-CSE-ConnectionGUID: I2Qw2siATsuCKO+WX6xWcg== X-CSE-MsgGUID: 3uzHabndQIS56fuWG+licQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,303,1739865600"; d="scan'208";a="177272047" Received: from iherna2-mobl4.amr.corp.intel.com (HELO [10.125.109.100]) ([10.125.109.100]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2025 08:16:24 -0700 Message-ID: <79975f50-7a98-4629-9ed8-c32596cab46a@intel.com> Date: Wed, 21 May 2025 08:16:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 5/9] x86/mm: Change cpa_flush() to call flush_kernel_range() directly To: Rik van Riel , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, x86@kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, nadav.amit@gmail.com, Rik van Riel , Yu-cheng Yu References: <20250520010350.1740223-1-riel@surriel.com> <20250520010350.1740223-6-riel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250520010350.1740223-6-riel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 7at847gigxxiq39wecxpdf733bk3dwgq X-Rspam-User: X-Rspamd-Queue-Id: 59BAE4000D X-Rspamd-Server: rspam06 X-HE-Tag: 1747840593-29260 X-HE-Meta: U2FsdGVkX19Zl1+ztGWZ9UncYISA/9kF6559hkaOIRCkajcaOB/T2IkS9jSwZAdsWHeo/0D+Ee05d3U9sSAXkocJ3a5Phe23tjSacinLmiz9BjSFhUNxhT5sF5lrT4WwNQiYuvAvcYmY32ZmX0Foq7aWmFSeaQtODg41jyPh7BHd9JlN1D0Klk2i/dLkrtk7BaLHFIx+YlyP/Lj5y5MIQiGus1k5HBZfYnOXcU60QLsDKdbCbNnkzcq0nOqXNG09rpJS0GO7iTrdrX3g6rdW9zN9rYjFFGm13L33LH3tDU9E4xVaBkxdIp//rP0nzBmYZ286QJhBdPW1FfInycAo9ZxV7KRWT3Sy+XKPBLz+drety8Kx+TuUZd3OmRooUdc7OBuGd1n9MhwPwcgSfZSk+4bLwPfgKppK+otvb79FXtbbh6txwubiHz/EaIpkDW8IYONiIHDVFm8fX5x0BFB64QjDyCMJErcnIG91sB2tv2qyX52p8rlRy9Vus4LmfesiGcFimLU9COP2PYGXA/uPQHk0sCkW2BsxXU5RD8qqpSnBRM9tcphXVo2fonCskLt8qFIZ7NxEL0EqfS/BwfeLe3KglarQPb21KkiU3vAt0EdTxXQlMLhKhUcOYnst+HmNKfDa1ILW4cqoTNUYLrCduMYyZPJ1/9CwYMKHnxYmVxaS9g0Jh4UzSy5YLWs2W8r+KF0n1Fyc/fouI3FzZ2aLrpE9AbstCt78Hj8wnQNEscGaSOLbsdLD5esYb55isHxrynTS7V/DxE7Fh9JfnaYu79Fy22E19UvqteGariVzX1stoIAnSFF+w06/N9HU4e7zwufMPMgcKqdUPG4csIR0p3C7YTnbmJV7lp92ygteS2mhE2klH1g8IdU/LjrS758BpOma030H1kA9O37rw2HEa2AfMdqSF07T5lI+baenOtWgvYO12l9i6XJHj6uBfUA4h2B5exfS/5eatqOnYNg XirJmFOu XJPkOvh9SSfZsP48z3VhjZbZqziu8a5w1Dl/BpUB9ajSgbXs2Xl7+JgvrM18vIccvwIWPIVDKf0verZp8s6Iovj6d7DLWn+GmE2X0UKXVIQpk+w51Eq028wTrsG7qQQNXNKKsrHx0KK1BlbP9HK+eGDfjQQSF7Saf4qO/XBbEBXPLUoccatgDaH5JY3PVs5eWjV5tucFhO2/WN36KFl0UGN7q6efOK7YXh4HnG+z4pDrsY2FV+gjI3f7pukICxxqZMvqcmGuTJwkYc/1oHV1oQy+P6lo7c0+pjizE7IUTBcU6WxATSJTkzSajXOFKbIliA9OF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/19/25 18:02, Rik van Riel wrote: > The function cpa_flush() calls __flush_tlb_one_kernel() and > flush_tlb_all(). > > Replacing that with a call to flush_tlb_kernel_range() allows > cpa_flush() to make use of INVLPGB or RAR without any additional > changes. Yeah, the pageattr.c flushing code has gone through some twists and turns over the years but it does indeed look like it has converged to be awfully close to the other flushing code. It used to do wbinvd() and a full flush, but the wbinvd() disappeared at some point. I don't immediately see any downsides to doing this. You could probably even hoist this up to the top of the series. I think it's a good cleanup on its own. Also, I'd make the point in the subject and changelog that this isn't just changing one function to call another, it's removing some duplicated functionality and consolidating it to existing common code. Maybe this for the subject: x86/mm: Have cpa_flush() use common TLB flushing infrastructure One super nit: > + start = fix_addr(__cpa_addr(cpa, 0)); > + end = fix_addr(__cpa_addr(cpa, cpa->numpages)); Please vertically align the fix_addr()'s.