From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65AADC2BD09 for ; Wed, 3 Jul 2024 10:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C21F16B0085; Wed, 3 Jul 2024 06:11:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD1976B0088; Wed, 3 Jul 2024 06:11:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A245E6B0089; Wed, 3 Jul 2024 06:11:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 84C0A6B0085 for ; Wed, 3 Jul 2024 06:11:34 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 327F51A0B3B for ; Wed, 3 Jul 2024 10:11:34 +0000 (UTC) X-FDA: 82298024508.10.620C9AB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id AB1C740024 for ; Wed, 3 Jul 2024 10:11:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OLwFSHIp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720001474; a=rsa-sha256; cv=none; b=Ym8ogUljJLqT97StOOV13yNfPb86PgAmpQIpX4OccrmXNDPv+DnYa9aPLFqX+78KfPSkKK 2j1UHQKcfL9Rr7o+XI6xom7H6KzoV5iQcayNNr/L0npjb/+p3yINLXhbGcqVsqipTE1q6O OTNdIkrJFzAmnbPjtSMCAYqcRU0W0Rw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OLwFSHIp; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720001474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VIW4O9cjcARid8kd3x3WmxH/dYq1njX/nUJ6yIxU7Lw=; b=MOu5ZUj2lAzbYYaXl8yonSD005XR0brfevxaqKm8QHpRU4L4IpYsmo9mQrkaClvf5o92+N dlJvbFPDR9WUtJuYiL3Q7MtjCiXNekY6Dp1O4/swnCU7AQ/XDKcILAXn2LdONbincvESOe dx02dqRPFptFfXIPTB0duKn5dKnk9cM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720001490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VIW4O9cjcARid8kd3x3WmxH/dYq1njX/nUJ6yIxU7Lw=; b=OLwFSHIpbbqZn/6LGl231jXhlM1U/N43FeHWY1UUZ/ifugdt149LRijsg30gNyUR5Jxo/g gtqenqKvJwObQe5DMrqXFJyGmKnlHzhH3fHChdX2q8DXiWT3veLRWdrd8sIjN4InD3Z6/b crvf+JloRYAXRL5w4vIoPo4VQnZtXjk= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-mjwaNBg1MDauAlWSXXCH1g-1; Wed, 03 Jul 2024 06:11:29 -0400 X-MC-Unique: mjwaNBg1MDauAlWSXXCH1g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-36794fcfdd6so249252f8f.3 for ; Wed, 03 Jul 2024 03:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720001488; x=1720606288; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VIW4O9cjcARid8kd3x3WmxH/dYq1njX/nUJ6yIxU7Lw=; b=drj2+k2v8y6A9rrSFIJfo0M4Z4onUf1N+/F/8fyWXZDZ4AjPvBWS5omTHoFtqndvv9 2ucOGUUpxVA9joUYxCIWzUdrOrF0vBBswxSUPUIKRgwcZxw1IsueLekHZRnuW1EcJkaW yhODHPtJjxfItMJ9Hr1C6+a+jITrk4J1L16laRcMXOw6y+WwTZ2DDZ0BzGDqzfrXflDo pQ26QXR3N6IenF5yin58xpDqus8dN4jxlMvO6Lp1xHiMp4Yz/ex63Hp6qRKefeV/hjKx ZncnR4RORuChTGnCFyems7jlU7zfFDcjnpgMdPbp+Ipzw2ZcLfEg3lgcsgoEHi3Jqj8p BlEQ== X-Forwarded-Encrypted: i=1; AJvYcCW3hhr+Xeo9tvjtssOlWQDXeQgcHnz/4LUYuCBrLrh8WlAY2vCGDNwqVYPxooyaR18XI1wff5iS5voVTvcWdrMCY3A= X-Gm-Message-State: AOJu0YzxVZYoO3/2gyuCIT/mSArlEmLCMOeotcxlj5jPwIGsHMIFtpd0 x05NX7RRbXo347UBb6JxxZLXecpiIH9YZ8jEVG5ocNulpWpBXGZ+ZW6PXtP3D3bBOxbbIeeCqcZ 33aISX7DDsmj8oxZhaY7xY3Sozv+ZPhlKE3QF56pz3ngc76M1 X-Received: by 2002:a05:6000:1052:b0:367:947d:ddce with SMTP id ffacd0b85a97d-367947dde8cmr692150f8f.68.1720001488340; Wed, 03 Jul 2024 03:11:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEq8kV0b9MR8S15SlDw9DVYj4k79XzLEYDyI2d9sDxNAZ4qmp8L1kzIHrav+ZPmtwzXoxBAyg== X-Received: by 2002:a05:6000:1052:b0:367:947d:ddce with SMTP id ffacd0b85a97d-367947dde8cmr692128f8f.68.1720001487885; Wed, 03 Jul 2024 03:11:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:3400:5126:3051:d630:92ee? (p200300cbc709340051263051d63092ee.dip0.t-ipconnect.de. [2003:cb:c709:3400:5126:3051:d630:92ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0d8ed0sm15514574f8f.28.2024.07.03.03.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Jul 2024 03:11:27 -0700 (PDT) Message-ID: <79910a02-7767-4f70-9248-319aba79fb45@redhat.com> Date: Wed, 3 Jul 2024 12:11:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] kpageflags: fix wrong KPF_THP on non-pmd-mappable compound pages To: ran xiaokai Cc: akpm@linux-foundation.org, baohua@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, peterx@redhat.com, ran.xiaokai@zte.com.cn, ryan.roberts@arm.com, svetly.todorov@memverge.com, vbabka@suse.cz, willy@infradead.org, ziy@nvidia.com References: <1fddf73d-577f-4b4c-996a-818dd99eb489@redhat.com> <20240703092023.76749-1-ranxiaokai627@163.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240703092023.76749-1-ranxiaokai627@163.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AB1C740024 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rfg5uftd6a1r13i7381wwb6h1yuytg4f X-HE-Tag: 1720001491-871718 X-HE-Meta: U2FsdGVkX188+XC8XtrcKoj9dB8hF4J4lS2yIIOfUkl0ECtVuQXLbRAGPbPn1p7GGMvy/m+qSSKeGecmVlLmzkn+YQWr4RG7QSoV9dt/k9nQoiwI0yeCwh6coRiO5a1ztZOqUryfEicfxFnPtYWkxrZXOd1tsV1uKICQXJ484CivZkn2JEf69BDRtSj+PFnRvKERy9cK37dquxfcWjBoVmovLFDRB3VMkCUkS2F7ehkYR4yiCEjDSUnnB88qJr/+QmqmeiiJIhwlAumV5UWDZGx1eM5D81k8VAXRfB+4ZIVqckLz56RK4XWo57gr/EEGWnOJLwsjj7ZChMBtc5vYBNnySIoocvgKeYaenOpd93l3uNu6090SHyYTz1TmWYmApVgv7dB2ho7he7iyAJC7srM1s40MTZaQ5obWEoaNoBeQp185u+GuqokOIa0XpQXTyfSCX+AQgiXXA0KwoRGSCuzfj5/740+LwUSa4leKiW5ulqIAUVhCcao9dUlMfs43SxPCdPYlfwtfv91C1MWFe/5yCBOQBEUMwd2zh1VgRELFtljrOOIlq/U+MtT7gPWeA8U3QcCntcxT5MWBTCTVoP8/9J0MSQvwlr0vN76qVy9uq3sv2PuwwZxwJgHS0z7RXCj7ZU/4fS1dvIpe5nruT5SzML596VJ4L6gBl1+RDwJE+kmR1xRCDCJ9ZBFu3X7rvI113jhN8R6d0mgUgpOyUxp9Issfz9s4ITlld87NzPAgoYAdrmElouUpqIzL/7civS0ziVREELMzg+Sac5vJYPzKkR0OXx3c/9RbX6YVvROqpiL7cFC0T9ENYdLma0skWI1+ExVH2Gv1tyHMobwV3XiIet+nTpscn9v2y7Dk5gjibKCKlldglYOx1+X4ASenbvFUTKcBjTzVqO+6UWUUHHvKjTDkFv0uvqJ/HMzz/jUn6CDrKM+iv72QDm+M2GJW//VMhhMI4EWEZ3xInnY 6HmGSzQr p2aQacKsLhvqb5wqOH6mvvUdBvY6ypGRnybAp160v4dYov/IJU+jFXy8MmIFnE/m4mMJLcvrWsBpitzlRplScGSIvLFCj+roaiDSN0FwWTC42PAUhKkGDUpSne89yPvJhvkFB/o9KcyvYMbLqcFC8O+RgP8A7hY7TOXaA5VxQHNeVjy+k7Nrxct0WLDg0BdLvkf6YQbsJ7KkkkIdo/djwalVlm9GPdfci9UF8ga90qOuZZ+BZkNVBBZkgUKiF5GN5AQu5pK19lDpE6wdR9DJTNJcvOhOEOyzCBDeGWe4kntIMZYA3dFen2GdJ0dAg5TSZjBe6LH3uGrW7k1LPHBnppVOCb7H2xU4ISkuHqv6/EIbO9yt6ok4dW0p/E6SozScEUM9a3+G7Qwv3E+Aw4NfRbTyrzi0DuhEZlm9g7/N0mMQucpvWTskvW2hWmQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.24 11:20, ran xiaokai wrote: >> On 26.06.24 04:49, ran xiaokai wrote: >>> From: Ran Xiaokai >>> >>> KPF_COMPOUND_HEAD and KPF_COMPOUND_TAIL are set on "common" compound >>> pages, which means of any order, but KPF_THP should only be set >>> when the folio is a 2M pmd mappable THP. Since commit 19eaf44954df >> >> "should only be set" -- who says that? :) >> >> The documentation only talks about "Contiguous pages which construct >> transparent hugepages". Sure, when it was added there were only PMD ones. >> >> >>> ("mm: thp: support allocation of anonymous multi-size THP"), >>> multiple orders of folios can be allocated and mapped to userspace, >>> so the folio_test_large() check is not sufficient here, >>> replace it with folio_test_pmd_mappable() to fix this. >>> >> >> A couple of points: >> >> 1) If I am not daydreaming, ever since we supported non-PMD THP in the >> pagecache (much longer than anon mTHP), we already indicate KPF_THP >> for them here. So this is not anon specific? Or am I getting the >> PG_lru check all wrong? >> >> 2) Anon THP are disabled as default. If some custom tool cannot deal >> with that "extension" we did with smaller THP, it shall be updated if >> it really has to special-case PMD-mapped THP, before enabled by the >> admin. >> >> >> I think this interface does exactly what we want, as it is right now. >> Unless there is *good* reason, we should keep it like that. >> >> So I suggest >> >> a) Extend the documentation to just state "THP of any size and any >> mapping granularity" or sth like that. >> >> b) Maybe using folio_test_large_rmappable() instead of "(k & (1 << >> PG_lru)) || is_anon", so even isolated-from-LRU THPs are indicated >> properly. > > Hi, David, > > The "is_anon" check was introduced to also include page vector cache > pages, but now large folios are added to lru list directly, bypassed > the pagevec cache. So the is_anon check seems unnecessary here. > As now pagecache also supports large folios, the is_anon check seems > unsufficient here. > > Can i say that for userspace memory, > folio_test_large_rmappable() == folio_test_large()? > if that is true, except the "if ((k & (1 << PG_lru)) || is_anon)" > check, we can also remove the folio_test_large() check, > like this: > > else if (folio_test_large_rmappable(folio)) { > u |= 1 << KPF_THP; > else if (is_huge_zero_folio(folio)) { > u |= 1 << KPF_ZERO_PAGE; > u |= 1 << KPF_THP; > } > } else if (is_zero_pfn(page_to_pfn(page))) > > This will also include the isolated folios. You'll have to keep the folio_test_large() check, folio_test_large_rmappable() wants us to check that ahead of time. Something like ... else if (folio_test_large(folio) && folio_test_large_rmappable(folio)) { /* Note: we indicate any THPs here, not just PMD-sized ones */ u |= 1 << KPF_THP; } else if (is_huge_zero_folio(folio)) { u |= 1 << KPF_ZERO_PAGE; u |= 1 << KPF_THP } else if (is_zero_pfn(page_to_pfn(page))) { u |= 1 << KPF_ZERO_PAGE; } Would likely work and keep the existing behavior (+ include isolated ones). -- Cheers, David / dhildenb