From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 929DDC43461 for ; Wed, 16 Sep 2020 18:12:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 12E4421655 for ; Wed, 16 Sep 2020 18:12:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12E4421655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52F366B0068; Wed, 16 Sep 2020 14:12:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7C86B006E; Wed, 16 Sep 2020 14:12:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A6176B0070; Wed, 16 Sep 2020 14:12:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id 20F116B0068 for ; Wed, 16 Sep 2020 14:12:35 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DDAE7181AEF09 for ; Wed, 16 Sep 2020 18:12:34 +0000 (UTC) X-FDA: 77269719828.28.home48_2313ca22711b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id A7C1C6C0B for ; Wed, 16 Sep 2020 18:12:34 +0000 (UTC) X-HE-Tag: home48_2313ca22711b X-Filterd-Recvd-Size: 2165 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 16 Sep 2020 18:12:34 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 14EA2B14F; Wed, 16 Sep 2020 18:12:48 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 16 Sep 2020 20:12:31 +0200 From: osalvador@suse.de To: Aristeu Rozanski Cc: naoya.horiguchi@nec.com, akpm@linux-foundation.org, mhocko@kernel.org, tony.luck@intel.com, cai@lca.pw, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/5] HWpoison: further fixes and cleanups In-Reply-To: <20200916175813.GD17169@cathedrallabs.org> References: <20200914101559.17103-1-osalvador@suse.de> <20200915212222.GA18315@cathedrallabs.org> <20200916072658.GA10692@linux> <20200916135358.GB17169@cathedrallabs.org> <20200916140921.GA17949@linux> <20200916144603.GC17169@cathedrallabs.org> <9bd7ac81968a7897474804d53bfc1286@suse.de> <20200916175813.GD17169@cathedrallabs.org> User-Agent: Roundcube Webmail Message-ID: <79739b73f77a124cafa056e56f57c450@suse.de> X-Sender: osalvador@suse.de X-Rspamd-Queue-Id: A7C1C6C0B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.018585, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-09-16 19:58, Aristeu Rozanski wrote: > On Wed, Sep 16, 2020 at 06:34:52PM +0200, osalvador@suse.de wrote: >> Fat fingers, sorry: >> >> Ok, this is something different. >> The race you saw previously is kinda normal as there is a race window >> between spotting a freepage and taking it off the buddy freelists. >> The retry patch should help there. >> >> The issue you are seeing right here is due to the call to >> page_handle_poison in __soft_offline_page being wrong, as we pass >> hugepage_or_freepage = true inconditionally, which is wrong. >> I think it was caused during rebasing. >> >> Should be: > > Tests passed with this patch on top of others. > Thanks! Thanks for giving it a shot! I will be sending patches tomorrow morning. Thanks