From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 182E9C433E0 for ; Thu, 11 Mar 2021 16:53:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 85CED60249 for ; Thu, 11 Mar 2021 16:53:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85CED60249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E69BA8D02D1; Thu, 11 Mar 2021 11:53:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E06E28D02B2; Thu, 11 Mar 2021 11:53:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCF6B8D02D1; Thu, 11 Mar 2021 11:53:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id B3C678D02B2 for ; Thu, 11 Mar 2021 11:53:45 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 729335DE6 for ; Thu, 11 Mar 2021 16:53:45 +0000 (UTC) X-FDA: 77908190010.02.3DAFA54 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 81AC5200039B for ; Thu, 11 Mar 2021 16:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615481623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RsNecIoLWMmtHw2ukLD+MXYyvQSCHtDN1GLSjaRSntQ=; b=aNQpgEJWAMqmnFArJwBXV4QW7bAtEeai/A1m3Fut9TjpMyAFZyu/ohg518Z0JQxR8p9juP R7kJmHLR9vhoz1x8/EvLsiWL6tM/pzWWZ5jIgtcbNsw7E27sedaumVkUndFdyQiQFL8SGC HKDSnLeu89l9yqzc++RMdMto7TXA4s8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-ibkYS-aaMPGpYU69OceJqQ-1; Thu, 11 Mar 2021 11:53:41 -0500 X-MC-Unique: ibkYS-aaMPGpYU69OceJqQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4E51CC624; Thu, 11 Mar 2021 16:53:40 +0000 (UTC) Received: from [10.36.115.26] (ovpn-115-26.ams2.redhat.com [10.36.115.26]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EC9218BBC; Thu, 11 Mar 2021 16:53:38 +0000 (UTC) Subject: Re: [PATCH] mm: cma: Use pr_err_ratelimited for CMA warning To: Baolin Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <796ca026-31e8-7958-5e7b-e8b5446247a3@redhat.com> Date: Thu, 11 Mar 2021 17:53:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 81AC5200039B X-Stat-Signature: kyjk55x8c55bpzyufmjck3d3mrmp4aqe Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf11; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=63.128.21.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615481618-550384 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.03.21 10:16, Baolin Wang wrote: > If we did not reserve extra CMA memory, the log buffer can be > easily filled up by CMA failure warning when the devices calling > dmam_alloc_coherent() to alloc DMA memory. Thus we can use > pr_err_ratelimited() instead to reduce the duplicate CMA warning. > > Signed-off-by: Baolin Wang > --- > mm/cma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 54eee21..d101bdb 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -500,8 +500,8 @@ struct page *cma_alloc(struct cma *cma, size_t count, unsigned int align, > } > > if (ret && !no_warn) { > - pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > - __func__, cma->name, count, ret); > + pr_err_ratelimited("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n", > + __func__, cma->name, count, ret); > cma_debug_show_areas(cma); > } > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb