From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98E2EC636D4 for ; Tue, 7 Feb 2023 16:53:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DA816B010C; Tue, 7 Feb 2023 11:53:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 28A236B010D; Tue, 7 Feb 2023 11:53:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12BB06B010E; Tue, 7 Feb 2023 11:53:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F30BE6B010C for ; Tue, 7 Feb 2023 11:53:43 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C7C47801F6 for ; Tue, 7 Feb 2023 16:53:43 +0000 (UTC) X-FDA: 80441092326.05.15B1E2C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf21.hostedemail.com (Postfix) with ESMTP id D18CD1C001A for ; Tue, 7 Feb 2023 16:53:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BK2YGvpS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7m9w95ne; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675788821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o5NcPOkp+Z/yhDkVYRJmYm46jPzt9w/1RGRXgbqCnuU=; b=hShSfixBvgABObnbmadJUZUaTmk7U/IxigKIaTXEz+roxzbqUMGPCVtAv05DyxURtYgNMX EQXW3yvJ6VMS61U2CRCfwEW7mhp1xcIbUTFQwepQOx3LW6xtPyRKgCT+yHztLc0z5fIxB4 xZHW+TkgGbSBv6hVSz9lIhoK6jrkRqU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=BK2YGvpS; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7m9w95ne; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675788821; a=rsa-sha256; cv=none; b=aWGe80BYN0761Iw78J24I3P6nDyzLXvGPUqKCnMN2hAcuK0Aty0rhNYYc77wdcQJm1WHcX dVeDENt5BUWunFdUY8hVxqjgOWa+aBJ1YmzlYIg+4JHe+1M7AlUpzfe1Vo4FksNuVGt/w0 914CWGA1J3GTsY4w7cDPzsYgPx4QqdA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 773315FC7D; Tue, 7 Feb 2023 16:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675788819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o5NcPOkp+Z/yhDkVYRJmYm46jPzt9w/1RGRXgbqCnuU=; b=BK2YGvpSLBwmZzbch5ZCxUOEYppRqJ9dQ8+rw/fEJVf/kkhrhG/vpB+5/adyHM4JgLJZ+B Am1HopSsvMc0DBHhOLoE6c+fUwZ8nYL4JfdXY/cljBoDNuk18Vl9avof/4w1+mbuZvb71E ye/lbay9Egv+iQobr6r08ArQ3WbtihQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675788819; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o5NcPOkp+Z/yhDkVYRJmYm46jPzt9w/1RGRXgbqCnuU=; b=7m9w95nelbKVOVN+1duhSn66FRAtgHTzBZfQx2jwnnZ/+welNcqzfBVs2fX6aLzzNlKo3J looNWePRzqiJLYCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A32313467; Tue, 7 Feb 2023 16:53:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gZyKEROC4mOTTgAAMHmgww (envelope-from ); Tue, 07 Feb 2023 16:53:39 +0000 Message-ID: <7962d171-fc29-88db-ee33-4326838d7b40@suse.cz> Date: Tue, 7 Feb 2023 17:53:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/4] mm, compaction: Check if a page has been captured before draining PCP pages Content-Language: en-US To: Mel Gorman Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML References: <20230125134434.18017-1-mgorman@techsingularity.net> <20230125134434.18017-3-mgorman@techsingularity.net> From: Vlastimil Babka In-Reply-To: <20230125134434.18017-3-mgorman@techsingularity.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D18CD1C001A X-Rspam-User: X-Stat-Signature: oxreby45sbwscrryyeh8oy5k5gzkp6ng X-HE-Tag: 1675788820-200863 X-HE-Meta: U2FsdGVkX19Ng4G/qzN1CtYZudaskujpVjPM0ad5VSV187tzrhakz2+mt8FKPEn9nyDh5DeTjXD/DSLSOzyO0nf4LEzt9ZG+Ph2/wXTJqiIn9y/NU1djutAzhXqna2uh4XXTUBQ1zm2uVMTsfkYHkP97VxVgw8HwVfWGpTtjAgfnC53/R6kLwhaPwwS7OYtr/+WbuW9BC3RN/3x5WL9fBLcAgll0EybMXXIEBMACM+96PPRZPP0JKI2KTsw9DVD10j2rYvSpWo2lhe15JNER5pJf5rpSy1UjrD3girFtuRFsbtxMlqSFCiOW3RJ0k/DZkiBzrCa06EmAN7GE03nPl7oMSueodO+U7WZgj4gq/2pDX44V64HI1UAehg7ysRk5/c0Z/WY4OeExl/6i4Rs+I0N8JWleddU52x41tbxtPVLMDq4WvOabpRKofltNUtMdHRZmo7UD2K9PGE/2h3t8nytXA2CtjPD87nRfj7IXE5jlLWTf45JWMpVAdfEC185fyy+5wxB3Wf3OErC9M8iCj9Vm7iNnbyPKgQBJ3k7R213G24V9ALdS7pIHRed7BRPyfxJXqxASTBOVr2YpkRBEAQYlZVnmX/3cGGz/lKBFUpzGHzQZZXJXx2SdaY4MGfatdCkbkSVK3DIdEKZcbYL6nUJr6Z+ZI12GLHNZ/Zbb3UTLyu1l+F/nxNCidup9tO9LzWt6AcIGBa1U4+Scw5G8bjMkG/6OSv/33m33MitakTTWVSn2DUZtFgUHFkuoPehqgAAhpZ7iSbMjFFJi1VFWL/5dgRh6OrzsQBjNhUiqJzb74b2fCES1hqLiGjucHzgbwXca2+UhOtCfQ9Cv0xmj52K2m4WwMzWvGRSlY/GEKNdYjXeZRYHFfCuGy/b59LeVSh9DjY2Jx2h7Ci9+nxFTGSs8inK3ehxM8lwY9X3FHb7lbWP9DHHUmZbN8e5SQIYGIgEq9ele+0JzQL9MuCh fbmfP27e jJtb4auHsSsTs9c0rw0YXZq523Os4zTJXEfn0xyzJhwE8MoPO6Qch74gMhccrrd9rKh4PIeh8loxfO5LPGL9SOA4rfWICGdNVFSypuxaMbi3ln73nlxyhFIZeuz6vVRMKT/09ozcaSAS/p78JHbADMeAyA0UBvjV4gWfLG16O8SmRt7aAxuuw0M98KVutqQ88wmBfIoxK0ZYVf23Su3iidABausWZiGkjdgAeoR2DJy8LjdxIc/FNQdpHPgR0fxvPKr1f/SmJBZUXRqGKOyNlaFigTvEcborZjVq8mF/WrEO2Q5OzChMWFSvprZyXciowGzBuyDxBwLKeb5qudtZZE7Gvd/xBpeD+W5XmOfzJDN5zQuETDXFZyGLyBWdXX04xixtiCNUyy7cJ6ubL9Xq9jQlOJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/25/23 14:44, Mel Gorman wrote: > If a page has been captured then draining is unnecssary so check first > for a captured page. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka > --- > mm/compaction.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index c018b0e65720..28711a21a8a2 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -2441,6 +2441,12 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > } > } > > + /* Stop if a page has been captured */ > + if (capc && capc->page) { > + ret = COMPACT_SUCCESS; > + break; > + } > + > check_drain: > /* > * Has the migration scanner moved away from the previous > @@ -2459,12 +2465,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > last_migrated_pfn = 0; > } > } > - > - /* Stop if a page has been captured */ > - if (capc && capc->page) { > - ret = COMPACT_SUCCESS; > - break; > - } > } > > out: