From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7222AEB64DC for ; Thu, 6 Jul 2023 11:58:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D55C68D0005; Thu, 6 Jul 2023 07:58:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D097C8D0001; Thu, 6 Jul 2023 07:58:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCCEC8D0005; Thu, 6 Jul 2023 07:58:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ACD7B8D0001 for ; Thu, 6 Jul 2023 07:58:14 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6EB4D40B70 for ; Thu, 6 Jul 2023 11:58:14 +0000 (UTC) X-FDA: 80981038908.21.8688692 Received: from esa2.hc1455-7.c3s2.iphmx.com (esa2.hc1455-7.c3s2.iphmx.com [207.54.90.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 6AC0EC0022 for ; Thu, 6 Jul 2023 11:58:11 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=fujitsu.com; spf=pass (imf10.hostedemail.com: domain of yangx.jy@fujitsu.com designates 207.54.90.48 as permitted sender) smtp.mailfrom=yangx.jy@fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688644692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgq9kQMnS1BqgPp0hN+dZx55/VS/gv70VzIukUPGwqY=; b=ST9MHHrwfItL8oekYtSI4FD4G4PILq0zYUBxCK7oBpnbs3aGKONniSVPjSJUJmLVPedpAW m+we2wwoG1KI7MZAAS9CDh7aPs7uuzp7QX+2tLPwSA8vxOoV7YYg3LqCO/3vX8l3sdqYdW jHUg7GdaD0I731y69875SHp+VBMteK4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=fujitsu.com; spf=pass (imf10.hostedemail.com: domain of yangx.jy@fujitsu.com designates 207.54.90.48 as permitted sender) smtp.mailfrom=yangx.jy@fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688644692; a=rsa-sha256; cv=none; b=2SJaDDzbOC+qp326nvPQSifbkt+M7TVubfGn6tpIzUmxIrRq0K5X9EpRuSO/M/9pFok1Ru /kDfOAdqZioOpZD7QklxDYaTt8UHuYLB0vh2xH8Sv98SqWuiFcMFepOxOwesiWJC+mu9Ff SL8VFprEMglJPybKMrqRPnzErAumhXA= X-IronPort-AV: E=McAfee;i="6600,9927,10762"; a="123623408" X-IronPort-AV: E=Sophos;i="6.01,185,1684767600"; d="scan'208";a="123623408" Received: from unknown (HELO yto-r1.gw.nic.fujitsu.com) ([218.44.52.217]) by esa2.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2023 20:58:08 +0900 Received: from yto-m2.gw.nic.fujitsu.com (yto-nat-yto-m2.gw.nic.fujitsu.com [192.168.83.65]) by yto-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id 3E9AB55605 for ; Thu, 6 Jul 2023 20:58:05 +0900 (JST) Received: from kws-ab4.gw.nic.fujitsu.com (kws-ab4.gw.nic.fujitsu.com [192.51.206.22]) by yto-m2.gw.nic.fujitsu.com (Postfix) with ESMTP id 824BDD5E88 for ; Thu, 6 Jul 2023 20:58:04 +0900 (JST) Received: from [10.167.215.54] (unknown [10.167.215.54]) by kws-ab4.gw.nic.fujitsu.com (Postfix) with ESMTP id 3DF9170BCD; Thu, 6 Jul 2023 20:58:01 +0900 (JST) Message-ID: <7956e695-3eac-25ef-4412-3a0ff33e3574@fujitsu.com> Date: Thu, 6 Jul 2023 19:58:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] memory tier: rename destroy_memory_type() to put_memory_type() To: Miaohe Lin , akpm@linux-foundation.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com Cc: ying.huang@intel.com, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230706063905.543800-1-linmiaohe@huawei.com> From: Xiao Yang In-Reply-To: <20230706063905.543800-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-27734.006 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-27734.006 X-TMASE-Result: 10--10.827800-10.000000 X-TMASE-MatchedRID: 6Yvl3or3fgqPvrMjLFD6eAdJO1X873z+vWY9kbV8t/dWjSWvFszxq4P+ YDa/Dhu95ZHdquAwKoEnZc8nHRklybmvMSppeWbNP0HVIeixJdAJlr1xKkE5ucC5DTEMxpeQfiq 1gj2xET/FG6rPbKnpuiGGQs/f4Ygppx4mVJ23D0QRW4LR41Fi8m/5EOWkmXj5uBsk5njfgGw/SZ 9wNeO8j2KgELVYfwoyHTR6rEcRrh5RPwES1RXV2rFpbR9jggy4UkCyfz2KH3gUXxbGG4P7rKPFj JEFr+olA9Mriq0CDAgBi3kqJOK62b+/RSFMoL2cxEHRux+uk8h+ICquNi0WJB9Sfbb9LDx9HkQb WPBv7SBkTYeysB4rr6sHUYWV14SWftwZ3X11IV0= X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6AC0EC0022 X-Stat-Signature: krmxmtme6jnfaawzrc5f1a9rw3axk1yd X-Rspam-User: X-HE-Tag: 1688644691-220200 X-HE-Meta: U2FsdGVkX18Qad+DTJmqFCE09JCGP83gCFB/F50mbAsusOsJUIUVGlNZjKhRPwlTktvKXb+g/k3QLKG4H2Hbh7/oi6N8LD/YQhySB3/PBTcdmZTyFzGKQQAEVVAvt8dtgCs/2lT6U2/IRVSvSIFssWOkpR2gKQyEMKvqUdeHqYMZUxoKEHy5vy5qGrm6KmYzlGjKwZ5Sdyo5uiJMnZ3sNd0rEKs4a+OgDvEXXDs4P9V9QvIJXa95uhVaKV5tA20SfYkq8Ad03uW4/NQw2yg75+CRuEBBqwBLUocAkTo7kRzutlgpBtasYJE1sTifI8bvJGYjyJBY1EUicv2+fv+2i45whrt4t17d1iW/EZYwRUsB690IXODeQBB1U+0Y7IIJNRGLpKL4CLPNw3gj/6RP9ZrhV6z6PT+7WupMCjBmW5Wp/t+01zDWuxeZDGyG61wYmno3YIHOUPCD2fhddfHLJ/nyTaZrgIJb3EknAj8MuKcMxFgS9gnR3qx0eZztnjmq/Jy+P8fv6yfCG6yNSOzKbvgnLenc4beWmZxoa5CQxw4FlvRKaITy/0iRyC8mcHse9lSaeVpzIryZSzvLCH1yYKM+3IGvQKxrj3rNG/2SpFwa0SOCI9Q3FZ/LxijkOFNY5xzcumEV+WSBZkd1PKZlZ3sC4kLqIcK5VhbVQ8Wq20xp+bIdptCVMXDSdLfOdBWiTNo2e23WVoGOLBoQGE4h51Es5q16ROzMdFXR7NkSTl2XmkluoJENL+kjKV+adA+YD1gFzAZXYmz7jT7s0lytJ2XYDC9+Bri6qOwbpqaRRV1b36R3TA9tOz4CjK7iJFCPxe83MzfKlXSpZ0OQ5GpuhgbbfWzTv7Cgi7KjSj94bQyiPJD4XTHAyUd6r9f5npaVxTTRUSZJJVIYOyUl9LQ/pCSTJvpR2imI2Mg2GDpuVQ5n7v9EJfpO2BmKXRG78OQ0yJQX2ICYm1qCfwJKK4q k9qmfv0i J6wJ/GQYtKJRSgd3R69JA2rXVAFVbz0bQXNApvmA//G5RE+3guc0+5AzwMp7t5ZZepVsgWGDT01K3RVob0h5artp9XUkGTN9qRwepPSe7jQ7gfoa8qQL45jOLxWDKK9z9AuXnMaeE+Ku9ZsFMnuMj4CKOOD2wFrjQAprOxlhK3z05fTGv0kXCU32UQamJCfWNErn/5JeCAXF8jS/QzZlEMA2WTq1Kw/jfGwyjYcOMlO5fZR53KnaWj8t4jGSySgDumrWUoZrr2QaBcwA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/6 14:39, Miaohe Lin wrote: > It appears that destroy_memory_type() isn't a very good name because > we usually will not free the memory_type here. So rename it to a more > appropriate name i.e. put_memory_type(). > > Suggested-by: Huang, Ying > Signed-off-by: Miaohe Lin > --- > drivers/dax/kmem.c | 4 ++-- > include/linux/memory-tiers.h | 4 ++-- > mm/memory-tiers.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/dax/kmem.c b/drivers/dax/kmem.c > index 898ca9505754..c57acb73e3db 100644 > --- a/drivers/dax/kmem.c > +++ b/drivers/dax/kmem.c > @@ -264,7 +264,7 @@ static int __init dax_kmem_init(void) > return rc; > > error_dax_driver: > - destroy_memory_type(dax_slowmem_type); > + put_memory_type(dax_slowmem_type); > err_dax_slowmem_type: > kfree_const(kmem_name); > return rc; > @@ -275,7 +275,7 @@ static void __exit dax_kmem_exit(void) > dax_driver_unregister(&device_dax_kmem_driver); > if (!any_hotremove_failed) > kfree_const(kmem_name); > - destroy_memory_type(dax_slowmem_type); > + put_memory_type(dax_slowmem_type); > } > > MODULE_AUTHOR("Intel Corporation"); > diff --git a/include/linux/memory-tiers.h b/include/linux/memory-tiers.h > index fc9647b1b4f9..437441cdf78f 100644 > --- a/include/linux/memory-tiers.h > +++ b/include/linux/memory-tiers.h > @@ -33,7 +33,7 @@ struct memory_dev_type { > #ifdef CONFIG_NUMA > extern bool numa_demotion_enabled; > struct memory_dev_type *alloc_memory_type(int adistance); > -void destroy_memory_type(struct memory_dev_type *memtype); > +void put_memory_type(struct memory_dev_type *memtype); > void init_node_memory_type(int node, struct memory_dev_type *default_type); > void clear_node_memory_type(int node, struct memory_dev_type *memtype); > #ifdef CONFIG_MIGRATION > @@ -68,7 +68,7 @@ static inline struct memory_dev_type *alloc_memory_type(int adistance) > return NULL; > } > > -static inline void destroy_memory_type(struct memory_dev_type *memtype) > +static inline void put_memory_type(struct memory_dev_type *memtype) > { > > } > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index 1719fa3bcf02..c49ab03f49b1 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -560,11 +560,11 @@ struct memory_dev_type *alloc_memory_type(int adistance) > } > EXPORT_SYMBOL_GPL(alloc_memory_type); > > -void destroy_memory_type(struct memory_dev_type *memtype) > +void put_memory_type(struct memory_dev_type *memtype) > { > kref_put(&memtype->kref, release_memtype); > } > -EXPORT_SYMBOL_GPL(destroy_memory_type); > +EXPORT_SYMBOL_GPL(put_memory_type); > > void init_node_memory_type(int node, struct memory_dev_type *memtype) > { > @@ -586,7 +586,7 @@ void clear_node_memory_type(int node, struct memory_dev_type *memtype) > */ > if (!node_memory_types[node].map_count) { > node_memory_types[node].memtype = NULL; > - destroy_memory_type(memtype); > + put_memory_type(memtype); Hi Maohe, I didn't find that destroy_memory_type(memtype) is called here on mainline kernel. Did I miss something? Other than that, it looks good to me. Reviewed-by: Xiao Yang Best Regards, Xiao Yang > } > mutex_unlock(&memory_tier_lock); > }