From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A924C02188 for ; Mon, 27 Jan 2025 16:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1DE0280186; Mon, 27 Jan 2025 11:59:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CDCD280181; Mon, 27 Jan 2025 11:59:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81F8D280186; Mon, 27 Jan 2025 11:59:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 641D8280181 for ; Mon, 27 Jan 2025 11:59:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 15861140471 for ; Mon, 27 Jan 2025 16:59:57 +0000 (UTC) X-FDA: 83053844034.17.75C614D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 8DD97C001C for ; Mon, 27 Jan 2025 16:59:54 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i4dKZLyi; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737997194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gg6xSa4aH4O1RPvgzdabSWR7ON+7U7aSszV2WgC1xm4=; b=148g66bKIgdjWSz5B+A1u8jG90QpMp+3oWDt71lV/XucqFiaFMoTeoP7ZjxNnzKmxNrmOB s7HBuicsZ24jN+ilGTmehjv70fZ7Udo6gZywcczTsVMNe6KEnbcFg6cItjcTHfRwpL85ao D03SE8OICtJZBWyz4L1BNpmmQX4cLOg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737997194; a=rsa-sha256; cv=none; b=2laRzZdRyvK4MrAxyCS7whkX0+TXeCHS6o4/DYWj0XCbfAMBj7/mgudq33MzjNq0GgwrRC mgdeieuhuoZbdLc17fmR68xdlgIZxHFHc6loKSQUEJorUYyz/uEq1KTowdrrhIuAXgUyGN mjlQi4scJyaiWpnGV7UMx2laDA6UpE4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i4dKZLyi; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737997193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Gg6xSa4aH4O1RPvgzdabSWR7ON+7U7aSszV2WgC1xm4=; b=i4dKZLyijdZK0ZQAz0G/kN8LYDo8GpWCQanFRlLSYVmCxsB8mtbOrkd93L0mk6RJcngSr0 P69XW6mnRX2t8LuwtwQk4qTNxycCYug+7GCh96D7wenkWhBOEEgMqR0sFLy1vkANzv7R2V 17p/kA8iwlhSUBdJ1j+jkUKv6jlWEec= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-HbKS2XRhM5mwOh6XHCvZ9A-1; Mon, 27 Jan 2025 11:59:52 -0500 X-MC-Unique: HbKS2XRhM5mwOh6XHCvZ9A-1 X-Mimecast-MFC-AGG-ID: HbKS2XRhM5mwOh6XHCvZ9A Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-38629a685fdso1598664f8f.2 for ; Mon, 27 Jan 2025 08:59:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737997191; x=1738601991; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Gg6xSa4aH4O1RPvgzdabSWR7ON+7U7aSszV2WgC1xm4=; b=pwidcdSXZj7QlUsJEUCVewBudK5yfv8tvDAHT561Bvaol9GdSUIrGGnyrp7uarDS0K A61HeedPttyIDenqAwITpYTFgs5aV6RbSP+g+X0RIkJI+CaNWUHaFj/TmbiZEDLEeRyq aetcLk5rpFE0gyN+cSoXCfbU9NXhrdf+2gvFAjhAs38/h6FigLf9si7eIKJAyffnDFx+ LZs+YdgnEYd2wKA8/DMOnNzkW89ZiVkvScZVqfI7J7w9ONoYT3CijGsNN27bacjEJIwV IWIrFjeop72NSLaYzeB9dVQRoHCtjW/yBy8mPIZFLBJunne2KXFqER4xVRvwR9v2hpnJ vI8Q== X-Gm-Message-State: AOJu0Yzuacl1FOfh24E2DBcGBQuirBhwiWhJ9tP9KLxoH4c9LN3hAhF7 OW0fDPpf5VMTveXN1x/Iaptu2y67hwk+IZuEe4Gi9j7Q1uvWHEpwiLmEIcot7BGN/t9wJfaRzz4 aKMk5i+lF/hRHXxiI0ZBoMTeWa4923PygdY+c2P3FhkhtZGyt X-Gm-Gg: ASbGncuq1t9tSsF1suwePvoa6gSc6LXbF0tJv80oUabSexs9qL0AshKZeAvlZuvrCrB c8LHswtKPrUo5xYFh3X4r8+mkR7JUB8Jr7yyTZhJsynGmczY9EZ3EDUSt3w5t12ZJbkl2Wy10lp 2TLtV6Tp9/Uod6NkS/MpdyYC/qjV5lTb0LOKmmod4bkkpF2FsFuB2Aba1SaDsp5aAI08Da6PIcn g5bYCZaHmznI95vKQ52VQ6DH+7Mv00959YSrHzGTIH/wBLwPrH9SYiX/zflyqrq28CfcWB2C/zc s2u0VuKrdUPL5QwRSaF9WSbWyBh68DsxClyIpN5SFyYirdYDTmGKtr1cNDOBb21xf49mpn5CKBm x1K6IYs0jmIIKCxjTOBBqToRhsDoX7TMy X-Received: by 2002:a05:6000:1863:b0:385:df2c:91aa with SMTP id ffacd0b85a97d-38bf565579fmr33649073f8f.7.1737997191271; Mon, 27 Jan 2025 08:59:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQ/PMqF3e1zaJl6Xd14meyKX4o2aJ0GCGQDzLJt6dJ9YypjazFw+CdYIhlZ+4HBZ1nfGKqWg== X-Received: by 2002:a05:6000:1863:b0:385:df2c:91aa with SMTP id ffacd0b85a97d-38bf565579fmr33649059f8f.7.1737997190926; Mon, 27 Jan 2025 08:59:50 -0800 (PST) Received: from ?IPV6:2003:cb:c736:ca00:b4c3:24bd:c2f5:863c? (p200300cbc736ca00b4c324bdc2f5863c.dip0.t-ipconnect.de. [2003:cb:c736:ca00:b4c3:24bd:c2f5:863c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188915sm11481591f8f.41.2025.01.27.08.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Jan 2025 08:59:49 -0800 (PST) Message-ID: <79534193-31c9-43a0-87af-023500c22042@redhat.com> Date: Mon, 27 Jan 2025 17:59:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Direct I/O performance problems with 1GB pages To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-block@vger.kernel.org, Muchun Song , Jane Chu , Andres Freund References: <503c29c8-bcc7-4a6c-ab2e-ebf238a9a1db@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FOWRlD1Z2ZuiQ28BFDCibvzY2uyslIVaEl4kIWAzaF4_1737997191 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: yj3r3rertm9jmmkrws4gz5mxw75zzucd X-Rspam-User: X-Rspamd-Queue-Id: 8DD97C001C X-Rspamd-Server: rspam03 X-HE-Tag: 1737997194-774875 X-HE-Meta: U2FsdGVkX18DmLcIgZmh3kd/0kzEPxSrpoxhTp/7OqLgQXAg0PGbCh5ns20Imfj6qU2dG725IEdwnw/riTQH0to3fvT3zSRanUS0P839CFEvROSeIKGN49tgrfZUk2tPXB4Vtx/lj4OWoUVxxYJMYrKyaQcJ67Kc6/bBcvwWLiT9pYA6y0lc6dmKrFj0qCHbI/c5yqll8dJ5LL4TUqNL1UiU+bUKR5i4r0LRcTmlR3Tixcr+zya/nQ2qv3Ia66ev8y5OOHhZXaeXH8ryPSJ6Ko0GPPP/AdMjY6DAhBJT7z9+GcuE3lmdCUGHMWP3hsqd1Pdzqs6uNGmfGijjsde/hT1BKURPalxBEgBRUWWKeqsowIRYUSg50mcmgC5KdM5K9EHaXKNbwa01CNcSkiCDObTVczGpjw5h6WvdlgLDaUrIrnHwp0CBPRcAs5+/h7ObQ5sBLFn4AMYtDPE57pVLxudIT+XyliDx8yN0hbRmCz1C5oX6d30lRI/txpwjmLc/v1pgV9YooCbftWgMD7a4DM4IRcj4oCFAD5MW3K+QrFAmDkD/EgvCNu+Tle+kfhovGRo+ahA14zS/EKmdGHkP0xqvLDfndQux1yZPF/9m8vfln6I4ojQTyLGbf2+2+OQl9MWFbotHX/V21dHGOWJC3U7IJElT+xMAGUEGSK6I1+Mi8HDzQ1a6+BMRsZ9jgdI1gbr8oXLEU+Is1IYDUtzVfbRS+myzB8Pu17DruBDIG+8aYNiuKGhhjak5hhB74n8eJgOCYbiWtQXjEKIAbr3M3fnrQEagplPslSw8q/QMQopdsTdxNScyo78hS2E0K+bGc+CtPQstFMCSKtuMqsfdICPv8GFb37kAGHB/2LekDjx5vrPGJnCZ0Cc62gsz8zGplCE18CkoFna1sAvV8IQXJy5C+E8mKwfKg+qZxfFSWq/1U5v62b8l1bREhv/2lkeraUks3A1d+cPyLp32Jso gz+982/p vbv8xDTbCdMDkz8MIuW7zef9Z+8h4juh9cGPaW20Hg1vUn1wqh90sKRzi+QZXrzsyNd9S2NSNHfA3cekOG1CHa78Z1Z7HwqnspK18rSs6ATUARhSt4l1J83tW2JuMn5pxAAbILGalr8ImyycWf70+yGtYIgdGDE2PVBGTPnC3on5KztJpsY3ZSDvok1drVYNd4mmZFi6fmA9j3r9ey5Bv6q0KZA8zjxqpj5cItnGT6huxy8fQdfrYLnmZGrZbYi2/iliZDm90zsD2QVFs/JcR12bhZukuWIWyjAoxx6piKa3EmyHonMttCvF/N0PdIOjdFZ5xc3x0rlxVc6hPKrrcXXLcxByCjubo2wvu9W2OgT6IK2t/KvOe22hq/LrHcSiih4ZrAZ33kcPwR3w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.01.25 17:56, Matthew Wilcox wrote: > On Mon, Jan 27, 2025 at 05:20:25PM +0100, David Hildenbrand wrote: >>>> 14.04% postgres [kernel.kallsyms] [k] try_grab_folio_fast >>>> | >>>> --14.04%--try_grab_folio_fast >>>> gup_fast_fallback >>>> | >>>> --13.85%--iov_iter_extract_pages >>>> bio_iov_iter_get_pages >>>> iomap_dio_bio_iter >>>> __iomap_dio_rw >>>> iomap_dio_rw >>>> xfs_file_dio_read >>>> xfs_file_read_iter >>>> __io_read >>>> io_read >>>> io_issue_sqe >>>> io_submit_sqes >>>> __do_sys_io_uring_enter >>>> do_syscall_64 >> >> BTW, two things that come to mind: >> >> >> (1) We always fallback to GUP-slow, I wonder why. GUP-fast would go via >> try_grab_folio_fast(). > > I don't think we do? > > iov_iter_extract_pages() calls > iov_iter_extract_user_pages() calls > pin_user_pages_fast() calls > gup_fast_fallback() calls > gup_fast() calls > gup_fast_pgd_range() calls > gup_fast_p4d_range() calls > gup_fast_pud_range() calls > gup_fast_pud_leaf() calls > try_grab_folio_fast() which is where we see the contention. > > If that were to fail, we'd see contention in __get_user_pages_locked(), > right? Sorry, my brain stripped the "_fast" in the callchain above :( -- it *is* try_grab_folio_fast() :) So yes, we are in GUP-fast as one would expect. -- Cheers, David / dhildenb