From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E19C2C433FE for ; Thu, 11 Nov 2021 10:01:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8F8BD61107 for ; Thu, 11 Nov 2021 10:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F8BD61107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 314BD6B0098; Thu, 11 Nov 2021 05:01:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 29F516B009A; Thu, 11 Nov 2021 05:01:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1176D6B009B; Thu, 11 Nov 2021 05:01:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 02BA36B0098 for ; Thu, 11 Nov 2021 05:01:41 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A3C4C800B8 for ; Thu, 11 Nov 2021 10:01:40 +0000 (UTC) X-FDA: 78796207560.07.374AD15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf30.hostedemail.com (Postfix) with ESMTP id EF6BBE0019B5 for ; Thu, 11 Nov 2021 10:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636624896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNcPNFwkNZzPAAuuM2VldGNI2vkzqJbh7gXLQwgsqaU=; b=bFTsg27RyE/7HLS40f8LKVx6Zzs0DWZEwrABN/4SocG0hj+xt06I42uf/8u8JRtOlCkmf9 HNoDCYt7XTse7LmKxUXEnyIPrH77f9/pxhIzFqWAK2JKmwOuliJ+59TtV7aqzxjn3DvRpY G8HjBzBfMiwtbvJoL7jjl8HhCC5/Deo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-GM3u9ZdKM7KU4f7zEljUpQ-1; Thu, 11 Nov 2021 05:01:35 -0500 X-MC-Unique: GM3u9ZdKM7KU4f7zEljUpQ-1 Received: by mail-wm1-f69.google.com with SMTP id j193-20020a1c23ca000000b003306ae8bfb7so2455030wmj.7 for ; Thu, 11 Nov 2021 02:01:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=CNcPNFwkNZzPAAuuM2VldGNI2vkzqJbh7gXLQwgsqaU=; b=FtxHSdSIdWEeKdPbt99i6CaybKwYFRolpX43oTVPLdUvZ8uKckmdipVg23iPEZG4xO 2Ogla7C5egwVy2CEUVnDpwkYCDfrizfFkS29fvPDFA4yd7aAHi5CZqPjToTAp9htGN+5 UdQGXgSyv6Sjd+B/O+fyKarAkwScxKt7BJhZ74IWqoUb9Kykwl29fyr3AsH4AOgP3skd vqKsuVdS0zvVZOx2GnpzwRC/0rsF60Aq4caNNnz6B2I397p1za5Ue+te83+vWl9J1haz YhEGWXzHY3AKz0FvBrCDPAfMRh5SYcXViHFnONMLlJGvy7X5Ipd9HdfdVRyykEAgbYAI 8Mpg== X-Gm-Message-State: AOAM530QE+PBYBSXAMC747KjrNaykG6g+x//su7bTZinzVZFpYhjS75B 2wF2oRfTx/uXnLxFCq3+IE7P6+ZmvbZEXXijBADjFfeZMloaWo3QRRSFa8qhEWzrc5pAy5oX6Ne jDG8dRL6Ccug= X-Received: by 2002:a1c:f601:: with SMTP id w1mr24132425wmc.112.1636624894403; Thu, 11 Nov 2021 02:01:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+YnB30s3H7o5szg4rvm692l/bAna1bgr0sO3KWz/TpfPh1f2WsLYXFlxrtbeUq96NmLkNQw== X-Received: by 2002:a1c:f601:: with SMTP id w1mr24132395wmc.112.1636624894177; Thu, 11 Nov 2021 02:01:34 -0800 (PST) Received: from [192.168.3.132] (p4ff23ee8.dip0.t-ipconnect.de. [79.242.62.232]) by smtp.gmail.com with ESMTPSA id a22sm2227713wme.19.2021.11.11.02.01.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 02:01:33 -0800 (PST) Message-ID: <794ecf14-a25e-8222-9f9c-7a77796fff6d@redhat.com> Date: Thu, 11 Nov 2021 11:01:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH 3/7] drivers/infiniband: use get_task_comm instead of open-coded string copy To: Yafang Shao , akpm@linux-foundation.org Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Dennis Dalessandro , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Alexei Starovoitov , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek References: <20211108083840.4627-1-laoar.shao@gmail.com> <20211108083840.4627-4-laoar.shao@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211108083840.4627-4-laoar.shao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EF6BBE0019B5 X-Stat-Signature: be71f7tz355gjwwwhgukyeiqjfgdmjns Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bFTsg27R; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf30.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1636624875-734267 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.11.21 09:38, Yafang Shao wrote: > Use get_task_comm() instead of open-coded strlcpy() to make the comm always > nul terminated. As the comment above the hard-coded 16, we can replace it > with TASK_COMM_LEN, then it will adopt to the comm size change. > > Signed-off-by: Yafang Shao > Acked-by: Dennis Dalessandro > Cc: Mathieu Desnoyers > Cc: Arnaldo Carvalho de Melo > Cc: Alexei Starovoitov > Cc: Andrii Nakryiko > Cc: Michal Miroslaw > Cc: Peter Zijlstra > Cc: Steven Rostedt > Cc: Matthew Wilcox > Cc: David Hildenbrand > Cc: Al Viro > Cc: Kees Cook > Cc: Petr Mladek > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb