From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DB5EC369AB for ; Fri, 18 Apr 2025 10:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A667B280159; Fri, 18 Apr 2025 06:13:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EECB6B007B; Fri, 18 Apr 2025 06:13:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 864F5280159; Fri, 18 Apr 2025 06:13:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 64E1E6B0032 for ; Fri, 18 Apr 2025 06:13:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 15D83B588D for ; Fri, 18 Apr 2025 10:13:03 +0000 (UTC) X-FDA: 83346751446.21.7B72C8C Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 3E39D100002 for ; Fri, 18 Apr 2025 10:13:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TRqCkjw0; spf=pass (imf14.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744971181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4/cLU9/OYuXAVmwO65dPpMtKI1TmuTdDoxDnsgNh+fE=; b=oFrAxBICkjBSGtz4rSumAphnnTqmeqzDR9V3FJXZKZvEbXsbbpRJT3ZJtUIVwa6TXbyUmM rrnAhE3CrfEjgCdZJ/R+b+5sIQw3MLM/gNQ5omdctEmcP8zyrkss432KMHrX9R/cpJUCKx XUBWMEZWYmocPkc1V9TJbPuMcpexjiY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=TRqCkjw0; spf=pass (imf14.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744971181; a=rsa-sha256; cv=none; b=XUiCIIfPILQW2n+419JxiLiN5vB1ox1z+gLreqEA6GZPs/XBiTkffxk1YSbJJJkGB2t+24 kZGcXNkVyWytFNzjZ6PGkqvy2UZo0qlLXCS4rddd0PXm5FgB7U44LQ+QGja6BF+uG91nlE QBuiuPaA/8JreppUuyCUMxs9o9OXNro= Content-Type: multipart/alternative; boundary="------------kOvTazskynk7WsOIyngpy1ci" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744971179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4/cLU9/OYuXAVmwO65dPpMtKI1TmuTdDoxDnsgNh+fE=; b=TRqCkjw0zbJA7WgI8qyGOsjqILqA02scAvb44Up6yGE38qoqu1KKrDbVoNgfc/dVHZ0HJi AXJd/65M3FnUdKmg5I/OQNoWrNVHiqHX2MlOAcZdfF/Qu3nH/nje8jXeSlOaG5LpbwoFlL ZgER6YMiP1e/sbjJEpjvLpnCwAN6hcE= Message-ID: <793e132e-6a6f-4b66-a0be-6a85bbb6a91f@linux.dev> Date: Fri, 18 Apr 2025 18:12:51 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/2] mm/rmap: rename page__anon_vma to page_anon_vma for consistency To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, nao.horiguchi@gmail.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Liam.Howlett@oracle.com, david@redhat.com, harry.yoo@oracle.com, riel@surriel.com, vbabka@suse.cz, liuye@kylinos.cn References: <20250418095600.721989-1-ye.liu@linux.dev> <20250418095600.721989-2-ye.liu@linux.dev> <7ec4f1f3-a059-4be3-a02c-81281daa18b5@lucifer.local> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <7ec4f1f3-a059-4be3-a02c-81281daa18b5@lucifer.local> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3E39D100002 X-Stat-Signature: 1qrur3i7do5yzdo7cfidm189iqwuadxg X-HE-Tag: 1744971181-229715 X-HE-Meta: U2FsdGVkX1/2xJLmBJOz0nlYr4TwnBdF4IUId04c8kb9XCu4tPc0M4akUWTDrzdHRc95hf3ZPfX4MZhXXrOsyxhHpq4lqKq85cLKkovDXDAAdgO8fEBVY5qOs6/wVv1lGeZkMc0D0zSWJnkTRGjpeoyb6T0CRkmQgKljPRAP0/xjLAvpNIdu2XuNQRe+5i8pAvr8eV5AedHBIeR9W6xO8/BRgZn/Ac1h+QKbm7vhNIZmBBhwQ2wyGvA0ref4GPnNw25WngQakfjl+Bzen5hZtFzCnIlwo56waUaiLojmWuoNaw5U4Iw2ero9Z1W5Gwr7jVFMQyjr2QQs5j/3B02EnJwUOZAU7W4FTo1YsZ+Nahfr14w6C75wc5GscAmjN6AaN0G10GbLkCJh4SC4mQ5MxAPAhseAKGfpp9o0+02V7nlL/GJYeq5bP+ZqF1EoE6tEUX2BOUBKFwYMSeDdbL3utBv0+ZyHWXOooU2ZwXwORCzd66bqMMFF6K4ha4l6RRXa8l+S8Jh0vZC0CKKRJF0ILH6FO0egQ8t3X2oo8S9Y68c21FnjLPPRrRwn8V74J8khkBgucKxmmllGRQLVmrVs2xeBwNPkIeGC6yPz4NMKdBbA45gkCYhwNvx0KZaW5gv8ejtC3oBQIm+eTuMQ1hmetATJATkvQ1vAguRJ9mrnHpHpymH2hgVUZIbgIOUeksxCNh2dz5jYqq5xCMEhG1+WQF0feUcu0gwhrS+7FA/WO4BcUMZA5fnRr7L3yLN/SPej0P7trUL7DAmlvCm6ZzX6mMH9TFFscDQYxIfo7ATbQBMeAqdEerIcVXkl1SFj+Z7AAM2TU+95rA9Q99z5PeQsfc4SJ5mLqNt/zdctk2WbkHCkwd2/2v1xQvNwF0uRP9ov9pRoVcFolDNpnG1fo53jXRJTk0G8sF2WtohE5whv4CbaNJlnDXOMq8s/9xFLPR/5A5moN0wAiJLBq3zM/AB 0SEti5Z3 nmur9B0xHZxNxl/xNaEdoRMQTW9ZRyYian6BbBBVgr0duArwOwK9DXkAR1cHrfLAeWw+Ho9b/CTwjF+gX4q8JFqmXk1zsypP5woHGGSAPVE0nKaT0srRTxTdCT5IzTFILrFZ29i6A/3VL3soeyQ6B/1LNqf322E+DAHa4XgBD/WyYr63xv2NiDdV6PgOWv97AMwBZy50UJr/AJVmsMhAC0okDH4AeaeptUL1aTO+5SoKACDwHv/88VKfdhjCrWHn9fZlRU5IAIb/QneFHDXDiiYtWlxfsplBwJtePNSNFSRUC0nMxjQHs1GG7uyapXCVZUQVcZb37i2OBAk20RRuP7NBEkccnMRK9m3wv1jaHSreGOG2dgXlXlcytjaS6ULB9bi1AqM2zSoY/6IiqZI1YcV2LnxTF5aZAtbBe6f9lmgTpw6Ug1S1HplvylltUmeP9+LY3jSGW3erzHbwKtxUFi2miNpLPkxSE7vD1cF9hl8DygBoyiFBFWAhtrl/JinKPOq0BG11h5lceAQQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a multi-part message in MIME format. --------------kOvTazskynk7WsOIyngpy1ci Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 在 2025/4/18 18:00, Lorenzo Stoakes 写道: > On Fri, Apr 18, 2025 at 05:55:59PM +0800, Ye Liu wrote: >> From: Ye Liu >> >> Renamed local variable page__anon_vma in page_address_in_vma() to >> page_anon_vma. The previous naming convention of using double underscores >> (__) is unnecessary and inconsistent with typical kernel style, which uses >> single underscores to denote local variables. Also updated comments to >> reflect the new variable name. >> >> Functionality unchanged. >> >> Signed-off-by: Ye Liu > For future reference, if you don't change the patch substantially, it's best > practice to propagate the tags you already received :) that way it should just > get taken! Got it, thanks for the tip! I’ll make sure to retain the ACKs and reviewers if the patch doesn’t change much next time. Appreciate the guidance :) Thanks, Ye > Anyway for avoidance of doubt: > > Reviewed-by: Lorenzo Stoakes > >> --- >> mm/rmap.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/mm/rmap.c b/mm/rmap.c >> index 67bb273dfb80..b509c226e50d 100644 >> --- a/mm/rmap.c >> +++ b/mm/rmap.c >> @@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct folio *folio, >> const struct page *page, const struct vm_area_struct *vma) >> { >> if (folio_test_anon(folio)) { >> - struct anon_vma *page__anon_vma = folio_anon_vma(folio); >> + struct anon_vma *page_anon_vma = folio_anon_vma(folio); >> /* >> * Note: swapoff's unuse_vma() is more efficient with this >> * check, and needs it to match anon_vma when KSM is active. >> */ >> - if (!vma->anon_vma || !page__anon_vma || >> - vma->anon_vma->root != page__anon_vma->root) >> + if (!vma->anon_vma || !page_anon_vma || >> + vma->anon_vma->root != page_anon_vma->root) >> return -EFAULT; >> } else if (!vma->vm_file) { >> return -EFAULT; >> @@ -803,7 +803,7 @@ unsigned long page_address_in_vma(const struct folio *folio, >> return -EFAULT; >> } >> >> - /* KSM folios don't reach here because of the !page__anon_vma check */ >> + /* KSM folios don't reach here because of the !page_anon_vma check */ >> return vma_address(vma, page_pgoff(folio, page), 1); >> } >> >> -- >> 2.25.1 >> --------------kOvTazskynk7WsOIyngpy1ci Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


=E5=9C=A8 2025/4/18 18:00, Lorenzo Sto= akes =E5=86=99=E9=81=93:
On Fri, Apr 18, 2025 at 05:5=
5:59PM +0800, Ye Liu wrote:

From: Ye Liu <liuye@kylinos.=
cn>

Renamed local variable page__anon_vma in page_address_in_vma() to
page_anon_vma. The previous naming convention of using double underscores=

(__) is unnecessary and inconsistent with typical kernel style, which use=
s
single underscores to denote local variables. Also updated comments to
reflect the new variable name.

Functionality unchanged.

Signed-off-by: Ye Liu <liuye@kylinos.cn>

For future reference, if you don't change the patch substantially, it's b=
est
practice to propagate the tags you already received :) that way it should=
 just
get taken!
Got it, thanks for the tip! I=E2=80=99ll make sure to retain the ACKs= and reviewers
if the patch doesn=E2=80=99t change much next time. Appreciate the gu= idance :)
Th= anks,
Ye= 
Anyway for avoidance of doubt:

Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>


---
 mm/rmap.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/mm/rmap.c b/mm/rmap.c
index 67bb273dfb80..b509c226e50d 100644
--- a/mm/rmap.c
+++ b/mm/rmap.c
@@ -789,13 +789,13 @@ unsigned long page_address_in_vma(const struct foli=
o *folio,
 		const struct page *page, const struct vm_area_struct *vma)
 {
 	if (folio_test_anon(folio)) {
-		struct anon_vma *page__anon_vma =3D folio_anon_vma(folio);
+		struct anon_vma *page_anon_vma =3D folio_anon_vma(folio);
 		/*
 		 * Note: swapoff's unuse_vma() is more efficient with this
 		 * check, and needs it to match anon_vma when KSM is active.
 		 */
-		if (!vma->anon_vma || !page__anon_vma ||
-		    vma->anon_vma->root !=3D page__anon_vma->root)
+		if (!vma->anon_vma || !page_anon_vma ||
+		    vma->anon_vma->root !=3D page_anon_vma->root)
 			return -EFAULT;
 	} else if (!vma->vm_file) {
 		return -EFAULT;
@@ -803,7 +803,7 @@ unsigned long page_address_in_vma(const struct folio =
*folio,
 		return -EFAULT;
 	}

-	/* KSM folios don't reach here because of the !page__anon_vma check */
+	/* KSM folios don't reach here because of the !page_anon_vma check */
 	return vma_address(vma, page_pgoff(folio, page), 1);
 }

--
2.25.1
--------------kOvTazskynk7WsOIyngpy1ci--