From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF853EB64DA for ; Fri, 14 Jul 2023 09:44:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13A6D6B0071; Fri, 14 Jul 2023 05:44:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C2DE6B0072; Fri, 14 Jul 2023 05:44:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA63E6B0074; Fri, 14 Jul 2023 05:44:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB0BD6B0071 for ; Fri, 14 Jul 2023 05:44:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AA790C01CC for ; Fri, 14 Jul 2023 09:44:20 +0000 (UTC) X-FDA: 81009731880.14.75A97B0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 70DF280016 for ; Fri, 14 Jul 2023 09:44:18 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689327859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2XPov6V6vaUcIrzKaeb7k3U6eOISRVUiwtF++xIHpsQ=; b=22XKEBas3kD+ST8/m4ZqB0K01aIpI9MyHFuo1mJgNsKhJ0xVLKz33vyH5EdSZa259gvJiA 8Eo+d+KcltsmXVmgFxVwv2Oz93EH6wL/pfSfd5D24Ja7P2TLySYeFHxvtdZoEpC4bOFccR KzNp2BqMARnkti9thOhvZO+YXi09Vxw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689327859; a=rsa-sha256; cv=none; b=Tkq7sAI7n5h3TB1/5Emsgbyz3G0LbXqeC49vDhc9FNAqaXQKIUT2/YdWL8ECyPmY/c182V dzHehQHpR+Zzu91X5Q7zo0wCHTIH1MkCZd2HeUMUbnONUkdf00VNp6YGiFSuSqFKxYvMlz rvbNRbqKY/1LgEg4N2yS71Up7lLlqtE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8FB7E1570; Fri, 14 Jul 2023 02:44:59 -0700 (PDT) Received: from [10.57.76.27] (unknown [10.57.76.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9CBF23F740; Fri, 14 Jul 2023 02:44:15 -0700 (PDT) Message-ID: <7935c31a-6c47-95c8-d6bd-176b81046699@arm.com> Date: Fri, 14 Jul 2023 10:44:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 2/9] selftests/mm: Give scripts execute permission To: SeongJae Park , David Hildenbrand Cc: Andrew Morton , Shuah Khan , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Mark Brown , John Hubbard , Florent Revest , "Liam R. Howlett" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20230713173237.66285-1-sj@kernel.org> From: Ryan Roberts In-Reply-To: <20230713173237.66285-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 70DF280016 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wuhn9kyzfiww78j7twb36yqux49ckbiu X-HE-Tag: 1689327858-530225 X-HE-Meta: U2FsdGVkX1/OUT2y3ojTrOwpQ+jQdnW4RZTk6XMZXOJpqXBPfXlxEMFoGEW0lr6//dRm3A94G1NdZwQLFdfWxfPmflEZmm/o+QULWtGhEn8KvsQDLY4lNiOdijkmbxCn7YFL/9pk9o2JTfBqYN3To4CnQPI8UX03de6SZ/osYkZNPN+cy9cXVt5jKRlL+5vMKSPcHOFFWkOT45FLk0jgWRvdm/v7kWrPProRKYfJotrtETVeACXU95SYHPikxnI9sVa2X370IlkBF7o2zOBiDpozMOEvxMlaNLcB6YPCedrdEBqnbqgatauy2SlnfIgQqphNjx8lbzY7Sy85iA8BV7r55V+y7H2siQfzgQaNOoUJ1aa11vFBLrKabIZLZNMPgZI0Jt75f4G/1PcIHknb1UFYiT/8si/SaxfOoUohkQLGP/NNWGxnERhGlMlH83mW6YXR19IcIpwL0HP1TUZA5RiaG39uZYt8OXXxIWNkYEdplgPxGHxAJ+reKaURvY/9gzeysnAoTUlm0D7Axg04hdjyrZAuGM0OPyyhGP2apH1tUjE4ExOZAy8DUJaLfPE4Lkq++wTnSpNS5nT1uTp872P27sjAugDx1DprfIvlYuqdNCnmgIj6zOLsoS7Me8dR8VWctjiRFbxDvblnE4bF56wgsI2m5/FJcHb8ippG4J9Jr2V8AZ/lT5vAuxe4CnWFkRo66FGv8vshIFjv+IL5mYdrMHn3QldMXawobTyofqjFr7v1zUecPwWYPQPzuJ1fN3fJuoVGm5YPMDA3e2Qvo1XLgBpRN8404JZWVLTemI4JU7rNjjrTHOACsoWdy5sFYYydAR7UXrxTr9DZP/kovQLtKlyZBpwjigCfiQODjpbhfVf3E+mikNBjNGZNlxfyNj1yoIwnQU+qT2BY0ySJDnnp1IobXuXTkb4/fLPsg+ctiq8rrQz0MSVTxB5lWtem/9rZ/OaFl1DUVLLD3MG VHwQJ0Nd VVS5G+p8wtilkXKragwkRyKMG0cNLsKicF7Cmfw2SM+8FFCh15bnIvHavEBfoswSoaSqGmIfFG7+/MpAvkQE8++kf/k+U2tgf44ewrMZjHR3SeZODVW3vc9IGAt5FWVw7xQ5HyxlN3BM1d6T3SS8X9cpsUAFA8zE2B085OwxSQC8LY4GodRrY02tZi5tKKMuZvhQxSD3fcc3YI5V7fRPm9H4JwWxw2T9V51x/V8SZ/dMUSL/qbhYsgaBpp8rK1V8nX4a62i7pAUi08M6xaRFDg6oYkjNKpyyrE1pRJVLRKIpzEAj+Nt5vhFoVK7PyhrrLHzDA2bESQMjAmQo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13/07/2023 18:32, SeongJae Park wrote: > On Thu, 13 Jul 2023 16:39:33 +0200 David Hildenbrand wrote: > >> On 13.07.23 15:54, Ryan Roberts wrote: >>> When run under run_vmtests.sh, test scripts were failing to run with >>> "permission denied" due to the scripts not being executable. >>> >>> It is also annoying not to be able to directly invoke run_vmtests.sh, >>> which is solved by giving also it the execute permission. >>> >>> Signed-off-by: Ryan Roberts >>> --- >>> tools/testing/selftests/mm/charge_reserved_hugetlb.sh | 0 >>> tools/testing/selftests/mm/check_config.sh | 0 >>> tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0 >>> tools/testing/selftests/mm/run_vmtests.sh | 0 >>> tools/testing/selftests/mm/test_hmm.sh | 0 >>> tools/testing/selftests/mm/test_vmalloc.sh | 0 >>> tools/testing/selftests/mm/va_high_addr_switch.sh | 0 >>> tools/testing/selftests/mm/write_hugetlb_memory.sh | 0 >>> 8 files changed, 0 insertions(+), 0 deletions(-) >>> mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh >>> mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh >>> >>> diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh >>> old mode 100644 >>> new mode 100755 >>> diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh >>> old mode 100644 >>> new mode 100755 >> >> Sounds reasonable to me. >> >> Probably due to: >> >> commit baa489fabd01596d5426d6e112b34ba5fb59ab82 >> Author: SeongJae Park >> Date: Tue Jan 3 18:07:53 2023 +0000 >> >> selftests/vm: rename selftests/vm to selftests/mm >> >> Rename selftets/vm to selftests/mm for being more consistent with the >> code, documentation, and tools directories, and won't be confused with >> virtual machines. >> >> >> and indeed, it contains >> >> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh >> old mode 100755 >> new mode 100644 >> similarity index 100% >> rename from tools/testing/selftests/vm/run_vmtests.sh >> rename to tools/testing/selftests/mm/run_vmtests.sh > > Thank you for tracking this and kindly Cc-ing me! I'd like to clarify a little > bit more, though. The permission change has made by the commit as you found. > Nevertheless, the submitted version[1] of the patch didn't change the > permission. I guess the change was made while managing it via some file > permission unsupported patches management tool. > > I had a similar issue with DAMON selftest and sent a patch restoring the > permission. Greg suggested me to update the framework instead, to support such > management tool[2], so I made it[3]. It recently also merged into 5.15.y for > DAMON selftests[4]. > > I have no strong opinion about whether we need to keep the permission or it's > good to have no execute permission since kselftest framework supports it. I > just wanted to clarify the events I've shown. Please correct me if I missed or > wrong something. Cc-ing Greg, since he might have an opinion. Thanks for the detailed explanation. Are you effectively saying this patch will turn into a no-op once its been munged through the various patch management tools? That's disappointing because it's a pain to have to invoke everything though bash explicitly. Many other scripts manage to have the correct execute permission set (see everything in ./scripts for example). Personally I'd rather keep this patch and try rather than proactively do a work around. > > [1] https://lore.kernel.org/all/20230103180754.129637-5-sj@kernel.org/ > [2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/ > [3] https://lore.kernel.org/all/20210810164534.25902-1-sj38.park@gmail.com/ > [4] https://lore.kernel.org/stable/2023042743-cheesy-parasitic-206d@gregkh/ > > > Thanks, > SJ > >> >> >> Reviewed-by: David Hildenbrand >> >> -- >> Cheers, >> >> David / dhildenb >> >> >>