From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFF7C47E49 for ; Wed, 23 Oct 2019 17:57:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D17F52086D for ; Wed, 23 Oct 2019 17:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D17F52086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 88FED6B0007; Wed, 23 Oct 2019 13:57:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 840E86B0008; Wed, 23 Oct 2019 13:57:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7565E6B000A; Wed, 23 Oct 2019 13:57:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 562976B0007 for ; Wed, 23 Oct 2019 13:57:56 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 0942D8249980 for ; Wed, 23 Oct 2019 17:57:56 +0000 (UTC) X-FDA: 76075807752.28.form52_4526d31348216 X-HE-Tag: form52_4526d31348216 X-Filterd-Recvd-Size: 2894 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 23 Oct 2019 17:57:54 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07417;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0Tg.GgAY_1571853465; Received: from US-143344MP.local(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0Tg.GgAY_1571853465) by smtp.aliyun-inc.com(127.0.0.1); Thu, 24 Oct 2019 01:57:48 +0800 Subject: Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap To: Matthew Wilcox Cc: hughd@google.com, aarcange@redhat.com, kirill.shutemov@linux.intel.com, gavin.dg@linux.alibaba.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <1571850304-82802-1-git-send-email-yang.shi@linux.alibaba.com> <20191023172420.GB2963@bombadil.infradead.org> From: Yang Shi Message-ID: <792ea136-4fa0-c87b-9399-5ca47c501c9c@linux.alibaba.com> Date: Wed, 23 Oct 2019 10:57:44 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20191023172420.GB2963@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/23/19 10:24 AM, Matthew Wilcox wrote: > On Thu, Oct 24, 2019 at 01:05:04AM +0800, Yang Shi wrote: >> + return map_count >= 0 && >> + map_count == atomic_read(&head[1].compound_mapcount); >> } > I didn't like Hugh's duplicate definition either. May I suggest: Thanks, Willy. It is fine to me. Will take it in v3. > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 2f2199a51941..3d0efd937d2b 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -695,11 +695,6 @@ static inline void *kvcalloc(size_t n, size_t size, gfp_t flags) > > extern void kvfree(const void *addr); > > -static inline atomic_t *compound_mapcount_ptr(struct page *page) > -{ > - return &page[1].compound_mapcount; > -} > - > static inline int compound_mapcount(struct page *page) > { > VM_BUG_ON_PAGE(!PageCompound(page), page); > diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h > index 2222fa795284..270aa8fd2800 100644 > --- a/include/linux/mm_types.h > +++ b/include/linux/mm_types.h > @@ -221,6 +221,11 @@ struct page { > #endif > } _struct_page_alignment; > > +static inline atomic_t *compound_mapcount_ptr(struct page *page) > +{ > + return &page[1].compound_mapcount; > +} > + > /* > * Used for sizing the vmemmap region on some architectures > */