From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8EBEB64DD for ; Fri, 23 Jun 2023 13:13:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6C9298D0003; Fri, 23 Jun 2023 09:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6796E8D0001; Fri, 23 Jun 2023 09:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51B6A8D0003; Fri, 23 Jun 2023 09:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4055C8D0001 for ; Fri, 23 Jun 2023 09:13:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0D729A015B for ; Fri, 23 Jun 2023 13:13:13 +0000 (UTC) X-FDA: 80934053466.29.3B0130A Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf19.hostedemail.com (Postfix) with ESMTP id 0DAA51A0051 for ; Fri, 23 Jun 2023 13:12:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=iReOyCzg; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687525973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=saQuMxlqr61JotE73oSpM0Mae8b4Qg6zNt4uVloyCYvmPIqYUo9IqB3GBono6VGmBWReVl 4CVP9iDZio1Y9gYNKVfjBBc8FLLtB5LB5qyeJ2i2XtMPw0/GoF0Ea0FtVMvosou5ZeYMdS NOFPTEKplvcBYNukDwSJa0K/6XjdV6I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=iReOyCzg; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf19.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687525973; a=rsa-sha256; cv=none; b=HpzMFe6O5DCeHsKbVmLlo1RWa9j96F+IFihuimipQAlrf98FzPTmBu0+x2X+r2qvfd6lob Xk36ytajVJqnoUmzz09XVi4xJf19oHUyPUu55q3Y87qAbFRURP+8NdXuAZxgDIx2w6ioDC a0jB5+pQAhm7qBmlQ9MqU5oFLGqqM8w= Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5344d45bfb0so101365a12.1 for ; Fri, 23 Jun 2023 06:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1687525972; x=1690117972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=iReOyCzgXqjGHDqep4+7Y02y+2KsxvqbysTBx4QdxMakwFT9O9Z6y8UTRhYCpdiwGk ivfBmaLpXRLdsg2xXtWNoGf0LJW9OuaoWVHjbG5+PmrhjKOTehTkz5xr7u03dJPl3Vvf epR4VYk9iCpPZkMT+p54jmiUndhguXzeWsKZiPn3OwVHy+V1VU+7xSZ1lgncoZQcneJS pVLxKUfpwqKrHzPfUfH95joX35kksCvYI/qVSfPkEqAU61Mo8RwQARiYkcVaAbzt+5qk cYcyAi42FXf01kq9CxVaIQAWB9c34fULDSPKve/N0V/DkCTafLxv3dWbsj8Ke3WxSlSL ozRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687525972; x=1690117972; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ztC9JD/gutKJP42tTw7xRzDnyP1Mlz22AqRtCxWHul4=; b=O28xFxOnBYs2NI3hm0a2K/UXdA5P96sFvpjllZjdO/y7GdPc78YjZ/9cRaWN5NUoSn LK0XEkN0vvEHt6ymD6NYI/y1/YEf/qf+dCK9KABmvIvia6xSi3uUFMOntDzh94L0DTBA 7LhQ+W9IOs6dPK+yFl6RFViW3E0ifP+ScaQU1Y4Ag7F7NWGa5m75L7UGcihE59N3IW9U DWiYR1CLyaHr4YCK7W9ByEisLzUtVC5PSixKh+RiP9WzgAS0PEW/ikzpL56PRC9fZCRC gOvYIFbRmUwfJlV1IZtRrmbCCobn47zIQ+eE2dOaOzuHMYBOVKMaQEQEwI/i+3JvaQlI QMUQ== X-Gm-Message-State: AC+VfDyeQMdTtLcdgVe1ng3EalGHeLgAco1uTRfKwKg+5yJZrItNlsmR RgrOi9vyNok0KJH/cLqC8jhYew== X-Google-Smtp-Source: ACHHUZ78dOQlFEQQrAnXInKb8JKnRB3NkeUnqCzTvDvkAqdG76W+IPYWNvfD8Ue2cdvcaNnPedDi+w== X-Received: by 2002:a17:902:dac6:b0:1ac:656f:a68d with SMTP id q6-20020a170902dac600b001ac656fa68dmr25602985plx.4.1687525971804; Fri, 23 Jun 2023 06:12:51 -0700 (PDT) Received: from [10.4.168.167] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id c15-20020a170903234f00b001b694130c05sm5473889plh.1.2023.06.23.06.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jun 2023 06:12:51 -0700 (PDT) Message-ID: <792beadd-7597-ec8c-e3b1-d8274d68d8c1@bytedance.com> Date: Fri, 23 Jun 2023 21:12:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 29/29] mm: shrinker: move shrinker-related code into a separate file Content-Language: en-US To: Vlastimil Babka , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230622085335.77010-1-zhengqi.arch@bytedance.com> <20230622085335.77010-30-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: hbkwz43y58f85bsyh8zht7uzdxorpn8a X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0DAA51A0051 X-HE-Tag: 1687525972-942864 X-HE-Meta: U2FsdGVkX1/8jPO402zM4rXQay2/UetFzHQrKzpC+SG8BtsKCqexm2PWIKvtGlbRoHn+vTuFCdu7HokXAevpS1+LFuV9yjHdel++EKB4dof5PabIlbjxZIuhwMgcnnU8FHz6ET8ujkdqCHG/KFxsgEjHvpCscysA//0Ha9VIcCHrmaSVVgsqUII8jq4muyXtyxFN1gKBXCujBYLqYDorLQ2gb7HFfhrYwvP8LnFIL51Ee97jXZPdH+Rdro7kmD1beskSBcI651FNMwJFMpeM1Nx5qCzd4mGXs6JhjlYZx0UK2jJ0XymYfEymJypqNYb7F54+sB7zC8VuvwMwP2wRRx2VMxmahvPDD6qs6eYIcs0mDCtiUAeIK5Gu17znIF9wSunbU61l3lEl0cX4OQcUPEIX8LSPDbSnGLRR7En7zewlI8QfiCjo3TBgaRYwaYfEqWkUY0C4Bwo3CPm6huBa365y+sD3hQYfY6JT5bKEc8GDWB9NglmfHN6GjriN1n9za8bS19XXpt3maI0T5Wm/VVo4dkplg1njPtsxrmRvoC5vlWAk7kVX6rPK1cKSnt0VNcEBR6uvfT5gc1omkbW1jRc+3ClPNlwcZ/4UY6GSuZfBtxroFk7rh/UUUGekVEb21f/VAwtU+PtFs12D9aLJTNBoY4+aMOD9I/pT/dSleVuM05qiwT+1C7ZNU9g/pZcnevmVQWnsjUWbimKCDG4DXfgP7+FgvktPKKGPyzitPaXri/bgfspveZwKyojHl5YvK4XSFHH3HaJRzuiu+JfyJzkXOnR4fvbFIXDsZfzG/RTDFZx4YnrxkwIjDsZqgKkFeheEB7ob0eHLZMT6vLDOEPAIrvq//WS8+4jYmg4xgR0NIjGAXC4luETJSwgY9EG6RYQ4tGxpg7ZhwkNLJlP783SMojFPq6ILJvqhWCdgt0hXeyK0atdTvKgxW0PJUNio4TGC+J4EfMYk2lLtsFD Qb3ECNqy 3jXRumjw/8bxF9C8m2TodAhXlHoLAbuGoemdUkRdwU/FWGTkaCkuPMqlEfPc/b1a8NwsWRhjNLLE+2SRjRxiqUWviS+aUg0+WeTMqiYiPcvfrEFXDmKtXyNocNrEOJ5D3E5vIpXG0XHROgnmNDpXln2eOWK1NVORQ5olJbAQCJg8mruNDhCO7XzpkMlV6ZfQZBknFmkwXo5YsK7TSujWZG6o2fI2705Kevi2gAmQ5wAA94k8jC1l0ZBvfWk/Y16rbvWksCoPGZD4ko2eY1/pua04XMri7EOqXDn7Vm7Oc/e+obQbuj0xXTNAIMhMs0eq31vE9GaMVmqoCyLVpCziw5kZbS1RotyCltAoYS2fYOiVmXKEGb9T7dTcWw3jJ+74DSWhvgy+4Dpz8YvKFHFOc/SDnd5kb+QqLdk4LaYDegMIHGH4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Vlastimil, On 2023/6/22 22:53, Vlastimil Babka wrote: > On 6/22/23 10:53, Qi Zheng wrote: >> The mm/vmscan.c file is too large, so separate the shrinker-related >> code from it into a separate file. No functional changes. >> >> Signed-off-by: Qi Zheng > > Maybe do this move as patch 01 so the further changes are done in the new > file already? Sure, I will do it in the v2. Thanks, Qi >