From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235EFC4332F for ; Wed, 23 Nov 2022 01:04:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF8C56B0072; Tue, 22 Nov 2022 20:04:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A801D8E0001; Tue, 22 Nov 2022 20:04:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F9DB6B0074; Tue, 22 Nov 2022 20:04:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7BDE56B0072 for ; Tue, 22 Nov 2022 20:04:31 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4C77012029E for ; Wed, 23 Nov 2022 01:04:31 +0000 (UTC) X-FDA: 80162911542.06.58D610C Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf03.hostedemail.com (Postfix) with ESMTP id A91D12000D for ; Wed, 23 Nov 2022 01:04:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669165470; x=1700701470; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=xIkQj2jeU/8NPzjK+TPyInzQOmljcCdXkpyBV4P2W8Y=; b=Xd5IOXCvyyYZHJtKy9S9rse+R80gUSz965uwkS3SP1AVsUBkt08/luu4 rwKk58kwbM1JP6InF1uJPVgN0Pd223YzQK3L/EBuEJezSG5yqhMnhR3Uq JX6iI7Ltg5RUN3PlSbsInsEyAiwblhztBDuM3igX8Y7d0CGkXGefq8b0q JDONKugV0zDlErZ1lAM8xE5UewTp0uC9nWj34mcbrswQ9IJkcWGNYdNZ1 Qs5lz3vlP314SXraZ0I7j7QJOZbeMdj1O3oPO6t0gyW/1F0TlzKM468Lv ea8IV3l3Nxa05SYHzBfaEAeqqLgkM3TeEGYr3u2yhKPM+VmtKeOktN943 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="315773033" X-IronPort-AV: E=Sophos;i="5.96,185,1665471600"; d="scan'208";a="315773033" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 17:04:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="643923109" X-IronPort-AV: E=Sophos;i="5.96,185,1665471600"; d="scan'208";a="643923109" Received: from coltsavx-mobl1.amr.corp.intel.com (HELO [10.255.0.114]) ([10.255.0.114]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 17:04:26 -0800 Message-ID: <791bf9a2-a079-3cd6-90a3-42dbb332a38c@intel.com> Date: Tue, 22 Nov 2022 17:04:25 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 06/20] x86/virt/tdx: Shut down TDX module in case of error Content-Language: en-US To: "Huang, Kai" , "peterz@infradead.org" Cc: "kvm@vger.kernel.org" , "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "kirill.shutemov@linux.intel.com" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <48505089b645019a734d85c2c29f3c8ae2dbd6bd.1668988357.git.kai.huang@intel.com> <52b2be9b-defd-63ce-4cb2-96cd624a95a6@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669165470; a=rsa-sha256; cv=none; b=lyYoAmuIc6ahFsjKJ1jSsKWSgmowUbtVP5WaM5p93m8mT1ek2l+NiGFU4L8Vk6WaqgHB7I VKM6Au7SclXCsGML/vAB84j7Vhbrc2QeSJkQaAT1UmKCEE2Bp+GZLhZY43Ede479uuCi1r i7DVRyRfXynnyu/Hy8MGD+APTESU2yY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Xd5IOXCv; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669165470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yk4h78kdMvK7uasYo9DtVy660ZKOV/i2uvyNaRLNlak=; b=cTk6vDEDVO8pxMKE7gX9wqiCI272KylngtCG7F4eO6JhhSdQ4sKxveENVeClSRIF0/8NMz 3RPEmBLVqVOtkMFWCsuc6P2KaWg64y86xRDsF5SGIsWluu2qLkPgDVColx599R/kBwkIBx lBDHgOfjwbgfDZAVD9sX6XsC9cKF7X8= Authentication-Results: imf03.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=Xd5IOXCv; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf03.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com X-Stat-Signature: b3cjjhkmptyz3ug4rcodzw6pz99fbix7 X-Rspamd-Queue-Id: A91D12000D X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1669165470-534411 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/22/22 16:58, Huang, Kai wrote: > On Tue, 2022-11-22 at 11:24 -0800, Dave Hansen wrote: >>> I was expecting TDX to not get initialized until the first TDX using KVM >>> instance is created. Am I wrong? >> I went looking for it in this series to prove you wrong. I failed. 😄 >> >> tdx_enable() is buried in here somewhere: >> >>> https://lore.kernel.org/lkml/CAAhR5DFrwP+5K8MOxz5YK7jYShhaK4A+2h1Pi31U_9+Z+cz-0A@mail.gmail.com/T/ >> I don't have the patience to dig it out today, so I guess we'll have Kai >> tell us. > It will be done when KVM module is loaded, but not when the first TDX guest is > created. Why is it done that way? Can it be changed to delay TDX initialization until the first TDX guest needs to run?