From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205E0CDB465 for ; Thu, 19 Oct 2023 19:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88D63800AE; Thu, 19 Oct 2023 15:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 816508D001A; Thu, 19 Oct 2023 15:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68FC2800AE; Thu, 19 Oct 2023 15:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 561AF8D001A for ; Thu, 19 Oct 2023 15:23:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 27DFAA0661 for ; Thu, 19 Oct 2023 19:23:58 +0000 (UTC) X-FDA: 81363186156.24.10DDED0 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 4E1EFC002A for ; Thu, 19 Oct 2023 19:23:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="q4/p2dse"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697743436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5uuyl1yr0QlhVwcr/kFqbwwoVuwQhjrCV37xzZewFRc=; b=P8FVY9+0nx53pxrU/Hc0v7SJweGvIYY+Ybn1XN86VjJe71E4QNC+1rh1Kmzu6O1EL5gthr VRiUIlZj8wBZe6NRsE22gf9FMmhboPkBR98tFQfG0SeMsWsNI+xqC+aaWBszR5ylzssXF1 SQh5sGiwTHCuEKtvNU6FRz4DR/rzK+k= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="q4/p2dse"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of hughd@google.com designates 209.85.128.172 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697743436; a=rsa-sha256; cv=none; b=7XpjLC8jf8TIwExPQ7HEcULnfGAlKEaZ1TAVYS8lHkse7YTqNWdsQxCGmk0ViqmJoLKEr4 mCFXvQZXIK1WHd8l2MwzUoLLcyX9I1lEXvBcWjgQB17uiakONLYuliNqolTPuIzNllw2j6 MLs0OIXTEyBCrMR9Vldxx2Z2WbRSqJw= Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5a87ac9d245so60162117b3.3 for ; Thu, 19 Oct 2023 12:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697743435; x=1698348235; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=5uuyl1yr0QlhVwcr/kFqbwwoVuwQhjrCV37xzZewFRc=; b=q4/p2dseM5e09JIxXxa1bWkpUJ9IxWzW1kPn4OLzbscqXoOCE5IBcUlFbEsVn4tVDH Obi4ewh7plm55e+cl6Atw96iV1aBU5AgSgCJqlrlDUSJAsHwZNBP3Su66ue16M9JUkB1 Sx0xJiLLRxAgAa9pqTmNTz4ffKGbTGfOr6jMgzH1xBEV2/gGIi3PUwyas12APR2O2FK/ r5z2YMrLwDAvkrIM9gjb4njZRKuiRPnxg1ccnkduINChk1O0UMlpE18lYspp2Z7izjp/ SaBSqDx1v02L8EOcIClIk8kac4+txYQRpb3JjnTHJe/578YUaE2vB8j/QU/nLyd8dc0t YOuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697743435; x=1698348235; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5uuyl1yr0QlhVwcr/kFqbwwoVuwQhjrCV37xzZewFRc=; b=kh5MlTMF5WoHC2788yP+aAYD+loRxfKX9qvsBmuolP3TFyVgFvgYZ8LlGst30uXs2g qe5bZNdleU46bsbb0Pc1kIOVvGvF68wPHWYBBy6UXuQHIn+DgN1k0h6YNZvuBDOoyfax APrBnhDxMwANZtQMZ+/iEuPsZnmtqj3BB8VDJqGbZ9G9E/fLTHEYf0bWyrcTpSP1zrJ5 2M5ucUbF6Qv1JiFDAlG7hm8bRfOwN0+5vey1vSlgVqeF4AdHl91QcG0j+au0OBJLvYZs 6DqPNPmm2erkoPTyWJqlSj34ZjwISlz8SEyFYJks4KF6PIjrrnuz2Gpj8oEX7S4rjcKq S/dg== X-Gm-Message-State: AOJu0YyhC5uh+we6yqsIlB5he+D8p9oFIrEladiuAuo6RuEJZ1VnVkq6 esl9mfqXb+6fVFK+v1E5wsd2iA== X-Google-Smtp-Source: AGHT+IF5RSaxdFZ8Qw7h9TmLML1tBIzoDCSUVaslk5eNl4uxiHalrl0qJkYPCIrJgQLx5qXnJXrtUw== X-Received: by 2002:a5b:291:0:b0:d9a:c5ac:9a60 with SMTP id x17-20020a5b0291000000b00d9ac5ac9a60mr3055680ybl.1.1697743435190; Thu, 19 Oct 2023 12:23:55 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id v9-20020a258489000000b00bcd91bb300esm20035ybk.54.2023.10.19.12.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 12:23:54 -0700 (PDT) Date: Thu, 19 Oct 2023 12:23:44 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Andrew Morton cc: Nhat Pham , Yosry Ahmed , hannes@cmpxchg.org, cerasuolodomenico@gmail.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Hugh Dickins Subject: Re: [PATCH v3 0/5] workload-specific and memory pressure-driven zswap writeback In-Reply-To: <20231019113627.bca226b1ac17fe9c3beecb21@linux-foundation.org> Message-ID: <78f9b0da-d69b-d709-946e-f10fec180233@google.com> References: <20231017232152.2605440-1-nphamcs@gmail.com> <20231019101204.179a9a1d2c7a05b604dad182@linux-foundation.org> <20231019113627.bca226b1ac17fe9c3beecb21@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4E1EFC002A X-Stat-Signature: 11wjwujbgs1xxj9njcykiahw9wbqyk81 X-HE-Tag: 1697743436-103613 X-HE-Meta: U2FsdGVkX18Mltzha8cJsyCQRg62U5lFKz9aq5Pt7RDCBkjtE5y4TM2FMK/OPFr1IOuUIIRGMiyI+UtQ02xprFRPwO7zujYs0rLvb8QVaKRatYgUMopiR3Idd1Nm4tMBNJ94iyq5qiqA5l9qQoIbdvVvccO5YWOadHFRRh5oxcsYjiahv5b3qFGUdQD/ySe1ilrBKiizmkLJmEEEQ3tlv/ouKwCUe9mri6FTjKj1erT4krtpxNFEXWskOi/8lKaC3q2Jdd0Iy2Lktm1qMtt8StDjLhx2tzd2b48NKslCi51AF4tHlKcm1GAa9Sm+pikECdpBudWpeF4nABmulC0vbpe2KuQyHgKeIrovUFYdUM2Q5tLwyzlejhZQ/wLz7G2o3MMSztgTXvAzkEfdgrzlCAlaMgBAfc6pMdO4Dxir/z0EFTaQCtumqtjRB2Ehzqqt5ClZlE3h+GtzdSlcqXUl1NUVPpB9paMMjQc7/17wWpFD8I+x1hxXoBdybHmBz469tJjcJmPQvHbbKZZmS8xA6W1meDKSPbU/pN+0Fzn1NNxNKSIgVOiiWasrTuBFfAvncZ0h2cSfnJJzRp4Hhg/O3xIy1urMe9YRm15nbyFqcC3ItwJojrFu02PssbJMW+dMHyw7RLG3x2K6+ZynIYonTQlHN4+gsBImkAP1AOIxj/fqyHWv5x7w+cJA6LF2LSO9VK079tcGg/c6aBOJgPv+Ud/j86rHVWQEcNCH44nmzG08NqpyvdTpFB8NpI90lCLn3oSJGZlW0lyFVWkIZi/FBNYH1/ELmZWxVHv8XK9EJYCVVa+rSYni9+F4sEWBHKwuRkVjlE0CRcGq7EzhuSH4Yl0n9GSX5e1MrrIhZzu5BkbFVrJ8WgWnC8XfJB+xIzg6bHgOj7Naj5JVawYmWJrJYDFcr0Ph91lUowrUZhO51b7uFB5OunvzVFMelQsMSQ0fPN1PXl693UOGpLsA5iu kHdLxG+F UMa0ixshtyJV5PIgLRN3uEtaaSZ38gkjiTpxqxAkt87H41VUfzQrYGDHTB/t8aLQwRDLxGL/InJ7vs5pmekbvTo6wAg03ins2HvAeQwYw76fg1gE0GzXrND0QePivL2AvSKZkORvufICuOv8j6pQXEsdvtu8cjFowqm3Wp5WSLrrUQ9vzjGzR3vGu/aOInyQbO6dxr6EP0OlSnsnpm7J8w+bEJmc+jYEmKIZYMMykCk4P12UroqTKUfZHTYKRz6sPlWChE2hmLC6CL5wiooJzGmSNfie6O1PMNMu2f6tFZDYR8i4uAmWl2CX+wjOcy1O98X4LnnWl1E4zVZekiRqBIXKUwVOmIZoDuC0dOHlJK9TBrGsTNsjEQ16VHjdBLNSwXTMcNKh3ReSnTJ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 19 Oct 2023, Andrew Morton wrote: > On Thu, 19 Oct 2023 11:31:17 -0700 Nhat Pham wrote: > > > > There are parts of the code that I would feel more comfortable if > > > someone took a look at (which I mentioned in individual patches). So > > > unless this happens in the next few days I wouldn't say so. > > > > > > > I'm not super familiar with the other series. How big is the dependency? > > Looks like it's just a small part in the swapcache code right? > > > > If this is the case, I feel like the best course of action is to rebase > > the mempolicy patch series on top of mm-unstable, and resolve > > this merge conflict. > > OK, thanks. > > Hugh, do you have time to look at rebasing on the mm-stable which I > pushed out 15 minutes ago? Okay, I'm on it - but (unless you insist otherwise) it's only a v3 of the 10/12 "mempolicy: alloc_pages_mpol() for NUMA policy without vma" that I'm expecting to send you - the rest should just cherry-pick in cleanly. I'll check that of course, but I'm afraid of losing details (e.g. any Acks you've meanwhile added) if I resend the lot. Hugh > > > I will then send out v4 of the zswap shrinker, > > rebased on top of the mempolicy patch series. > > > > If this is not the case, one thing we can do is: > > > > a) Fix bugs (there's one kernel test robot it seems) > > b) Fix user-visible details (writeback counter for e.g) > > > > and just merge the series for now. FWIW, this is an optional > > feature and disabled by default. So performance optimization > > and aesthetics change (list_lru_add() renaming etc.) can wait. > > > > We can push out v4 by the end of today and early tomorrow > > if all goes well. Then everyone can review and comment on it.