From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC41C369D3 for ; Fri, 25 Apr 2025 19:49:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44FC96B0007; Fri, 25 Apr 2025 15:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FCF06B0008; Fri, 25 Apr 2025 15:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 275906B000C; Fri, 25 Apr 2025 15:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D44C6B0007 for ; Fri, 25 Apr 2025 15:48:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E2B1812086A for ; Fri, 25 Apr 2025 19:48:58 +0000 (UTC) X-FDA: 83373604356.05.1982FE0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 2A463A0008 for ; Fri, 25 Apr 2025 19:48:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O+t1bQU4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745610536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iyio0+rdGGHZ3rJEpArzIbX1q77xWWWNHXXnWo3MTWI=; b=SwImCruWH6AKR0EX5q9fFNNZ8pO2bCeVYqjxXxtsekDRGN3pOyLsFGo5xAIoIJq2tRMck9 59QMAOJuMlw8V/udrxhqOHrh/RMEGwrIljjaNtK80zcw5U+hKKTEVtxhsobJbFrp+Aep4u ZYxXssyM46EOWUxdMIZSsn1p7/Z5uYg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745610536; a=rsa-sha256; cv=none; b=AiXUKegs+PwmgU3IwXaDPzvt14ALN3uFPEe+iR0jw/lPSRBpYAktIy0XvJ3q0EdISSjYpZ gDvNHCyp+xU8dalr6+YhLcHrAVwEkymhV+lpKMrIaHvSi1VguhY79PHXDAEve//dLsALar MwyReRNXqGsEgs1y8OCASjcl+CQUVMg= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O+t1bQU4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745610535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Iyio0+rdGGHZ3rJEpArzIbX1q77xWWWNHXXnWo3MTWI=; b=O+t1bQU41M+2cIK0CrRj1GH+/nN8ZWeWkjCX7E9U9RKtm9WyRVhGIz06TLtkbBiFKkMA67 /Bwd9mk2ovTPx16+Uj2oUU2H7rtUPNhuehfRTi+jVINHC3t1G+taZhnAjMcE2tv0LToRMs OImxAX0pLQd6uEiC81mKlse7AghMK0Y= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-A2L1Y_wuOFG4O44fw6xl0g-1; Fri, 25 Apr 2025 15:48:54 -0400 X-MC-Unique: A2L1Y_wuOFG4O44fw6xl0g-1 X-Mimecast-MFC-AGG-ID: A2L1Y_wuOFG4O44fw6xl0g_1745610533 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43e9b0fd00cso12794055e9.0 for ; Fri, 25 Apr 2025 12:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745610533; x=1746215333; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Iyio0+rdGGHZ3rJEpArzIbX1q77xWWWNHXXnWo3MTWI=; b=G3b9FTLNqOAprP3+tdm3VV4p5fU82WC5nwk6vmeMZI65tTIx9R3JH+A5VtQ6GNrVhs m+lxPCiaCWr1h95yCXXyjSFmW9W3cS9dGN5l43jiQ2Rngzkde28o6Jra+m5K5Y6Bv1TE Sj9a4+auL9PgP9Ar14rr7nHRIdKOYKRCphkO6XZvIB3d+aJbjHLY5N/BR8IbJdkoD3b4 nDvDV8QWM2ZDShAd8c5obJbr296Yh3X5Ru8Zhy8dju3K42hOMhzuJ1NUK+9Fx8FT6127 8sTA9ptJPJE3a9if6C/+crsZRSK0qlipN/XjFj6PAZp4Oz0Qd+AEdACQUjAGgnR9kScG zpKA== X-Forwarded-Encrypted: i=1; AJvYcCVPWT3Z6STGvcj9iAevixj4C3Y0XghTe2yOhgV7PjjIzvrz1fU9ENPw+ZggZl7r+QlLIgkcUkVSLw==@kvack.org X-Gm-Message-State: AOJu0YwcFmjyXZh3w8BjGOZx+A9/fhFGAVSOhqKNo3nRcqkdCTFQwhGl SIv8dABo81e2IJ5XCnUHpHD6r2phkY9fq8qzkSLVYPUD62S73rR2jfEopbMGQb7wz0lqRSPrbgF bMSd3efyFdITpStF0QM7y19s56/C1xA3+CPjDfEBD70v53pWoTzUPgzOg2zE= X-Gm-Gg: ASbGncsbuv5Mk3e9y48BI8OaeuamDKUfTnT1QK9B7C1jCFcc3eoZ3UhR7/o83G2exym 0Ma2RS5AlUAFygarki9jrzCQzEwRO9BPd6tgpNH9bp3670k6+Hxoq1iJU9Wec1uPQfLTGMZ0aMT H1Dj/gH+C35cWPqueZL9SjdVFo1MSwzhk6zQS4chAJ5DjPjGnBxd/wNSZM+OnOIcvq1NajILYpB TRrjVpRtQp13erVzeJpKDjkoZ5JdEMyaboWkvoZlFRgpw4thdGbQKD3k5TuQdfbqenQ7GJg/fZ1 4s2b71om6hP+7+76UjPtO5j20FSD/tXrhqJNfX1ejg== X-Received: by 2002:a05:600c:45d0:b0:43d:5264:3cf0 with SMTP id 5b1f17b1804b1-4409c4de02dmr67828815e9.11.1745610533017; Fri, 25 Apr 2025 12:48:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCFfrtzSc+UtPRGo0BIvDxCf3n2hnwRdIbAoPATpGWLsnc5w/p+CDOEbj1RMEvVgHKgNRMBw== X-Received: by 2002:a05:600c:45d0:b0:43d:5264:3cf0 with SMTP id 5b1f17b1804b1-4409c4de02dmr67828555e9.11.1745610532645; Fri, 25 Apr 2025 12:48:52 -0700 (PDT) Received: from [192.168.3.141] (p4ff23df8.dip0.t-ipconnect.de. [79.242.61.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5310ad2sm34335985e9.21.2025.04.25.12.48.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 12:48:52 -0700 (PDT) Message-ID: <78f88303-6b00-42cf-8977-bf7541fa45a9@redhat.com> Date: Fri, 25 Apr 2025 21:48:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] mm: convert track_pfn_insert() to pfnmap_sanitize_pgprot() To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: htWHZa9BGNOYOOwiRKIUkk-yL2WKAcZV-V6Nn9MQZc0_1745610533 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2A463A0008 X-Rspam-User: X-Stat-Signature: bfr8pjon8itfemct8mzndh8owgg5okkr X-HE-Tag: 1745610535-800268 X-HE-Meta: U2FsdGVkX18pa1jML5/W330RBdl4Cb+fq53YmDL5vVKvMwelN2qQE420UWtHFz67EbuJZrl/s1SSgbd5dh15P80egOfAehyK5/Dh9fSEj7dNfyLiuWvj/DfLw4g+PxpP1aPsPjlvrcmSlyHYeY9uD9dWDhlYCZJJruaJpGVX6iCSH6OEFR+Fv8UCx8ENjddNDSmUbzqBIF6caqSM5BkjS2J0uX4NkL5fjy734obRO48nn2+77OaoM8cVhMkQys9B/o9sVcjnCelPdZTecFl7nSD3N+61Ffvrnswyh9JybjxO6nBABAvDWvp0Pp7L0jX+v9AC+1ID/5ObzFy3i6KkEC6z3WSijbazrr2YCZkMG37Q4GZ1K8MzwFSpT0Bx/RzzfIKWFHWE4n0zM3gDor4fIV5Kfx2H35GYb2BPl0L+BrHyoCGeI73bBK/IQane8mGbU6XQBGv6CEg3E9pJxHm2rvsGiHOwMlDv2lUJh+JNQDbXAAe/b00suiyfIQ8puqhmfnNlfc/Ac92h3rij3RexviequAdl7AsKXpHTXNmBjC/KEeOKrqvnp97xNRzUAL34ENfPjSSr8vjDtRAYbiqlRYRUHs/JVDelZJcBiTBRN/sRCe4+WBMLRkEJ1X9YP/XfyNsc4zgZSOeBRrQP7slYkkwMhPPcm+X+H/mvbk+te2JwHwmBTsNYGsyuMzIU8LxVQjFZKYRICZ1RwL2dy28HJ3sZtFK7gCNIsiw4r20L9dAyBIbHU3NeNu5XaoXEceBfPQ6X6ICMOU0OkbzRKRNHcA62rmUEP/PYRoaLgonPeb2ZnedEcmgkfcckAD4IixeLcNFgCg4Uw6qC6xwPt6jRjLLZ1zsGZMjjovEWymAf2UVlWdbPdIty4BT8OnPzTGigJLH53hqaHnhHR46WMZhqgGIhychsfHuuOlGmbNlruSF+W4W/8ZzoRAoRfeXVYS4mbgM+KNTWPZpkjEFDKdt 0ogiF2mY 3FvAFIbdWooNVWp4Tq/FL4a9kmaPs7TdSBhJ5LDgnyWrUMH3eHFYsTjoHUm0PTsYMGeCheKg7OEcaVyeny+dqqp6WKK9+pY1yeh5h5ZSRRvDPBM7DWcb+h56TdtuBy6+rgjU1DYQwbLCXiSrmWpgoIBUD93a3s6RVsMoRHNmwYtGmxQTk9H1Albb4CIYng5OYI9P3hIMnTKNtG4MubN5/gJF/ONz4NWbZrggiY/eK0R/MRgorDAbZzrtpZukeDCOGPGdtXmDTSNzudSDAncLLCLXPXMfU3iPQrZtoUYDGO31dWwny1XDJebci+uSjPguc2O0JEPi0lrNxLv5yvWL+aym0bx8FICTxfADQFPskLF1ZsT0XPFjgo5pBk102ED3hb/3ImLUoJ0JhvldfRoZcVt1xoqHgpXCOy7Q02LqXCeR+HjGL3RoAceMQr9vtIukfyWvugBRWQOByobmWZsiMoql/XA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.25 21:31, Peter Xu wrote: > On Fri, Apr 25, 2025 at 10:17:06AM +0200, David Hildenbrand wrote: >> ... by factoring it out from track_pfn_remap(). >> >> For PMDs/PUDs, actually check the full range, and trigger a fallback >> if we run into this "different memory types / cachemodes" scenario. > > The current patch looks like to still pass PAGE_SIZE into the new helper at > all track_pfn_insert() call sites, so it seems this comment does not 100% > match with the code? Or I may have misread somewhere. No, you're right, while reshuffling the patches I forgot to add the actual PMD/PUD size. > > Maybe it's still easier to keep the single-pfn lookup to never fail.. more > below. > [...] >> /* >> @@ -1556,8 +1553,23 @@ static inline void untrack_pfn_clear(struct vm_area_struct *vma) >> extern int track_pfn_remap(struct vm_area_struct *vma, pgprot_t *prot, >> unsigned long pfn, unsigned long addr, >> unsigned long size); >> -extern void track_pfn_insert(struct vm_area_struct *vma, pgprot_t *prot, >> - pfn_t pfn); >> + >> +/** >> + * pfnmap_sanitize_pgprot - sanitize the pgprot for a pfn range > > Nit: s/sanitize/update|setup|.../? > > But maybe you have good reason to use sanitize. No strong opinions. What it does on PAT (only implementation so far ...) is looking up the memory type to select the caching mode that can be use. "sanitize" was IMHO a good fit, because we must make sure that we don't use the wrong caching mode. update/setup/... don't make that quite clear. Any other suggestions? > >> + * @pfn: the start of the pfn range >> + * @size: the size of the pfn range >> + * @prot: the pgprot to sanitize >> + * >> + * Sanitize the given pgprot for a pfn range, for example, adjusting the >> + * cachemode. >> + * >> + * This function cannot fail for a single page, but can fail for multiple >> + * pages. >> + * >> + * Returns 0 on success and -EINVAL on error. >> + */ >> +int pfnmap_sanitize_pgprot(unsigned long pfn, unsigned long size, >> + pgprot_t *prot); >> extern int track_pfn_copy(struct vm_area_struct *dst_vma, >> struct vm_area_struct *src_vma, unsigned long *pfn); >> extern void untrack_pfn_copy(struct vm_area_struct *dst_vma, >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index fdcf0a6049b9f..b8ae5e1493315 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1455,7 +1455,9 @@ vm_fault_t vmf_insert_pfn_pmd(struct vm_fault *vmf, pfn_t pfn, bool write) >> return VM_FAULT_OOM; >> } >> >> - track_pfn_insert(vma, &pgprot, pfn); >> + if (pfnmap_sanitize_pgprot(pfn_t_to_pfn(pfn), PAGE_SIZE, &pgprot)) >> + return VM_FAULT_FALLBACK; > > Would "pgtable" leak if it fails? If it's PAGE_SIZE, IIUC it won't ever > trigger, though. > > Maybe we could have a "void pfnmap_sanitize_pgprot_pfn(&pgprot, pfn)" to > replace track_pfn_insert() and never fail? Dropping vma ref is definitely > a win already in all cases. It could be a simple wrapper around pfnmap_sanitize_pgprot(), yes. That's certainly helpful for the single-page case. Regarding never failing here: we should check the whole range. We have to make sure that none of the pages has a memory type / caching mode that is incompatible with what we setup. Thanks a bunch for the review! -- Cheers, David / dhildenb