From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9644C388F9 for ; Wed, 11 Nov 2020 12:10:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE920206C0 for ; Wed, 11 Nov 2020 12:10:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ePDDo/IV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE920206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 326426B0070; Wed, 11 Nov 2020 07:10:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AF736B0071; Wed, 11 Nov 2020 07:10:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129D76B0072; Wed, 11 Nov 2020 07:10:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id D18FA6B0070 for ; Wed, 11 Nov 2020 07:10:26 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 726F88249980 for ; Wed, 11 Nov 2020 12:10:26 +0000 (UTC) X-FDA: 77472020052.30.clam24_55067e9272fd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 402DC180B3C94 for ; Wed, 11 Nov 2020 12:10:26 +0000 (UTC) X-HE-Tag: clam24_55067e9272fd X-Filterd-Recvd-Size: 4703 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Nov 2020 12:10:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605096624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y65as4hO2k5CaDRlNinPuyS+/mcMvfkWE/AmgknX/f0=; b=ePDDo/IVplNCu6+gd4seMQu+2rPdX3cHBMzVu9QTYHqQUVrcaSwN0PV8h4gpmlB5DFEOMu Jiftqd9w5r5Qg7H77fmS/aW0HwdlwSwsjXOGqvnZbpw5/eUUnaaN+GcPiQb+BrG/Zo7w99 oweXDrQhLj8Czf24r0OUuRqQyfetEjc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-KIVkhXwCPsa4RlcUPDHLEA-1; Wed, 11 Nov 2020 07:10:20 -0500 X-MC-Unique: KIVkhXwCPsa4RlcUPDHLEA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AEE2A879526; Wed, 11 Nov 2020 12:10:18 +0000 (UTC) Received: from [10.36.114.151] (ovpn-114-151.ams2.redhat.com [10.36.114.151]) by smtp.corp.redhat.com (Postfix) with ESMTP id 721865C62B; Wed, 11 Nov 2020 12:10:16 +0000 (UTC) Subject: Re: [PATCH v1 2/4] powerpc/mm: print warning in arch_remove_linear_mapping() To: osalvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rashmica Gupta , Andrew Morton , Mike Rapoport , Michal Hocko , Wei Yang References: <20201029162718.29910-1-david@redhat.com> <20201029162718.29910-3-david@redhat.com> <20201104094255.GA4981@localhost.localdomain> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <78f48ca7-d801-238d-f107-11b82d8a6384@redhat.com> Date: Wed, 11 Nov 2020 13:10:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201104094255.GA4981@localhost.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.11.20 10:42, osalvador wrote: > On Thu, Oct 29, 2020 at 05:27:16PM +0100, David Hildenbrand wrote: >> Let's print a warning similar to in arch_add_linear_mapping() instead of >> WARN_ON_ONCE() and eventually crashing the kernel. >> >> Cc: Michael Ellerman >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: Rashmica Gupta >> Cc: Andrew Morton >> Cc: Mike Rapoport >> Cc: Michal Hocko >> Cc: Oscar Salvador >> Cc: Wei Yang >> Signed-off-by: David Hildenbrand >> --- >> arch/powerpc/mm/mem.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c >> index 8a86d81f8df0..685028451dd2 100644 >> --- a/arch/powerpc/mm/mem.c >> +++ b/arch/powerpc/mm/mem.c >> @@ -145,7 +145,9 @@ void __ref arch_remove_linear_mapping(u64 start, u64 size) >> flush_dcache_range_chunked(start, start + size, FLUSH_CHUNK_SIZE); >> >> ret = remove_section_mapping(start, start + size); >> - WARN_ON_ONCE(ret); >> + if (ret) >> + pr_warn("Unable to remove linear mapping for 0x%llx..0x%llx: %d\n", >> + start, start + size, ret); > > I guess the fear is to panic on systems that do have panic_on_warn (not > sure how many productions systems have this out there). Exactly. > But anyway, being coherent with that, I think you should remove the WARN_ON > in hash__remove_section_mapping as well. Thanks, I'll add a patch doing that. > > Besides that: > > Reviewed-by: Oscar Salvador > Not sure if the functions below that also have any sort of WARN_ON. > native_hpte_removebolted has a VM_WARN_ON, but that is on > CONFIG_DEBUG_VM so does not really matter. Right. Thanks! -- Thanks, David / dhildenb