From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7CCAECAAD3 for ; Thu, 1 Sep 2022 15:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17EA08D000D; Thu, 1 Sep 2022 11:07:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 108A68D0006; Thu, 1 Sep 2022 11:07:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9C6D8D000D; Thu, 1 Sep 2022 11:07:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D6D168D0006 for ; Thu, 1 Sep 2022 11:07:15 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA46C4081D for ; Thu, 1 Sep 2022 15:07:15 +0000 (UTC) X-FDA: 79863844830.30.F0A0BB2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 4F4F140058 for ; Thu, 1 Sep 2022 15:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662044834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n51zgqgBl470PB0vgcZT4BRIRHbxoQSrqhNCiStba2E=; b=ObDiSLMfQ9MXDmrGnlC1LZZNZWle7oseddosLR97XfdCMFtq6NiEU84hrrYb+YIX+PVJ95 lMwvk1ghQb+NVS3Q/a+XVJLVsH26CMN+7TkcbwgomSX2qCI1PUwBoHSpVpz7igyTQh4Sou 4X/G4lPfE32Y+MmVTqFcZL1HZ3QkZEY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-414-D2_hmmrUNfCa_CqxBiJ55Q-1; Thu, 01 Sep 2022 11:07:13 -0400 X-MC-Unique: D2_hmmrUNfCa_CqxBiJ55Q-1 Received: by mail-wm1-f70.google.com with SMTP id r10-20020a1c440a000000b003a538a648a9so9963122wma.5 for ; Thu, 01 Sep 2022 08:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=n51zgqgBl470PB0vgcZT4BRIRHbxoQSrqhNCiStba2E=; b=06H14ZoIrQmMQH1rG8fVpAGDM24JCWRG9827X0u3HAeE+75aykzX2/Rfxfbcxi6YX1 hTmqJpa1GGhDdBzw8qro3Cuu0tYoAUanFn+vTQtOVuYlYDopZHiO7z+Z5Kow0nxUyFct UbJD0MNWyQIKz5WX/HWZE0ZshJn+lGaajpUmrKUugXmFv43T86m7mYsI9vFyPeX4mswR 8JPPgM8xjyyZOq+AzpbhMV8pYrShrMNhcuqsvkFJ2+pVsmazLnXgoU4nnnJR9z+5Nts9 c9dqCiJRpViZDk+005ruDFxay0GwWENOKN3CFZBlSjZ4ub7ygY6WCV+0Ashy9KA/06b3 HnDA== X-Gm-Message-State: ACgBeo31CNqKukkJwllV/C0WsayzajEo17HYavyQ8eyJePBFBSB0PdEY NTSQJAb02ujjCzy/6pXBjdUOrGizhqs81iGgqCSTXFgCEwQcOhB/j4FSlLBv4pPf/0rAOxeGspr NrAwFPqk1kzE= X-Received: by 2002:a7b:ce13:0:b0:3a6:34f8:e21d with SMTP id m19-20020a7bce13000000b003a634f8e21dmr5628122wmc.22.1662044831142; Thu, 01 Sep 2022 08:07:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR4MsTHzosmA7E7hGiZjHmjlTUlB0s2DWeDkp38EpmRPnqXeJG3hehRWe5SqC6TIKnfqy7LhVg== X-Received: by 2002:a7b:ce13:0:b0:3a6:34f8:e21d with SMTP id m19-20020a7bce13000000b003a634f8e21dmr5628080wmc.22.1662044830813; Thu, 01 Sep 2022 08:07:10 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:9e00:fec0:7e96:15cb:742? (p200300cbc7079e00fec07e9615cb0742.dip0.t-ipconnect.de. [2003:cb:c707:9e00:fec0:7e96:15cb:742]) by smtp.gmail.com with ESMTPSA id a6-20020a5d4d46000000b00226dedf1ab7sm9303786wru.76.2022.09.01.08.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Sep 2022 08:07:09 -0700 (PDT) Message-ID: <78e55029-0eaf-b4b3-7e86-1086b97c60c6@redhat.com> Date: Thu, 1 Sep 2022 17:07:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: Kent Overstreet Cc: Michal Hocko , Mel Gorman , Peter Zijlstra , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, void@manifault.com, juri.lelli@redhat.com, ldufour@linux.ibm.com, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, changbin.du@intel.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, arnd@arndb.de, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kasan-dev@googlegroups.com, io-uring@vger.kernel.org, linux-arch@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220830214919.53220-1-surenb@google.com> <20220831084230.3ti3vitrzhzsu3fs@moria.home.lan> <20220831101948.f3etturccmp5ovkl@suse.de> <20220831190154.qdlsxfamans3ya5j@moria.home.lan> <404e947a-e1b2-0fae-8b4f-6f2e3ba6328d@redhat.com> <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC PATCH 00/30] Code tagging framework and applications In-Reply-To: <20220901142345.agkfp2d5lijdp6pt@moria.home.lan> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662044835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n51zgqgBl470PB0vgcZT4BRIRHbxoQSrqhNCiStba2E=; b=4uZgxQtXJRm/EgLhZg3ns+Ww9nk0uWKgt+UJZeonbYFZquRUprDOTNUCovPhpxZvKjQ3nh CGpeKlqp4FOLGMV8t4F0pY0k6tk8iaqTJjoRjrsXzvPUwra4Xc6xb7HFcId7nTd51Y9mH4 G8nzrxdROzSo6gPoVTdmQ1MdvZc9vQg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ObDiSLMf; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662044835; a=rsa-sha256; cv=none; b=sZCkS3GyFGnUVvDtnFBAcMkp2GNY6m1R5np3k/XkRbRZlkqxiEbtu5PTx8OvMgaJg0eMO9 TYNleh3G5Ns9P7NM34YaTu0te4eQh3AzZmJcIRwTRgbpFQVk8tpXrKG4uIRzx4KsbbDEaX eHYej5/YudLnYSMoq0CNP8wQNZ3MOEM= Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ObDiSLMf; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: 88pf65bmh4ryp7q76oxsm9zurmyqj6uu X-Rspamd-Queue-Id: 4F4F140058 X-Rspamd-Server: rspam05 X-HE-Tag: 1662044835-624784 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.22 16:23, Kent Overstreet wrote: > On Thu, Sep 01, 2022 at 10:05:03AM +0200, David Hildenbrand wrote: >> On 31.08.22 21:01, Kent Overstreet wrote: >>> On Wed, Aug 31, 2022 at 12:47:32PM +0200, Michal Hocko wrote: >>>> On Wed 31-08-22 11:19:48, Mel Gorman wrote: >>>>> Whatever asking for an explanation as to why equivalent functionality >>>>> cannot not be created from ftrace/kprobe/eBPF/whatever is reasonable. >>>> >>>> Fully agreed and this is especially true for a change this size >>>> 77 files changed, 3406 insertions(+), 703 deletions(-) >>> >>> In the case of memory allocation accounting, you flat cannot do this with ftrace >>> - you could maybe do a janky version that isn't fully accurate, much slower, >>> more complicated for the developer to understand and debug and more complicated >>> for the end user. >>> >>> But please, I invite anyone who's actually been doing this with ftrace to >>> demonstrate otherwise. >>> >>> Ftrace just isn't the right tool for the job here - we're talking about adding >>> per callsite accounting to some of the fastest fast paths in the kernel. >>> >>> And the size of the changes for memory allocation accounting are much more >>> reasonable: >>> 33 files changed, 623 insertions(+), 99 deletions(-) >>> >>> The code tagging library should exist anyways, it's been open coded half a dozen >>> times in the kernel already. >> >> Hi Kent, >> >> independent of the other discussions, if it's open coded already, does >> it make sense to factor that already-open-coded part out independently >> of the remainder of the full series here? > > It's discussed in the cover letter, that is exactly how the patch series is > structured. Skimming over the patches (that I was CCed on) and skimming over the cover letter, I got the impression that everything after patch 7 is introducing something new instead of refactoring something out. > >> [I didn't immediately spot if this series also attempts already to >> replace that open-coded part] > > Uh huh. > > Honestly, some days it feels like lkml is just as bad as slashdot, with people > wanting to get in their two cents without actually reading... ... and of course you had to reply like that. I should just have learned from my last upstream experience with you and kept you on my spam list. Thanks, bye -- Thanks, David / dhildenb