From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29384C021AA for ; Tue, 18 Feb 2025 17:26:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB9828016E; Tue, 18 Feb 2025 12:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B5C51280169; Tue, 18 Feb 2025 12:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A23AD28016E; Tue, 18 Feb 2025 12:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 844D9280169 for ; Tue, 18 Feb 2025 12:26:35 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3C4B04709B for ; Tue, 18 Feb 2025 17:26:35 +0000 (UTC) X-FDA: 83133744750.07.36DAD20 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf15.hostedemail.com (Postfix) with ESMTP id 6DD83A0017 for ; Tue, 18 Feb 2025 17:26:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739899593; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QP4nWSTt7YSnUxuYxA7Y5tvuI/IYTdI7dH6x4l/ZFMg=; b=cEztt9wkD6LiCHcLxGprvXxNJ/vKRKpijio3yiyatdVMWfR29OgirxEURRUr9yd6Ik26Nc bZ3UCsaGfpBiJTfnT2zFBTG0ukAcORIPKCmzs+JLbaW3P2iUDJKu6sCAJlUBB9L+XdNBSR uaZfHPlrvJh86DWywmS61mx6jlRzRKs= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739899593; a=rsa-sha256; cv=none; b=KJVNLhkO/aa6lYqmMoQ1qWQY2SE+E7b8FqBzqpLa77QnI0dxQ5EYwn6QeqRqYpWU1heLJR 0n8XzXHwDFjFRlw32FU2yOSX97BafdOUHDOLrOsAPrsV7CnuZ0suMV0Fwg5dtKSIVQgkcf M6tTuwjX1W1pQTXhYfUeXJTt219HJz8= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tkRJg-000000002oZ-121S; Tue, 18 Feb 2025 12:23:28 -0500 Message-ID: <78e2f84848a6515b903cc3660b829b5bcd378f12.camel@surriel.com> Subject: Re: [PATCH v11 05/12] x86/mm: add INVLPGB support code From: Rik van Riel To: Dave Hansen , x86@kernel.org Cc: linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla Date: Tue, 18 Feb 2025 12:23:28 -0500 In-Reply-To: References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-6-riel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: bsezcetgtcr8br97mpfzj1rrfhzf7fxa X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6DD83A0017 X-HE-Tag: 1739899593-791293 X-HE-Meta: U2FsdGVkX19V8eCxWnyuuNVNMtFZOD0icjEOyfoTXWcjzviNLf4vZHuZXM0tH06SdqM2KhlTISkCkPZTPBCJepPzB+bW/sUXr5AmOKJWeOtuSsHjD+QZNmRp9c1yrxkdz1RjnRpCDKorX5ITg+NVyNTlYxamB0JTA9mpg1FAbWWRxqjb3Ghzx9Z111RDI+DlaXrm6/ZCQ8CkVCDI+bYoltJ3IdOzZIND3GKsCx5POOfp3V+RqnV8cBpMRP8HHIftTYn98Jf9HaBnp/JcGPhR6H1b+I035DLpYXPSJbcX30aYYa2DXUSExGzqc05DeKRXs4nCe0EQSMYZ4P1VxOZirNslP5vHWBnUM/LjtCkV4BfDRSPbDV12YLjBjEKTMi4GRnFINUyMf/YgczbWGXaNo4KLMX+ZgVlTCNJSquGHubo2fj+PslGmFijoPPC45AW+q9AZslaBMsarzFlKjnCjyLd+Obmb55ZnBhM2Nr+SISj4csbA0OMDqyhuLLJ79CIKKwzYum2VgtM8suFmdHiL0JYJXtppxmiO+oaKGKAte6TQnYHpDULoYsWLeCVsuAAcT37BHyrYwkzNhsqmJ53T/WNWdKIqfirY3htdiMKX5zr3RE2rKw3UXjMZ+t+y/Fy/rwNUvMBgpdq/tGCzk8j4dOTc5I3FaoIshOhYAwRJJqHPU1J7K/pAoV39ls73SnxQoP/jbEvPyT0c+zMvtIwT1CSLmJkCJ5Gq+jjK+pTGybcCBtWs/+EZQG7UxfcXQoHpjp2VYkjXsvkxsqoEnwwiq2LpHDAcUEM0ACqlLXIIG473A2KKittUjFak3dJbUzFGYDY7lxw7hIG59yQjj9FtbZ36x+R0V8LanGLv/z80aFeop5cLozxpB52l88O4zHXnGkYSnZvIgx89ZKq7byYihBuAD7Z1bfwqSgMJGvMewpRPH/HBE96tReFyJLMY16xXt5rZdgmfTNzUkQokpQx 9ne6b2l7 USyW/g8W/co06O1dsE9g7AiFgnfv8hUbQ/jrkzHoUT5BOV6bdJlCsvxzazSBcprd3gtrZBIAS/t3Tg/rsOzFvjH/D1aPREnuyfynzMPzCR84St9CkrewYc+VQzs5NPyphpWA3X2e/ciA7SauoAo1twe3n8b/B+39o7w+vHrzawzR2VGIBI9iEHF/a7zXZg++cBIXGAenTzYUKrUgGBYT7vVhqSIq1NZWxer99hDQw3VX5gE5q4B9F/3g7VafE2DNxNLYw/PaMeq5f7zKkikWk+QwsX9Xl5ApGK5lIfu7W3GlyifMr7TuVJVupzWTmxyBYBwlgWUOq2oai0XZK1XIYtIA5QeBgtgxFKZaEr/PO1KMx91A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-14 at 10:22 -0800, Dave Hansen wrote: > On 2/13/25 08:13, Rik van Riel wrote: > > Add invlpgb.h with the helper functions and definitions needed to > > use > > broadcast TLB invalidation on AMD EPYC 3 and newer CPUs. >=20 > You should also note here that (or if??) all these functions get used > later in the series. >=20 You made me look, and there was indeed one helper function that is not being used. I removed it, and added in the commit message that all the (remaining) functions are used. > > +/* Flush addr, including globals, for all PCIDs. */ > > +static inline void invlpgb_flush_addr_nosync(unsigned long addr, > > u16 nr) > > +{ > > + __invlpgb(0, 0, addr, nr - 1, 0, INVLPGB_INCLUDE_GLOBAL); > > +} >=20 > Something about the "nr - 1"'s needs to get mentioned *somewhere*. I > think the best place is actually in __invlpgb(). Basically make the > calling convention for __invlpgb() be the _sane_ thing where nr=3D=3D1 > flushes 1 page. Then do the nr-=3D1 in __invlpgb() and document why. >=20 > I don't mean to insult the AMD ISA designers here. I might have done > the > same thing. But the software to use the instruction ends up looking > really funky. It would be great to limit the number of places that > deal > with the funkiness to exactly 1. >=20 > With those two nits addressed: >=20 > Acked-by: Dave Hansen Nits addressed, and the Acked-by header added to the next version :) Thank you! --=20 All Rights Reversed.