From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A4AC25B74 for ; Sat, 25 May 2024 01:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6977F6B007B; Fri, 24 May 2024 21:34:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 646C76B0083; Fri, 24 May 2024 21:34:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 535836B0085; Fri, 24 May 2024 21:34:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 35AED6B007B for ; Fri, 24 May 2024 21:34:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DB16F1A0824 for ; Sat, 25 May 2024 01:34:28 +0000 (UTC) X-FDA: 82155198216.28.B597E77 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id 756B180009 for ; Sat, 25 May 2024 01:34:25 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716600866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=joaNy7SSzugI1pLPGEjJjlCf0Z4CVpBBTG8AU8bV5J8=; b=5olO4WEw9iZZ0xUNQ5djoPdsP1JFFRjj/HC1tmgAkq153oL7KQZ4WL6miB+LglGigFZESL 4PT7kqTbPrsnK8CtrP0nnNUIVZOILjPo46mnwmRsobSNLT/DBGM4uNFgW4HJWBafJVTPQZ 8RySpQelW9/5Ty/56nzWu57c3U6cya4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716600866; a=rsa-sha256; cv=none; b=FGWqSmJ9ixMRpTahfjDSmd7qGQk6SoKXN3jXmoHh7QvpiHoFkRUFwgtF4bOaVIrEPU+iIC c4bRJPUFhEpTOp/WYC0cor7cOFhlkzb270lJEC3k4VLpBD8MafO+PTTpFCH7Dtqjc72Jt1 BV5N9OnPLsb8M8PmVFppWfPDMdzKnqY= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VmPVl6g8JzwPbw; Sat, 25 May 2024 09:30:39 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 955D6180069; Sat, 25 May 2024 09:34:21 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Sat, 25 May 2024 09:34:21 +0800 Subject: Re: [PATCH 04/13] mm/memory-failure: save a page_folio() call To: David Hildenbrand CC: , , , , , , References: <20240524091310.1430048-1-linmiaohe@huawei.com> <20240524091310.1430048-5-linmiaohe@huawei.com> <65447480-f46f-4256-a093-f8232fb6ed84@redhat.com> From: Miaohe Lin Message-ID: <78e22db5-791d-0086-f6a3-8c9bba2ca4cc@huawei.com> Date: Sat, 25 May 2024 09:34:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <65447480-f46f-4256-a093-f8232fb6ed84@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Queue-Id: 756B180009 X-Stat-Signature: gsjr6ohjtg5ub9moyxeddhtbxh4t6ube X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716600865-290489 X-HE-Meta: U2FsdGVkX18QPvuTcjGW5KOecT+FRlRfCdnX4g0g1NJ/9CnGK4IjpQm9pryXlV4Ti1QsNvrM8sbtn1V/fEx/IiXaypv3brZilBq7QtxlvFTQjooYC0GDMh20ZR96j5eF8RLKdwcrALe7nEQpDGa7fw6QCkqTxXCNyAwPNUfRmBK5m9ukt7lOlQkZbfFicjePLnqfpKMarolMMSBCY9oSrdmlgAz7PxDpjMPKnIKzMS3xTgJyLiY0DIxsOx03H84KKk5fT0f/gOI48GesA2zdTPziqfCPrPJO2iEgvdSG2iEhy0d/yfPCHkDpcHKd4BV+Pyk4BgJWqNs7sCz3HfR5AMWTY7P2edEUa1EwH87xhI9OMFKPcIrFXeOiqwkn72korUG+eh5MzniG6Zz9T+0TmOSSNoZmT1I6GBWHo6vvbyH+IOtMyUKGKVQwnOi99qSHlBSDCnJ2Hqk6twaRkPyZjYZiPfAw6g6TRfEqFqt6ovPfxfR5A4OXxxzqm9J1ga9oGGfLJYZLpAAgGkXOSvRKet2z6NULpK0SMmXRTqmi2d6dZTuFm7nYRMQhfnowJ5XgiR0jMruo/Q6Dvx4+CTFvNs6xFUVW7xUcGmjidpo0dkZJUscrfZgFJrFshrdwFzLZqrkGil3SPbyd0FZd5kVXNFvUNV8oe2DaNyn/cqYZAyEpRELulhIwYiDC9QeWuCNXAkqfBE8WUclB9bK9UQ80TPMjPHOmdgceClyi9uNYpqh23lCDTvLo23qw+ZByOYASojJMTDGwAVytQDzVHxJ5ndr/NYNBHtV5x2/e4me3b4l2Kzyp0G/JBPr2T60dXDWGoVn3Lt1NtM3j6MLzvgNt6eL/ToC4g060OmCA25yMEUY+UN+sW3URTu+HKAR5ku3tzszC713cnnGuRZL4tWpzsiq+WTu7gfiTp5eW3190jtHgl7UB9clREkKvQu6lrDA9GKlyPOJPtDeIHRtKRGF MkZdUSYi ov/sto3W/N7q8KJlITDoxAawZs1c4Ply4V3raSGxWiD2h515Ck1lEdeQOHeECQScy8mQp1esn5YqznBRYPtIkmKXVff1MJBd1n58xyjUk/liJIgFtApck4y8/uutz40xU1+IGyeh/pz0j/BS/KJO0NssR5ETjIKcGlycQjXH05dkdOc6IoCz1lide5f3kTN4hN+6DTEjb0DKQecUALdp/Pt84vF6x9QXqpiRqQk7TCyNTnZrzdYA41paA/OYzfeIRw3tVEUt0JsF021adEhWZAF/vcmfLga5fU/+FdM6woRuHAn8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/24 23:06, David Hildenbrand wrote: > On 24.05.24 11:13, Miaohe Lin wrote: >> Use local variable folio directly to save a page_folio() call. >> No functional change intended. >> >> Signed-off-by: Miaohe Lin >> --- >>   mm/memory-failure.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index b571aaf987a2..73878ecdec22 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -1658,7 +1658,7 @@ static bool hwpoison_user_mappings(struct folio *folio, struct page *p, >>       unmap_success = !page_mapped(p); > > We should be using folio_mapped() here. Will fix this. > >>       if (!unmap_success) >>           pr_err("%#lx: failed to unmap page (folio mapcount=%d)\n", >> -               pfn, folio_mapcount(page_folio(p))); >> +               pfn, folio_mapcount(folio)); > > Reviewed-by: David Hildenbrand Thanks for your comment. .