From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE3AC83F2E for ; Thu, 29 Aug 2024 15:10:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DE06B0088; Thu, 29 Aug 2024 11:10:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDC6D6B008A; Thu, 29 Aug 2024 11:10:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7DAB6B008C; Thu, 29 Aug 2024 11:10:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9A0556B0088 for ; Thu, 29 Aug 2024 11:10:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3F5C8140EF8 for ; Thu, 29 Aug 2024 15:10:53 +0000 (UTC) X-FDA: 82505620386.11.7F2CD89 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id DE6EB140026 for ; Thu, 29 Aug 2024 15:10:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aIpRGuCR; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724944163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=742HdEu3y/K1UJtuDMv6TuLUwdK2EQDoHlw6iX2aPxg=; b=gxiwGKDEswYcx/aZBrM2QuMGoq3drHJ1aoklT/fUB8NW0Vwg3caw8HeNPuaxwy4LL3Amq2 gL4Xp3LnGgeVFOPM0/FTtuUL4czSl/+vJu2XkkjsjGjqLHbBl2f5wm7HeIif0RU5Hn9545 aBZ1AS5DuJTsKoq/tzGaWXqkvMKW5hI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724944163; a=rsa-sha256; cv=none; b=AgcYPZa5Y9Z3xYZWnk5I9zCLW5X5ucmk7YOBvXc4bp1gADjja8K96bulCj2gIwYneSoMFP 7Vw2aeIuqnscwHGWwT6RStappGT/JIZs9PjFsGoIa9IhAO4aNS4+97RWbTRTiYm7kJII50 2Jg4RWfhqXkkBCozNl2fGqHS69ZApBQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=aIpRGuCR; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724944250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=742HdEu3y/K1UJtuDMv6TuLUwdK2EQDoHlw6iX2aPxg=; b=aIpRGuCRq76Q6GjYOEYZGiNyHYVHdxMn3k21NWGEqs2/Ul4N1EzOIxxnPV1VWg9r1VLBC5 YXyq4ic0sXe6lUiTEON2MJ+HEqXanjFnAfQ+zSMs2LGQbKCXNff2PExYXAF0v88DxroM5Z GDFzATf9CBnUAK24pzYUIMcCNCcHFXA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-41-1Ujekl5lMECef9v8aAdEBA-1; Thu, 29 Aug 2024 11:10:46 -0400 X-MC-Unique: 1Ujekl5lMECef9v8aAdEBA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42807a05413so7616595e9.2 for ; Thu, 29 Aug 2024 08:10:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724944246; x=1725549046; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=742HdEu3y/K1UJtuDMv6TuLUwdK2EQDoHlw6iX2aPxg=; b=TP02Z5mjqGlIKIdlce6C19yn2Lrq9I3IzvrsqWnTczijWHYgkL9wlEMz7LPK6UR5xi yjPms4bzIs3YOPRG3omW0bMRqCcN5hK7TfgG87WEJI2YRGmtuFbS5nPtLff3/OhQ+n8C 2QtKAKFW2dBB3WXw4238pFLzLnBQiA0BfjE5t0Q8TNFs5lyczInqRd8RtOGO7Aws53gp dnP6Z6zS1Y7kkghzKBJXvvrCbGyiz6wGKZDJa7rqsLQMoodqXBhPVf09/7UIz++ITWjb OgPXcJ5Fs6Htrwn6jVqiIJsZGf5dVN1Boa6cg0siDZVp4+E+kyWBz1Ala36bYrzjl/al cdXA== X-Forwarded-Encrypted: i=1; AJvYcCXOK7IkivHEjX7ashCXqjwAjBbEroGIHEJNFn2detlmCVsIq/aoA5TqajNmMCWM2s7VC5Pt/hYeIA==@kvack.org X-Gm-Message-State: AOJu0Yz/uu6RT14CWasNmc8tYFpKS1mpf5byLTHc2hZK6nIn5j8Els0o viqgnUQIXFxGj6stCxz9y+45+gAqPMnJnL+75sPzWSblQptsInMQYmIpokHsWLg5HeGaG5ydQTk TeC9GY7FJZpzdJJ6BaY4a1p/KnxQ4Oo6mtkgTI8NZiGbr0hRm X-Received: by 2002:adf:f692:0:b0:368:633c:a341 with SMTP id ffacd0b85a97d-3749b5498c8mr2248055f8f.22.1724944245659; Thu, 29 Aug 2024 08:10:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEd3r5RL+/Yvnv3ycJ/E8POGkC5dJYHyE+SYP6z4w6Y3S0/Jq0vbDVxfXMZSW/qRQW5hylSBA== X-Received: by 2002:adf:f692:0:b0:368:633c:a341 with SMTP id ffacd0b85a97d-3749b5498c8mr2247967f8f.22.1724944244729; Thu, 29 Aug 2024 08:10:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c711:c600:c1d6:7158:f946:f083? (p200300cbc711c600c1d67158f946f083.dip0.t-ipconnect.de. [2003:cb:c711:c600:c1d6:7158:f946:f083]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6e33e2asm19927845e9.45.2024.08.29.08.10.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Aug 2024 08:10:43 -0700 (PDT) Message-ID: <78d77162-11df-4437-b70b-fa04f868a494@redhat.com> Date: Thu, 29 Aug 2024 17:10:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/19] mm/fork: Accept huge pfnmap entries To: Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Gavin Shan , Catalin Marinas , x86@kernel.org, Ingo Molnar , Andrew Morton , Paolo Bonzini , Dave Hansen , Thomas Gleixner , Alistair Popple , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sean Christopherson , Oscar Salvador , Jason Gunthorpe , Borislav Petkov , Zi Yan , Axel Rasmussen , Yan Zhao , Will Deacon , Kefeng Wang , Alex Williamson References: <20240826204353.2228736-1-peterx@redhat.com> <20240826204353.2228736-8-peterx@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240826204353.2228736-8-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DE6EB140026 X-Stat-Signature: pdd61aann8sdupezmj4ze5z51nf6xqos X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724944250-487136 X-HE-Meta: U2FsdGVkX1+zd5ZCV10TX/ldqL9ihVO6+6cXgVRhuUzQBR/unux4r/5FAT5f+m8lNu5BKJki1tIYeHnASeT+WyMQjtxURmCMilEQJT/Gc4iU3ACdlteFh5w4jLJysQvAim79ZNmEHf7s7I4PjZg57MAb3c4f6Y8/NIPXrfrsIfQ+dMSZhgD561uqoOtTqwx89SUR4IqdtkwlxxTBi623Xh5W2ZlI6FAX7gyIco9c7xXtWvJFnHfcHbldf4RaeQRC1R198CMhY7CrT1XRV7VVotE7EBB4b2zw31N7k3gDJVV44vMZuJveilCA5AqCPXsG48RsOL5cZJBSa2sei18PokeIVRkUfYcF2imFn4C9Zmk5kLpvmReha0maZ9iZWs4S7BAlevCsVSx8Q1eSC5f9jI9xDw7pnTQ42WRoeNmtCU+fkFNXHig6+ERltaByC70mYbVO78yss34vVKToQVMryf+IBHebyIpdX1QXnWI3S2PMSegnvTOg5lFO3y0x3H3DeOKZ2cyeqyiKIl8GOTiJW6i1GObumk+k3oKVGiS7K6CN8Cv4MS5ULY7EtpD6qrY0COrLgMFR5RM3gO2zXyBEVA1bt4lplCvK+uoaLus2VrSInSAit5I3eZTMhYr+s+mERbzXBQ3R61nzUTJL4MgtOndiT4rWS0P0LPm5f2U8q2Q5HJBfACUl7utHcpjBOcgmIO/phYdkf/0InMa1REOPlmmu1YidAT0hKTtXVwAgNaSHp+vknloO5UCaDx+KnyBrW9/Ch2881MU9Z6fnr2Bh5eh/hI/EwOT4EyH/0brN0/ErAQNKE20MtortC52oOVLjCdCl4BcAwFiNSRCpc5Fy7O8374jWGUFgfYEE/+Jv8nxV+mjV4bk2ut3+XhI5IyyeiQwcgeSCNVOKU6TPQqyxcGTxPaYfc/hgZhvexhBRBC8T2MeiQcfYwxCNJncGzAffuWyJNr/KHDw2BOv/TTy /Dngqn2K YLiE1NgrQBLC9zQEYqcC+itR0ac3987ztjgI6eEMvmePON8fvMib6BMh34vFjY9p2/llvJ6ccwbGkDulLdo32QfiBSaRvWokEG8MUoShMRkvwPs/aBv6Al7+7jrRX89MLWvmyNl6FksU47AgDmbf2iusQ/MYYtD1kY3QlDM3Lo/0E+iHqyNomV/Ft8qeDFhzJPsxwq75VEZTNrDd0wy+5UPFrFiDTuhemWIlelelxdhYMTEGslEA8FzFekHBJ6EcHg6bV14VwQsTJp8LDYotV4CI5ZWGydQXKoasC3CLqUA3sdvVgelQ7k3Jgg9NR1FzimHMBTRPWecZPfiB8oEiWhUoVUBCROMCkoMCwsx9durTiS/5BrQllqwTDyKWdSTEubcNl91gEVj5Ih69d8vSi2kDuzKgxUQNUKwdXzKUgWh0SxHw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.24 22:43, Peter Xu wrote: > Teach the fork code to properly copy pfnmaps for pmd/pud levels. Pud is > much easier, the write bit needs to be persisted though for writable and > shared pud mappings like PFNMAP ones, otherwise a follow up write in either > parent or child process will trigger a write fault. > > Do the same for pmd level. > > Signed-off-by: Peter Xu > --- > mm/huge_memory.c | 29 ++++++++++++++++++++++++++--- > 1 file changed, 26 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index e2c314f631f3..15418ffdd377 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1559,6 +1559,24 @@ int copy_huge_pmd(struct mm_struct *dst_mm, struct mm_struct *src_mm, > pgtable_t pgtable = NULL; > int ret = -ENOMEM; > > + pmd = pmdp_get_lockless(src_pmd); > + if (unlikely(pmd_special(pmd))) { I assume I have to clean up your mess here as well? -- Cheers, David / dhildenb