From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608BAC282C5 for ; Mon, 3 Mar 2025 10:01:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A74E26B008A; Mon, 3 Mar 2025 05:01:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A25D7280004; Mon, 3 Mar 2025 05:01:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89F02280003; Mon, 3 Mar 2025 05:01:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6E3D36B008A for ; Mon, 3 Mar 2025 05:01:41 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id ED6B4804CC for ; Mon, 3 Mar 2025 10:01:40 +0000 (UTC) X-FDA: 83179797960.14.E8AF483 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 8CD802001D for ; Mon, 3 Mar 2025 10:01:35 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KMXt778T; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740996096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XPMg8qYY6woJwUtyf2x+IAiV5yepPU5ZWaNNfhk/IJY=; b=zEa40H2HGDEgfzLl3vnFoNtq+Y/BwWmtw6GvJfVrq6SyGGt9jew0ed6NlrTK7csANbxji8 s8ydRTk8qrozweRghhWHrgO1Cpo/8prHbe/bLDJZhF1I52cNzFQYo/CSv6JjqB9OATV4Tu hvO+ePBWLU2n8k/tqQORE7oqbQl7QL8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KMXt778T; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740996096; a=rsa-sha256; cv=none; b=CbjqVbH/9ig2alVDJdWVwz/a3+LBfnGq+QTFFYw9mOoabUbtpPJ3r4YGJ9WFZsYQFs0PFQ Tcb3GuFep29lL82xE2VuGqKYPTXPrQO+0luugcDk4ScOgQIMWXQJNrazDeP/H3ZBRNO3TZ 3I8xsl/yRoBAEsebPbUa7JSTZwcBFco= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740996094; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XPMg8qYY6woJwUtyf2x+IAiV5yepPU5ZWaNNfhk/IJY=; b=KMXt778T3xHG4I364oclQCIpcYz2OoiBACYg24/K2NDxZb8J8ecy1LAdIs3jDZUyhgEr+H Q955Gxz9UhM0Z+Ki5JWUnjVxWXuNOvTCTV5duxiB1z0CqOT7JS4oDQ6GyNEpb+Q64yBrbc EXqmpAG/KVbLcCLmk6pezV5uFFVuIe8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-0KvC878rND-qnc9Yp6Dw6Q-1; Mon, 03 Mar 2025 05:01:28 -0500 X-MC-Unique: 0KvC878rND-qnc9Yp6Dw6Q-1 X-Mimecast-MFC-AGG-ID: 0KvC878rND-qnc9Yp6Dw6Q_1740996087 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4399c32efb4so22143015e9.1 for ; Mon, 03 Mar 2025 02:01:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740996087; x=1741600887; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XPMg8qYY6woJwUtyf2x+IAiV5yepPU5ZWaNNfhk/IJY=; b=VfbRssZ4ZnayTmxbEespmmkGI61lS5ZfcvsnlyRPPae4oqivnkXe3d/9zWglgsydN9 zpi3bE6BpQUSp/dbBCMpfbk6zQT4w42RZiZqrAgGSH8z2x3g0gv1ZKn6DKpACTN/FWKv I6Na5MqOzHpfyGluI8OYr8QKu9iNwMe4U/anW9oESY2cf4gig35aYB2y/bG/wi9Sh6E3 b+nuhkAmh/bTv5ny1aBUxRsDGeBmh7P0z5uDFVZitL559xlOlVv35cHtgCRgTj8B87d6 qgWgmouTepWv4/T4VQ2228q4gv+ODGJlRB5ZVSLsXAf+AXNPu5XhGkGgWzyqVsRY3zlH Zzig== X-Forwarded-Encrypted: i=1; AJvYcCXyaEQYF9j3J4G3j/0qZ5Xn0KWBgN6nwYKh7eyqG4NuPGaNaozPojEWVypOCrU1OlTTYpnDybLcug==@kvack.org X-Gm-Message-State: AOJu0YyQkc4WfSOwvJB6T70WF1rxcaf9Ey43JxfNkSyHL9RfGYCh76wT 8Cvvdzaa3BSZpOLtslQhg4jsKj0LZ4lYQ+YkQ33vT6ZZhZMWBK0S9E8zkyUZPlAavJ/VuYC0Ahc dcb3XHASVhv0rNWxy7xg/2sRtPMG8VAJvwzqmqF15vVLLhW0v X-Gm-Gg: ASbGnct63qFNqX4IoUzIfPS9h2pFJbCD0TKaC5eaKeB9+ewIGr5nn1qVUcdYHpdQaPp sCCXxE9B/qJoGuR/gfngwZEYvwpITrJlKU5tM4RdOtkJmcKIezvwzYte9Cucwvk++nfR/E0XnA2 NhDRelfWbLvJutSy/eGcE4OdEtP00I9haMSkogAclvlXETIV7bCk7RLMdcBfo9rLojT2+t3sly6 FRhb7Dm6LMAmsAD1X8jL/85W/PVaxJuJ84Ht+zzh/r8Bd8xK+Yh+imj+uwlAZycj+0oa1tWbHXw sfX2Ka3llPomgdLyUkbV0DaNTcI1GFNdYlRwTizUSe0eCjS1KyiJ30ziqvPxikcy65c5Y1NyZpj 2JnX6rGBRllnJyVOsWM7DuihNW8XtSod6uUcPJYioBbA= X-Received: by 2002:a5d:59a2:0:b0:390:ff84:532b with SMTP id ffacd0b85a97d-390ff845589mr3552477f8f.7.1740996087030; Mon, 03 Mar 2025 02:01:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGXZqIa1M7mGR2dYNXiAZ4lWYbl7hOIdDdeUw6ofOE6vBxI8shgA38Lt8+iwmpijQWMi3sT/g== X-Received: by 2002:a5d:59a2:0:b0:390:ff84:532b with SMTP id ffacd0b85a97d-390ff845589mr3552443f8f.7.1740996086689; Mon, 03 Mar 2025 02:01:26 -0800 (PST) Received: from ?IPV6:2003:cb:c734:9600:af27:4326:a216:2bfb? (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43b737043aasm152241565e9.14.2025.03.03.02.01.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 02:01:25 -0800 (PST) Message-ID: <78d55e35-6cda-4f5e-8e52-0a54b1e64592@redhat.com> Date: Mon, 3 Mar 2025 11:01:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] arm64: mm: Populate vmemmap at the page level if not section aligned To: Zhenhua Huang , anshuman.khandual@arm.com, catalin.marinas@arm.com Cc: will@kernel.org, ardb@kernel.org, ryan.roberts@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, dave.hansen@linux.intel.com, akpm@linux-foundation.org, chenfeiyang@loongson.cn, chenhuacai@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_tingweiz@quicinc.com, stable@vger.kernel.org References: <20250219084001.1272445-1-quic_zhenhuah@quicinc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250219084001.1272445-1-quic_zhenhuah@quicinc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3yVLT5wHEPoBNsrGic5A67o1PK6udFf0s8j9Tx5o-ys_1740996087 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: die6bw7jfxgzdm79ukfrh7ag3xz9yrrx X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8CD802001D X-Rspam-User: X-HE-Tag: 1740996095-22322 X-HE-Meta: U2FsdGVkX1+LjyDq+3QaK5ZmsKKJZPl15fTUNerMMmQMjKd5NrqILeHfqc5zA5OjtT970uP7W2B3PCirDADlyMtIjcG1D/tvAjqYHy1Et9wSCmPTQQT8K5BZ8VxENqqm1/S7Ifx2s8I4sRM9nG5HyRiYCCpFdOVAs8KXcs5qG4XG8bSZDhB039OOTbrdyD+LFPi4MJzXXXHsymxAMP5ms0/7RbC8c9Rjt0avPbF0YQjXlfZ45pKv0vkvL6Fgzr4SJDk4STO6ktTJ1om4Y6vkXbrj7va0xvdX67+drNH6tY8t5U1AiOOTsDNtQd7Js8u8xQtJ8m3FHsyBDv92l03yeX0UNKqxVJUQKNCYCvlRqpMAr6RPpZyeldEA52S8Wl3+Vc2NvejPEq9T1uiP8Q4j2I66OHzrqzKbuqeP5p1jSbgef6QL6/0hKJnq2JJdmge7I/85KfA6E3A3aLMTAq3VHagaEd6gr6UFMt20bOP/8jzENHMnWKghfHmplO7dVZ68uGhYnehmaUJCdq8Aw/Bw2IJ5KHlGd6YJ5mEKV18aPag4g/oRVap0zjURy0fJXspIrvVf6wC0tK1yKBY7fTvD2M5oTEqO99z/ik38Ayv7OjfSpDyVOK487YfhEshw+BBusrIBw3YhBayamzJRs8/GYzwCvxokl9swRrI1U9sELKqk27mmbMOFs8soQ4Otl4j2qsl8AqqaH4UgTrHsC/C4YXxmFyPaZP/dtLwJJ6x2laGMGKTFqHKlrYdUOpo6RjbOb8r96Ow3iEZFbzDJiIUOEwhB+KiFS/7/ZHkyNyAqGb4jlq07BKjjVy1xLDngSwmJ/nNwulMXO02mzY7bFWN2rz2/jIRI10qt5tnJ82/zUqZue/RkYxJJ7HyjbfxrZEkdN5uo+894J0UBSXtoZY1dSg86+NeUdcYE45k935Dc07PCYx9fQTSMAgD+xXRC/4k46PmOTKwYmAdW1a1Iwr6 495poZV/ MGGRPA3+QGlOxve/cuP8vUYoVtqNgLAhu7stz8y1UBWuSbjCD/QjXrDhBWTkYQTttGEK9USn4EtIiFeQEOKmXlgmB1IWJVszlVTPUBg60DNRTtZ3QIzvSO9FpIDr6cfepMFo9zRilsvTNVj02MAnViRRwuOBnZWG1qdbLaroWA7uyG39G8I3OBMdRhKg9I1Hn9KNg4YM2zAV/rmBxW0CS23+tiuWMM/Z4Gu/RCEsR1wuXzWobixpgpYyWncYfBFbWUGNW4iFZUQlha+OLqo409Gx06gz7mh77XmOK1tR5UXwsIwQQcoW+3aPhg52zaIPU+/eIYBSmTh71Nu9e5LVv0oyTQ5kRPbE3PxU14ZDWgeuVf9YwX/q1ELLnED1FT+UPjNfcm7tNilUAjRQjF1ZBsHOBiTwBLqHgC5UOOWgj+5eIbDhljEOTMYmiYv7Jfh8V/yFShquqVmXRWFxgTEJJQE3EqzFTGwTh67xs+WK05mvVFWGeJlKpPmtD7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 19.02.25 09:40, Zhenhua Huang wrote: > On the arm64 platform with 4K base page config, SECTION_SIZE_BITS is set > to 27, making one section 128M. The related page struct which vmemmap > points to is 2M then. > Commit c1cc1552616d ("arm64: MMU initialisation") optimizes the > vmemmap to populate at the PMD section level which was suitable > initially since hot plug granule is always one section(128M). However, > commit ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > introduced a 2M(SUBSECTION_SIZE) hot plug granule, which disrupted the > existing arm64 assumptions. > > The first problem is that if start or end is not aligned to a section > boundary, such as when a subsection is hot added, populating the entire > section is wasteful. > > The next problem is if we hotplug something that spans part of 128 MiB > section (subsections, let's call it memblock1), and then hotplug something > that spans another part of a 128 MiB section(subsections, let's call it > memblock2), and subsequently unplug memblock1, vmemmap_free() will clear > the entire PMD entry which also supports memblock2 even though memblock2 > is still active. > > Assuming hotplug/unplug sizes are guaranteed to be symmetric. Do the > fix similar to x86-64: populate to pages levels if start/end is not aligned > with section boundary. > > Cc: # v5.4+ > Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > Signed-off-by: Zhenhua Huang > --- > Hi Catalin and David, > Following our latest discussion, I've updated the patch for your review. > I also removed Catalin's review tag since I've made significant modifications. > arch/arm64/mm/mmu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c > index b4df5bc5b1b8..de05ccf47f21 100644 > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -1177,8 +1177,11 @@ int __meminit vmemmap_populate(unsigned long start, unsigned long end, int node, > struct vmem_altmap *altmap) > { > WARN_ON((start < VMEMMAP_START) || (end > VMEMMAP_END)); > + /* [start, end] should be within one section */ > + WARN_ON(end - start > PAGES_PER_SECTION * sizeof(struct page)); > > - if (!IS_ENABLED(CONFIG_ARM64_4K_PAGES)) > + if (!IS_ENABLED(CONFIG_ARM64_4K_PAGES) || > + (end - start < PAGES_PER_SECTION * sizeof(struct page))) Indentation should be if (!IS_ENABLED(CONFIG_ARM64_4K_PAGES) || (end - start < PAGES_PER_SECTION * sizeof(struct page))) Acked-by: David Hildenbrand Thanks! -- Cheers, David / dhildenb