From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE6CC7EE2D for ; Thu, 25 May 2023 12:54:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08FBA280004; Thu, 25 May 2023 08:54:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2F3F280002; Thu, 25 May 2023 08:54:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5A4F280004; Thu, 25 May 2023 08:54:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C3812280002 for ; Thu, 25 May 2023 08:54:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8722E409F8 for ; Thu, 25 May 2023 12:54:23 +0000 (UTC) X-FDA: 80828770806.19.7B1E50D Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf15.hostedemail.com (Postfix) with ESMTP id 18772A0014 for ; Thu, 25 May 2023 12:54:20 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685019261; a=rsa-sha256; cv=none; b=mon1WXKYuBVsEhP6JDz1KtHQChXK6kyvFMEBDw9x5ndpt3dRRW484+tDhMNjpyIyV14vmC UpZtEFwyXPEcLCCSWSEyCwwJhjg0ukfkN+1oXsnjM1A4jVxHDE91zTTk5oh31IUeAcfDsc ikhi7Mu09Q4J8D5A2wFe8hVYsLRqZ88= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685019261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SdT5R3m9rZCokN9uO6H95AhoqA+livNaJXRoPZKNaD8=; b=VPCo0UbUoxt3ToqvvBHSxmNlx+wUTzwXZ16WaFPlY8WhFTTCBd4MJ9RpfFuNme5AFQ35ZF LGSnVn84iiARRrcELMDSRG7b4WW+DsN9+LaNuOkmziCqfQZVzlElMQENoOC7gjpM5odajb Wt9Hdtpkj4LotWqQ4+eZNSihJnjwZ8Q= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R781e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VjSMoYJ_1685019255; Received: from localhost(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VjSMoYJ_1685019255) by smtp.aliyun-inc.com; Thu, 25 May 2023 20:54:16 +0800 From: Baolin Wang To: akpm@linux-foundation.org Cc: mgorman@techsingularity.net, vbabka@suse.cz, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] mm: compaction: add trace event for fast freepages isolation Date: Thu, 25 May 2023 20:54:00 +0800 Message-Id: <78d2932d0160d122c15372aceb3f2c45460a17fc.1685018752.git.baolin.wang@linux.alibaba.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 18772A0014 X-Stat-Signature: jor7dn63513dcc9zaopb1zfiu85j1hzz X-HE-Tag: 1685019260-668650 X-HE-Meta: U2FsdGVkX1/lFTD16Js5RL4dbaSLDKymg8i5CE/0RLdsYrLEEcX8F0KW3sA5cqrNeC/OayW9/7o35j0zerSF1zHIFGDzsW/6plUxvnYXHNcvQpTLWngxzVJkVE7X/q3b+jacBs3YiDNK1QyNuFpdyT73Cwd8j4Ktmrwb//JO1jofQYMY9qT83z6wCTMgAmFuoCg++T23bzHjmX9CxgnhuE8IWtrS/sMm5UhsqAY/ir9V/tXJlL4qYkWXYaHD4jSeG8axPA3EjVBUJYtp/fb9u57zA42aZKVaFjT4pZbisuX8R7V6qH6Eac0urRksbYryuMQNCmlTm8wjDNSHI7qO4UO0jUMZSsOF2DWmRTQfDfRTFPblXzOvbKiCUW16wTIp9JIqnDJIzEjayelYg7q//DEua9ktSQcjC8jsJ+mE8TwsLtAubj0ZVBJT+IZcvnl3t2Ni5gXu/OqJPqxJQoAWjpSv7HbWJepEEa8E/NFIvL3+QwZ7uN7Q4gWYbHyfKjmgfaJsq6JX3Jf4Q8kzgX0gHKswnzeVoECrnXLm3bpZhyzYBxSlfvPvYfySnFNZRvaNhzuAqqE4BbNtu9C2CMDSi/dAmucyGuumqNDFDaDoXg5KDJHAR7vO8XCTt3E8Npn/qbQsVfy5K35U8IvF3i+B//fF5l3z8FZlnWxgSH1cpP3rPwn8miE/h4xx3Z9B80foee9qrq8DMBX2DQbzfzAe50axpF90OKhOAI+wF7iuCCDKI52ogtKnSd89RppQRC+wXTJI7kQfQZurPsskVmkDAAuCEEuG6VrbPegWGKflD8RoKc/Dv3nRVCfuie+suo5vYMvA28uWM5gQAoMc/F+0cP+ZpvKrKyaTXQEmDkEw6JSdu0S11tM4saFOm8zxiiOR/ZZJMNsqFqcvqFIWplzQakDnsCPPN9H1axB5Mdsj/K+Bc9lx8u0Ye/CUlK1iWylIj02hax4hZ3chMRsS2z2 nV3wC5bc G90yyKNzNGPlphMkCbAHzAh+TDDyTvyxGM7q7sU1z6KIWhvAFBk/OvLMNlpEfwRnSiufyCtavmLm3Zn5wznIgyAR6Ow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The fast_isolate_freepages() can also isolate freepages, but we can not know the fast isolation efficiency to understand the fast isolation pressure. So add a trace event to show some numbers to help to understand the efficiency for fast freepages isolation. Signed-off-by: Baolin Wang --- include/trace/events/compaction.h | 11 +++++++++++ mm/compaction.c | 6 +++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h index 3313eb83c117..2b2a975efd20 100644 --- a/include/trace/events/compaction.h +++ b/include/trace/events/compaction.h @@ -64,6 +64,17 @@ DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_isolate_freepages, TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken) ); +DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_fast_isolate_freepages, + + TP_PROTO( + unsigned long start_pfn, + unsigned long end_pfn, + unsigned long nr_scanned, + unsigned long nr_taken), + + TP_ARGS(start_pfn, end_pfn, nr_scanned, nr_taken) +); + #ifdef CONFIG_COMPACTION TRACE_EVENT(mm_compaction_migratepages, diff --git a/mm/compaction.c b/mm/compaction.c index 65d8d9223acc..eccec84dae82 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1438,7 +1438,7 @@ static int next_search_order(struct compact_control *cc, int order) static void fast_isolate_freepages(struct compact_control *cc) { unsigned int limit = max(1U, freelist_scan_limit(cc) >> 1); - unsigned int nr_scanned = 0; + unsigned int nr_scanned = 0, total_isolated = 0; unsigned long low_pfn, min_pfn, highest = 0; unsigned long nr_isolated = 0; unsigned long distance; @@ -1537,6 +1537,7 @@ static void fast_isolate_freepages(struct compact_control *cc) set_page_private(page, order); nr_isolated = 1 << order; nr_scanned += nr_isolated - 1; + total_isolated += nr_isolated; cc->nr_freepages += nr_isolated; list_add_tail(&page->lru, &cc->freepages); count_compact_events(COMPACTISOLATED, nr_isolated); @@ -1557,6 +1558,9 @@ static void fast_isolate_freepages(struct compact_control *cc) limit = max(1U, limit >> 1); } + trace_mm_compaction_fast_isolate_freepages(min_pfn, cc->free_pfn, + nr_scanned, total_isolated); + if (!page) { cc->fast_search_fail++; if (scan_start) { -- 2.27.0