From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDE5C54E58 for ; Tue, 12 Mar 2024 13:17:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA5536B024C; Tue, 12 Mar 2024 09:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C55166B024D; Tue, 12 Mar 2024 09:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACE9B6B024E; Tue, 12 Mar 2024 09:17:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 9D4786B024C for ; Tue, 12 Mar 2024 09:17:10 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2E45C160634 for ; Tue, 12 Mar 2024 13:17:10 +0000 (UTC) X-FDA: 81888437820.24.A866458 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 11F9880018 for ; Tue, 12 Mar 2024 13:17:06 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xb+uS07y; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710249427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SBqhUy8gNKwpVUuDOXHAAg+jQI/tHffAOqWXKvmnq8s=; b=5+0u06qZ64f0mK+5EtxqTywWEdbGKiq0etFcH0JzGzuL2yV7S36Rzj/5jzQyncq2SzU8Df tQFFAzEpG6bGCpoLAGXxMDInOqmShnzVhqOmyb7xDfQ7GazLdtSOb8C2OrrvnK6zTT2B+4 X0mNTQJZM7jyaKcushwy6669/wMXHwY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710249427; a=rsa-sha256; cv=none; b=6VGommL+oEP0zMrnTlcK/FkDLfkxjygk3hb33MI6LCoEN4fwp7TpF5ODfBnwZNRi57tNOQ Nli8XgkA4vVeo76qRpG7GbFR8rsFCT0CrfAWJTxQ8tkkWr5DvNW1skFzAqOtD07RjGD/NW FkSeIZao+E7bd66Xdi+3xFCqGMc0sKU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Xb+uS07y; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710249426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SBqhUy8gNKwpVUuDOXHAAg+jQI/tHffAOqWXKvmnq8s=; b=Xb+uS07yBa+Uvi0I6tMdhj1B7yhUWDBChXTtuk3rNd+xdXXO/HFPCOaWAjpbis+Lh567p2 AePo3XbBeRt+5zv3B/rGxzriSCR5O6HbPfdeXOOgdvrIqm244m10RQxTsIqtPbs9os+LDH TfHvbC4DXFidPOyFnoXa3Xg5kiORDAo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-450-yCyQZlCzPWiM142qxynmpA-1; Tue, 12 Mar 2024 09:17:04 -0400 X-MC-Unique: yCyQZlCzPWiM142qxynmpA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41332121e2dso4931905e9.2 for ; Tue, 12 Mar 2024 06:17:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710249423; x=1710854223; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SBqhUy8gNKwpVUuDOXHAAg+jQI/tHffAOqWXKvmnq8s=; b=D34tgvEmMQx2AONeXS6QkpfuYyn7TNcthoukbIfHDeT0DKCd6hTwRd+EFfRR9VtKNY vLFtHd10Dx5WjWuIzQ+pdHNyBSKt5acEftbChImsjSdI0VSWWM+SmwdGubD5bDz87PuB ezFH8nshRk1F2EbkhNRpExg4CQSmV8MWAQjtF5Cz6qfyL+mqh+O6ust9RllAJqfwCjPO DWvWoEQm665V4UJBeGpfEsTDKL5/8VAoEmm2tiGNq902EAPEREiZ8GmOM7RGcSRwxwjP SjeNDq2qKk+HfQfK9fevpiybrpE8hvKT31l3pc9mHddMsIGHD+tW1YOogXW5zgwazcq+ B4qg== X-Gm-Message-State: AOJu0Ywbi8s7znWZ2GhFPcYA8mo/FEbdMDYMJcjI+5qumVjssimpt2ph vOmQXMwPzdq9EeF4Oe5b+K/LFJrvLVMZiyXm2uF4PWUxQQeGsicHHN9DAz7xueiN4YI2QXK4+WT WYva+oKs/9y7vT2OeWjnF8FV8XBGg1L93HV9REpMVAq+sObAb X-Received: by 2002:a05:600c:3111:b0:413:160a:8112 with SMTP id g17-20020a05600c311100b00413160a8112mr7788294wmo.34.1710249423412; Tue, 12 Mar 2024 06:17:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyG7wWiZBxrx18MZomVBKuU73UvWtZYxTgiFS/JhviW+XE6uawM9YQV/ecVKhkutVw8V5a8Q== X-Received: by 2002:a05:600c:3111:b0:413:160a:8112 with SMTP id g17-20020a05600c311100b00413160a8112mr7788270wmo.34.1710249422924; Tue, 12 Mar 2024 06:17:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4f00:a44a:5ad6:765a:635? (p200300cbc7074f00a44a5ad6765a0635.dip0.t-ipconnect.de. [2003:cb:c707:4f00:a44a:5ad6:765a:635]) by smtp.gmail.com with ESMTPSA id o4-20020a05600c510400b00412cbe4f41bsm19404674wms.4.2024.03.12.06.17.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 06:17:02 -0700 (PDT) Message-ID: <78d1e235-b055-48ce-a987-e8719163caf7@redhat.com> Date: Tue, 12 Mar 2024 14:17:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Always initialise folio->_deferred_list To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240312035017.516865-1-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240312035017.516865-1-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 11F9880018 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: xrg5ezcwz6aesntwf7agsajfr7npuxyf X-HE-Tag: 1710249426-630279 X-HE-Meta: U2FsdGVkX18+lo0HTPaCXc0TL+YaskPaX5vXvJ+DkL9h3bfJlyGSSX7H+LK0SsXQhLYEKjz0RRaefnh6Tvb8aZHeHDOsRlKmi+f/Cd2R0d0UWsMKcv6C9O1Zhl16zILONeP/wkgyBz5tQ5IezjOWjzmF8aZuLYueFt/KFMzVE3cgor893Xti9REY/WwwWvGg1+bBZi7h3ieAzWVy2+oLnMxT8TUNfDPKmSFlABLEaD/QcAw8H5dKy61XrZYEFhfy/KXDyByPhdTZW2gX5hvU7opupuCCekTHVmbJPYg+9rz7WUA+xtvVcF+s70vVm/QmVD8WomAy205nglXvkj10rhLhzBMOAdza5pmazr0ruhU4yRflCl6A8R3c+qgacLgmcCWwtOe1SfYQ8/tmLHAOBSmFhVWnvFm1SFun3KEUaX7rHF9uu7Bt+eg6tjR6c/SWVws9jDDLRRQk3VZO7H5EFSp/6EZR8Ati7WJDH2OWMLK055DRL4T8KrYiyapE4VcHHCN83ZGZRC7uPuc3dt0ckEBShLWBB4ad6qHOXRyUwB7o66C5Tog3dpqmW16k3ENcq66MXhYDYHcQD54tjfwp3qizgIiFBECTeoa0PN9TbXk46Euha71DHhlKv5xhlyN4Oc68SRJIc2USAV0NkpMCXhTjMrDfl0Hr3rD5jZc/9gCL7I0cMypR08fKGApfyLsqYwmiV7pGyFZugad5QLiusUU6eH+xxgZHNuvrUkgxdK1Po2vOC8/me2o/gCB5fnb4K1M39AsrqhxjwOc4LNsGX9J/PqWTpR7EwMmvVtrCc4h8qo60A6Qw49fhq6KALRjZuD6tA+9zoFfaY8CWweZ+HKkYXhZ9H3Cgmkg73oh/SAols5dJfpVLaORtl2lqGLN/h5KgAzLs599ffeylf2wQo7wn2Xgv6BFPZdGENVXTaMtXlSgoNxSYKAr/ny9OXpqMeZAusVl4sSNuuvjiwOo sbW/f8Z2 ezZXo45HFW40mlKFdhcN61Ep6lUplAvvSqpfms69tyJuuSAwLD13v+p2Mi7uPuR20gEIDqw3a2RvebtNZu/ogb6LxAbjFh0E7qQVyxVn0JIjFhoupbtY0aDRSB9BqkxxRtGiTalYRvWK0nVUJ5oYa9nMdWADUXKBySfJ3agBgbLbyusOxtxx9A80er67/4SZnBTPQn2KwSroBjul4uX3ted43vA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.03.24 04:50, Matthew Wilcox (Oracle) wrote: > For compound pages which are at least order-2 (and hence have a > deferred_list), initialise it and then we can check at free that the > page is not part of a deferred list. We recently found this useful to > rule out a source of corruption. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/huge_memory.c | 2 -- > mm/internal.h | 2 ++ > mm/memcontrol.c | 2 ++ > mm/page_alloc.c | 9 +++++---- > 4 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 9859aa4f7553..04fb994a7b0b 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -792,8 +792,6 @@ void folio_prep_large_rmappable(struct folio *folio) > { > if (!folio || !folio_test_large(folio)) > return; > - if (folio_order(folio) > 1) > - INIT_LIST_HEAD(&folio->_deferred_list); > folio_set_large_rmappable(folio); > } > > diff --git a/mm/internal.h b/mm/internal.h > index 7e486f2c502c..10895ec52546 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -525,6 +525,8 @@ static inline void prep_compound_head(struct page *page, unsigned int order) > atomic_set(&folio->_entire_mapcount, -1); > atomic_set(&folio->_nr_pages_mapped, 0); > atomic_set(&folio->_pincount, 0); > + if (order > 1) > + INIT_LIST_HEAD(&folio->_deferred_list); > } > > static inline void prep_compound_tail(struct page *head, int tail_idx) > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 138bcfa18234..e2334c4ee550 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -7483,6 +7483,8 @@ static void uncharge_folio(struct folio *folio, struct uncharge_gather *ug) > struct obj_cgroup *objcg; > > VM_BUG_ON_FOLIO(folio_test_lru(folio), folio); > + VM_BUG_ON_FOLIO(folio_order(folio) > 1 && > + !list_empty(&folio->_deferred_list), folio); > > /* > * Nobody should be changing or seriously looking at > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 62240014a498..8374ba9b6249 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1006,10 +1006,11 @@ static int free_tail_page_prepare(struct page *head_page, struct page *page) > } > break; > case 2: > - /* > - * the second tail page: ->mapping is > - * deferred_list.next -- ignore value. > - */ > + /* the second tail page: deferred_list overlaps ->mapping */ > + if (unlikely(!list_empty(&folio->_deferred_list))) { > + bad_page(page, "on deferred list"); > + goto out; > + } IIRC, hugetlb might overwrite this with _hugetlb_subpool? Isn't that a problem we have to handle? -- Cheers, David / dhildenb