From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B6A3C433EF for ; Thu, 14 Jul 2022 10:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB6089401A1; Thu, 14 Jul 2022 06:38:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6633940134; Thu, 14 Jul 2022 06:38:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2D8D9401A1; Thu, 14 Jul 2022 06:38:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A1518940134 for ; Thu, 14 Jul 2022 06:38:07 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6E79821390 for ; Thu, 14 Jul 2022 10:38:07 +0000 (UTC) X-FDA: 79685355414.19.A988083 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 136C5C006F for ; Thu, 14 Jul 2022 10:38:06 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id l23so2650113ejr.5 for ; Thu, 14 Jul 2022 03:38:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Da9JEC7sUGHY+kW86al+MlF51R6SUQjf24M49G8OwHc=; b=Isuq/1wYooZH6BO+IB2xH/kNqgXgun32tM7cxOGn/4aLx7rrXD7Fj1cs3t0LF1YaV+ qXpIh9aHLUSV53PoYEbnJiQODneoIHgD92DlWgEL2QWSroHPeBwOaPtea9AwfD035Ofn o3M0pSwX4HSbG3TEqF9mi6yaN2bmsPw6gVIgSaN90CJic4A15RAWpYyxPTpJ4Mfa7pRM w2rCfaqhAumOMHgfS54ziXMc/N7YF0v/ok2HHhpUMdG6AMscLGH26ZJ2amjdk+q2xeKt bjRpyvHN23eNYfXAfkk4JhhVwkgjJBC/xEgZwy/C4GbLedLtROm7i/catTfIcJI4bGht 8nFA== X-Gm-Message-State: AJIora+jKyi+OvTBESyoCHj71fzrRlVykKtTd3NiG9Xep5QuAXb/A+nz 2TqT4hT+M9tHVaAs5jw1k3U= X-Google-Smtp-Source: AGRyM1tylAikhT0jp8xuKYehbTcWTlzDur0ynRLeAdWpAL3ujadz/4Hz4YTv5mkPVzYlKcYDne9mDA== X-Received: by 2002:a17:907:2815:b0:72b:70f6:4ced with SMTP id eb21-20020a170907281500b0072b70f64cedmr7883051ejc.353.1657795085810; Thu, 14 Jul 2022 03:38:05 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::70f? ([2a0b:e7c0:0:107::70f]) by smtp.gmail.com with ESMTPSA id ey6-20020a0564022a0600b00431962fe5d4sm805026edb.77.2022.07.14.03.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 03:38:04 -0700 (PDT) Message-ID: <78cd3375-e95e-51b2-bf89-bad645e16ea4@kernel.org> Date: Thu, 14 Jul 2022 12:38:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2] can: slcan: do not sleep with a spin lock held Content-Language: en-US To: Dario Binacchi , linux-kernel@vger.kernel.org Cc: lkp@lists.01.org, Jeroen Hofstee , lkp@intel.com, kernel test robot , Richard Palethorpe , Linux Memory Management List , ltp@lists.linux.it, "David S. Miller" , Eric Dumazet , Greg Kroah-Hartman , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Sebastian Andrzej Siewior , Vincent Mailhol , Wolfgang Grandegger , linux-can@vger.kernel.org, netdev@vger.kernel.org References: <20220713154458.253076-1-dario.binacchi@amarulasolutions.com> From: Jiri Slaby In-Reply-To: <20220713154458.253076-1-dario.binacchi@amarulasolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657795087; a=rsa-sha256; cv=none; b=TmmezTawQl96BswA0FlDXGYLvYvBGL/MyhNNiPOU7ENUvIgTkawi0454NZLXcvGlIfIA28 +quifobXrpiEwH57fLJ2JxLcYvqI1GVgGn6WlHCHEgNcQPeGy90Ag3NkYBxYtuy1488/P1 RpxtKb0lCOAKM6S3TQAYUt7LeGrA0Ys= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=jirislaby@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657795087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Da9JEC7sUGHY+kW86al+MlF51R6SUQjf24M49G8OwHc=; b=dILtrFa14qPtJRiOhHasFZ5ksFfxG8ZExxJQfw7JRRt4NGw6SETrsfUh3g0FdiCHFCTMKX ezL3CAf+ZkVJeJnUK2h+Q0TkkL2Dk8MRAO8vJgecDKGaVt0sAJKIk5pHpNWr9f0KJUj4DE t1jySzkNl+L3ohldkwqM0rfDnk4Om0o= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 136C5C006F Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none); spf=pass (imf22.hostedemail.com: domain of jirislaby@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=jirislaby@gmail.com X-Stat-Signature: k4eq8admjtfpj8g6p89dajqnjhfyphmm X-Rspam-User: X-HE-Tag: 1657795086-321724 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13. 07. 22, 17:44, Dario Binacchi wrote: > We can't call close_candev() with a spin lock held, so release the lock > before calling it. > > Fixes: c4e54b063f42f ("can: slcan: use CAN network device driver API") > Reported-by: kernel test robot > Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/ > Signed-off-by: Dario Binacchi > > --- > > Changes in v2: > - Release the lock just before calling the close_candev(). > > drivers/net/can/slcan/slcan-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/slcan/slcan-core.c b/drivers/net/can/slcan/slcan-core.c > index 54d29a410ad5..5214421dedf3 100644 > --- a/drivers/net/can/slcan/slcan-core.c > +++ b/drivers/net/can/slcan/slcan-core.c > @@ -689,6 +689,7 @@ static int slc_close(struct net_device *dev) > clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags); > } > netif_stop_queue(dev); > + spin_unlock_bh(&sl->lock); > close_candev(dev); > sl->can.state = CAN_STATE_STOPPED; > if (sl->can.bittiming.bitrate == CAN_BITRATE_UNKNOWN) > @@ -696,7 +697,6 @@ static int slc_close(struct net_device *dev) > > sl->rcount = 0; > sl->xleft = 0; So all these sets need not be under the spinlock? If so, you should explain why in the commit message. > - spin_unlock_bh(&sl->lock); > > return 0; > } thanks, -- js suse labs