From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E79ECAAD8 for ; Wed, 14 Sep 2022 10:26:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 417E68D0002; Wed, 14 Sep 2022 06:26:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C8098D0001; Wed, 14 Sep 2022 06:26:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28F188D0002; Wed, 14 Sep 2022 06:26:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 177528D0001 for ; Wed, 14 Sep 2022 06:26:42 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D949BAAE5C for ; Wed, 14 Sep 2022 10:26:41 +0000 (UTC) X-FDA: 79910312202.25.274E240 Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by imf17.hostedemail.com (Postfix) with ESMTP id 6B81840098 for ; Wed, 14 Sep 2022 10:26:41 +0000 (UTC) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663151199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lj2gDBWDxhbWfpJ3F2DuTG5OBZRpUdCDuERum2ovK+M=; b=hi3QMYUHfOuFXdjn7Jj90aA+Gc8WFyhf8nuRHV+74HB/tNyT3LV3i6+Gsw71o0FMvw094B T46x39QgtouHs46DDXcMBrAcRHg9wi2LiZQUdlakIHuX64XxSOjOKKY4Xa6GzOcMOD5ovV nK9SK1GTc5h9GFctTL9sFh5S1a3jFDo= Date: Wed, 14 Sep 2022 10:26:38 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <78c7cd3900e0a33da514be8799b35f9f@linux.dev> Subject: Re: [PATCH] mm/damon: fix missing damon_del_region() To: "SeongJae Park" Cc: akpm@linux-foundation.org, sieberf@amazon.com, shakeelb@google.com, foersleo@amazon.de, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20220914095206.70459-1-sj@kernel.org> References: <20220914095206.70459-1-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663151201; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lj2gDBWDxhbWfpJ3F2DuTG5OBZRpUdCDuERum2ovK+M=; b=ta/yFMl3MypDieltE1+zJWHGd6GYhpPatqNA9IpBvWmrJHcg4lN9GrgzTGMygyZXLt1DT9 bcU5Oz++wM+ggCy/LM5w4DvuLUsNncFsPWHPMmSKz6ubt8698ovSt7APpgXUp3OhNUPf4L rhkohnyxEIloZ4OKE3rHkXFykM5UqJs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hi3QMYUH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of yajun.deng@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663151201; a=rsa-sha256; cv=none; b=LLtY0nVbB6MrNSXD6cQJgymkaXY5LpmRn5vGm3i04Z8HPW4exni8L4SSz8MYgaDNFJaqUB zNAejzFZY6BznoPVZVczey/D/aRXJ/cTJ+mz/m8uKRn0mqv3tEJe2jQzUtAGo1gRyV2hLU wKH+LIebgdgrGY9385QYCyJ9bt/7U9M= Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=hi3QMYUH; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of yajun.deng@linux.dev designates 188.165.223.204 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev X-Stat-Signature: 1f76hst57n693c19cwr78ne1qiddom3w X-Rspamd-Queue-Id: 6B81840098 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1663151201-386754 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: September 14, 2022 5:52 PM, "SeongJae Park" wrote:=0A=0A>= Hi Yajun,=0A> =0A> On Wed, 14 Sep 2022 17:36:36 +0800 Yajun Deng wrote:=0A> =0A>> It should be called damon_del_region() b= efore free each region, so use=0A>> damon_destroy_region() instead of dam= on_free_region().=0A> =0A> What 'damon_del_region()' does is deleting the= region from target's regions=0A> linked list so that nobody references i= t later after its freed. However, as=0A> each region is linked to one tar= get, and as we will free the target here, the=0A> list will also be freed= . Therefore, we don't need to worry about future=0A> references to the re= gion.=0A> =0A> Anything I'm missing?=0A> =0AOK, got it.=0A=0A> Thanks,=0A= > SJ=0A> =0A>> Fixes: f23b8eee1871 (mm/damon/core: implement region-based= sampling)=0A>> Signed-off-by: Yajun Deng =0A>> ---= =0A>> mm/damon/core.c | 2 +-=0A>> 1 file changed, 1 insertion(+), 1 delet= ion(-)=0A>> =0A>> diff --git a/mm/damon/core.c b/mm/damon/core.c=0A>> ind= ex 0b1eb945c68a..e62e7ebf4b12 100644=0A>> --- a/mm/damon/core.c=0A>> +++ = b/mm/damon/core.c=0A>> @@ -361,7 +361,7 @@ void damon_free_target(struct = damon_target *t)=0A>> struct damon_region *r, *next;=0A>> =0A>> damon_for= _each_region_safe(r, next, t)=0A>> - damon_free_region(r);=0A>> + damon_d= estroy_region(r, t);=0A>> kfree(t);=0A>> }=0A>> =0A>> --=0A>> 2.25.1