From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E93C77B75 for ; Tue, 16 May 2023 23:19:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8895C900004; Tue, 16 May 2023 19:19:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81258900003; Tue, 16 May 2023 19:19:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B238900004; Tue, 16 May 2023 19:19:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E68F900003 for ; Tue, 16 May 2023 19:19:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1F5EC40141 for ; Tue, 16 May 2023 23:19:02 +0000 (UTC) X-FDA: 80797685724.11.14B6CC3 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf27.hostedemail.com (Postfix) with ESMTP id D0C5D40009 for ; Tue, 16 May 2023 23:18:59 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=edbVTnyq; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684279140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6VevJ1vGUj20/tD3Yj2GGzM81HOY6lYpsXDwoLyRLgo=; b=MCmuLGtfOoXZGdFHrwJPJI8ZLulrZmmr8zxXZ6TVQSXIXIniN1sJUbSGilO9TbxYrsEtNQ EqZXpmhklracnfcqlZFRX3zRiVuZGA8hWWdt5GJgyYtFM3QPoXv49ZC7eKDjPaMFxq15eZ /dNLuuI0vk8CNLfRd48ARqBKFM6qGE0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684279140; a=rsa-sha256; cv=none; b=rEXrGlurKSiJNXd2XqFi66PCcn85VWK2/ZInyJdDrdUrLzcF5tiVLBWOZwHrrxbFnyRt+K tvFLmid1v0krv5pB+J5XD8qZLe/04O1jV6+macbZj0N5aZUN7uYNrm1lY1Z3ApgGswP6r5 KPeSejN8f4NJ3GXB2OcwD+IdBPaInfs= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=edbVTnyq; spf=pass (imf27.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.100 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684279139; x=1715815139; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aTTXi21fx3EQBbKsXrlszRhCxMf11Htc3j/PZEduJLo=; b=edbVTnyq/5YCUIrxdUEDP4/cBRejTQ7ifuWJlwr97d5QOJyQfgMXbo8f adF+EpCfqiSlnnmRWtaOtm7GdY110iOCoigeZKLsAkgjNDlElzZBIDXcp 7VIoq00sHTid0U2Ww0bUkk4E7fDAG8HrvsuBhe12Ik5c8h/X4BdMxX9l5 CZ9yUaSGnxmPZqtIcOvZbXtNqiMWxIOxfW62XyJeRIQyMPR+BVUi2HIie 1zy7Z4oVvkZtF4jEyrshYBRM36XvYXw73XS2fzlpjhYMqiAUhG/p6wJ5t 8TX+S1fqo79HcFLUovmKVk9KyiQv15WpxmSKW0P0gpWOBQrEvMhgK8T8i w==; X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="417270308" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="417270308" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 16:18:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10712"; a="791257808" X-IronPort-AV: E=Sophos;i="5.99,280,1677571200"; d="scan'208";a="791257808" Received: from mtpanu-mobl1.amr.corp.intel.com (HELO [10.212.203.6]) ([10.212.203.6]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 16:18:57 -0700 Message-ID: <78bb0097-7dca-254f-45a6-5cea6baec0c4@intel.com> Date: Tue, 16 May 2023 16:18:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 3/6] PKEY: Apply PKEY_ENFORCE_API to mprotect Content-Language: en-US To: jeffxu@chromium.org, luto@kernel.org, jorgelo@chromium.org, keescook@chromium.org, groeck@chromium.org, jannh@google.com, sroettger@google.com Cc: akpm@linux-foundation.org, jeffxu@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org References: <20230515130553.2311248-1-jeffxu@chromium.org> <20230515130553.2311248-4-jeffxu@chromium.org> From: Dave Hansen In-Reply-To: <20230515130553.2311248-4-jeffxu@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D0C5D40009 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: zfac14da1f8kdk5i8czmbrkc3ts1ctm9 X-HE-Tag: 1684279139-775889 X-HE-Meta: U2FsdGVkX1+kfbkJ+KyMCImzRAe1p/Lz0eiRPmGQgQnes6/iSi2RJreAywNTOfVztthanIo2H3zvmSxXlmdGe+yIpvOiAaNzLVwrkcdMB9UvuVczh60PJebqrd3b3/NEHqXUHzohhjaRak7zCjp7vpQt1YH95je+gF+Jc0w7J2no1Fc/qbM4u1xt+lJfxgP/4p4jqKwv6QmRfkRBmmphtAN5KwgUb3G9aopVkioYkPXg8DFzI0RYMHe4qAU5Crt44kByfKWxlJUXnk9aPal/mHwB1wvYPUvkpQuKQI3zIbcqDgqePKETf8e7d3UakvxtPuebfg201TaEFJO7KcW/OL4LmjB/6suxMnaoL/pacp46nrFgxpoo1XxRUQL7e6ofccO0gxQDISXz0aOE6Yv271FIb1fbfS8A1Lf3AVuwU9T+MiJBiCvdnnFJTNQejaquhVNHYDxysLZoOV2agx+BvhS3jOs8eKv342l16JY+6gQsfKt2HzOWRNL0o9Z26L53NsFpPgTfl1vi6lDIm3k7Lizz6tDo7qSglqR140E1Au51IcXRtWUev+n25YvlvlI/YuDVak7KMCozT4942OR85xCkmsFZYtcVI2AIH8rgS1mhf0InswEWlgWyyIjKaFPkVSb4PYmf7D2P6m/mmDNMkrFo7cFrPt/5zMkpKbHuCvZPzhCArXT/oPBPi9N18/2YQinjEsys9jZuRck0uVG98X75afmJNKvFmIOPFDFoSWlkYaEqeFQtWje4xocmzZoEMAhszKanbDR0hWsFyyBmBwkFQSlgee2ClMKDyUq68OOs4RtJ5ipdVboNSjrg6WP+Zw3/7lA/8WGb/VfmSEo3dmec15Cquizuwv5V37baljZ5D6Q56dDpwTKxehseCXy49yESvbCw2oky9UK8drfDJZH701M0ZwmOmsjuPcMBw5DzdO6tBhhaHIPtLhTpjw5WbnVKaqf/6hUQ/qUykdn 2W06jJ9z lSDNSMkw8Cr8LlhkM2HyeVfIlmN/9Xs3RnR/6PlrXJcIZFfkdKwSAaSo3sG1gwgArxOsbIXqTVMPwt22uioQa+q3DzSks4iYlXIN26DFxieKZYdmuwrpxrBUJE1BimpTw65fh0iiaBcU7L6wQQjtzMnaXLXjk4zaFe1BnZIrGKNyF7SdeFOqy0esSp3j4EZPq0IQUZTrZRhrtmZ21i7jBxfpmr8bPwHaorMEaNddASNHlgVIeQ8vqqvy3qV5RC9/WQC+r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/15/23 06:05, jeffxu@chromium.org wrote: > /* > * pkey==-1 when doing a legacy mprotect() > + * syscall==true if this is called by syscall from userspace. > + * Note: this is always true for now, added as a reminder in case that > + * do_mprotect_pkey is called directly by kernel in the future. > + * Also it is consistent with __do_munmap(). > */ > static int do_mprotect_pkey(unsigned long start, size_t len, > - unsigned long prot, int pkey) > + unsigned long prot, int pkey, bool syscall) > { The 'syscall' seems kinda silly (and a bit confusing). It's easy to check if the caller is a kthread or has a current->mm==NULL. If you *really* want a warning, I'd check for those rather than plumb a apparently unused argument in here. BTW, this warning is one of those things that will probably cause some amount of angst. I'd move it to the end of the series or just axe it completely.