From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3957C6FD1D for ; Tue, 4 Apr 2023 13:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4973E6B0071; Tue, 4 Apr 2023 09:48:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 447696B0072; Tue, 4 Apr 2023 09:48:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E7986B0074; Tue, 4 Apr 2023 09:48:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B9716B0071 for ; Tue, 4 Apr 2023 09:48:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D47711C6D7F for ; Tue, 4 Apr 2023 13:48:07 +0000 (UTC) X-FDA: 80643837414.20.7E5C1EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 948D2C0014 for ; Tue, 4 Apr 2023 13:48:05 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ArHeF70/"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680616085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zsTIZUaOt4/p51daq2PZX1n16o1nkazviHKpSzXwqxo=; b=zQLC+c5JNDjR69wB2lTRwqy/rOJoE6/E3MEMD7k/N6VsRA7/O1h9RQTkr4HEG7O0bYYS+c UU53fYrOkhhoQneiFKB0Ny1gJhPAsYQaZu1fx620eNRJKRFHwlAfO/nBCblEAWMP860xk2 PSQ7cyrHn/lXOxPY9LtphHOfGOQPILs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="ArHeF70/"; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680616085; a=rsa-sha256; cv=none; b=l3zg46f+dmLkFXc046pXgXnehj2V3z4BXj+G4ysFuUJ7Kt6LR9QdsxKKr7jeppDMQdCGFG 8yhl5S5vBmoXaCPIfjFjB+yfhcnUmzZfxmd2IIR+Q2OuxgHz0YVmcs1P8300EZRWEcGcZC /S3CrF/GjRwFt4F7nsukbGKyJA/NmnU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680616084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zsTIZUaOt4/p51daq2PZX1n16o1nkazviHKpSzXwqxo=; b=ArHeF70/hRk2CF/NkNwJhUWtTFgN/xrNP1xI9/O4iDpUFTs66FPCYWfd3DrEmMh+I6tAbd WvBiPjaCPXghfR+HXSg6eZRnmJkhBjLSmeqGBmnIOkCq2AQaJ6Ss4v4hBN2LZs1Zz4UP69 4ohj/3+nx0RAfMynf/M/iLXNhr7rbmg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-8k2kOcxAM8G8k5YJ7oW-Kw-1; Tue, 04 Apr 2023 09:48:01 -0400 X-MC-Unique: 8k2kOcxAM8G8k5YJ7oW-Kw-1 Received: by mail-wm1-f72.google.com with SMTP id ay37-20020a05600c1e2500b003ee69edec16so17828705wmb.5 for ; Tue, 04 Apr 2023 06:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680616079; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zsTIZUaOt4/p51daq2PZX1n16o1nkazviHKpSzXwqxo=; b=5WJwXFMTJmOBuNLEUB1hiyDm7jc22e/ZaoJ3uguHgouv2q2f6o86d9aM9hmJy/b4Ca JNQPIrjeiP4prfy6gA7T38Fh4fZ4cUN+XLKjxjPWXI1lq1RJ3yaG5kR7VuNuoEsZc4xx 09zL8lHdSwfx5Sbn/8Nsng4TwXxinf1+jBebU4+eh8kUghhooblrfX6xPF6zEocUG9zK q/NZXYZWCs6R/UEtKe2FIr34+EWOC7OvbaUN+qdlOOBWvhdTM5pQMGC3sHiUs56kXQXt SQgK/lCtMSyFtaX/bvn4WsrKt+XbBiFw6cmQHGz8i71m5UZlSNLCl7qCJ3y+yD4uYaGf gJZw== X-Gm-Message-State: AAQBX9eOWUT04S6w3RtpIER7tBF9l7j+d5aTBi5268OZevkR02G7V69K T63U+tVys1G4O58F+nYxwJlF4EcYckdHqjlVqgJPWGU7CyVdW9sAJnOEP4EudFEY8GgjD/GiTS9 ZENk3GvFYGDg= X-Received: by 2002:a5d:4d11:0:b0:2ce:9819:1c1e with SMTP id z17-20020a5d4d11000000b002ce98191c1emr1783357wrt.30.1680616079626; Tue, 04 Apr 2023 06:47:59 -0700 (PDT) X-Google-Smtp-Source: AKy350bmtLhdkOTL49G5hyyIR/dGwEI3AOPEAjf+veEKXRQyea3PV+FawQK0/io3jdVH76JN5ImpWw== X-Received: by 2002:a5d:4d11:0:b0:2ce:9819:1c1e with SMTP id z17-20020a5d4d11000000b002ce98191c1emr1783320wrt.30.1680616079268; Tue, 04 Apr 2023 06:47:59 -0700 (PDT) Received: from ?IPV6:2003:cb:c709:b600:e63:6c3b:7b5d:f439? (p200300cbc709b6000e636c3b7b5df439.dip0.t-ipconnect.de. [2003:cb:c709:b600:e63:6c3b:7b5d:f439]) by smtp.gmail.com with ESMTPSA id d7-20020adfe2c7000000b002d419f661d6sm12391832wrj.82.2023.04.04.06.47.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:47:58 -0700 (PDT) Message-ID: <78a31392-8f9b-9705-918a-24edb650f395@redhat.com> Date: Tue, 4 Apr 2023 15:47:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/3] arch: Introduce ARCH_HAS_CPUMASK_BITS To: Yair Podemsky , linux@armlinux.org.uk, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, will@kernel.org, aneesh.kumar@linux.ibm.com, akpm@linux-foundation.org, peterz@infradead.org, arnd@arndb.de, keescook@chromium.org, paulmck@kernel.org, jpoimboe@kernel.org, samitolvanen@google.com, frederic@kernel.org, ardb@kernel.org, juerg.haefliger@canonical.com, rmk+kernel@armlinux.org.uk, geert+renesas@glider.be, tony@atomide.com, linus.walleij@linaro.org, sebastian.reichel@collabora.com, nick.hawkins@hpe.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, mtosatti@redhat.com, vschneid@redhat.com, dhildenb@redhat.com Cc: alougovs@redhat.com References: <20230404134224.137038-1-ypodemsk@redhat.com> <20230404134224.137038-2-ypodemsk@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230404134224.137038-2-ypodemsk@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 948D2C0014 X-Stat-Signature: ajujqd34t4s3x6t4n1e8wpxpuqzeowdg X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680616085-400328 X-HE-Meta: U2FsdGVkX18fQrw6Bm2HsRwbIQHjcK/Zp2pHeby14G8ianzSjj9Pst1Qy5MOGsa1aByFx68l0x+UHG/P9cRFr/gbHB/7c8QWa4hN05YcvntceErVCnFQE7V2PozpZm4FHIkRuZb+cVgE5CO93fUew4avyi62Gc3voNX21265nu6v/B7LDvoKimE7VkrCHqkv5el7j1KMOCe8rrH8PHLC5R+WbIdECJJhFqq5vSMFnQ1lOpcNnvzUbvoJy/ASErbnzhQviXsvELvxkweaVFSViNSYLdGlHo4UpsjfeBatM2KnC3n481asCwtvQsRNgsnoC6+/RnfqVbtsN0jw4yGf6lmte8wDFSx7yPwASX0B2EzbkMa/TG9GLUmdVyNkrvk738OCHOItI0Fh8VeoH96TYO4U7a2bG5uYh/nnpnf8f5B8sds/L1vE1sfgmNSsaj1MRSV2KFBR0ynTmvmCBhovnH3+pEuKTOVfHSJFPIu3kiDFhJwwktglp44E82SSjrZ0O3hbQ9T8TBFqWu/85LE6LF+2isG2VEOyKZ0zH+4vQy1dvscOvTfNG7YRnDCJKU9lwWRxS1i+WUGBYxWeVbqHkHUBKB7MmiToFSOPv7P9v0Ckhsh1FGwiV/fKPKvb/4FRtirLr7McsJ1IVwMxJKy0Cb/iZ4qrEkkCQFirn2ceIw6c5CA9cvFBJkmqGdA+hczEnG648mpol1Ck9iBtRvbstPETvj+KmwCkSWEpdG10MYKZJuaszfEVLv8+sjKTmWR8RUvf7avPCzUzSXvUsUJ6YS+RL0xBzzekvl7pRm4w4CL/sPedukVkCZAIzTFlM0/49v9P25KOy2e6vh940BE34T78PJAKfoYRbWmNBtdt946eHLhdy90xHzMR34UPNvGoH1Nn5qsLY6lwdoGVfKbjsQLjYLGOxidtt1pqRfkZThUqCV0fYX5G9zFD6NZyz0UQB0OZjzJ3bLxHGrmYy4Z jjL4RA4o uj9BZ8H4dbewOhY8/ETJOTYkUL51gP3mIJPCVGZsTGhoumNY42C6iDZYV3JqtFWulIam5lZJx1kHhEGud335G1gRs3T+ylmhAlwlnBRBgpnxHT5mRST9jLUskXsxhmJfRtrSxMvocHMCgqCmxNwSdAGncpDtUJTydWBJEP39RhU3ZzyXoivR/2LQZIn69DhnbQUjefsgoyMP2AHxBH3Zf1hUw3rzBGDKPsMAjzxNc4gIW7gmNZf2bvl8a3KPlXENyoiI1PdgoM3DkbCTl/2S5EZkEgQmHpd6IBNXpdSNsf7hqkTPPVx4rT4VkKIcDNHnaUu9aTrAJXNlm908/gkAVD9xWQNXXuy4JmUuZFywwO/0p8+3H3ZrarALOZrNAP9K/QH13/RtRfGJ0G2Y1KUiewuRTfQJ2GxM2HriqQBkKQMG3lA+j8Jji6II9Uw7dQPOyOTD+17llHliafzI9ieQI5QNuHhc9p36ufEQV0HVlPm75X3ZPs3RGxp6sRHtaYBpsvEofETqTvsYBmc1R3Cs3QngTVIx+vz8jK5Lhr4D3YUND7H+1OaL7Vq2p3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.04.23 15:42, Yair Podemsky wrote: > Some architectures set and maintain the mm_cpumask bits when loading > or removing process from cpu. > This Kconfig will mark those to allow different behavior between > kernels that maintain the mm_cpumask and those that do not. > I was wondering if we should do something along the lines of: diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 0722859c3647..1f5c15d8e8ed 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -767,11 +767,13 @@ struct mm_struct { #endif /* CONFIG_LRU_GEN */ } __randomize_layout; +#ifdef CONFIG_MM_CPUMASK /* * The mm_cpumask needs to be at the end of mm_struct, because it * is dynamically sized based on nr_cpu_ids. */ unsigned long cpu_bitmap[]; +#endif }; But that would, of course, require additional changes to make it compile. What concerns me a bit is that we have in mm/rmap.c a mm_cpumask() usage. But it's glued to CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH ... shaky. At least if we would properly fence it, there would be no accidental abuse anymore. > Signed-off-by: Yair Podemsky > --- > arch/Kconfig | 8 ++++++++ > arch/arm/Kconfig | 1 + > arch/powerpc/Kconfig | 1 + > arch/s390/Kconfig | 1 + > arch/sparc/Kconfig | 1 + > arch/x86/Kconfig | 1 + As Valentin says, there are other architectures that do the same. -- Thanks, David / dhildenb