From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A117E77179 for ; Fri, 6 Dec 2024 17:08:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 761046B01FF; Fri, 6 Dec 2024 12:08:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 711526B0200; Fri, 6 Dec 2024 12:08:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563946B0202; Fri, 6 Dec 2024 12:08:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 382B06B01FF for ; Fri, 6 Dec 2024 12:08:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B49F343307 for ; Fri, 6 Dec 2024 17:08:32 +0000 (UTC) X-FDA: 82865166846.17.9889360 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2067.outbound.protection.outlook.com [40.107.243.67]) by imf18.hostedemail.com (Postfix) with ESMTP id 3227C1C001E for ; Fri, 6 Dec 2024 17:08:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ef00w610; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.67 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733504902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dzqv1zbEGTToad85Zam20Nqs8nVBCpjtlUKJnR0g34U=; b=q4J4/fxHXO0dxZJGeOxF33ZeZ7/t+CkMWWyD30NbOXGnESkx1M/OLNV87Wf/5OGimEr/rJ DYbFWO+Ajkuoq4TUgfa0I6eTWL32SOAizSy8PGclJ6eJvGvTuMeEgYk3qf/OuQFMYhAf1y 9o5zkU1MI7ubrjqlUkn6ZjwJB51MSSw= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1733504902; a=rsa-sha256; cv=pass; b=TeGRvc5woQrrtsGQ6SxtwoW9h7m37wRvi+Mxlc9MT4Qz4v59U+YySkB1QL/e0bG3N5xF1u PTmjxmYBICoeVpj2rVyPK5OM7BMlo6VapifOhA0gn/Bs593Fy0yP9XB9LfnemxlSPt0zOb PQgnlEz+I83kxA0CNy9eVkYkqodPF5U= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ef00w610; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.107.243.67 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=T8dgXghDFe7QIZ+R1WWpMewV93Uiw6aXslttKJjmypypajEmXXX8scCWG8v7fxSJEccjJU4PoO5Ep644dypgoqAQP3w/0sorRZTTLPnh5SMfXItM5AZ39xxfjfzfExRJtInrtOS0kTiIP7EHB20IQ8kL6b/j9b7q1tqA9zsM8f8bubfnK+6c7whc0BAsvKx7UKgExIiLy0/oCKNqzBwUBtHuv+kS+0c0DJrL3AJwoZaVQNBRrnv75ZNjKdoGlIzcy+BqMDdDr5RCoGDZZEhpzbRGh/KOuQ5C6Zqd+lVi9SEUHCZ2JdcTr1IkjKId6lIYFB6DnIziWvYe74o87RTOZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dzqv1zbEGTToad85Zam20Nqs8nVBCpjtlUKJnR0g34U=; b=fbuznfZezBABvHadpybproSqQNnYC6wIi9QLpWSSXODP+DGPyHekhqnKnnxLjWh/cKR3zDDWy9HLX6t2CvidGiShICHRG1jpJLiefxsHNUkQv0wjGLyeQblLIp/BeBN0pqb87FT29OdhhVaoZRbotGuXpxaeZIXG0vrcHVAeiIGK4ijQuMMz7EyxkJXSb15538CBBmjBZRClNAUIIhnzkrZuuzaBmxXHdDhiMJZLhPPRMwsLExuayAD3FdulHrOO0N0UwL1yInh90Yom60YuYMxec4b04AxQ6gRsWJ6cmXwfPcsizTfDu0Y+NRnfsIuSRSol+TOmEtju4IVKRU5nyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dzqv1zbEGTToad85Zam20Nqs8nVBCpjtlUKJnR0g34U=; b=ef00w6105NqvNBAbSSZGAcjVdPtRrdbUnaVkE7VhgE+ju/oafWpwO+yhS0crYCoJjNkVhUQh1dw6WBr7rshbfOpfLdJiy36+XX9jAKPfR/egggASk3U+WuTUtYRNK4NyDHSgHnd9Lsbs9Z9JSskyoZHdrJ4u23pv8jo0ruuNcxIy5pw45Tru9fVrKRBkOsU8HIbVdU+etOe+Ir6iG0V9hOtktTPXg1ILHvhsAyXQiIMq4moMbXDMxIrB7tA8zvjugWMGp+GYKmAJBAkmGBqlShOjqJlYSGcLcQN3FPgWPzcY2AxcXvYbdG2XCLjsnQ3Cxp9YGIup6NMALkIf8NJAGQ== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SJ1PR12MB6123.namprd12.prod.outlook.com (2603:10b6:a03:45a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.11; Fri, 6 Dec 2024 17:08:23 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%3]) with mapi id 15.20.8230.010; Fri, 6 Dec 2024 17:08:23 +0000 From: Zi Yan To: Matthew Wilcox Cc: linux-mm@kvack.org, Andrew Morton , Geert Uytterhoeven , Vlastimil Babka , David Hildenbrand , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , Ryan Roberts , Alexander Potapenko , Kees Cook , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Vineet Gupta , Mathieu Desnoyers Subject: Re: [PATCH] mm: use clear_user_(high)page() for arch with special user folio handling Date: Fri, 06 Dec 2024 12:08:21 -0500 X-Mailer: MailMate (1.14r6065) Message-ID: <78D4C1B5-3EE7-47F0-A7A2-F1ACFE71CED0@nvidia.com> In-Reply-To: References: <20241206141938.2750393-1-ziy@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: BL1PR13CA0371.namprd13.prod.outlook.com (2603:10b6:208:2c0::16) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SJ1PR12MB6123:EE_ X-MS-Office365-Filtering-Correlation-Id: 082fe65c-5ce5-4d7a-c0ac-08dd16189799 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tLOgD9eKOWmPvVV0mDz7AUoCrzvv6TQmmPyY9fW4/xnHcoUHnGiPO8ays7I9?= =?us-ascii?Q?WZSN5QLamiYEXRSzVgAos65d+HSOsB8JW3GtpiEdOk/21/nv1xEH72yFvInd?= =?us-ascii?Q?fHCb9y/zAqHOGMhy+sPzcWGPtq+p428OHI0XslXBL6IZMvRzI/foLYVjEDlA?= =?us-ascii?Q?uA/KKLOnZPfYitwsuYXeBMOo+dOhuFeRpcbGN7NrFNi98VQOcOoiJRfYE+e2?= =?us-ascii?Q?OEELdhoCf1siiDpqaPAG+44w3xLwupOCR4NtWSam4Wl4IJbbAqk5u6uGdqBu?= =?us-ascii?Q?IsdADR+/+7Q6KwCiHwnx4g8PQyED+guAT1QuAZyomfmLaLVR8b2rty4DJzje?= =?us-ascii?Q?9GI9lxWmDj3hAign047eoWIpkaypXU/2s8W2q+OD3vb94L8x9UVumGBcOree?= =?us-ascii?Q?ewn3vs+QkAkHOp45uBBR0ksbfpZPOoJwl0Nxc3A9oSQsB5DJrlgJy0XPgBr6?= =?us-ascii?Q?rory0x1v/3TdNP30ZhYt2FY9Ft3byf4C/TeAzQzLgG9ron1zh7MRz7FFsqU7?= =?us-ascii?Q?+zR8dxXQB60xAzG1WamBrctQEozsuDNMpOg6JYFouNFCHE62QRT8V4ocCna9?= =?us-ascii?Q?mT5XCQP7ZhKHwt9dBsMFVnc32aRtXyed95YewgpPo805qijsT65PN/ztyAcg?= =?us-ascii?Q?K02AsFJy9/q11y795mr3bVbEBRkD+uTwMfO+nJXSXZUYTglZpffQNSNo/nCE?= =?us-ascii?Q?AYaFCaSOs7BsNmHiBhZfoF/+sETpXt+yH5ybR5LZ/FCzm0pR8CPo+w5zKldE?= =?us-ascii?Q?9L06L/ZmlHjtHjcG1XRHFzmqBqNNWBSP/wWYb8IUl0lh60UlT9/9FQ0neXAO?= =?us-ascii?Q?/2xbaa4L0qFevT8XxQB3Xk5iDqLQZcDSQmWipYY1Gxvcn0N1dGoAy4Nsr4W/?= =?us-ascii?Q?U2MR5EFzR3ea9FAGazQOR9Lw/3eAjzCeCZR1MHsIxIH5FQDrgk2qMaualTBr?= =?us-ascii?Q?l8i/hVgxx/f04c3WOiJIaXkG3gqD6xCbbD0X2NVH+mOD0QrE+ZC4He/V1VSx?= =?us-ascii?Q?NdC0oxBj3lUMLrHPeALNNc+ZRpBvostPSpcgMP77SzIHsEncTmOX16TgZnAO?= =?us-ascii?Q?boY4NOvSBYiO93qoxyW2SaBrmeAN5SCu1VVybYVtQGM5x8GR+bvzUoqo3wGo?= =?us-ascii?Q?K6+p7kXjmpSBgY567IZkYk3ia+GSi4XmRWTQopnr+vAXHaddJnpO2ewBBHd3?= =?us-ascii?Q?0RgIkX3MIc+5A5M8gZ2JpjCgSadOB31M2+xqVDUIs1r3ybCnZsaO5nDdsg9h?= =?us-ascii?Q?v/jKxA0U+UxviYw0fFDtr8Lk+QEviHFLPXyYiBQLhgbDTfG0mnF4mPzwtP7W?= =?us-ascii?Q?kpQcECY8d6LOf/G+dgcP7EWQVVssYylszISQHiyaalenEA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IZDPsvGyHjCACyK3qoTrPTOJo7rDJZSJEn7g64app7s39J8qj3gZ2p5dVWYU?= =?us-ascii?Q?1p3vajQoi/dQbkh3/L1z1Tj/pp+IcB3KefWvfV2pWK3tmtVUtBW+hxd00Qdx?= =?us-ascii?Q?bnZLLQGL+GTcTi9glBQHwis51IaXjRLFbiY1xe+5EzgvcyOAHVXzpfFF4AUB?= =?us-ascii?Q?UN7VaYP7H/umCvT4ZkyEinRuvoyTDuSULeytHmYx4qowWGGk4737XA7ShW57?= =?us-ascii?Q?yqbfVwSYj5z/8W2j4sq27WBCk9T5if7yonGQ0wT3moSFSXxhAn4HS2udKdbS?= =?us-ascii?Q?VItWt2sN1tNCrs5DhQTZqOQFvHeqgiz72StCvRXgwu7bFPlaJe514I+Q0/ud?= =?us-ascii?Q?uz4BfzJUtMIJpvqUDBO5lZlLl0i5nchbPp9c7ZqELe/kGKuO9+AhmoxfG4ao?= =?us-ascii?Q?s3BvwyO2BXe/C2yEDPWUbA8b2EkbowWACDPjiiM4C7Ha8O5FU0OLa+rncBkM?= =?us-ascii?Q?SeQHrVCrBm2CH9kiGR3YL+TWAXN4GuWDCme3CXBpPChminehchNKVjAWyS4R?= =?us-ascii?Q?JpC8sjiZa0VEeh9R2/biL4Km/QNGqzDmoXXoSc33KH+tFr7IrHdvMxZG0emy?= =?us-ascii?Q?diVe6Fxg2q0T+vavpjUgNmh2izbBa15mFbdr9vmkEWnmDKrEsqDwfazzthkC?= =?us-ascii?Q?bZDhHy71Jn2T/rnZ9FcKDXxe/G+/sK+vKf1YVdVeUHmLQ/svQu4A+IHYoftc?= =?us-ascii?Q?XdNVcNrsYCkrplbBEOfa766S9eJUPWb3okMPpK19kkkwkPCE/giOhS9x2qjq?= =?us-ascii?Q?sDZB95KHY6jE9hfsKKx+mwns0LXQvOPzvlITy7T+YIzxPVWFkVAh/TPLF4px?= =?us-ascii?Q?1cGNWE3z4hp2PiwAUQElSQ7cnABQHmeLHqtknGKdBPBB1oeUWXuFs3lVsX7H?= =?us-ascii?Q?kM5xqt5JJZ4yOLax9eBgD9CLAuq5Z/7eMRy6qphvzwz5J/JUcKrf9GV8ztpM?= =?us-ascii?Q?YDzkGdctu0kcxpbQQrOcs0yAlFFO4hGuOeuFJCdb18VgD+JTkRVTRs0t4m5H?= =?us-ascii?Q?FnrgLhGCZGFE00VPigVgGK3udMbfg1AIC6mOQ5yf600TvbmOrVRx6dYRKzsd?= =?us-ascii?Q?oJpyhX7fa/jhX5cjkg4K+NIa3cb5xLlL+I+p/XwKwd1OjKR0nGRsnEpI0PF8?= =?us-ascii?Q?Y98qfUJr4l4UcMvB+7wYNQouFfA+DOtFH11rYs7mlfQ8G38+d2m0mXZzeJsd?= =?us-ascii?Q?YpDTvLx0Xzi1vYAUvqtkeblGd3ofYNsWbkW4wx8rWEtbTeZ57Wdob0wnuwLT?= =?us-ascii?Q?sZs+wuTzJfYjewiOMV/L0LqkYEjh9shSxFxQd1uZL75qIrvDyDYA11nZ4V14?= =?us-ascii?Q?DMAkuK9tW5q4p61PQfa64cJXYZHCzZCz3RJFfcZN8fUzo78y76Me8nP2qO9b?= =?us-ascii?Q?cc1KjUsQVSbtEtMcumEvGX+yLFOTH/4balA9u6PMpvESOlUdCjW5ry39qBvq?= =?us-ascii?Q?N9wJS8HFM/HIN0kKaMirU0FkitamS7MJGk4eg9RPkijRBgEUon7oJAQvLROb?= =?us-ascii?Q?QgD5P7AaOr/XvMk3FI2iwuL9xAv3sny7GemTBMAOnRWKAER9KpjGB4A8nPQC?= =?us-ascii?Q?zIxfUWt2YDSbd5/7TYTC/eiqOlOvI6OaTjpP+K1R?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 082fe65c-5ce5-4d7a-c0ac-08dd16189799 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2024 17:08:23.5919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w3nCMz3KNen/YCikIO2fQDiOTUW25gYXtr/kDRHP5t+bid6jNgw5xrBNnV4CDgU9 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6123 X-Stat-Signature: a8utrr5k67ot4kianhyafmd7pqt4s1az X-Rspamd-Queue-Id: 3227C1C001E X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733504901-557180 X-HE-Meta: U2FsdGVkX1+/0NMUAsl1DsNTy23E9ziIKkFIS43Wjydx7cF9HabCrJNexYX2GGL4ZtMe92pjU98M1/tkKReTa1eC7oQkgVu1Z7VK7EofbpLeHvs8ED6rAcgqP1mkao/oW1C+qgmB+Usyijnme9xL7AKgdNABMH859f8kYHcBAoAybzVcGGn1ZyZ1DC+NVi6ry33Onf0wEsbchu/dzNWCEwJH4bv/C+iXl5VHDcP6R8C//tuB/FJ5AvEuyKSfr1OAmRAWd8IQtaatA5xUc6Sd1yVptCjFqdwcPEHKnWiuyfpOSQgKt63lABIE8Voe/9qsIcfK4+tKxXVk9sI4NfzgbdR57O+aKm/WtB5BK+XdSfQpxOBxT94wKhFKck2OGfR946C0ZwJWjfh/opIuQJ+7cjrEVihISmq8MAmbnjY7i4ha8eAXVr8UFNYfqUpiSKc+JyB46dNA+SACNpqPISo2XxmSe00cqWJ9PWIx2fi5aDWOt4r7zebVO5k6s55Dx+mDhZlGyZV1XIJo4V27SVpZDTYkaPaJgu95SdjuHUnuq6H4SoE6fE8/FffD0Q5UwT4JR5494F4jSh3kB8CYbUqhShdqj84FBDY9UkXp1SWnh9SMCdWuZlNOoX9udSi7Qsf8h1VxCdA7q/Fs/kZvbG3dmPAUelvnh3CuBu9ydasIftEBRJphNps71nvLtH12y+Ff3sZbv8618wJE9k9A7mpib2LKFeMqBn4xSQqWE6i279VWxIIdSkn5YVTPnCzGp28qs/aBPQKNrEo5j5j7o0BfnGtL1RxVODqbPsRZkbWh4ku646zHtejYbEkv5G+FvZYOA0b+KfoEMNijVQ23cTOThamTTrtPDwUwD2nPZKJs+eGr9kja7OA/CbRgHRIAQEjO4tWyD6wiTx0qps3ZocSpxyoeVyRIT25eoBUGXYUCVlLtnTOq8jCJ7FXB1mdPx4hdquGd8Aa4OQESY5Ppbka UN4iM+Ey OeykKOP+3Hui/Ax29g1DSlj88aQiGRiWjyNOedeqZu7HX3Uql7dsP/68K6hWqH0S9QrtD4CcKSU67cIUbLseEhur6n9XK9yuD1R9/Pq3X56FyEjkRlx1Lcu5mHDCxpkHSzxI2GYx8LXhl0VD8pmYHmr0B8X8xvwVVyreM5FcE81IMxf9cFhKn6A1thCYA1x1BBHIER3aVYGvEEEzgvZSmzwTvrRgwyCR3SumzRAlkcE0kdV+90yfEOGKqiT325FEUcrSmSkmM6jDEsTSdsIriVVlXS2OTJ2mQYUDidD7f3tEo2AlP2253o09rv+d+lFbvgsFhrq5guVIzCHoR6Uv6hSFK5t/jRgheKIhVSRSUiWXpobH4pc1J+/HWxyFL5Gx+27c5T3HrXHqNvtWJYBYPiCoYVA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6 Dec 2024, at 11:42, Matthew Wilcox wrote: > On Fri, Dec 06, 2024 at 09:19:38AM -0500, Zi Yan wrote: >> For architectures setting ARCH_HAS_CPU_CACHE_ALIASING, which requires >> flushing cache and arc, which sets folio->flags after clearing a user >> folio > > I think arc just has some legacy code left that needs to be ripped out. > See commit d5272aaa8257 which took away ARCH_HAS_CPU_CACHE_ALIASING > from arc. The PG_dc_clean bit seems not to be related to cache aliasing. See commit eacd0e950dc2 ("ARC: [mm] Lazy D-cache flush (non aliasing VIPT)") > > Looking at 8690bbcf3b70, I wonder if you want to use > cpu_dcache_is_aliasing() here? Yeah, this is more precise. Will use this in my next version. Thanks. Best Regards, Yan, Zi