From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F502C433FE for ; Sat, 12 Nov 2022 19:37:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D72016B0071; Sat, 12 Nov 2022 14:37:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D22016B0072; Sat, 12 Nov 2022 14:37:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE9E96B0074; Sat, 12 Nov 2022 14:37:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ABD3D6B0071 for ; Sat, 12 Nov 2022 14:37:16 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7F6DA12024D for ; Sat, 12 Nov 2022 19:37:16 +0000 (UTC) X-FDA: 80125798872.12.C4AA0E1 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 1F03820002 for ; Sat, 12 Nov 2022 19:37:15 +0000 (UTC) Received: by mail-pg1-f177.google.com with SMTP id f3so564221pgc.2 for ; Sat, 12 Nov 2022 11:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ae3zsNTUGJCSO95ziRPGHoXWUiriLhIsXToU81lFzec=; b=AKbzuKalV3IzX2rlsXBtV2YfOD/Zq9vUY6C0ty/N0dZLheQXK6aBNGDkG8s9yu8br4 8KRlLV8b6dpwfYJcse1QORVqYRGXLs2ku8Xyfd3l5J9G3pudZkrKvOpfZnLVPM/yUjkP +J8WdiSi3+pW2nFkRdWwegQY1BO+t4uVrscNzcR+A+J4sgFtnIrhQTmxqW59ucuA/zUm xoBpIFaAv2W2Yt4ca8LzoV9TZLnIX5nPWCSXGBqZzVxHbgLyNtys2oB+P4/VZFZqWXK8 9rHs/3DcAf2fqiqTFbbnU4Z/UqnWX9yZN8+fw+YUVdCOZhKHDeMI//3HXqpBbNnEJ4Z+ h6Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ae3zsNTUGJCSO95ziRPGHoXWUiriLhIsXToU81lFzec=; b=Xcsudq8ClH6KVekDSponNlf9hNDKnBn/vrxNvwIAnc4mmT9AOyAJ+gZqm3bi6XcKjU ox/UfxhFmxuK0+850H46DEGE/X7rRNhtS+6JMC5nIuHsrGnwU322wArXDo+IcaGR2G78 +xpQCeI5p9hV2fcuLNwtUO4ypwiin6VOPz0BuMJPO9IBM8Do8tc9lUie4oHDjs49zebn x2Bd1LFerz5W/OACKxFTCQY+acy7ch7oFu33+w+Ox/IDlKTsy3tc01OCqZSNGRAdQSB1 EcGafu9rPJ84C/GhaCRpX/edR6i0OMCpeqncOJP6XkdJXhUkVyja6I8Rt/XuU+uKKAg3 2e/Q== X-Gm-Message-State: ANoB5pkmShiDuKJ9Iycu3Ac+1dKCCxX1u3vBO/nlaScFe43kQeHvUPlK vjIpRBvXlMfXroEemeEWfiI= X-Google-Smtp-Source: AA0mqf49agb8/jSJ2tSsNf/2WFj/LzlSgMWbaBmjVj8g5Nfo1PoD3jy+j5u+8yeTR5HF05NPHVQBAg== X-Received: by 2002:a05:6a00:3011:b0:563:5e0a:97e8 with SMTP id ay17-20020a056a00301100b005635e0a97e8mr7856945pfb.75.1668281834694; Sat, 12 Nov 2022 11:37:14 -0800 (PST) Received: from smtpclient.apple (c-24-6-216-183.hsd1.ca.comcast.net. [24.6.216.183]) by smtp.gmail.com with ESMTPSA id g22-20020a63e616000000b0047679467c78sm141177pgh.57.2022.11.12.11.37.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2022 11:37:14 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [PATCH v9 0/3] fix hugetlb MADV_DONTNEED vma_lock handling From: Nadav Amit In-Reply-To: <20221111232628.290160-1-mike.kravetz@oracle.com> Date: Sat, 12 Nov 2022 11:37:12 -0800 Cc: Linux-MM , kernel list , Naoya Horiguchi , David Hildenbrand , Axel Rasmussen , Mina Almasry , Peter Xu , Rik van Riel , Vlastimil Babka , Matthew Wilcox , Andrew Morton Content-Transfer-Encoding: quoted-printable Message-Id: <78B2DE9B-C9D5-4E3F-8328-427590C5A610@gmail.com> References: <20221111232628.290160-1-mike.kravetz@oracle.com> To: Mike Kravetz X-Mailer: Apple Mail (2.3696.120.41.1.1) ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AKbzuKal; spf=pass (imf03.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668281836; a=rsa-sha256; cv=none; b=hbltJADcUoAnmxagMnqEPB4w3VqII53xwEr6FoKjB7qohGm8EbSxXqm3I4siIvmgeLsIl2 +350dBWJbaIUENmiT4+hYq7qXzhIQHYYXyP9o3Kaxsa3z9W2kLmP+MaCfmHO5fD5+smkbE ReX6z68yE9LCi/rYP3ZrmX45p7jNenU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668281836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ae3zsNTUGJCSO95ziRPGHoXWUiriLhIsXToU81lFzec=; b=I0Jp7K+HEr//H2LFGNOEpm6oaFCsSM4jV6DMJ0l6g+GmEEUZAG21NfXiRJ7f0kOedXJ74+ X2qX+G73mpIO+PtV1Awl/mvMqwKRuRGrSxbP4iZ/wYZ3cGKKLG1qbFXfcGyYpcqvPKY8Ws 3+69nqU2N9F5oQdNgEklQO4JAjRLXpI= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1F03820002 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AKbzuKal; spf=pass (imf03.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: xafp9e38pd9beimn7jss44199xp88jor X-HE-Tag: 1668281835-151664 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Nov 11, 2022, at 3:26 PM, Mike Kravetz = wrote: > This series addresses the issue first reported in [1], and fully > described in patch 3. While exploring solutions to this issue, > related problems with mmu notification calls were discovered. The > first two patches address those issues. >=20 > Previous discussions suggested further cleanup by removing the > routine zap_page_range. This is possible because = zap_page_range_single > is now exported, and all callers of zap_page_range pass ranges = entirely > within a single vma. This work will be done in a later patch so as = not > to distract from this bug fix. >=20 > [1] = https://lore.kernel.org/lkml/CAO4mrfdLMXsao9RF4fUE8-Wfde8xmjsKrTNMNC9wjUb6= JudD0g@mail.gmail.com/ >=20 > Mike Kravetz (3): > madvise: use zap_page_range_single for madvise dontneed > hugetlb: remove duplicate mmu notifications > hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED processing >=20 > include/linux/mm.h | 29 +++++++++++++++++++++-------- > mm/hugetlb.c | 45 +++++++++++++++++++++++++-------------------- > mm/madvise.c | 6 +++--- > mm/memory.c | 25 ++++++++++++------------- > 4 files changed, 61 insertions(+), 44 deletions(-) With my limited knowledge of hugetlbfs, it all looks good. Having said that - 2 random thoughts: 1. It is more intuitive to me to have mmu_notifier_invalidate_range_{start|end}() next to = tlb_{start|end}_vma(). I think that one day these two should have been combined into a single function, which could have also executed adjust_range_if_pmd_sharing_possible() as needed. 2. If you still have a concern of exposing zap_details as you had in the past (not that I care), consider putting zap_details and zap_page_range_single() in mm/internal.h. Thanks, Nadav=