From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C852BCCA479 for ; Wed, 13 Jul 2022 21:21:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF47C940160; Wed, 13 Jul 2022 17:21:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA31D940134; Wed, 13 Jul 2022 17:21:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1D9D940160; Wed, 13 Jul 2022 17:21:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C5A39940134 for ; Wed, 13 Jul 2022 17:21:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 933D733DA2 for ; Wed, 13 Jul 2022 21:21:46 +0000 (UTC) X-FDA: 79683348612.28.C32DBB0 Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf26.hostedemail.com (Postfix) with ESMTP id 040E6140068 for ; Wed, 13 Jul 2022 21:21:45 +0000 (UTC) Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26DICbg7008908; Wed, 13 Jul 2022 14:20:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=J/3MljKjGkniIPnSWaoyz6Ju6TZE3novv3hPxM7i26A=; b=L78E16POIsSX9UP6K/VZ5ugQFdDrhIhQTFTD/TKhF7hOc9uYNgm6tH/t+Fjnf1PF9ma3 LyZoiQgxTuYifzSeM7yUVllmxDaTmAzA9qO23UmHnsEIvWzQTvVkI12k0KK+X/xJ5R8F eC26hhiF8Shhj7j1LfPHomRI6K/9W5oiS54= Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3h9h5f70p4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 14:20:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLszG1xOys8C8yaVhdYkd/5ntBFuRj3r9Sh4E3zpENMyrhOnL9EDiy+855YNs9yChu/MHpxTcavTJ5D5EZwjVF3jKs2gL3+WPlGFh8GCV4reoX6crrcwD1NioknQKDk3aaaA6mvx7kdTB2703/JaRAmwpi281raE41Tn1Zi9MXhxqePfWsmJdTsqCwK9kGOBRjC9JqdfdQMbA/pCjeREyBXRsM+UYRvzRa4riBD+igBRM2GvuKt5cYJKRNznxvU+IvjOGwksRe7/JdNyY2cvdTMQdu8xTaODadHYz8FkmJ/BaHIM0JWahrdwmodgQoZyc0o+PeMMeD/u8OQx6CR/8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/3MljKjGkniIPnSWaoyz6Ju6TZE3novv3hPxM7i26A=; b=oRsnTN40JTssLq0DV1vUvcgFtBDvrp1ap0R9YfogHrv/4lRaHoLyL7MPmCWOfAtk5ZxlVbEPVmzxHHZUa3N2bHw7o4byEvf/78+/4aACRSThKWNkNKdLHhU5XZNVBPa8vqF7tJBNz4KCKgHrzshgm9f37sp5GL4fAe2hHUoslZJbjwOmeCzEPIMR7XdLB7StOriQUEI+kau1li1GVZ8Si6FgxJLuSltUZ1JKZmUApNHDtIqG9S8T2VsoWIMn19to5/GI71j78vIKv4MK8q8DedT1N5Tgkj8Nxp54ZbetoJavr7gfCGwxVghsfF7dV5hsYjn/htfHDdJaA+YhsjYTdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by BY3PR15MB5011.namprd15.prod.outlook.com (2603:10b6:a03:3ca::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 21:20:56 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::5de3:3999:66df:42d1]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::5de3:3999:66df:42d1%4]) with mapi id 15.20.5438.012; Wed, 13 Jul 2022 21:20:56 +0000 From: Song Liu To: Peter Zijlstra CC: Song Liu , bpf , lkml , Linux-MM , "linux-modules@vger.kernel.org" , Luis Chamberlain , Steven Rostedt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Masami Hiramatsu , "naveen.n.rao@linux.ibm.com" , "davem@davemloft.net" , "anil.s.keshavamurthy@intel.com" , "keescook@chromium.org" , "hch@infradead.org" , "dave@stgolabs.net" , "daniel@iogearbox.net" , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Thread-Topic: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Thread-Index: AQHYlpK25UY5kW1ND0S/krM8qG//OK18FxyAgABbw4CAAE2vgIAADyyA Date: Wed, 13 Jul 2022 21:20:55 +0000 Message-ID: <78A18945-0841-4CCE-8A33-6C09ECBFF7E1@fb.com> References: <20220713071846.3286727-1-song@kernel.org> <20220713071846.3286727-2-song@kernel.org> <7C927986-3665-4BD6-A339-D3FE4A71E3D4@fb.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a2342e2-2985-4a20-25f7-08da651592f1 x-ms-traffictypediagnostic: BY3PR15MB5011:EE_ x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fi4jLR4SVQg0bdPQ9YUBNnKO/qpqqqTW6DNnTrnlNwmxgtUOtVLEdkJ2MlU1bgZ4AWtdWi9uQ/cZ/18jJduq82KO/13MT4xF18BxwgV9UHJwxmhGvAdPdsNhi7qVQmfDhmHbp9tmnvtYSv8Ofuf9aRgGisM4o6t7yKidt1ZlT7MiWbYlz9UaMoRWK9b+AnhvD3PnlJHehj07mnm1OAwdmnzQGSiL5vzewj3Jl+qjNnoHRoe5mHUZ8AneVRUPEffH6QcRNRnUhZqKYS5jpcWhD3bXpm0H36kwCBAFJTUJK1gP0SypbfKqn5KaM175MthIm17b3ssjXnUucrjK6z+7eS3FID73XPtHxFT91+4yA5T32LovU+ks1DzXqxXBkSVLJk9IwEmpVbxzTU+J3siwf9/+qUykSdc25ygIdB5zk/qGH3tEg21BfieRJEgravjtpTbUDvnW8N4VGf3nqFqnVaGxPmpfHtrwgGe702KyT+mjlKe1MIqBOYCvPm2ctMVs1hVomHUqYHvDYu2nZ3ezZxMxbWcIRAE8cOKrpZ0DBwjE6dh1klxpKb4V9jZEfd1h6NRk/bT07CAbSwbBIck/cTK0MKi7h/6cCZa56/euzfM9YwbuPvmEklXOw89XLoRvmddxzOItsK6m780UXHA5/f397kwvLxeQiXxGH7T5qGttplf2x3OgfKwyGGHDBZCJW00izqZUSlKgCWl2XuBxC71fMrR3EyKFVo4hfj6KWPvZylXI8nKkh2bOjDBOeQf28jp7L9xRW3V5B1R/GzRgTS5DsJ6reE1gScGRRRYY9JbUMc8t2LyhMHmpkWz++anepwulILAMnVKOgrqRmLbADcPdApOLqtsr8wBLA/hI2xo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(64756008)(76116006)(66556008)(91956017)(66476007)(66446008)(8936002)(66946007)(2906002)(478600001)(4744005)(5660300002)(7416002)(4326008)(36756003)(8676002)(6506007)(54906003)(33656002)(6916009)(71200400001)(41300700001)(186003)(6512007)(86362001)(53546011)(2616005)(122000001)(38100700002)(316002)(6486002)(38070700005)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?h8Y6B+axFnz/xxORosmkN7QShWUmKc5VHuPZuJZ2MSVLn/XcEmYFl8RamI/O?= =?us-ascii?Q?84IVBjGVLsceKUtCCu7mmytiqjNAdFsN32cypIUOtDA7hw62F+s2V7lCEwVF?= =?us-ascii?Q?rGZ8JgMz5TCNdBxz8P4baPXLLYuoxj4cx09culnwPuT35K80LVRdfMrk7bRY?= =?us-ascii?Q?kAQ8hIziH7HO3Iy2zpaygElOH2BtFCrL3rofCwkZ9MamfiJIwF/gZr3c4GxK?= =?us-ascii?Q?aOM+Dm/ewpk4qYYmmjdDOeeIlrM+iVa+OeK0wykTdgU0SLwSdM7rUn6/tfiY?= =?us-ascii?Q?U/3zriPOiu1dpv3Ud9Wd8CAiV1a+mDXT7KtZ6BbWYiXrfaG5FbgJEqxHNa7g?= =?us-ascii?Q?pVKtlduDFzDwHV3g6d4X4Mt2ELL/AyICE7lWDtNIewCFycvZRgcRVLsDgznI?= =?us-ascii?Q?kKp3YWbqG6bnKiq9J68fGneFWW/5CwJn61wCkZfd2gx2LFiHlW9j4r3876cT?= =?us-ascii?Q?86qT3m1SAjj0tI3eIDdFb/hYteoCGSGGwEf9K1jg9wtmOkVt3vTkUKt09qtj?= =?us-ascii?Q?WB+CEjvP1aao+vNoeDaUH3BT2Jla/zc98CZysgMr3SN87CoklDJMrtmutBF0?= =?us-ascii?Q?VE8gK8NRgLQ9W7Kk75dPCRlZY3bAvjgXgSMZjgN+CITLdLYJrjhunHPzTaaN?= =?us-ascii?Q?A6atuFHG0CWGeSLa23qW2XYoWx5j1bi1dra8gY1/V4zM/H3dMVwLjY9AAQG/?= =?us-ascii?Q?uyjpYnvaJAfLHreCIbDkjXWR1CYU+NyMetw2PG9QzbltGpJv1BJDjvWV+PZ0?= =?us-ascii?Q?xXg1Sn4WOgWy84qdpQYsogbVscwZqoRvRRd1VIZwfQu85z9P/O1CW64ZZE9n?= =?us-ascii?Q?RjoDLkeEztW876zRyt+mb54xqHq62qu3h/DVbQAvhcqLS6frVvuZgQAPjKwU?= =?us-ascii?Q?7ioYCFSzMHYO2MdBVvNHv4v0i0icaoIUzSyJFOcMlCweUhQlyM3hAfTbixYX?= =?us-ascii?Q?3rvFioQMSAQAyZrhwbj1Ei1sUDf8dkBUcr02OzbNARhN2p+Kb1jRY7O2s3Jf?= =?us-ascii?Q?uWKD7UC4TILzaEJO6NNQyqIeKngmIwpoumza2KwIxHCaA/nrfQQvIxB6tGYs?= =?us-ascii?Q?j8P6RYagNyTmKZEsxa9D2t6wDgcWO9dTpWIVCood3ibi8CQPva1S/ZnVAq4o?= =?us-ascii?Q?C+/BGQyrLVcJOo59xMwrej++qJfaadXN98vxoOnFAarBHvjIOjj+4zDRbu0y?= =?us-ascii?Q?rCZYkEIlzY6QPS49fdaBiokfISntFIZYviibBNJiuwfsX2LaLH+vugIteO+j?= =?us-ascii?Q?TT99owLcJULQSWrO/985HrDgzMb1VMEgKJ6Ewa/hFD2LhL+OA1S3FLnnP8gU?= =?us-ascii?Q?rIWGAGFSI9AR0xd7JdxTetSgv4iacU/6+7IpzTeE5AQJ9epacl1ugoai5vJQ?= =?us-ascii?Q?+keJOn5mhgseweFJ3FOOxpB8YejrsfKKcB5AepRST0L75lPZyWaRkiHBP4lx?= =?us-ascii?Q?Ioas29KxULxQlitMdO4HT9XA/Cqe6qCYW8KUkNdnjq/G2WlD7nCjRz6C7Hv9?= =?us-ascii?Q?geiuRwGf5YAgeYwp1vrkRnqweyLUlvfa3cO9b57P4xLJ6GPflxpcT4aGv1f5?= =?us-ascii?Q?wWctPkxfDDrvCr2YPw9ESf+hNRh9g0qkP+8eVf8ZsS2hOi1eGcKhpPXhwuZp?= =?us-ascii?Q?fyi+YZHykLEdxNHhjWNxtcQ=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: fb.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2342e2-2985-4a20-25f7-08da651592f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 21:20:56.0186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7IJzOdzqmd/mjsk9nwZ72oXf1r++3h0OeaAfRoYDAs+xrfRIkSfjrwL0XJuS9PWprj327/q2SxZgoouRqxIybQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR15MB5011 X-Proofpoint-ORIG-GUID: Iq4d5a0RcFByeK_hZOQhD7uUhJmtIwZV X-Proofpoint-GUID: Iq4d5a0RcFByeK_hZOQhD7uUhJmtIwZV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-13_11,2022-07-13_03,2022-06-22_01 ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1657747306; a=rsa-sha256; cv=pass; b=MeFdSeBaxBZNUy4h15ilfemKGMZIOK99eyMJ13sNnpiNiKOaN/FmpvWLZ45sNvYi6xH6Vl wWi+Y90bJXAb9fHE7PShDnFuAKcg+r39v/2DFAG6yP9bYaAyuL5JMK7altwp7Jo/m9J6BW CBsmUaReYukB8KCBlu7etzMLplxZfTw= ARC-Authentication-Results: i=2; imf26.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=L78E16PO; dmarc=pass (policy=reject) header.from=fb.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf26.hostedemail.com: domain of "prvs=819375f3bc=songliubraving@fb.com" has no SPF policy when checking 67.231.145.42) smtp.mailfrom="prvs=819375f3bc=songliubraving@fb.com" ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657747306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J/3MljKjGkniIPnSWaoyz6Ju6TZE3novv3hPxM7i26A=; b=DK/+Wzq/75u/Tt6DlQdySNQ0M6uBrwnrt147oLk4dcx1zUC+V6IS/wx4J0PwTpS2jgr7cr St4qxDqNiqZ14XLYm52Q+X2DmlyIeFj7SL/SHhbuUroCnH2smRnLvPe7Bp54YkQKej1iQ5 +PLKkkULBLKg6rACrBPn9LDmhtLPoz0= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=L78E16PO; dmarc=pass (policy=reject) header.from=fb.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=none (imf26.hostedemail.com: domain of "prvs=819375f3bc=songliubraving@fb.com" has no SPF policy when checking 67.231.145.42) smtp.mailfrom="prvs=819375f3bc=songliubraving@fb.com" X-Rspam-User: X-Stat-Signature: hikkxuypi7sn7yygs5h4ze4ihbedyif5 X-Rspamd-Queue-Id: 040E6140068 X-Rspamd-Server: rspam08 X-HE-Tag: 1657747305-676834 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jul 13, 2022, at 1:26 PM, Peter Zijlstra wrote: >=20 > On Wed, Jul 13, 2022 at 03:48:35PM +0000, Song Liu wrote: >=20 >>> So how about instead we separate them? Then much of the problem goes >>> away, you don't need to track these 2M chunks at all. >>=20 >> If we manage the memory in < 2MiB granularity, either 4kB or smaller,=20 >> we still need some way to track which parts are being used, no? I mean >> the bitmap. =20 >=20 > I was thinking the vmalloc vmap_area tree could help out there. Interesting. vmap_area tree indeed keeps a lot of useful information.=20 Currently, powerpc supports CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC,=20 which leaves module_alloc just for module text. If this works, we get separation between RO+X and RW memory. What would it take to enable CONFIG_ARCH_WANTS_MODULES_DATA_IN_VMALLOC for x86_64?=20 Thanks, Song