From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: punit.agrawal@arm.com, will.deacon@arm.com, Steven.Price@arm.com,
catalin.marinas@arm.com, mhocko@kernel.org,
mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration
Date: Wed, 3 Oct 2018 12:17:52 +0100 [thread overview]
Message-ID: <789784ee-4830-753b-5d14-f5c7d90622c4@arm.com> (raw)
In-Reply-To: <bad51030-5f02-4fc9-741c-0fffbd690aca@arm.com>
On 03/10/18 12:10, Anshuman Khandual wrote:
>
>
> On 10/03/2018 03:52 PM, Suzuki K Poulose wrote:
>>
>>
>> On 02/10/18 13:56, Anshuman Khandual wrote:
>>>
>>>
>>> On 10/02/2018 06:08 PM, Suzuki K Poulose wrote:
>>>> Hi Anshuman
>>>>
>>>> On 02/10/18 13:15, Anshuman Khandual wrote:
>>>>> Architectures like arm64 have PUD level HugeTLB pages for certain configs
>>>>> (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be
>>>>> enabled for migration. It can be achieved through checking for PUD_SHIFT
>>>>> order based HugeTLB pages during migration.
>>>>>
>>>>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>>>>> ---
>>>>> A A include/linux/hugetlb.h | 3 ++-
>>>>> A A 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
>>>>> index 6b68e34..9c1b77f 100644
>>>>> --- a/include/linux/hugetlb.h
>>>>> +++ b/include/linux/hugetlb.h
>>>>> @@ -483,7 +483,8 @@ static inline bool hugepage_migration_supported(struct hstate *h)
>>>>> A A {
>>>>> A A #ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
>>>>> A A A A A A if ((huge_page_shift(h) == PMD_SHIFT) ||
>>>>> -A A A A A A A (huge_page_shift(h) == PGDIR_SHIFT))
>>>>> +A A A A A A A (huge_page_shift(h) == PUD_SHIFT) ||
>>>>
>>>>
>>>>> +A A A A A A A A A A A (huge_page_shift(h) == PGDIR_SHIFT))
>>>>
>>>> nit: Extra Tab ^^.
>>>
>>> The tab is in there when you apply this patch and all three checks are tab separated
>>> in a newline.
>>
>> Well, with the patch applied, at least I can see 2 tabs for the
>> PUD_SHIFT check and 3 tabs for PGDIR_SHIFT check. Which seems
>> inconsistent. Is it just me (my mail client) ?
>
> I am sorry, you are right. Did not understand your point earlier. Yeah there is
> increasing number of tabs for each new line with a conditional check. Is there
> a problem with this style of indentation ? Though I will be happy to change.
I have been under the idea that all the checks at the same level could
have the same indentation. (i.e, 2 tabs in this case for each). Looks
like there is no rule about it. How about replacing it with a
switch..case ?
Cheers
Suzuki
next prev parent reply other threads:[~2018-10-03 11:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 12:15 [PATCH 0/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 1/4] mm/hugetlb: Enable PUD level huge page migration Anshuman Khandual
2018-10-02 12:38 ` Suzuki K Poulose
2018-10-02 12:56 ` Anshuman Khandual
2018-10-03 10:22 ` Suzuki K Poulose
2018-10-03 11:10 ` Anshuman Khandual
2018-10-03 11:17 ` Suzuki K Poulose [this message]
2018-10-03 11:27 ` Michal Hocko
2018-10-02 12:39 ` Michal Hocko
2018-10-03 2:16 ` Anshuman Khandual
2018-10-03 6:58 ` Michal Hocko
2018-10-03 9:58 ` Anshuman Khandual
2018-10-03 10:59 ` Michal Hocko
2018-10-03 11:37 ` Anshuman Khandual
2018-10-03 11:48 ` Michal Hocko
2018-10-03 13:06 ` Anshuman Khandual
2018-10-03 13:36 ` Michal Hocko
2018-10-05 7:34 ` Anshuman Khandual
2018-10-09 14:14 ` Michal Hocko
2018-10-10 3:09 ` Anshuman Khandual
2018-10-10 9:39 ` Michal Hocko
2018-10-11 3:16 ` Anshuman Khandual
2018-10-02 12:15 ` [PATCH 2/4] mm/hugetlb: Enable arch specific huge page size support for migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 3/4] arm64/mm: Enable HugeTLB migration Anshuman Khandual
2018-10-02 12:15 ` [PATCH 4/4] arm64/mm: Enable HugeTLB migration for contiguous bit HugeTLB pages Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=789784ee-4830-753b-5d14-f5c7d90622c4@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Steven.Price@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=punit.agrawal@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox