From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDDFC64EC4 for ; Fri, 3 Mar 2023 09:05:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F21F46B0072; Fri, 3 Mar 2023 04:05:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EABE06B0073; Fri, 3 Mar 2023 04:05:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4AF16B0074; Fri, 3 Mar 2023 04:05:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C5A5D6B0072 for ; Fri, 3 Mar 2023 04:05:57 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 90DEA1608CC for ; Fri, 3 Mar 2023 09:05:57 +0000 (UTC) X-FDA: 80527004754.09.46CF874 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 183E0120011 for ; Fri, 3 Mar 2023 09:05:54 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hdaKejUO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677834355; a=rsa-sha256; cv=none; b=qR4ry73yxt0OiM7Eiw5uE22NlWKSvGblgbLFLafr22OnV7/M1DKY2OvDWebz9yQ3Ba0ZvV SDFMXQrxAINDxfHwUyeQwfkH19yzzrnI7xERthfBKxoaF6Tezi9m+I28hUkMjx8D1xbDZ9 vBiIG4HXRDzoOFBXX1uidTcxKnGs018= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hdaKejUO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677834355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YS0CjwhYVbsUEzzioDGeRBPspcNXXioriZQMTd1XWIQ=; b=QzVs90tg3jjF5aBnYZLZtxp99b2VdHMrs38EnONJxZrEpshFfHZsu2CgQe65CAtX70TITe z8PARVz4CJKBTAFLCLWoX8L8/MnxEUCRNN7gZQfetAZMkdbFRd0Jv7rRh47JVxA+8fo8ee Q7kNPR+TMwnXT4u5sALff1o0HTFFnhQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677834354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YS0CjwhYVbsUEzzioDGeRBPspcNXXioriZQMTd1XWIQ=; b=hdaKejUOf/CePWfqvGNSh5dM3nu5ICqXF2iZZE01GMMe5eoh1R5v6+NumpPXKuGMRpcTP9 IsTSXSMQhiJQbkcVy6lE1SOo9L1G2Dl91oaS5ebL4yOn/NfdM2Wp7HKotOSLMcITGBlBS3 xm6Dta4pCGdTyYg+L68k2Z73OhkQ2OE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-494-plpJsYt-Mmi-iQHQLCIIBw-1; Fri, 03 Mar 2023 04:05:53 -0500 X-MC-Unique: plpJsYt-Mmi-iQHQLCIIBw-1 Received: by mail-wm1-f69.google.com with SMTP id p22-20020a7bcc96000000b003e2036a1516so2527794wma.7 for ; Fri, 03 Mar 2023 01:05:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YS0CjwhYVbsUEzzioDGeRBPspcNXXioriZQMTd1XWIQ=; b=2/zMp6Zy6q36JFJLMM7ZOUgPrX08aWaJcH2DaKb//jKoDhDl+W54F82HAjpCIrhC64 i5Iw1E7Sj4p6Gs1ew1osKyGMfgAZTBIYFglE4Tv6iJGJ5D7v/NYbK0kQeyXn3ud+Xxvo 1I9nKQHZtolwJ4B5x1KF6pQ+FW+g5yOHYffPx8wK6u/SzfV1Ctr6t9uuCmHYUrbcf9lG gjvRhyuWbPkullEYuezlbTzsrrR1Opj4c4pzo/5chAy3p3OrJDwUSldmY7f7m4Zkv7+j 9MiBJvs/3iDw3yfNsGd9jRJmk7oImEpn4wkxyyPPZXBJboWPB4+My5GOCgGS5f6lepqf mBnw== X-Gm-Message-State: AO0yUKUYqD47lbbOexKHZxQYuwXg+XuUvQPaqpqd1YcHUlxyyRvZbGsj 0bqEK9AXP//xGA2bHYRs6xUkHIubKWJuBCRiQt2/mPvoraW3R+Aycj4JqowVDLFy+UCCQxuiFSE k4dWbmISvcLg= X-Received: by 2002:a05:600c:46d1:b0:3e1:f8af:8772 with SMTP id q17-20020a05600c46d100b003e1f8af8772mr962680wmo.9.1677834352100; Fri, 03 Mar 2023 01:05:52 -0800 (PST) X-Google-Smtp-Source: AK7set8jagMcNMmXQyfHV0dH3kB3yk7ffQXREEni9HXk4xFVSy4fCDC0ZRzxCl37hRsdKx/W7igNWA== X-Received: by 2002:a05:600c:46d1:b0:3e1:f8af:8772 with SMTP id q17-20020a05600c46d100b003e1f8af8772mr962632wmo.9.1677834351710; Fri, 03 Mar 2023 01:05:51 -0800 (PST) Received: from ?IPV6:2003:cb:c702:6100:f5c9:50a5:3310:d8ac? (p200300cbc7026100f5c950a53310d8ac.dip0.t-ipconnect.de. [2003:cb:c702:6100:f5c9:50a5:3310:d8ac]) by smtp.gmail.com with ESMTPSA id o14-20020a5d408e000000b002bfd524255esm1593826wrp.43.2023.03.03.01.05.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Mar 2023 01:05:51 -0800 (PST) Message-ID: <787e7d9a-fcf4-ad5f-97f1-c0e1c1553c2d@redhat.com> Date: Fri, 3 Mar 2023 10:05:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, chriscli@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, michalechner92@googlemail.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20230301190457.1498985-1-surenb@google.com> <31a88065-063a-727e-52fd-9fbc7d17fb5c@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 1/1] mm/nommu: remove unnecessary VMA locking In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 183E0120011 X-Rspamd-Server: rspam01 X-Stat-Signature: 3joenphjebinjy16zbins5tesipt9c14 X-HE-Tag: 1677834354-693692 X-HE-Meta: U2FsdGVkX18b1+8sqbFycyJe41JBLOrX0EtTHY0mVsBazZ0WmWGFjcddCCHUZ3iRLswTidroKkbGnfSZ+wgAa8dQyzIuTxng7dsNYdOOreGwPbCVQkfQem2pSY3bFWZ3F84pD6m7hjgKjGFGZug1Mmizp2qWsKLT4WNEhE7JInM3iAcuK5htWBwxWUFu6VxVqrMb8djFcoF+2+uc5CONaGVflKl/yqQR8RIpQIFZwzrPzol46IDKpEy2e2WCSKXz/1bGF7/aXu3m+YIJOHxIfkFaVgqcN/Zf1HJpUo0i0KjnqnX81npJ6dVRqTVBnLpGzmPdS06MScLysYPLqleWzvTeCKdp82PZOE9l+bXd8iUHRUDAHj4ku1djQTJpLMN75ApZpxOVlAHDOIhJft0NQRFrki95MP70wdzaxDPb5ALqhpBBLsR8xWWY8hYUhNihDmxArGy0rSObJMo3sOZr+dLuT0gs9jc+85MoRh/LHx7kAmrd+IoJuXD1mvtEBV3WeLG/O9xZmGUFak/5qxI5Vc9oJFlS2RNhqU3WUEWmUODyn0QnaMisT2JzPg3LQScQpszLyw7vSaCXesT3VmvZ9eEXPRmRz7Lc/ZKvMeWLc/O5tThIN07sE55OadHWG9nTOGdt/wFrNKc/1O+Li3NezY0u27N3qAsGvyJCBL1TUmQa1Ci+vB+2cmyRoQCtZKk/Qy9/sm8cJhocHJNC9b/aExK3QlCo+vfzlzoM3UnfJ5Cz4nNW0w7XLk5SsoT4izwzXk9ns82aXC3fkiZasZu0H5VyBv0GcntBhvzAbd056fxIoQdq8yhB3uCdP2p/S2LvOOlyOa2EOAc+uC1ckkjHb+BUPlnYVpgI6vlusjn++wZn5+foweuRGHsDXNc96QSZhoCbQr66rAb/vrANOrGKKj4oaWu5y2dytRPwAEX5QtndD9ykc4qIfrrfMvLRDdTT71I1c9fRqMOjpZpm/8F JYXB89/T BH3dpGusoSbluwS6Q+Ht55X7XhTk13gq/4+yHafEePlx9eSKdZLkicklRBjswLDR+8HzMsFMlSh57sGOB6zhT2i884qYI6T0p77iNITRZrigvdmOICUqetze87VEMmgSxfZ8rjBe99wDYGydaewjKWWiMQeLwWR0zJlWuJEYkaWffS8nSyPToI942Xa1ppiNnF3mm8v/GptjhgR2nz49aHpNp/5dgTey8p8wDoZ9YjUNwd9/NeIhe3n9OyN+BB/NusFo/6MVVAqStVpdYBDRQwG6BH2eqwu6mM+HAJtcj4DUMDxBEtAPpStczHvH09V/S3LQpIAwGrn+W63WahYheQ9mxzJac8Xk5bUrOELA3jFl7Gmkk0oGbIsYrgUs4VeoB6JnEksap++Qk2ePTFbHXIGhCcBX95AXUPb9v1G2LZTf33fBOigqLeEyVpuzuMZi65YU5l3xJsu3YmPQ2i4SCh3546A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> >> Just a general comment: usually, if review of the original series is >> still going on, it makes a lot more sense to raise such things in the >> original series so the author can fixup while things are still in >> mm-unstable. Once the series is in mm-stable, it's a different story. In >> that case, it is usually good to have the mail subjects be something >> like "[PATCH mm-stable 1/1] ...". > > Ok... For my education, do you mean the title of this patch should > somehow reflect that it should be folded into the original patch? Just > trying to understand the actionable item here. How would you change > this patch when posting for mm-unstable and for mm-stable? For patches that fixup something in mm-stable (stable commit ID but not yet master -> we cannot squash anymore so we need separate commits), it's good to include "mm-stable". The main difference to patches that target master is that by indicating "mm-stable", everyone knows that this is not broken in some upstream/production kernel. For patches that fixup something that is in mm-unstable (no stable commit ID -> still under review and fixup easily possible), IMHO we distinguish between two cases: (1) You fixup your own patches: simply send the fixup as reply to the original patch. Andrew will pick it up and squash it before including it in mm-stable. Sometimes a complete resend of a series makes sense instead. (2) You fixup patches from someone else: simply raise it as a review comment in reply to the original patch. It might make sense to send a patch, but usually you just raise the issue to the patch author as a review comment and the author will address that. Again, Andrew will pick it up and squash it before moving it to mm-stable. That way, it's clearer when stumbling over patches on the mailing list if they fix a real issue in upstream, fix a issue in soon-to-be-upstream, or are simply part of a WIP series that is still under review. -- Thanks, David / dhildenb