From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93052C433F5 for ; Mon, 11 Apr 2022 10:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270656B0072; Mon, 11 Apr 2022 06:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21FFA6B0073; Mon, 11 Apr 2022 06:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E7F96B0074; Mon, 11 Apr 2022 06:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 016186B0072 for ; Mon, 11 Apr 2022 06:32:29 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C65A621965 for ; Mon, 11 Apr 2022 10:32:29 +0000 (UTC) X-FDA: 79344234018.18.BBD7D95 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 205221C0002 for ; Mon, 11 Apr 2022 10:32:28 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EB43521112; Mon, 11 Apr 2022 10:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649673147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7yn14Y/CNyAPNmn1Vk4CncuqQ7yIwJ/m/NWdKk6AwE=; b=SHIFLTG4fxP64tFjsmBTuKW0xZaXURXx4OYOA89r2RKiKxJYta/2cGgn+YEzmneyLPYPaz f3+wUrbivyqaIIY8WQe0YbouLIfFxBsamLsw1gsvp3xhqJzkLU23ETGXOB2RzHmgOyrmI+ 7QjOAnL77o0eCKq1cNnt5pCT6Q1c9QU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649673147; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7yn14Y/CNyAPNmn1Vk4CncuqQ7yIwJ/m/NWdKk6AwE=; b=phA3f4AM9CXr/rcsh4h12IH/EqBtuKqQwnwM0eNcSFQpqqgZI4StWaBfSJ4TzVTN0y4f/N UXwzQxc0PNJL0gAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C3C3013AB5; Mon, 11 Apr 2022 10:32:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aUP+LrsDVGL0YQAAMHmgww (envelope-from ); Mon, 11 Apr 2022 10:32:27 +0000 Message-ID: <78656e93-fc52-5ae1-4da3-b779dac4d779@suse.cz> Date: Mon, 11 Apr 2022 12:32:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] mm/slub: remove duplicate flag in allocate_slab() Content-Language: en-US To: Jiyoup Kim , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: Ohhoon Kwon , JaeSang Yoo , Wonhyuk Yang , Donghyeok Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220409150538.1264-1-lakroforce@gmail.com> From: Vlastimil Babka In-Reply-To: <20220409150538.1264-1-lakroforce@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=SHIFLTG4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=phA3f4AM; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 205221C0002 X-Stat-Signature: 83ikrj46wndrdrifhydgdtpdi34pj7kk X-HE-Tag: 1649673148-501656 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/9/22 17:05, Jiyoup Kim wrote: > In allocate_slab(), __GFP_NOFAIL flag is removed twice when trying > higher-order allocation. Remove it. > > Signed-off-by: Jiyoup Kim Thanks, added. > --- > mm/slub.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 74d92aa4a3a2..a0e605ab3036 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1939,7 +1939,7 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > */ > alloc_gfp = (flags | __GFP_NOWARN | __GFP_NORETRY) & ~__GFP_NOFAIL; > if ((alloc_gfp & __GFP_DIRECT_RECLAIM) && oo_order(oo) > oo_order(s->min)) > - alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~(__GFP_RECLAIM|__GFP_NOFAIL); > + alloc_gfp = (alloc_gfp | __GFP_NOMEMALLOC) & ~__GFP_RECLAIM; > > slab = alloc_slab_page(alloc_gfp, node, oo); > if (unlikely(!slab)) {