From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E095C83F1B for ; Fri, 11 Jul 2025 14:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C121C6B009B; Fri, 11 Jul 2025 10:29:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEA2E6B009C; Fri, 11 Jul 2025 10:29:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B26EF6B00A4; Fri, 11 Jul 2025 10:29:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A05406B009B for ; Fri, 11 Jul 2025 10:29:57 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 33E46C0288 for ; Fri, 11 Jul 2025 14:29:57 +0000 (UTC) X-FDA: 83652218034.17.8CD60D2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf25.hostedemail.com (Postfix) with ESMTP id 6A72AA0012 for ; Fri, 11 Jul 2025 14:29:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mOlk+bhs; spf=pass (imf25.hostedemail.com: domain of da.gomez@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=da.gomez@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752244195; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PTeAsD9FhDcAIQ8s42817QEk6wWazM74474kKbABeHA=; b=QuaemnARR+X38xv9a/hWNORcQlhOxVv/h32PB4E0cPXAD4PG7QT+4CPmCjlD4EW9oj1C0O QbWSUVLWNWeE/Xjb3lt5xjqSvT8r8CM9Uxn+tuvVYlZwzTuwgrzHMGSwTR+PX5VHMC8YX5 JN1rdSEoN2ZjCH0LxdArbEhuZayuKi0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mOlk+bhs; spf=pass (imf25.hostedemail.com: domain of da.gomez@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=da.gomez@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752244195; a=rsa-sha256; cv=none; b=UKf72tZpVxNgYGH19mThg/z1F00LoHi7VPu1lX8TEmi/bR4WKJDTzjyclQZH+htYNXHkBK vi+DcA+A29SSN2uhThYtp8rVrg8o3XP5waGv5GEKwYpF+AGgZ5YSSlBh1og5W6Vj3j52N1 P9KSfyklbWPvCluBn8uRYyt3rccURqQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AF7F960007; Fri, 11 Jul 2025 14:29:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41F92C4CEED; Fri, 11 Jul 2025 14:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752244194; bh=DTb+gl/sBn1Q70ZFf4J9pi63JbHRu+GK7lRSoMKGCfo=; h=Date:Reply-To:Subject:To:Cc:References:From:In-Reply-To:From; b=mOlk+bhs+QWla1mgbTTAaraZvXJCzWrRmqnz3rb7Y8etqK3kSJwFXCUZQsvMbXPq0 +//oeak4deRfAFpavcouYKjPgsKPWdYQgGANPWUAQsebYi5o7oVas9K8j+kQFgJc2+ JesaEDMCVMCtM7TfExq69iR+FmL159eLZW8R5EtXGzlYyaSwR1tRRgze8DfOUotxFF aY6BkH84hf/3AwOX/szk6bMA0O+YP7sTYDw2on3MjguYR0w2lpVvscLaqcEwpqLpb1 AOEwX0ZqbpLEfeMr7IhgrswEpwz+lHaa1djwmjCJtS3JnPUqyUDV7WujpCsf2KJWAG axH98LIXH2KSw== Message-ID: <784081fa-0fee-4df6-b8d5-6435eead877f@kernel.org> Date: Fri, 11 Jul 2025 16:29:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Daniel Gomez Subject: Re: [PATCH v2 2/8] execmem: introduce execmem_alloc_rw() To: Mike Rapoport , Andrew Morton Cc: Andy Lutomirski , Borislav Petkov , Christophe Leroy , Daniel Gomez , Dave Hansen , Ingo Molnar , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Peter Zijlstra , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , Yann Ylavic , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org References: <20250709134933.3848895-1-rppt@kernel.org> <20250709134933.3848895-3-rppt@kernel.org> Content-Language: en-US From: Daniel Gomez Organization: kernel.org In-Reply-To: <20250709134933.3848895-3-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6A72AA0012 X-Stat-Signature: i7rag4ryduiawkghkfxt8qtr9hcdx8yn X-Rspam-User: X-HE-Tag: 1752244195-363771 X-HE-Meta: U2FsdGVkX1+Wno8jSPy5oinsPPqaBI1Ufj3dK7Pp0IV5S4PzamAJvMuLWgP+A1Mkl0yJ+s6OHxcB7mFYbwWLJYFeocb5t5yh8QJM8w3rSoMlin2H91pBk56u5mclgHkKMrcUj/BhJDyPA/gnumte1N1+sWyxd2PddZ0xbd7l4XZkKIjYQUllijuaS/lOfHbJO8UdIiZtPSC6z+2LzWOLcKUlc+2VUsBOdnPet7CXyz1p+5pG/ibwa+t9D3RMzEqWPJLIdfCmyBuXt5ZOib8c+npRjs5P8JVAAvWbQbj7Ggy2CKvMRxJQ6iw9h6rYMVW9XNfLOyh4iGckbLmz7WF28lpvqGQ/XZhsZIXiKAxaxjX3SIlluZUOnuzlMASkl2OwWN0MeUFPTAK0WEW8AJgQLY5d7hJxCa5oX8LAjotOazUcJV4uDkZ4lNnEOnro79x2v/IdrExOYs17hDBLytmlCTDVsTcKs11Jlokj7UvRT014ELzevk8JUWYe4rZsBMYS1Ml7Ah8jLAbaSx+ho744O6fZEqx0KDDK/jol17v/vzxPZH4yTn7JsuasRZNum9ytP+XNqaz9guUb5tTBemTVwnIvM097offFDO+3Wl6Cw2ixefcoAfasPAmljaFfkxROCwByGoyarnqgEbSvUbSIWG+IG/NwoqbMPr6Pd6hSyjmB1YxBW4LH0F83BnkjZ0cR1K7Xve5YavZKvWW68pgV0n8YduyBJ1NLyPnQ6ihd0ecC+d7uFjbOlunHZzDeOWdSj/FnGBB9i2k8cCN1G1jwX7VSmU55EOXGe4RczHmrkhEtmm+yQFvulvxpT+qtFC1LPc1OBA/USQd6Nfy5/j93RfudPLxMxz8nepQuoiGl+7WsLTvGPfInppJmOBKX2N45wL0obOW3tvcRPlsKhLUfOQiEOVYhzhwrmb/vAwhSKvsVkqqVrzPWspN0nD899oqnmVngrH1/hJIzR6PHH7Y mVJdc9V9 rD965NBh0W++fTL05vLxx1kS/EfyUFT++wAfd7xmHraz2eE8P0WBwytzpwCP59oDV7qT64YJXyoEouodeM/0u6DC4NcHQzNey6RcWXjqPV/I4LaVOwSvP2nfsydyWN9/As3havh971kF8buYmFSUIrmNEVbVlXbFdIZT9J2x0/cBSOg4zvFSVQWzALM8IeOfAvtqm+TIPW1rytRCQszo8qU8DmhfJdfCQuTSEldMy9OZuy6AvwcrKZAt/yUq9JXC5Qtj3DyU8z68sEh4hrbRUKT2pM22NvFy0uD7BvHVDl75Vm/tAdr1jEfqAa+J0q7KIZlDmneOjWBu+8FTyS2DSfSGU4zMh1DbPj8XN41iIPHrpE3Dx+XbrNhF7qT7PvFsffcqn/0A9BZyLviqglUS1CrdgYZhghPvcbDWc92EKH+F4HqtJO2OL0FIANjAdZmHXnUQKzjeBDoIVFK8rZy2+8miupBPtcl03i8Yz1LQKfBLC/z7kD2kPGP4fQexc4TXlHgtS/xd+20I9hxQbDrDGRoTO5/pgv3WwVSjUNTOOKfONazQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/07/2025 15.49, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > Some callers of execmem_alloc() require the memory to be temporarily > writable even when it is allocated from ROX cache. These callers use > execemem_make_temp_rw() right after the call to execmem_alloc(). > > Wrap this sequence in execmem_alloc_rw() API. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Daniel Gomez > --- > diff --git a/mm/execmem.c b/mm/execmem.c > index 0712ebb4eb77..6b040fbc5f4f 100644 > --- a/mm/execmem.c > +++ b/mm/execmem.c {...} > @@ -387,6 +397,21 @@ void *execmem_alloc(enum execmem_type type, size_t size) > return kasan_reset_tag(p); > } > > +void *execmem_alloc_rw(enum execmem_type type, size_t size) > +{ > + void *p __free(execmem) = execmem_alloc(type, size); > + int err; > + > + if (!p) > + return NULL; > + > + err = execmem_force_rw(p, size); > + if (err) > + return NULL; You don't need to save the error here. That, allows err declaration to be dropped.