From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F8FC4332F for ; Wed, 13 Dec 2023 09:59:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39EE96B0184; Wed, 13 Dec 2023 04:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34DDF6B0480; Wed, 13 Dec 2023 04:59:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F02E6B0481; Wed, 13 Dec 2023 04:59:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0D42C6B0184 for ; Wed, 13 Dec 2023 04:59:10 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D1CC9140751 for ; Wed, 13 Dec 2023 09:59:09 +0000 (UTC) X-FDA: 81561346818.30.A19252D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 640AA8000F for ; Wed, 13 Dec 2023 09:59:07 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PIzHDrI2; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702461547; a=rsa-sha256; cv=none; b=KVs3I5086Y+vxmYCgrlYJSuBv/ySEqzrSJFaKTpWBVGuWa59jzHk40F0XhX/20vHeh+v8k mTTdTqIJAw1xwIbAe/cXCAwra8E90sNp1a6S1VmvnhLt6RwnPOL/ugGkgOgXqMErbOgkaU k8+USDMidY3V7nEY9xmBvZLaSerOPHM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PIzHDrI2; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702461547; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJhC2mLo7M1xrewt5LCijIe6486cl8jsTWSgbKFncqI=; b=nVxeScaPUSOLKhchENkhA2oSbyym5kAuVvJHvf6UH5elE3IOgU5G9/z1I4Mp69GLQUJH5G 8J+OPgnd2yDQBLmWCPWm6jBMIfx1SuaPP6aMFDvP65BlZtB02Itt9D+7Ow/gJSoJl+VmDq AOBZbTyf5WEeZNyj7NNjcYlX+kTyBNs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702461546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JJhC2mLo7M1xrewt5LCijIe6486cl8jsTWSgbKFncqI=; b=PIzHDrI2LnwYJMLr2mqSafqIyNQ0DChvhO1FcWj8Gk4vj+mKFcKQ15ARcuumbCt286VpC6 Db6HHTq9dhdwY2PHe2k1/x+iJxqfQ2htswDCJbskQ6zb9A4ZSCGWUOMn4Udepd2rIi5go8 +/6n0KSBw8nD+PqtU0j7WesBwUlXDLQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-eIPgDkv6NOOg0EN5V5XAXg-1; Wed, 13 Dec 2023 04:59:05 -0500 X-MC-Unique: eIPgDkv6NOOg0EN5V5XAXg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3334b472196so5339025f8f.1 for ; Wed, 13 Dec 2023 01:59:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702461544; x=1703066344; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JJhC2mLo7M1xrewt5LCijIe6486cl8jsTWSgbKFncqI=; b=UUspLKbIK7wNBfRfSUDD3lo2YE6jV9zQ264aoUOpJ64eVbTpqEihQsGwspWkTdmflv q9EhqUpmYwMRkFF3GqDusV0zcS+krFzJiXpNoZPyUN+zQVXGZyYhInu93lqB9kJ0NxUC +761GWTyBs6o3Ul8FiOAj2plaR943S7M6GTDA8MpnhALr4ND8coERgBcBW/dDByxQFZ6 3CY+mD1lNHjKyeHRi3GbDYJQM4WA3cEwPCIrCBskDolaJEx1022f7oHV+KBRoB6ofU6k A2zadCxILESz7N8+hA/ClJoCjNy1Yx/d5hvROn3X5QTkdRjuqWu/0qyZXDsAhfLoiLM4 OOZQ== X-Gm-Message-State: AOJu0YzgD/aTwAdvg81iyo6ZGvXo/KSDr7wI0EFNi1kplEzDYPkW4yap VGqFb09mwsXVwG8HTfOoRnpqBa/FXR8hO+sJA3PKLMMnN1zfeRs7xOL6vfnRgMYL3/38mSggFwI /W2eF4SsJxbI= X-Received: by 2002:a05:600c:1715:b0:40c:2bb5:f86 with SMTP id c21-20020a05600c171500b0040c2bb50f86mr3930709wmn.74.1702461544275; Wed, 13 Dec 2023 01:59:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYzOLPzh70Ndpe0zyponvfmOjfEIVO72cb1HP6w/sqXyCdveuNm5mjm3u+Rce1in5eocQ3Hw== X-Received: by 2002:a05:600c:1715:b0:40c:2bb5:f86 with SMTP id c21-20020a05600c171500b0040c2bb50f86mr3930684wmn.74.1702461543853; Wed, 13 Dec 2023 01:59:03 -0800 (PST) Received: from ?IPV6:2003:cb:c709:6e00:7e5:5f4d:f300:5d52? (p200300cbc7096e0007e55f4df3005d52.dip0.t-ipconnect.de. [2003:cb:c709:6e00:7e5:5f4d:f300:5d52]) by smtp.gmail.com with ESMTPSA id fc7-20020a05600c524700b0040c44cb251dsm12118228wmb.46.2023.12.13.01.59.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Dec 2023 01:59:03 -0800 (PST) Message-ID: <783a4178-1dec-4e30-989a-5174b8176b09@redhat.com> Date: Wed, 13 Dec 2023 10:59:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] selftests/mm: add UFFDIO_MOVE ioctl test To: John Hubbard , Muhammad Usama Anjum , Mark Brown Cc: Suren Baghdasaryan , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, ryan.roberts@arm.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, Peter Zijlstra References: <50385948-5eb4-47ea-87f8-add4265933d6@redhat.com> <6a34b0c9-e084-4928-b239-7af01c8d4479@sirena.org.uk> <3240f4b5-081b-4075-851a-7d1cd86f4333@redhat.com> <3eadd79c-c02a-495f-92c0-0315046ef59f@nvidia.com> <3d22f342-280f-4a44-87f4-8cca291cfce7@sirena.org.uk> <0f97db9c-5b86-4f56-8463-2520fe79f709@sirena.org.uk> <2e4a719b-f2b3-48db-99db-d96040d78b12@collabora.com> <0d68fe7f-2a96-467d-87b0-52db36704e1d@nvidia.com> <926b42f9-3689-480f-8dd5-78fc0ee6088d@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <926b42f9-3689-480f-8dd5-78fc0ee6088d@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 640AA8000F X-Stat-Signature: 1zfwc4amkqzd9mdsqzo9pxhgpbarc7py X-Rspam-User: X-HE-Tag: 1702461547-297293 X-HE-Meta: U2FsdGVkX19VjZyLGn+ULE1A0hKETVVrk9OU/q9waD9DVWehwaOLdgIbhm6PP02jbvEkC5d75dDt80n1axiMYcTI4PnmRHgu3MlgtWvUOYOCl8YtcTfjM0mbO4lVOcBmXNYWrcSshrJeHfLK/GY1WoQWjnPlBfnaqP5oG0xkYP+mER/5qAmzUS/SsOUPXaD9DJQ/NlMYJF652AqpDyqdNh8xR3ybC6VD6t9Clu00cNQ/y529LiGRuIuKLpCnprtRdfzqjB1SP5KJpkdIJ5Rvk+pSaCb4Lm0xpb39vz1WgtaL6euEzYJBLIXdOEqJL5cSMtyJcPUvT6R+mbJmZc/Pifyhz8fnHMIHCor35LdhpCirMtjh1Ox8PufG+DM2xxgeuf4OEYgYT9a0Y2cTywZ9320ZbYTOn4k1mTtmF04PWxkx2Sh4WXiPeoruq6zA4NK57AzAH3KIdWdMcflBEEhZnr997uTtz8o34HLCqu0tqrZfR15HZcQyJ/xmpd5/OFw0i4w9weqghDqhlvSu004Z4gV77WA9LwaBO0k1jnePpojGj2sivzbo3ZGhPungSw9s8+DbWh52wc+5X+uqfj/5+qIjW1mBPAEg0bB6R/kCQbV5fdcAcHYEXzztbxXQnCgWvVGVMjKAYq6ZIjwyrQIWlt6sMJzuKARE9GYvrP0jHrYfRiEN4P1Pp/6YQhfDZC2j4NIAMFRYmkjdrQqo/xDvJFh9gDvSG7agQtzFgtTyYVjvrrb3GR5yiWjXevE7dyaXOu7TC8Y9FrmdR6wncY/5X0HEj5dpJW8iugrOmzIcJB/FbpW9GQgEd5WD0T+qnE1+rVTH6ahZNhVIjykKDJ8e5v84jlt/+0kvGWw3FbzHrvt87ryfTjhVnmpyJRUWtXUABp7pIaH9yvCnL8JrLqz+q/BxfzYfVbh8J5goKSDa0n3K6rxCVCoOmkVq/cY21UeQjUPe/EmbizKkmKJAl4k c8l4SjQ5 TYkCcttRwYY726cS/Fcmg8IlNjCkal/Yc5MGC1CUcqfVj2orTzD2tskXE4onFYEK+3NnvMlLcBCOfA5joPaQAbEfx7vpvnMidaYIM8cnRP5BP7Sw5/Hk84dw5NjXV05P2RoO9YqJuphHBP2sjnOd3anKbedAQy8kniaQJtYgWtoid5gkar9We1AwZ8t5zEsN1CD4Thf2qNkN3KRL0EkK0MBTbpft1itiFG+L1xaA1SzbIr4SdfNEQ+RYo/4TUFSyK8s9utgWdU6RRuYEw77Fcmct1YroUqhE7S6muLt+oiO57+VkztU/dXUX+gvzsD/1SBwVjxM0uR2K7oqv15o2/EjvBgisuhLfHBDxsGkvaT4X6v8uruM54nuC8bm+nik+j0G0OjbjGJWk2SlyaEKDi7KcASUnTCWbDiNCPQMNQGbrQNtlTv+kL5miJaIsKqDMCs8To1KaqnvGEgfkhuc9zHpDGhg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.12.23 06:55, John Hubbard wrote: > On 12/12/23 21:52, John Hubbard wrote: >> On 12/12/23 19:58, Muhammad Usama Anjum wrote: >>>> ... >>>> Oh, this sounds like it would work nicely. No more "make headers" >>>> required (hooray!). Instead, the new approach would be "selftests are >>>> allowed to include from tools/include", and then we can just start >>>> copying the files that we need to that location, and gradually fix up >>>> all the selftests. >>> No, this wouldn't work. >>> * The selftests are applications which include default header files. The >>> application don't care from where the header files are picked up at >>> compile >>> time. We should be able to build the application on normal system with >>> latest headers installed without any changes. >>> * The header files cannot be included directly as they need to be >>> processed >>> first which is done by `make headers`. Here is a diff between kernel fs.h >>> and processed header file to be used by applications: >> >> Well, that's not the proposal. The idea is to snapshot various uapi/ >> headers >> into tools/include, just like what is already being done: >> >> $ diff ./include/uapi/linux/fs.h ./tools/include/uapi/linux/fs.h >> $ > > Oh sorry, that's exactly what you were saying you don't want. ahem. :) > > Another variation though, would be to run "make headers", and snapshot > some of those files into tools/include. ^ this is what I had in mind If you're writing a test that needs some new fancy thing, update the relevant header. -- Cheers, David / dhildenb