From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613EAEB64DD for ; Thu, 13 Jul 2023 07:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1AF26B0071; Thu, 13 Jul 2023 03:13:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCB536B0072; Thu, 13 Jul 2023 03:13:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A92166B0074; Thu, 13 Jul 2023 03:13:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 96DD66B0071 for ; Thu, 13 Jul 2023 03:13:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 746A3C0140 for ; Thu, 13 Jul 2023 07:13:51 +0000 (UTC) X-FDA: 81005723862.22.7BAC451 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id 8E1D6180014 for ; Thu, 13 Jul 2023 07:13:49 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689232429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wODkCk55kq4Sh7CHviS8BxVpkBeT2S4ed5XyidAno0E=; b=hulDi49LIsJk3TruQRtdP+RjxZE0+upXOvP8xB3BE51b6O/qpUQ7VO+eIbSDNpA3epxoDm VQ7pO6cgubF/Lc0iccWuvsF+mFLJOcC97IBB9drs3n6oYwYcShKIUuAhD8dNuG7GKANLaH NylSlbgbk7pM62aM1uM4OGBqdRZ4N0k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689232429; a=rsa-sha256; cv=none; b=NXCACKqgiPNIIn09piez0WZbG4P/jRDuVqwzvPp2e8yEe86/kO19STgthSEkFnmpqqwmik BugjZxI84Q/5/wFptPaJpHPssUX1kTWuoF215Puuvj7j6+/Il5j5qnV18bNoPpGDwgkPBe U5ZgWVjQnSRlfXyNEAHNBh9f6k/AZhs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8CE612FC; Thu, 13 Jul 2023 00:14:30 -0700 (PDT) Received: from [10.57.78.6] (unknown [10.57.78.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 26E413F73F; Thu, 13 Jul 2023 00:13:46 -0700 (PDT) Message-ID: <7830cca8-068b-ce56-79fa-61dcb0c18bc2@arm.com> Date: Thu, 13 Jul 2023 08:13:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 2/5] kselftest: vm: Fix mdwe's mmap_FIXED test case To: Florent Revest , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com References: <20230704153630.1591122-1-revest@chromium.org> <20230704153630.1591122-3-revest@chromium.org> From: Ryan Roberts In-Reply-To: <20230704153630.1591122-3-revest@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8E1D6180014 X-Rspam-User: X-Stat-Signature: c5hpsd3k9jp6skkiny8ihi6sgmrcgkg8 X-Rspamd-Server: rspam03 X-HE-Tag: 1689232429-86913 X-HE-Meta: U2FsdGVkX19M6R3m/DW4yrEKyERnflaK1gMkOzVMH7EMwhG9YDLntRZJ9mfXQm0SNbGI1kTPfyZBPGWphBzeooFSjHoTWB0wp0iww5rakSuYPD7tIL72Zop3OM0igucPSGkbsHrOVQo22PE+UTG91gOatPwKtJOsdl/62rS/gtRydAQKPH2VTGMEr4O93qFT+1XCOzwoXOn71eCd0YfCwK0B/GF0wzU6enjZpR6MGHTXOmVSQTs+11kuLxom2idoqyzTqMd2p4NrCH9vD/rVb21hK5HUJMV5SLmPRLd1cMRFMV1XL9NV66hqMSrxOQ6ffBGd88LE/asNKQdAudn2hhLjlwFrzf1B81vGkyY8EuREYslbfTzTxLQVvH0kxSRG4qLbJkFARSdhYh6ljRfF/1D4eXtsdZpvbPrF0ycEdDLDep5DTLzjjkjcTpbO5fXbxHTFgjX3ANPKwlt8XAUqQTUVmaNHVhpHn4DcLgjzGyTj5dgMDNkoGwoKxUnnL3BuncDjnTVZI28KNlyvo1b2K/R+0+eFICQI4NlVgohW0T1tKQZztFDFuhgriUv537lHwhNH4iDcFE0GovwPl9pWz/xR/KgG7+WCgW2vfPBvw9OA36xh+NBUFFJluh3X5N8ksB5fr04vcbVHWqa2cpzLFCVjVbRs+z2A/fsmKCkX4hSNP2Zz0dBS+3ZmTxIQgsf2R5JQXEkQm5hdDhNdIbsX3MDEZXWdABtmzqRIPqNb6TEm19oDhjGL2Y+dxb53i15hiytUSvLXNazthz40t7p9KaIEN556oUQX9uePEAMTPPtt8l4YxkoHYRtD5To4QbhGNUZFB7XspIQNgVLUt6MwH4kULbm4bsHo8uoL81/XrmbkH2UNfvVEB97OA13Lvv2x/3c0Pu2+WU17A5LFoNO1S6Am6PBRdNQOSs5cSLe/C292jMsFN6kVEOGZDtLTpLoJYpBjbdTMM1AsVX5a7AM zxw7IaBO foxi0XxrIRtC1GohXE5w6DBQXLDYaFnGNeW3VqwdzyG98FV7y4E8/+MV32pmmAdkOU9s2O+3e6eUu20EV6+3dqRNbFEyGf80rCuCfUcHOWjU7HeRngj3GOMo+Y76MkGwlOyqKe+QeHxi8XKOVabQUz/DJfP/N0JtPjkQEDdsNxZpk28TMU7EE0HuXWfKtWn9sCk9QBvMLHpKkuMKGm3aCTb9bnZSp4SGXSoXkmjQ4Pu2kON9poM0H9zFHBWuP1XkZwexUdSIDVbDqXH71w1gmCOgG0pRIUjiKHZXajzDIUAloU5Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04/07/2023 16:36, Florent Revest wrote: > I checked with the original author, the mmap_FIXED test case wasn't > properly tested and fails. Currently, it maps two consecutive (non > overlapping) pages and expects the second mapping to be denied by MDWE > but these two pages have nothing to do with each other so MDWE is > actually out of the picture here. > > What the test actually intended to do was to remap a virtual address > using MAP_FIXED. However, this operation unmaps the existing mapping and > creates a new one so the va is backed by a new page and MDWE is again > out of the picture, all remappings should succeed. > > This patch keeps the test case to make it clear that this situation is > expected to work. > > Signed-off-by: Florent Revest > Reviewed-by: David Hildenbrand > Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execute") I'm currently working to get all the mm selftests running (and ideally passing!) on arm64 and saw these same spurious failures. Thanks for the patch! Reviewed-by: Ryan Roberts Tested-by: Ryan Roberts > --- > tools/testing/selftests/mm/mdwe_test.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mm/mdwe_test.c b/tools/testing/selftests/mm/mdwe_test.c > index d0954c657feb..91aa9c3099e7 100644 > --- a/tools/testing/selftests/mm/mdwe_test.c > +++ b/tools/testing/selftests/mm/mdwe_test.c > @@ -168,13 +168,10 @@ TEST_F(mdwe, mmap_FIXED) > self->p = mmap(NULL, self->size, PROT_READ, self->flags, 0, 0); > ASSERT_NE(self->p, MAP_FAILED); > > - p = mmap(self->p + self->size, self->size, PROT_READ | PROT_EXEC, > + /* MAP_FIXED unmaps the existing page before mapping which is allowed */ > + p = mmap(self->p, self->size, PROT_READ | PROT_EXEC, > self->flags | MAP_FIXED, 0, 0); > - if (variant->enabled) { > - EXPECT_EQ(p, MAP_FAILED); > - } else { > - EXPECT_EQ(p, self->p); > - } > + EXPECT_EQ(p, self->p); > } > > TEST_F(mdwe, arm64_BTI)