From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6F7C61D97 for ; Fri, 24 Nov 2023 02:37:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A12FA6B06E7; Thu, 23 Nov 2023 21:37:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C1D66B06E8; Thu, 23 Nov 2023 21:37:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B0FC6B06E9; Thu, 23 Nov 2023 21:37:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7AFB16B06E7 for ; Thu, 23 Nov 2023 21:37:48 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 474EE1412D8 for ; Fri, 24 Nov 2023 02:37:48 +0000 (UTC) X-FDA: 81491287416.30.DF78369 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) by imf30.hostedemail.com (Postfix) with ESMTP id 3B23280003 for ; Fri, 24 Nov 2023 02:37:45 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rxOvgmZb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700793466; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jTrWgPTmhL+pfMdbtv8oZ0hXd6mtQwXeT2Ul7xLq8pM=; b=yiFDBFZKg8Hgi1RzMNWrh7HNWkGs2jFMJhMTmlFkxv+tLgFxWzOmRo3oyNC5hBT3mOWBBK wajOvxyGjXYHtp+w0FHxgYyGaz4DKfZbDHj/RE38f9k00u2m3hgIa+TQ3EgDWyeDjwVXDA U/PTGohi+4ysLi4IJKAos3DOAMsQtCE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=rxOvgmZb; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf30.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.178 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700793466; a=rsa-sha256; cv=none; b=C26iXiOdR10zOxDdDs4xtJx8XeoAkznW2YveDaRE9TgIc1NP1WNnH6JSr+JYKdk0QEd65/ c1/0s8+RhsAtxtVm8G8oqasb4HpLRwBGguW+SoQVJYuZ94uWUVBP1BTl9OQUuLq2MVU5mQ IPK5WkMnxMs55LjHqtLm3TbNsApFz5U= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1700793464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jTrWgPTmhL+pfMdbtv8oZ0hXd6mtQwXeT2Ul7xLq8pM=; b=rxOvgmZby8bs+M3u65ZmeIsiqbfYUlsFgcTKzcFbx4s3TWRBH3/Fy2bflm9Ge7uAnlhMg7 NRSN9f6J3N1rxV/qkm6ezPqAmqnkBD83WnvIhOO9PFpHKRVf5fljDi2N+FXichstd1OsF7 OsnIgQ0FQNEpn6Pdym/EEmcM2fMpV7o= Mime-Version: 1.0 Subject: Re: [PATCH] fs/Kconfig: Make hugetlbfs a menuconfig X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Fri, 24 Nov 2023 10:37:06 +0800 Cc: Peter Xu , LKML , Linux-MM , Andrew Morton , Mike Kravetz , Muchun Song , linux-fsdevel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <7830CCC4-B1E4-4CCD-B96B-61744FAF2C79@linux.dev> References: <20231123223929.1059375-1-peterx@redhat.com> To: Randy Dunlap , Peter Xu X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3B23280003 X-Stat-Signature: hhtebxt149au8uxitfwmsbymkof9txcg X-Rspam-User: X-HE-Tag: 1700793465-601809 X-HE-Meta: U2FsdGVkX19TmdMYm0EFkykUlkBaHPR/HK3uFbrnZOMbCDiA9bokeTJEL/XlI01CXJ+YRGA3RQWZn5Ycm000GS8sa7zBptYKvkIO/gYXn1jIcmZHYOKIUitHJfuu1ioEj/6SLwDQ7nLuj3fb6SqPC7S0eUrpeBlW5Wx98bMjU+vt38fLohNE7i5yK9vzVPyhyOiVVEFOiueY998xsOpPr24p2/r1X9v1wJQBwSQI6gfdo3AcN3V5+v8x5cs+UJGshZcj8bhX3FSX5vgbUSmdy4Sd/wp3fCU1ASzl1/d9Q7dylggNPsOizV9ZwPQviRb5DvVFVum8G3PxjjOOaxD6F88zWALIJqTNo1HHUvQtSGoCHe4PNR/LNjhsn5uMni5MtCsCnipgf8O7Edeg/LpKRb34uEycY1HSlUczajVo+v+A8NREh4Wwrnuw8D1kcLZaIoTr0hGvfIzLW7/jkhqtfDm8Io6IIvvSLSDTalYSQ4BdlDuUmzyF4GwNL/vzXBAcSj6yiGi/zIqC+pvGAKBCb8xMnEW+sBm7iYOHPVyR0N8OJm4oLg2JZW5sOEnG67z7ZWtlj5vVY0FZM+Q7emf7kaq0yDZYWDnTJQgtJGbXVpwjWgPawS1xldf/FJU8yR1Ffxa08HVKKrudgghCzOBX0nhk3uhjQg45/hvsjp8F3Yz7Np3npXNOV1eH3J0EIhbosEqloFQkW/VV5c1lSIS+N4A+g8yfCPKgS5bZ9jEYyrdI1Nz6LGJoOqjEvraQk4SyaVvCgBSthmFBAXIQwQe+ffzmfsNIpoAyB0kqFb3Bye2pmT5dXuQmONL3MfT/aAKOdO5qbK8o6p0MhqD3+plRdL5KzVolhStPH1BSMbLgMT1dHT8VMBJsnjrDZt22cIDOcAIse1yQPNyCrUmtw4KGi6lQ/yxUGO5LVXQzD03bl6NnSY37wqa6bJjstYWGKUomHGdTgAOM/FFWEDiBP/l Po/k1Aon VphXHYPx2etAsx0FFW5qt1u6UdX0nF9JXNYiGRzlTyt+25ZkvY9tk8pQ0u3omZb72kS5EV+8bJuCFl3dsNxROvPAanceuhZlOH3Lvrd0XrMjoMrega+baUke3q9zaG8JWSmnTETA64rTYpIFgnwXoqZhhCnNaBIReaoGN2E2RYXZFt5nbhhMiwBrG0fPjL6Zb8zS1QcyXRdJI4EAqsv++sSXZ87eLir2z/BPD+Giyt7qR3DfrkOqR3dQhy6SuzLLiBQ29bHdjP21Fl/4kuOyZMJ0E0s5B4cFAom1PFg+4/4TT4TTgN075duPxirNq2vI4Nvl0vXVt0h7O9KMe5Zz8byaAzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Nov 24, 2023, at 08:19, Randy Dunlap wrote: > > BTW: > > On 11/23/23 14:39, Peter Xu wrote: >> Hugetlb vmemmap default option (HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON) >> is a sub-option to hugetlbfs, but it shows in the same level as hugetlbfs >> itself, under "Pesudo filesystems". >> Make the vmemmap option a sub-option to hugetlbfs, by changing hugetlbfs >> into a menuconfig. >> >> Cc: Mike Kravetz >> Cc: Muchun Song >> Cc: linux-fsdevel@vger.kernel.org >> Signed-off-by: Peter Xu >> --- >> fs/Kconfig | 20 +++++++++++--------- >> 1 file changed, 11 insertions(+), 9 deletions(-) >> >> diff --git a/fs/Kconfig b/fs/Kconfig >> index fd1f655b4f1f..8636198a8689 100644 >> --- a/fs/Kconfig >> +++ b/fs/Kconfig >> @@ -254,7 +254,7 @@ config TMPFS_QUOTA >> config ARCH_SUPPORTS_HUGETLBFS >> def_bool n >> >> -config HUGETLBFS >> +menuconfig HUGETLBFS >> bool "HugeTLB file system support" >> depends on X86 || SPARC64 || ARCH_SUPPORTS_HUGETLBFS || BROKEN >> depends on (SYSFS || SYSCTL) >> @@ -266,14 +266,7 @@ config HUGETLBFS >> >> If unsure, say N. >> >> -config HUGETLB_PAGE >> - def_bool HUGETLBFS >> - >> -config HUGETLB_PAGE_OPTIMIZE_VMEMMAP >> - def_bool HUGETLB_PAGE >> - depends on ARCH_WANT_OPTIMIZE_HUGETLB_VMEMMAP >> - depends on SPARSEMEM_VMEMMAP >> - >> +if HUGETLBFS >> config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON >> bool "HugeTLB Vmemmap Optimization (HVO) defaults to on" >> default n >> @@ -282,6 +275,15 @@ config HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON >> The HugeTLB VmemmapvOptimization (HVO) defaults to off. Say Y here to > > Is this small 'v' ^ a typo? Yes. Thanks for pointing it out. Although it is not related to this patch, but it will be nice for me to carry this tiny typo fix. Hi, Peter, would you like help me do this? Thanks.